[PATCH 2/2] drm/amd/pm: update existing gpu_metrics interfaces to fit upgraded structures

Update the gpu_metrics interface implementations to use the latest upgraded data structures. Change-Id: Ibdbb1c3386de12c53bea3b8c68bbeebd14787287 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h| 8 ++-- .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 14

[PATCH 1/2] drm/amd/pm: correct gpu metrics related data structures V3

: I0a139e1e1f09fe27deffdce1cec6ea4594947625 Signed-off-by: Evan Quan --- .../gpu/drm/amd/include/kgd_pp_interface.h| 112 ++ 1 file changed, 112 insertions(+) diff --git a/drivers/gpu/drm/amd/include/kgd_pp_interface.h b/drivers/gpu/drm/amd/include/kgd_pp_interface.h index 41c89f7d6412..85aa5cb957eb

[PATCH 2/2] drm/amd/pm: update existing gpu_metrics interfaces V2

Update the gpu_metrics interface implementations to use the latest upgraded data structures. V2: fit the data type change of energy_accumulator Change-Id: Ibdbb1c3386de12c53bea3b8c68bbeebd14787287 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h| 8 ++-- .../gpu/drm

[PATCH] drm/amd/pm: correct the watermark settings for Polaris

The "/ 10" should be applied to the right-hand operand instead of the left-hand one. Change-Id: Ie730a1981aa5dee45cd6c3efccc7fb0f088cd679 Signed-off-by: Evan Quan Noticed-by: Georgios Toptsidis --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 8 1 file changed, 4

[PATCH] drm/amd/pm: correct the gpu metrics version

For V1_0 and V1_1, they come with different size. Misuse may cause out of memory access. Change-Id: Icd06e673b9259d8d381301c145f0e9eff3408ee5 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH] drm/amd/pm: fix Navi1x runtime resume failure V2

INTERRUPTS_ENABLED flag clearing into current mp1 state set routines Change-Id: I4eb3d5d76068412a6ab228af7fe7f794e53c1eaa Signed-off-by: Evan Quan Reviewed-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 9 -- drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h | 7 + drivers/gpu

[PATCH 1/2] drm/amd/pm: make DAL communicate with SMU through unified interfaces

No need to have special handlings for swSMU supported ASICs. Change-Id: I1ec552c6a2a4283cf6ab3acfe6c0753bfcca57a9 Signed-off-by: Evan Quan --- .../amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 134 +++--- .../gpu/drm/amd/include/kgd_pp_interface.h| 14 ++ drivers/gpu/drm/amd/pm

[PATCH 2/2] drm/amd/pm: label these APIs used internally as static

Also drop unnecessary header file and declarations. Change-Id: I877b48c32c599534798e14e271c3e700b0d6ebf6 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 1 - drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c| 1 - drivers/gpu/drm/amd/amdgpu/nv.c | 1 - drivers

[PATCH 1/2] drm/amd/pm: drop redundant and unneeded BACO APIs

Use other APIs which are with the same functionality but much more clean. Change-Id: I5e9e0ab5d39b49b02434f18e12392b13931396be Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/nv.c | 20 + drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h | 9 --- drivers/gpu/drm/amd/pm/swsmu

[PATCH 2/2] drm/amdgpu: disable runpm if other reset method not runpm capable is chosen

Otherwise, the runpm will be always enabled on a BACO capable target even the reset method was forced as like mode1. Change-Id: If6bf55c533e91470c9c83383788466161608f68d Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2

[PATCH] drm/amd/powerplay: unify the prompts on thermal interrupts

The prompts will contain pci address(segment/bus/port/function), severity(warn or error) and some keywords(GPU, amdgpu). Also this address the issue that pci bus retrieved by PCI_BUS_NUM(adev->pdev->devfn) is wrong. Change-Id: I714d1dffb30a6cf76dcede087cf5d9302f683ed8 Signed-off-by: Eva

[PATCH] drm/amdkfd: report the real PCI bus number

Since the PCI bus number retrieved by PCI_BUS_NUM(pdev->devfn) is wrong. Change-Id: I882a8531a65cdf91be20e34a034aca1f43f658b4 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdkfd/kfd_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amd

[PATCH] drm/amd/powerplay: check whether SMU IP is enabled before access

Since on early phase of bringup, the SMU IP may be not enabled or supported. Without this, we may hit null pointer dereference on accessing smu->adev. Change-Id: I644175e926cd4fef8259f89002d6f8eda04fe42c Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c |

[PATCH 2/4] drm/amd/powerplay: implement ASIC specific thermal throttling logging

Enable this for Arcturus only for now. Change-Id: I4ad4fbb4f932d748849574e0f4dde01bb7db487a Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 44 +++ .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 1 + drivers/gpu/drm/amd

[PATCH 1/4] drm/amd/powerplay: update Arcturus smu-driver headers

To fit the latest 54.24.0 PMFW. Change-Id: I38d08da6bf5120a7902b7366e09ca3fbc2c25f54 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher Reviewed-by: Kenneth Feng --- .../drm/amd/powerplay/inc/smu11_driver_if_arcturus.h | 12 ++-- drivers/gpu/drm/amd/powerplay/inc/smu_v11_0.h

[PATCH 4/4] drm/amdgpu: added a sysfs interface for thermal throttling related V3

: Evan Quan Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 11 drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 71 ++ drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 10 ++- 4 files changed, 89

[PATCH 3/4] drm/amd/powerplay: enable thermal throttling logging support V2

logging will be performed every minute to avoid log flooding. V2: simplify the implemention by ratelimited printk Change-Id: Ia4534700ee183c16b3231b461208bd0277f3b6a7 Signed-off-by: Evan Quan Acked-by: Christian König Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 11

[PATCH 3/3] drm/amd/powerplay: give better names for the thermal IRQ related APIs

Thermal control is performed by PMFW. What handled in driver is just whether or not to enable the alert(to driver). Change-Id: Icf857054b74f021e7fee2bf3aa9b314aa0d5ef09 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 drivers/gpu/drm/amd/powerplay

[PATCH 2/3] drm/amd/powerplay: use the common APIs for IRQ disablement/enablement

Also the new logics for MP1 SW IRQs disablement/enablement are added. Change-Id: I57ef8f21ab3d51aa0d557f511d89f5fa2ce08144 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 79 --- 1 file changed, 57 insertions(+), 22 deletions(-) diff --git a/drivers

[PATCH 1/3] drm/amd/powerplay: stop thermal IRQs on suspend

Added missing thermal IRQs disablement on suspend. Change-Id: I959a1d56930de434cc8534334220d3faeadf79f8 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm

[PATCH 2/9] drm/amd/powerplay: some cosmetic fixes

To make code more clean and readable by moving ASIC specific code to its own file, more code sharing and dropping unused code. Change-Id: I6b299f9e98c7678b48281cbed9beb17b644bb4cc Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 213 - drivers/gpu

[PATCH 1/9] drm/amd/powerplay: drop unnecessary CHIP_ARCTURUS guard

These APIs internally guard they will not break ARCTURUS. Change-Id: Ib6775c1c8c5211ea45db6c3fb604a8279411ab37 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 38 +--- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 8 ++--- 2 files changed, 20

[PATCH 3/9] drm/amd/powerplay: centralize all buffer allocation in sw_init phase

To fit common design. And this can simplify the buffer deallocation. Change-Id: Iee682e76aadb5f34861d69d5794ced44f0a78789 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 330 ++--- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 105 --- 2 files

[PATCH 8/9] drm/amd/powerplay: drop unnecessary dynamic buffer allocation

Since the structure comes with only several bytes. Change-Id: Ie9df0db543fdd4cf5b963a286ef40dee03c436bf Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 3 --- drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 2 +- drivers/gpu/drm/amd/powerplay/smu_v11_0.c

[PATCH 6/9] drm/amd/powerplay: clean up the overdrive settings

Eliminate the buffer allocation and drop the unnecessary overdrive table uploading. Change-Id: I8ba5383a330e6d5355cea219147500c1b4a43f47 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 2 +- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 2 +- drivers/gpu/drm/amd

[PATCH 9/9] drm/amd/powerplay: add firmware cleanup on sw_fini

To avoid possible memory leak. Change-Id: I4740eac7fc2c6e934ec8f503e5a98057f0902f4a Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 ++ drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 + drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 1 + drivers/gpu/drm/amd

[PATCH 5/9] drm/amd/powerplay: clean up the APIs for pptable setup

Combine and simplify the logics for setup pptable. Change-Id: I062f15eab586050593afd960432c4c70fbdd5d41 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 17 drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 66 - .../gpu/drm/amd/powerplay/inc

[PATCH 4/9] drm/amd/powerplay: clean up the APIs for bootup clocks

Combine and simplify the logics for retrieving bootup clocks. Change-Id: Ifca28c454f3769dece0cc705ba054ff34db0ab60 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 4 - drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 - .../gpu/drm/amd/powerplay/inc

[PATCH 7/9] drm/amd/powerplay: clean up the SMU hw setup operations

Postpone some operations which are not must for hw setup to late_init. Thus, code sharing is possible between hw_init/fini and suspend/resume. Also this makes code more clean and readable. Change-Id: Id3996fd9e2dbf2ff59d8a6032cc5f6730db1295c Signed-off-by: Evan Quan --- drivers/gpu/drm/amd

[PATCH] drm/amd/powerplay: use work queue to perform throttling logging

As IO operations(access to SMU internals) and possible sleep are involved in throttling logging. Workqueue can handle them well. Otherwise we may hit "scheduling while atomic" error. Change-Id: I454d593e965e54b13fdf04c112abb0a022204278 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd

[PATCH 02/16] drm/amd/powerplay: drop unused APIs and unnecessary checks

Minor code cleanups. Change-Id: I6d240241e78cae17288c1d49dbae6ab1796b1128 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 74 --- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 2 - 2 files changed, 16 insertions(+), 60 deletions(-) diff --git a

[PATCH 06/16] drm/amd/powerplay: clean up the APIs for pptable setup

Combine and simplify the logics for setup pptable. Change-Id: I062f15eab586050593afd960432c4c70fbdd5d41 Signed-off-by: Evan Quan Acked-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 17 drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 66 - .../gpu/drm/amd

[PATCH 07/16] drm/amd/powerplay: clean up the overdrive settings

Eliminate the buffer allocation and drop the unnecessary overdrive table uploading. Change-Id: I8ba5383a330e6d5355cea219147500c1b4a43f47 Signed-off-by: Evan Quan Acked-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 2 +- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 2

[PATCH 13/16] drm/amd/powerplay: max code sharing between .hw_fini and .suspend

Thus redundant code can be dropped. Change-Id: I672f84ed5856da53b7f8f915b2f24ca11cd4b228 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 44 +++--- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay

[PATCH 04/16] drm/amd/powerplay: centralize all buffer allocation in sw_init phase

To fit common design. And this can simplify the buffer deallocation. Change-Id: Iee682e76aadb5f34861d69d5794ced44f0a78789 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 342 ++--- drivers/gpu/drm/amd/powerplay/smu_v11_0.c

[PATCH 10/16] drm/amd/powerplay: max code sharing between .hw_init and .resume

Then redundant code can be dropped. Change-Id: Icbafbb7ffc8189a09f4236786aea6702ee73f9f4 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 42 ++ 1 file changed, 18 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay

[PATCH 12/16] drm/amd/powerplay: better namings

And some minor changes as dropping unused parameter and label internal used API as static. Change-Id: I0af0aea029dc4fc7d8e150ab6ec984e9a5f1a74a Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 12 +--- drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 2

[PATCH 05/16] drm/amd/powerplay: clean up the APIs for bootup clocks

Combine and simplify the logics for retrieving bootup clocks. Change-Id: Ifca28c454f3769dece0cc705ba054ff34db0ab60 Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 4 - drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 - .../gpu/drm

[PATCH 14/16] drm/amd/powerplay: allocate the struct amdgpu_irq_src on the stack

Since it is only several bytes in size. Change-Id: Ie9df0db543fdd4cf5b963a286ef40dee03c436bf Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 3 --- drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 2 +- drivers/gpu/drm/amd/powerplay

[PATCH 11/16] drm/amd/powerplay: resort those operations performed in hw setup

Those common operations(for all ASICs) are placed first and followed by ASIC specific ones. While the display related are placed at the last. Change-Id: Id45caee98273c8c0b9c1c9f2713fcf8106e02000 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 61

[PATCH 01/16] drm/amd/powerplay: eliminate asic type check

By moving ASIC specific code into its own file. Change-Id: Ib6775c1c8c5211ea45db6c3fb604a8279411ab37 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 59 +++ drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 8 +-- drivers/gpu/drm/amd/powerplay

[PATCH 03/16] drm/amd/powerplay: implement a common API for dpms disablement

So that code can be shared between .hw_fini and .suspend. Change-Id: I4a0eeb7cdecbf5b24fac3d0fe1d8fcb1ca9f0b0a Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 178 + 1 file changed, 77 insertions(+), 101 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 09/16] drm/amd/powerplay: move those operations not needed for resume out

Since smu_smc_table_hw_init() is needed for both .hw_init and .resume. By doing this, we can drop unnecessary operations on resume. Change-Id: I2af6277efaa9adba2de69161e20e54c4aa10a411 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 40 +++--- 1 file

[PATCH 08/16] drm/amd/powerplay: postpone operations not must for hw setup to late_init

So that we do not need to perform those unnecessary operations again on resume. Change-Id: I90f8a8d68762b5f88d7477934128a17bf67e3341 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 57 +++--- 1 file changed, 28 insertions(+), 29 deletions(-) diff --git

[PATCH 16/16] drm/amd/powerplay: skip BACO feature on DPMs disablement

Instead of disabling and reenabling it later. Change-Id: I90775202178f3b7695f42f39ce240bbfd51a1346 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 72 ++ 1 file changed, 31 insertions(+), 41 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay

[PATCH 15/16] drm/amd/powerplay: add firmware cleanup on sw_fini

To avoid possible memory leak. Change-Id: I4740eac7fc2c6e934ec8f503e5a98057f0902f4a Signed-off-by: Evan Quan Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 ++ drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 + drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h

[PATCH 3/4] drm/amd/powerplay: update how to use metrics table on Sienna Cichlid

Retrieve only those data interested instead of the whole table. Change-Id: I6008351209be3b8812c547043a532e5fb90dd980 Signed-off-by: Evan Quan --- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 3 + .../drm/amd/powerplay/sienna_cichlid_ppt.c| 197 +- 2 files changed, 146

[PATCH 1/4] drm/amd/powerplay: update how to use metrics table on Arcturus

Retrieve only those interested metrics data instead of the whole metrics table. By this, the memory copy can be dropped. Change-Id: Ice2b2ba4647301119130be0ba65bb587f19d38ae Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 213 -- .../gpu/drm/amd

[PATCH 2/4] drm/amd/powerplay: update how to use metrics table on Navi10

Retrieve only those data interested instead of the whole table. Change-Id: I78a3ecce1075e73b96c2ee0b13aacc469bb09021 Signed-off-by: Evan Quan --- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 1 + drivers/gpu/drm/amd/powerplay/navi10_ppt.c| 180 -- 2 files changed, 127

[PATCH 4/4] drm/amd/powerplay: use the same interval as PMFW on retrieving metrics table

Current 100ms interval makes no sense. User gets outdated data due to this. Change-Id: Ie1d950285460443d493f1647463b68cbe4a5ec67 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 2 +- drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c | 2 +- 2 files changed, 2

[PATCH 3/3] drm/amd/powerplay: add error messages on some critical paths

Helpful for error diagnostic. Change-Id: I983ca308a2ee6ed11e16ec59ad97040d98b90512 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 118 +++-- 1 file changed, 87 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b

[PATCH 2/3] drm/amd/powerplay: forbid to use pr_err/warn/info/debug

Use dev_err/warn/info/dbg instead. They are more MGPU friendly. Change-Id: I07ad32c11dcf86cb1e3d1da1afa449f1f7dbd645 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 10 ++ drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 10 ++ drivers/gpu

[PATCH 2/3] drm/amd/powerplay: drop unnecessary wrappers

These APIs are used in amdgpu_smu.c only. Thus these wrappers are unnecessary. Change-Id: I7768a84e3a7dfbbfa624ac97d94138de52402827 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 24 drivers/gpu/drm/amd/powerplay/smu_internal.h | 3 --- 2 files

[PATCH 3/3] drm/amd/powerplay: correct the APIs' naming

'UVD' is a HW engine name for Vega20 and before ASICs. For newer ASICs, the similar engine is named as 'VCN'. Change-Id: I5f1b9500ed5d35e395a5da32b81a78eb87bffc68 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 13 + drivers/g

[PATCH 1/3] drm/amd/powerplay: drop dead vce powergate code

This was for Vega20. However Vega20 support is already dropped from current swSMU. Change-Id: I5400496dff2e338de4622823484b88cda6018ec1 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 6 ++ drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 1 - drivers/gpu/drm

[PATCH] drm/amd/powerplay: move maximum sustainable clock retrieving to .hw_init

Since DAL settings come between .hw_init and .late_init of SMU. And DAL needs to know the maximum sustainable clocks. Change-Id: I0702b7332a0d7c0b29dfdf4999c18efb588b8862 Signed-off-by: Evan Quan Reported-by: Flora Cui --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 19 +-- 1

[PATCH 5/7] drm/amd/powerplay: drop unused code around power limit

Drop unused APIs, variables and argument. Change-Id: I59c99de30bf3fa0e5ed058aaa8ab95d0a9c748aa Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c| 4 +-- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 20 --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 35

[PATCH 2/7] drm/amd/powerplay: maximize code sharing around power limit

Also cache the current and max power limits. Change-Id: Ida2ce964736bee2e558522441d3505f84c4e00f4 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 49 - .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 2 + drivers/gpu/drm/amd/powerplay/inc/smu_v11_0

[PATCH 6/7] drm/amd/powerplay: correct power limit retrieving based on current power source

Instead of hard coding it as SMU_POWER_SOURCE_AC. Change-Id: I57066b2c206f8e1e2276f959ff2704dcbe6e5d77 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b

[PATCH 1/7] drm/amd/powerplay: drop unnecessary get_pptable_power_limit wrappers

Minor code cleanup. Change-Id: I56a56ebe4a86e7fca5de02d41928f533dda4d185 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 10 -- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 3 +-- drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 3

[PATCH 3/7] drm/amd/powerplay: simplify the code around retrieving power limit

Use the cached max/current power limit for other cases except .late_init. Change-Id: Ia4c063207faf051db27be1956f40554913c31c3b Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 7 +++ drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 6 +- drivers/gpu

[PATCH 4/7] drm/amd/powerplay: simplify the code around setting power limit

Use the cached max/current power limit and move the input check to the top layer. Change-Id: Iefc7a89b871ce20422c2e70b8cd7ac85a0a7beba Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 11 +++ drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 16 ++-- 2

[PATCH 7/7] drm/amd/powerplay: add check for power limit OD support

Before counting the OD percent into max power limit margin. Change-Id: I83b24d614e07fbc5eac41ff7cd668a1c2f33c6b2 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay

[PATCH 1/2] drm/amd/powerplay: drop redundant .set_min_dcefclk_deep_sleep API

It has exactly the same functionality as .set_deep_sleep_dcefclk. Change-Id: Ib4d2d604ca014e194cb2b61ac770e4370ecad74d Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 11 +-- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 3 +-- drivers/gpu/drm

[PATCH 2/2] drm/amd/powerplay: drop unnecessary wrapper .populate_smc_tables

Since .populate_smc_tables is just a wrapper of .set_default_dpm_table. Change-Id: I80e89146359d6cf5d80f1887878d371b41b41cb0 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 +- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 - drivers/gpu/drm/amd

[PATCH 1/3] drm/amd/powerplay: drop unnecessary SMU_MSG_GetDpmClockFreq check

Since SMU_MSG_GetDpmClockFreq is known to be supported for Vega20 and before ASICs only. For those ASICs supporting swSMU, it is not supported. Change-Id: I8ee71664baa32e40df5bb793550785120f3770c6 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 17 +++-- 1

[PATCH 2/3] drm/amd/powerplay: revise the calling chain on sensor reading

milar changes will be coming. Change-Id: I95beba6c117b0cd3b0acea6158bf62240c6eac5a Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 81 --- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 2 - drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 2 +- drivers/gpu/drm/amd/powerplay/

[PATCH 3/3] drm/amd/powerplay: maximum code sharing on sensor reading

Move the common code to amdgpu_smu.c instead of having one copy in both smu_v11_0.c and smu_v12_0.c. Change-Id: Idc59c6f686139d034348a613f1a7b9213198312d Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 4 drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 4

[PATCH] drm/amd/powerplay: drop unnecessary "@" on OD sysfs output

To follow conventional style. And this unnecessary "@" confuses our userspace tool. Change-Id: Id4cdc611d63e800cf5a93449b6331a1e8323e727 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH] drm/amd/powerplay: declare driver if version mismatch as "warning" explicitly

So that user knows it's just a warning and can be safely ignored. Change-Id: Ic518ec3eb68c6bd6682e6131e32cfe90843341ff Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powe

[PATCH] drm/amd/powerplay: fix compile error with ARCH=arc

0d19eb853eb0a2e0c0d Reported-by: kernel test robot Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c index 677f8ad

[PATCH 1/4] drm/amd/powerplay: drop unnecessary wrappers around clock retrieving

By calling the target APIs directly. Change-Id: Ic1c92f26f7aeab334632a26bf75c3e232d1db0e1 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 9 - drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 1 - drivers/gpu/drm/amd/powerplay/navi10_ppt.c

[PATCH 2/4] drm/amd/powerplay: bypass wrapper on retrieving current clock frequency

By calling the target API(asic specific) directly. Change-Id: I711a57f46cd471928b7700b3a651ebfee9bf8206 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 363 +- drivers/gpu/drm/amd/powerplay/navi10_ppt.c| 5 +- .../drm/amd/powerplay

[PATCH 3/4] drm/amd/powerplay: unshare the code for retrieving current clock frequency

By moving them into asic specific file. Since they are really ASIC specific. Change-Id: I932369d5c2033ab8567d26bebcac053a500227f0 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 11 +++ drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 10

[PATCH 4/4] drm/amd/powerplay: drop unused code and wrapper around clock retrieving

Clean code by dropping unnecessary ones. Change-Id: Idf89ef6fa787b61cd8baf8ded7e3f323bdcef189 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 8 +++- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 3 -- drivers/gpu/drm/amd/powerplay/inc/smu_v11_0.h | 8

[PATCH 2/4] drm/amd/powerplay: revise calling chain on setting soft limit

This helps to maintain clear code layers and drop unnecessary parameter. Change-Id: I2d27547414d964552d0515e76e165d34c8ce0132 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 +- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 20 + .../gpu/drm/amd

[PATCH 1/4] drm/amd/powerplay: put setting hard limit common code in smu_v11_0.c

As designed the common code shared among all smu v11 ASCIs go to smu_v11_0.c. This helps to maintain clear code layers. Change-Id: Ib5bd4b40702f1442a4b094d927aa5fc101b960c5 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 36 - .../gpu/drm/amd

[PATCH 4/4] drm/amd/powerplay: put dpm frequency setting common code in smu_v11_0.c

As designed the common code shared among all smu v11 ASCIs go to smu_v11_0.c. This helps to maintain clear code layers. Change-Id: I1f848eba0b6b56f8b5ef6f0888ee6955ba1d2070 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 65 -- .../gpu/drm/amd/powerplay

[PATCH 3/4] drm/amd/powerplay: revise calling chain on retrieving frequency range

This helps to maintain clear code layers and drop unnecessary parameter. Change-Id: I2250a014759a0c855e476bbfa9642c1efc47ae26 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 6 +-- drivers/gpu/drm/amd/powerplay

[PATCH 05/14] drm/amd/powerplay: add new UMD pstate data structure

This is used to cache the clock frequencies for all UMD pstates. So that we do not need to calculate from scratch on every UMD pstate switch. Change-Id: I3f2ef5ee2e6e433518f726988bbe5970848b99c8 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 15 +++ 1

[PATCH 02/14] drm/amd/powerplay: update Arcturus default dpm table setting

Preparing for coming code sharing around performance level setting. Change-Id: Ie32b6af39f22d05c08096959bab0e02e53856170 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 297 +++--- drivers/gpu/drm/amd/powerplay/inc/smu_v11_0.h | 4 + drivers/gpu/drm

[PATCH 06/14] drm/amd/powerplay: update UMD pstate clock settings

Preparing for coming code sharing around performance level setting. Change-Id: I51b1536b62995f0fecd51b91f238793f57485aa9 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 6 +- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 47 ++--- drivers/gpu/drm/amd

[PATCH 03/14] drm/amd/powerplay: update Navi10 default dpm table setup

Cache all clocks levels for every dpm table. They are needed by other APIs. Change-Id: I8114cf31e6ec8c9af4578d51749eb213befdcc71 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 182 ++--- 1 file changed, 158 insertions(+), 24 deletions(-) diff --git a

[PATCH 07/14] drm/amd/powerplay: update the common API for performance level setting

So that it can be more widely shared around SMU v11 ASICs. Change-Id: Ie110edf2ec519699448d3ff3215188ba243d2415 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 91 +++ 1 file changed, 77 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 12/14] drm/amd/powerplay: drop unnecessary wrappers

By calling the target APIs directly. Change-Id: I0f24f603d2fcb94d2078a35c405a1406093ba5e3 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay

[PATCH 11/14] drm/amd/powerplay: drop Sienna Cichlid specific set_soft_freq_limited_range

Use the common smu_v11_0_set_soft_freq_limited_range. Change-Id: I9f8772880b324ce9e741291751bb1b8ff4c36ea3 Signed-off-by: Evan Quan --- .../drm/amd/powerplay/sienna_cichlid_ppt.c| 20 ++- drivers/gpu/drm/amd/powerplay/smu_internal.h | 1 - drivers/gpu/drm/amd/powerplay

[PATCH 10/14] drm/amd/powerplay: drop unnecessary Sienna Cichlid specific APIs

As a common performance level setting API is used. Then these ASIC specific APIs are not needed any more. Change-Id: I04c810859794b07ce8905a8df797ed6b5ae116a8 Signed-off-by: Evan Quan --- .../drm/amd/powerplay/sienna_cichlid_ppt.c| 178 +- 1 file changed, 1 insertion(+), 177

[PATCH 01/14] drm/amd/powerplay: add more members for dpm table

These members can help to cache the clock frequencies for all dpm levels. Then simplifying the code for dpm level switching is possible. Change-Id: Ic80359adb8c0e018f306782f24e3f8906436f5e2 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/inc/smu_v11_0.h | 15 +-- 1 file

[PATCH 09/14] drm/amd/powerplay: drop unnecessary Navi1x specific APIs

As a common performance level setting API is used. Then these ASIC specific APIs are not needed any more. Change-Id: I2c8831b9d00618c6578ee42b34e26892c5dba515 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 248 + 1 file changed, 1 insertion(+), 247

[PATCH 04/14] drm/amd/powerplay: update Sienna Cichlid default dpm table setup

Cache all clocks levels for every dpm table. They are needed by other APIs. Change-Id: Idaa853356720e48ab3279f420ba1ae18bb7de4fd Signed-off-by: Evan Quan --- .../drm/amd/powerplay/sienna_cichlid_ppt.c| 234 -- 1 file changed, 211 insertions(+), 23 deletions(-) diff --git a

[PATCH 08/14] drm/amd/powerplay: drop unnecessary Arcturus specific APIs

As a common performance level setting API is used. Then these ASIC specific APIs are not needed any more. Change-Id: Icd96ce42218d78d670dd0c1f88663fd42108b311 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 170 --- 1 file changed, 170 deletions

[PATCH 13/14] drm/amd/powerplay: drop smu_v12_0.c unnecessary wrapper

By moving the implemention to renoir_ppt.c considering it's really ASIC specific. Change-Id: I6f7a594235dffdf75b56d1de5b9dc6d49833d7e8 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/inc/smu_v12_0.h | 3 - drivers/gpu/drm/amd/powerplay/renoir_ppt.c

[PATCH 14/14] drm/amd/powerplay: drop unused APIs and parameters

Leftover of previous performance level setting cleanups. Change-Id: Idddc4adce365b34eacbc13f75cc0629859c6d412 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 12 ++-- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 9 +++-- drivers/gpu/drm/amd

[PATCH] drm/amd/powerplay: correct the .get_workload_type() pointer

This seemed a typo. Change-Id: I1e4da590829395617e90d0d43562f934a1ae0234 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/smu_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/smu_internal.h b/drivers/gpu/drm/amd/powerplay

[PATCH 1/2] drm/amd/powerplay: drop unnecessary wrapper around pcie parameters setting

This can also help to maintain clear code layer. Change-Id: I9bf6a7bb93112ae40bd549ee4d7afb42a968aacf Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 33 ++- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 - .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h

[PATCH 2/2] drm/amd/powerplay: correct the supported pcie GenSpeed and LaneCount

The LCLK dpm table setup should be performed in .update_pcie_parameters(). Otherwise, the updated GenSpeed and LaneCount information will be lost. Change-Id: I028c26ca0e54098cb93d9e9266719f1762ba2d7e Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 17

[PATCH 4/6] drm/amd/powerplay: sort the call flow on temperature ranges retrieving

This can help to maintain clear code layer. Change-Id: I9c95dd70273ab56c1ddb40592574ed283a34737f Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 33 +++ drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 2 ++ .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h

[PATCH 1/6] drm/amd/powerplay: correct Navi1X temperature limit settings

These are needed for temp1/2/3 related hwmon interfaces. Change-Id: I4fe04dc65ba2153bbb9c507769a9d8ddeac66094 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 6 +- drivers/gpu/drm/amd/powerplay/inc/smu_v11_0.h | 4 drivers/gpu/drm/amd/powerplay

[PATCH 2/6] drm/amd/powerplay: correct Sienna Cichlid temperature limit settings

These are needed for temp1/2/3 related hwmon interfaces. Change-Id: I76ec427aaae67a0dd257e2b1d7908990eb79a5b2 Signed-off-by: Evan Quan --- .../gpu/drm/amd/powerplay/sienna_cichlid_ppt.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 3/6] drm/amd/powerplay: cache the software_shutdown_temp

As it's needed in the succeeding thermal irq setting. Change-Id: Iee34fb6515a88a684c7f1214e40edb7e65245f8d Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 4 drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 1 + drivers/gpu/drm/amd/powe

<    1   2   3   4   5   6   7   8   9   10   >