zhi Zuo
Acked-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 15
> .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 71 +++
> drivers/gpu/drm/amd/display/dc/dc.h | 6 ++
> drivers/gpu/drm/amd/display/dc/dc_dp_type
dgpu/display: set vblank_disable_immediate for
> DC")
>
> Cc: Harry Wentland
> Cc: Alex Deucher
> Signed-off-by: Nicholas Kazlauskas
Now I'm curious whether vblank_disable_immediate or PSR
save more power.
Reviewed-by: Harry Wentland
Harry
> ---
> driv
On 2021-11-30 10:46, Rodrigo Siqueira Jordao wrote:
>
>
> On 2021-11-29 7:06 a.m., Jani Nikula wrote:
>> On Fri, 26 Nov 2021, Daniel Vetter wrote:
>>> On Thu, Nov 25, 2021 at 10:38:25AM -0500, Rodrigo Siqueira wrote:
Display core documentation is not well organized, and it is hard to find
>
On 2021-11-30 10:59, Rodrigo Siqueira Jordao wrote:
>
>
> On 2021-11-30 10:48 a.m., Harry Wentland wrote:
>> On 2021-11-30 10:46, Rodrigo Siqueira Jordao wrote:
>>>
>>>
>>> On 2021-11-29 7:06 a.m., Jani Nikula wrote:
>>>> On Fri, 26 Nov
On 2021-12-01 15:33, Alex Deucher wrote:
> Reorder the code to fix the warning.
>
> Fixes: 8808f3ffb14d79 ("drm/amd/display: Add DP-HDMI FRL PCON Support in DC")
> Cc: Fangzhi Zuo
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> driv
f ("drm/amd/display: Fix DCN3 B0 DP Alt Mapping")
> Cc: Mario Limonciello
> Cc: Harry Wentland
> Signed-off-by: Nicholas Kazlauskas
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 3 ++-
> 1 file changed, 2 i
Thanks for this. It's really good to see this.
Reviewed-by: Harry Wentland
Harry
On 2021-12-09 09:20, Rodrigo Siqueira wrote:
> Display Core (DC) is one of the components under amdgpu, and it has
> multiple features directly related to the KMS API. Unfortunately, we
> don
On 2021-12-09 03:02, Yizhuo Zhai wrote:
> Hi All:
> I just found a bug in the cramfs using the static analysis tool, but
> not sure if this could happen in reality, could you please advise me
> here? Thanks for your attention : ) And please ignore the last one
> with HTML format if you did not fi
des the driver interface to interact with the GFX/Compute engine.
> +
> +MEC (MicroEngine Compute)
> +The is the microcontroller that controls the compute queues on the
This should probably say "This is..." or "The MEC is..."
Again, really nice to see this. I can&
low).
I've been wondering if it's appropriate to call our chips ASICs? I
know we do it all the time but our chips strike me more as general-
purpose use devices than application-specific devices.
I might be bike-shedding a bit. Overall this is a great summary of
AMD GPUs and will s
low).
I've been wondering if it's appropriate to call our chips ASICs? I
know we do it all the time but our chips strike me more as general-
purpose use devices than application-specific devices.
I might be bike-shedding a bit. Overall this is a great summary of
AMD GPUs and will s
With Christian's comments addressed both patches are
Reviewed-by: Harry Wentland
Harry
On 2021-12-10 10:54, Mario Limonciello wrote:
> `edp_stream` is only used when backend is enabled on eDP, don't
> declare the variable outside that scope.
>
> Signed-off
On 2021-03-19 10:22 a.m., Alex Deucher wrote:
On Fri, Mar 19, 2021 at 3:23 AM Evan Benn wrote:
AMDGPU_DM_DEFAULT_MIN_BACKLIGHT was set to the value of 12
to ensure no display backlight will flicker at low user brightness
settings. However this value is quite bright, so for devices that do n
’
[-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:913:16:
warning: no previous prototype for ‘dce80_validate_global’
[-Wmissing-prototypes]
Cc: Harry Wentland
Cc: Leo Li
Cc: Alex Deucher
Cc: "Christian König"
Cc: David Airlie
Cc: Daniel Vetter
Cc: A
/../display/dc/calcs/dce_calcs.c:2016:1: warning:
the frame size of 1216 bytes is larger than 1024 bytes [-Wframe-larger-than=]
Cc: Harry Wentland
Cc: Leo Li
Cc: Alex Deucher
Cc: "Christian König"
Cc: David Airlie
Cc: Daniel Vetter
Cc: Colin Ian King
Cc: amd-gfx@lists.freedesktop.org
s for dsc bpp in 16ths and unify bw
calculations")
Signed-off-by: Alex Deucher
Cc: Dillon Varone
Cc: Stephen Rothwell
Reviewed-by: Harry Wentland
Harry
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++--
drivers/gpu/drm/amd/display/dc/dc_dsc.h | 2 ++
2 files
tions which does
mutex_lock().
Signed-off-by: Nirmoy Das
Reviewed-by: Harry Wentland
Harry
---
drivers/gpu/drm/amd/display/dc/dce/dce_abm.c | 2 +-
drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c | 6 ++---
.../gpu/drm/amd/display/dc/dcn20/dcn20_dccg.c | 2 +-
.../drm/amd/display/dc/
On 2021-03-11 9:22 a.m., Alex Deucher wrote:
On Wed, Feb 17, 2021 at 11:53 AM Harry Wentland wrote:
On 2021-02-16 12:28 p.m., Alex Deucher wrote:
Commit 098214999c8f added fetching of the AUX_DPHY register
values from the vbios, but it also changed the default values
in the case when
rn it into
an helper that can be shared across those drivers.
Signed-off-by: Maxime Ripard
Patches 1 & 2 are
Reviewed-by: Harry Wentland
Harry
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 21 +-
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 17 +--
driver
drown out the rest of the driver's
DRM_DEBUG_DRIVER messages.
Cc: Harry Wentland
Cc: Alex Deucher
Signed-off-by: Luben Tuikov
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 67 +--
1 file changed, 33 insertions(+), 34 deletions(-)
diff --git a/drivers/gpu/dr
+Nick, Bhawan
On 2021-03-24 4:39 p.m., Alex Deucher wrote:
On Tue, Mar 23, 2021 at 4:18 AM Thomas Lambertz wrote:
DMCUB_SCRATCH_0 sometimes contains 0xdeadbeef during initialization.
If this is detected, return 0 instead. This prevents wrong bit-flags
from being read.
The main impact of this
On 2021-03-24 5:13 p.m., Harry Wentland wrote:
+Nick, Bhawan
On 2021-03-24 4:39 p.m., Alex Deucher wrote:
On Tue, Mar 23, 2021 at 4:18 AM Thomas Lambertz
wrote:
DMCUB_SCRATCH_0 sometimes contains 0xdeadbeef during initialization.
If this is detected, return 0 instead. This prevents wrong
: Harry Wentland
Harry
Alex
---
From c9398160caf4ff20e63b8ba3a4366d6ef95c4ac3 Mon Sep 17 00:00:00 2001
From: Werner Sembach
Date: Wed, 17 Mar 2021 12:52:22 +0100
Subject: [PATCH] Retry forcing YCbCr420 color on failed encoder validation
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
On 2021-03-29 3:54 a.m., Louis Li wrote:
[Why]
This issue is found when scaling is not equal to one from src to dest.
When issue happens, there are offsets in both axis x and y between
two cursors. Users cannot control APP under such a condition.
What's the use case? I don't think we support t
avoid spamming the log when DRM_DEBUG_KMS."
The change is
Reviewed-by: Harry Wentland
Harry
[how]
Define and use pr_debug macros instead of a few spammy DRM_DEBUG_*'s.
Signed-off-by: Victor Lu
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 20 +--
.../drm/amd/
On 2021-03-30 10:28 p.m., Alex Deucher wrote:
Missing check for CONFIG_DRM_AMD_DC_DCN.
Fixes: 752106f5c5cd ("drm/amd/display: Set max TTU on DPG enable")
Signed-off-by: Alex Deucher
Cc: Wesley Chalmers
Cc: Stephen Rothwell
Reviewed-by: Harry Wentland
Harry
---
drivers/g
On 2021-04-01 10:22 a.m., Alex Deucher wrote:
Use uintptr_t rather than uint64_t.
Signed-off-by: Alex Deucher
Cc: Dave Airlie
Cc: Harry Wentland
Reviewed-by: Harry Wentland
Harry
---
drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On 2021-04-07 4:34 a.m., Jude Shih wrote:
[Why & How]
We use outbox interrupt that allows us to do the AUX via DMUB
Therefore, we need to add some irq source related definition
in the header files;
Signed-off-by: Jude Shih
Reviewed-by: Harry Wentland
Harry
---
drivers/gpu/drm
)
| ^~
Fixes: 83b39e1fc3ea ("drm/amd/display: Log DMCUB trace buffer events")
Cc: Leo (Hanghong) Ma
Cc: Daniel Wheeler
Cc: Harry Wentland
Cc: Solomon Chiu
Cc: Alex Deucher
Signed-off-by: Shaokun Zhang
Reviewed-by: Harry Wentland
Harry
---
drivers/gpu/drm/amd/display
d-by: Harry Wentland
Harry
---
drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
index a928c1d9
x27;t have a proper driver validation for the above case, we can see
some problems like a duplicate cursor in applications that use multiple
planes. This commit fixes the cursor issue and others by adding adequate
verification for multiple planes.
Cc: Louis Li
Cc: Nicholas Kazlauskas
Cc: Harry Wen
uis Li
Cc: Nicholas Kazlauskas
Cc: Harry Wentland
Cc: Hersen Wu
Cc: Sean Paul
Signed-off-by: Rodrigo Siqueira
EIther way, this patch is
Reviewed-by: Harry Wentland
Harry
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 51 +++
1 file changed, 51 insertions(+)
di
On 2021-04-15 1:55 p.m., Shashank Sharma wrote:
This patch checks the return value of the function
dc_link_add_remote_sink before using it. This was causing
a crash during consecutive hotplugs of DP MST displays.
Cc: Harry Wentland
Signed-off-by: Shashank Sharma
Reviewed-by: Harry Wentland
src_y values.
Signed-off-by: Harry Wentland
Change-Id: I5e951f95fc87c86517b9ea6e094d73603184f00b
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdg
src_y values.
v2:
- Add code comment describing the reason we're rejecting non-zero
src_x and src_y
- Drop gerrit Change-Id
- Add stable CC
- Based on amd-staging-drm-next
Signed-off-by: Harry Wentland
Cc: sta...@vger.kernel.org
Cc: nicholas.kazlaus...@amd.com
Cc: amd-gfx@lists.freed
src_y values.
v2:
- Add code comment describing the reason we're rejecting non-zero
src_x and src_y
- Drop gerrit Change-Id
- Add stable CC
- Based on amd-staging-drm-next
v3: removed trailing whitespace
Signed-off-by: Harry Wentland
Cc: sta...@vger.kernel.org
Cc: nicholas.kazlaus.
.
Might cause problems to try to access a subsampled surface if the
coordinates doesn't make much sense.
Anyway patch is Acked-by: Christian König
Thanks,
Harry
Regards,
Christian.
Am 23.04.21 um 16:09 schrieb Harry Wentland:
[Why]
This hasn't been well tested and leads to complete sy
## Introduction
We are looking to enable HDR support for a couple of single-plane and
multi-plane scenarios. To do this effectively we recommend new interfaces to
drm_plane. Below I'll give a bit of background on HDR and why we propose these
interfaces.
## Defining a pixel's luminance
Curr
From: Bhawanpreet Lakha
Add the following color encodings
- RGB versions for BT601, BT709, BT2020
- DCI-P3: Used for digital movies
Signed-off-by: Bhawanpreet Lakha
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/drm_color_mgmt.c | 4
include/drm/drm_color_mgmt.h | 4
2 files
nits
The usage is similar to color_encoding and color_range where the driver
can specify the default and supported tfs and pass it into
drm_plane_create_color_properties().
Signed-off-by: Bhawanpreet Lakha
Signed-off-by: Harry Wentland
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4
imum white level for the SDR plane.
Signed-off-by: Bhawanpreet Lakha
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/drm_atomic_uapi.c | 4
drivers/gpu/drm/drm_color_mgmt.c | 17 +
include/drm/drm_color_mgmt.h | 6 ++
include/drm/drm_plane.h
On 2021-04-26 2:07 p.m., Ville Syrjälä wrote:
On Mon, Apr 26, 2021 at 01:38:50PM -0400, Harry Wentland wrote:
From: Bhawanpreet Lakha
Add the following color encodings
- RGB versions for BT601, BT709, BT2020
- DCI-P3: Used for digital movies
Signed-off-by: Bhawanpreet Lakha
Signed-off-by
ll IGT tests start to pass again, which means our overlay
> support works as expected.
>
> Cc: Tianci.Yin
> Cc: Harry Wentland
> Cc: Nicholas Choi
> Cc: Bhawanpreet Lakha
> Cc: Nicholas Kazlauskas
> Cc: Mark Yacoub
> Cc: Daniel Wheeler
>
> Signed-off-by: Rod
On 2021-04-30 6:39 a.m., Shashank Sharma wrote:
> Hello Pekka,
>
> On 30/04/21 15:13, Pekka Paalanen wrote:
>> On Wed, 28 Apr 2021 13:24:27 +0530
>> Shashank Sharma wrote:
>>
>>> Assuming these details, A compositor will look for DRM color properties
>>> like these:
>>>
>>> 1. Degamma plane pr
On 2021-04-30 8:53 p.m., Sebastian Wick wrote:
> On 2021-04-26 20:56, Harry Wentland wrote:
>> On 2021-04-26 2:07 p.m., Ville Syrjälä wrote:
>>> On Mon, Apr 26, 2021 at 01:38:50PM -0400, Harry Wentland wrote:
>>>> From: Bhawanpreet Lakha
>>>>
>>
On 2021-04-27 10:50 a.m., Pekka Paalanen wrote:
> On Mon, 26 Apr 2021 13:38:49 -0400
> Harry Wentland wrote:
>
>> ## Introduction
>>
>> We are looking to enable HDR support for a couple of single-plane and
>> multi-plane scenarios. To do this effectively
on on crtc
Bhawanpreet Lakha (3):
drm/color: Add transfer functions for HDR/SDR on drm_plane
drm/color: Add sdr boost property
drm/color: Add color space plane property
Harry Wentland (3):
drm/doc: Color Management and HDR10 RFC
drm/color: Add output transfer function to crtc
drm/amd/display
nance definition
* define input/output transfer functions for luminance space transforms,
rather than defining the luminance space of an input directly
Signed-off-by: Harry Wentland
---
Documentation/gpu/rfc/hdr-wide-gamut.rst | 416 +++
Documentation/gpu/rfc/index.rst
quot; from transfer function name (Harry)
- add DRM_TF_UNDEFINED enum as legacy default (Harry)
Signed-off-by: Bhawanpreet Lakha
Signed-off-by: Harry Wentland
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +-
.../gpu/drm/arm/display/komeda/komeda_plane.c | 4 +-
drivers/g
imum white level for the SDR plane.
v2:
- fix type in description
Signed-off-by: Bhawanpreet Lakha
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/drm_atomic_uapi.c | 4
drivers/gpu/drm/drm_color_mgmt.c | 17 +
include/drm/drm_color_mgmt.h | 6 ++
i
ucing named transfer functions. The original
LUT behavior is preserved with the default "1D LUT" transfer function.
Signed-off-by: Harry Wentland
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 11 +++-
.../gpu/drm/arm/display/komeda/komeda_crtc.c | 7 ++-
drivers/gpu/drm/ar
From: Bhawanpreet Lakha
Add color space definitions for BT601, BT709, BT2020, and DCI-P3.
Default to BT709, the sRGB color space.
Signed-off-by: Bhawanpreet Lakha
Signed-off-by: Harry Wentland
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +
.../gpu/drm/arm/display/komeda
Show the CSC matrixes in a 4x3 format.
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/inc/hw/dpp.h | 28 +
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/dpp.h
b/drivers/gpu/drm/amd/display/dc/inc/hw
uot;drm/amd/display: fix a crash on USB4 over C20 PHY")
> Cc: Rodrigo Siqueira
> Cc: Harry Wentland
> Signed-off-by: Nicholas Kazlauskas
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 5 +
> 1 file changed, 1 insertion
On 2021-12-21 16:18, Alex Deucher wrote:
> On Tue, Dec 21, 2021 at 1:47 PM Deucher, Alexander
> wrote:
>>
>> [Public]
>>
>>> -Original Message-
>>> From: Deucher, Alexander
>>> Sent: Tuesday, December 21, 2021 12:01 PM
>>> To: Linus Torvalds ; Imre Deak
>>> ; amd-gfx@lists.freedesktop.o
rence before null check")
> Fixes: 3f68c01be9a22 ("drm/amd/display: add cyan_skillfish display support")
> Signed-off-by: José Expósito
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 3 ++-
> 1 file changed, 2 insertions(+),
On 2022-01-04 10:33, Mario Limonciello wrote:
> The WA from commit 5965280abd30 ("drm/amd/display: Apply w/a for
> hard hang on HPD") causes a regression in s0ix where the system will
> fail to resume properly. This may be because an HPD was active the last
> time clocks were updated but clocks
ters.
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
index 57f2729a7bd0..8367ecf61af1 100644
--- a/drivers/gpu/drm/a
On 2022-01-05 12:06, Mario Limonciello wrote:
> The WA from commit 5965280abd30 ("drm/amd/display: Apply w/a for
> hard hang on HPD") causes a regression in s0ix where the system will
> fail to resume properly. This may be because an HPD was active the last
> time clocks were updated but clocks di
registers.
Cc: sta...@vger.kernel.org
Signed-off-by: Harry Wentland
Reviewed-by: Huang Rui
Acked-by: Christian König
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.
On 2022-01-10 04:06, Rajib Mahapatra wrote:
> [Why]
> During resume path, dpcd_set_source_specific_data is taking
> extra time when core_link_write_dpcd fails on DP_SOURCE_OUI+0x03
> and DP_SOURCE_MINIMUM_HBLANK_SUPPORTED. Here,aux->transfer fails
> with multiple retries and consume sigficantamount
t; Fixes: e27c41d5b0681 ("drm/amd/display: Support for DMUB HPD interrupt
> handling")
> Addresses-Coverity-ID: 1493909 ("Null pointer dereference")
> Signed-off-by: José Expósito
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/
om
synchronization.
v2:
Don't drop is_blanked logic
Reviewed-by: Jun Lei
Reviewed-by: Mustapha Ghaddar
Acked-by: Bhawanpreet Lakha
Signed-off-by: meenakshikumar somasundaram
Tested-by: Daniel Wheeler
Signed-off-by: Alex Deucher
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/disp
On 2022-01-11 02:52, Mahapatra, Rajib wrote:
> dpcd_set_source_specific_data is not specific to OLED panel. It is called
> from boot-up path also.
> Hersen Wu introduced it in resume-path while enabling OLED panel for Linux in
> below commit.
>
If we set it in the boot-up path we'll probabl
A bad merge of
1abaa75bae9e ("drm/amd/display: Fix for otg synchronization logic")
caused Linus to see a lot of underflow on his two 4k displays.
This set pulls his revert and fixes up the original patch.
Linus Torvalds (1):
Revert "drm/amd/display: Fix for otg synchronization logic"
Meenakshi
-=wg9hDde_L3bK9tAfdJ4N=TJJ+SjO3ZDONqH5=bvoy_...@mail.gmail.com/
Cc: Alex Deucher
Cc: Daniel Vetter
Cc: Harry Wentland
Cc: Dave Airlie
Cc: Christian Koenig
Cc: Jun Lei
Cc: Mustapha Ghaddar
Cc: Bhawanpreet Lakha
Cc: meenakshikumar somasundaram
Cc: Daniel Wheeler
Signed-off-by: Linus Torvalds
---
drivers
:
Don't drop is_blanked logic
Reviewed-by: Jun Lei
Reviewed-by: Mustapha Ghaddar
Acked-by: Bhawanpreet Lakha
Signed-off-by: meenakshikumar somasundaram
Tested-by: Daniel Wheeler
Signed-off-by: Alex Deucher
Signed-off-by: Harry Wentland
Cc: torva...@linux-foundation.org
---
drivers/gpu/dr
On 2022-01-11 15:51, Linus Torvalds wrote:
> On Tue, Jan 11, 2022 at 7:38 AM Harry Wentland wrote:
>>
>> Attached is a v2 of the buggy patch that should get this right.
>> If you have a chance to try it out let us know
>
> I can confirm that I do not see the horrib
On 2022-01-12 10:53, Alex Deucher wrote:
> On Wed, Jan 12, 2022 at 9:28 AM Harry Wentland wrote:
>>
>> From: Meenakshikumar Somasundaram
>>
>> [Why]
>> During otg sync trigger, plane states are used to decide whether the otg
>> is already synchronized
rt modifiers but infer the actual layout of the
> underlying buffer. Therefore, a new flag fb_modifiers_not_supported is
> introduced for these legacy drivers, and allow_fb_modifiers is replaced
> with this new flag.
>
> Signed-off-by: Tomohito Esaki
Acked-by: Harry Wentland
Harr
eucher
Series is
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> b/drivers/gpu/drm/amd/display/dc/co
On 2022-01-21 06:26, Yongzhi Liu wrote:
> [why]
> Resource release is needed on the error handling path
> to prevent memory leak.
>
> [how]
> Fix this by adding kfree on the error handling path.
>
> Signed-off-by: Yongzhi Liu
Reviewed-by: Harry Wentland
Harry
>
for intersect_frl_link_bw_support() instead
>
> Fixes: c022375ae095 ("drm/amd/display: Add DP-HDMI FRL PCON Support in DC")
> Signed-off-by: Randy Dunlap
> Reported-by: kernel test robot
> Cc: Fangzhi Zuo
> Cc: Alex Deucher
> Cc: Nicholas Kazlauskas
> Cc: Harr
of the original patch.
>
> Fixes: 2e45b19dd882 ("drm/amd/display: retain/release at proper places in
> link_enc assignment")
>
> Cc: Qingqing Zhuo
> Cc: Aurabindo Pillai
> Cc: Rodrigo Siqueira
> Signed-off-by: Nicholas Kazlauskas
Reviewed-by: Harry Wentlan
On 2022-01-24 09:17, Alex Deucher wrote:
> This breaks HDMI audio.
>
Do we have more info? This is DP code, but maybe the display is connected via a
DP-HDMI adapter? Or via a n MST or USB-C hub?
As Siqueira mentioned, we couldn't reproduce the issue and the original change
was intended to fix
On 2022-01-25 06:32, Lazar, Lijo wrote:
>
>
> On 1/20/2022 11:34 PM, Alex Deucher wrote:
>> Some architectures (e.g., ARM) throw an compilation error if the
>> udelay is too long. In general udelays of longer than 2000us are
>> not recommended on any architecture. Switch to msleep in these
>
ith new caller link_hwss->set_throttled_vcp_size
> which needs that hook, and that causes null ptr hang.
>
> Signed-off-by: Fangzhi Zuo
Reviewed-by: Harry Wentland
Harry
> ---
> .../display/dc/dcn31/dcn31_hpo_dp_stream_encoder.c| 11 +++
> .../display/d
ositive either way.
>
> Signed-off-by: Bas Nieuwenhuizen
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dml/calcs/dcn_calcs.c | 1 -
> .../gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c | 2 --
> .../drm/amd/display/dc/dml/dc
On 2022-01-26 04:39, Lucas De Marchi wrote:
> Remove the local yesno() implementation and adopt the str_yes_no() from
> linux/string_helpers.h.
>
> Signed-off-by: Lucas De Marchi
Reviewed-by: Harry Wentland
Harry
> ---
> .../drm/amd/display/amdgpu_dm/amdgpu_
derstood, so decrease the assertion to a clearer warning about the problem.
>
> Signed-off-by: Mario Limonciello
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>
leaving the 2017 quirk in its original place or moving it
down works. I don't have a strong preference.
With the comment style addressed this patch is
Reviewed-by: Harry Wentland
Harry
Regards
Aditya
On 2022-01-28 12:35, Colin Ian King wrote:
> There are quite a few spelling mistakes in various function names
> and error messages. Fix these.
>
> Signed-off-by: Colin Ian King
Reviewed-by: Harry Wentland
Harry
> ---
> .../amd/display/amdgpu_dm/amdgpu
On 2022-01-28 20:04, Yang Li wrote:
> Eliminate the follow smatch warning:
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c:2246
> dp_perform_8b_10b_link_training() warn: inconsistent indenting
>
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
Reviewed-by: Harr
k_hwss")
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c
> b/d
On 2022-02-02 13:49, Fangzhi Zuo wrote:
> From: Wayne Lin
>
> [Why]
> commit "drm/amd/display: turn DPMS off on connector unplug" and
> commit "drm/amd/display: Clear dc remote sinks on MST disconnect"
> were trying to resolve the resource problem when we connectors get
> disconnected under MS
nks on MST disconnect"
> - Revise a bit the logic in above patches and change to turn DPMS
> off/clear dc remote sink within amdgpu_dm_mst_connector_early_unregister().
> Since drm will call .early_unregister for all disconnected connectors,
> we can ensure to also handle disconnecte
Series is
Reviewed-by: Harry Wentland
Harry
On 2022-02-03 13:58, Alex Deucher wrote:
> To align with other headers.
>
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c | 4 ++--
> .../amd/include/asic_reg/{dcn => dpcs
Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> b/drivers/gpu/drm/amd/display/
call to drm_plane_create_color_properties
with a default of BT709 means we're getting BT709 as color_encoding
as part of atomic commits.
Harry
> Fix the mismatch by using an initial value of BT601 in
> drm_plane_create_color_properties().
>
> Cc: amd-gfx@lists.freedesktop.or
On 2022-02-07 13:57, Harry Wentland wrote:
> On 2022-02-07 11:34, Maxime Ripard wrote:
>> The amdgpu KMS driver calls drm_plane_create_color_properties() with a
>> default encoding set to BT709.
>>
>> However, the core will ignore it and the driver doesn't forc
On 2022-02-10 03:42, Maxime Ripard wrote:
> Hi Harry,
>
> On Mon, Feb 07, 2022 at 01:59:38PM -0500, Harry Wentland wrote:
>> On 2022-02-07 13:57, Harry Wentland wrote:
>>> On 2022-02-07 11:34, Maxime Ripard wrote:
>>>> The amdgpu KMS driver calls drm_pl
")
> Signed-off-by: Michel Dänzer
Looks reasonable to me.
Reviewed-by: Harry Wentland
Harry
> ---
> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 +
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgp
On 2021-05-18 3:56 a.m., Pekka Paalanen wrote:
> On Mon, 17 May 2021 15:39:03 -0400
> Vitaly Prosyak wrote:
>
>> On 2021-05-17 12:48 p.m., Sebastian Wick wrote:
>>> On 2021-05-17 10:57, Pekka Paalanen wrote:
>>>> On Fri, 14 May 2021 17:05:11 -0400
>>
On 2021-05-17 4:34 a.m., Pekka Paalanen wrote:
> On Fri, 14 May 2021 17:04:51 -0400
> Harry Wentland wrote:
>
>> On 2021-04-30 8:53 p.m., Sebastian Wick wrote:
>>> On 2021-04-26 20:56, Harry Wentland wrote:
>
> ...
>
>>>> Another reason I'm
On 2021-05-17 3:08 p.m., Alex Deucher wrote:
> Unused so remove them.
>
> Fixes: 5791d219561cb6 ("drm/amd/display: Refactor and add visual confirm for
> HW Flip Queue")
> Signed-off-by: Alex Deucher
> Cc: Wyatt Wood
Series is
Reviewed-by: Harry Wentland
Harry
On 2021-05-11 11:44 a.m., Alex Deucher wrote:
> To stay consistent with the user's setting.
>
> v2: rebase on multi-eDP support
>
Series is
Reviewed-by: Harry Wentland
Harry
> Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1337>> Signed-off-by:
> Alex Deuc
splay/dc/dce60/dce60_resource.c:183:3: note:
> in expansion of macro ‘XFM_COMMON_REG_LIST_DCE60’
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:187:3: note:
> in expansion of macro ‘transform_regs’
> drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:645:43:
&
ut
this should fix the issue.
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 11 +--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> b/drivers/g
On 2021-06-04 9:16 a.m., Werner Sembach wrote:
> convert_dc_color_depth_into_bpc() that converts the enum dc_color_depth to an
> integer had the cases for COLOR_DEPTH_999 and COLOR_DEPTH_11 missing.
>
> Signed-off-by: Werner Sembach
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |
On 2021-06-04 4:07 p.m., Alex Deucher wrote:
> Unused so remove them.
>
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> .../gpu/drm/amd/display/dc/dcn31/dcn31_dio_link_encoder.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --g
301 - 400 of 3329 matches
Mail list logo
