On 2023-09-14 13:53, Hamza Mahfooz wrote:
> On eDP we can receive invalid modes from dm_update_crtc_state() for
> entirely new streams for which drm_mode_set_crtcinfo() shouldn't be
> called on. So, instead of calling drm_mode_set_crtcinfo() from within
> create_stream_for_sink() we can instead cal
On 2023-09-05 13:13, Alex Hung wrote:
> [WHY]
> edid_override and drm_edid_override_connector_update, according to drm
> documentation, should not be referred outside drm_edid.
>
> [HOW]
> Remove and replace them accordingly.
>
> Signed-off-by: Alex Hung
> ---
> .../gpu/drm/amd/display/amdgp
On 2023-09-14 17:12, Hamza Mahfooz wrote:
>
> On 9/14/23 17:04, Hamza Mahfooz wrote:
>>
>> On 9/14/23 16:40, Harry Wentland wrote:
>>> On 2023-09-14 13:53, Hamza Mahfooz wrote:
>>>> On eDP we can receive invalid modes from dm_update_crtc_state()
27;content type' value in the avi infoframe also.
>>
>> v2:
>> - rebase to amd-staging-drm-next
>> - mark CRTC state for reset if content_type differs
>>
>> Reviewed-by: Harry Wentland (v1)
>> Signed-off-by: Joshua Ashton
>> Co-developed-by: Mel
On 2023-09-22 05:58, Stylon Wang wrote:
[Why & How]
These DPCD addresses are either declared in other header files
where it makes more sense or simply not used by any DC code.
Remove them to reduce redundancies and potential confusion.
Signed-off-by: Stylon Wang
Reviewed-by: H
Hung
Reviewed-by: Harry Wentland
Harry
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 42 ++-
1 file changed, 23 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 5efebc0
y and it
> preserves test results.
>
> Signed-off-by: Melissa Wen
>
Reviewed-by: Harry Wentland
and merged.
I also took the liberty to expand this to the recently merged dcn35
code.
Harry
> ---
>
> Hi,
>
> Two relevant things to consider for this change. One is that
On 2023-09-13 12:43, Melissa Wen wrote:
> Logging DCN3 MPC state was following DCN1 implementation that doesn't
> consider new DCN3 MPC color blocks. Create new elements according to
> DCN3 MPC color caps and a new DCN3-specific function for reading MPC
> data.
>
> Signed-off-by: Melissa Wen
>
On 2023-09-13 12:43, Melissa Wen wrote:
> Color caps changed between HW versions which caused DCN10 color state
> sections on DTN log no longer fit DCN3.0 versions. Create a
> DCN3.0-specific color state logging and hook it to drivers of DCN3.0
> family.
>
> rfc-v2:
> - detail RAM mode for gamc
On 2023-09-13 12:43, Melissa Wen wrote:
> Hi,
>
> This is an update of previous RFC [0] improving the data collection of
> Gamma Correction and Blend Gamma color blocks.
>
> As I mentioned in the last version, I'm updating the color state part of
> DTN log to match DCN3.0 HW better. Currently,
On 2023-09-22 16:12, Mario Limonciello wrote:
> During the suspend process dc_set_power_state() will use kzalloc
> to allocate memory, but this potentially fails with memory pressure.
> If it fails, the suspend should be aborted.
>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2362
>
gt; Suggested-by: Harry Wentland
> Signed-off-by: Mario Limonciello
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 11 ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 8
> drivers/gpu/drm/amd/display/dc
On 2023-09-26 08:38, Melissa Wen wrote:
> On 09/25, Harry Wentland wrote:
>>
>>
>> On 2023-09-13 12:43, Melissa Wen wrote:
>>> Logging DCN3 MPC state was following DCN1 implementation that doesn't
>>> consider new DCN3 MPC color blocks. Create new e
On 2023-09-26 01:56, Cong Liu wrote:
> This patch fixes a null pointer dereference in the error message that is
> printed when the Display Core (DC) fails to initialize. The original
> message includes the DC version number, which is undefined if the DC is
> not initialized.
>
> Fixes: 9788d087
On 2023-09-27 01:23, Christian König wrote:
> Am 26.09.23 um 15:09 schrieb Harry Wentland:
>>
>> On 2023-09-26 01:56, Cong Liu wrote:
>>> This patch fixes a null pointer dereference in the error message that is
>>> printed when the Display Core (DC) fails to ini
On 2023-09-27 10:07, Harry Wentland wrote:
>
>
> On 2023-09-27 01:23, Christian König wrote:
>> Am 26.09.23 um 15:09 schrieb Harry Wentland:
>>>
>>> On 2023-09-26 01:56, Cong Liu wrote:
>>>> This patch fixes a null pointer dereference in the error
On 2023-09-25 15:49, Melissa Wen wrote:
> Add 3D LUT property for plane color transformations using a 3D lookup
> table. 3D LUT allows for highly accurate and complex color
> transformations and is suitable to adjust the balance between color
> channels. It's also more complex to manage and requ
lor space, a custom shaper 1D LUT can be used
> just before applying 3D LUT.
>
> v2:
> - use DPP color caps to verify plane 3D LUT support
> - add debug message if shaper LUT programming fails
>
> Reviewed-by: Harry Wentland
> Signed-off-by: Melissa Wen
> ---
> ...
r caps to degamma params
>
> v3:
> - remove unused color_caps parameter from set_color_properties (Harry)
>
> Signed-off-by: Joshua Ashton
> Signed-off-by: Melissa Wen
Reviewed-by: Harry Wentland
Harry
> ---
> .../amd/display/amdgpu_dm/amdgpu_dm_color.c | 29 +++
ctm *)dm_plane_state->ctm->data;
> + /* DCN2 and older don't support both pre-blending and
nit: formatting this with a newline before the comment and then:
> + /*
> + * DCN2 and older don't support both pre-blending and
would make thi
On 2023-09-25 15:49, Melissa Wen wrote:
> From: Joshua Ashton
>
> Create drm_color_ctm_3x4 to support 3x4-dimension plane CTM matrix and
> convert DRM CTM to DC CSC float matrix.
>
> v3:
> - rename ctm2 to ctm_3x4 (Harry)
>
> Signed-off-by: Joshua Ashton
; Co-developed-by: Harry Wentland
> Signed-off-by: Harry Wentland
> Signed-off-by: Melissa Wen
> ---
> .../amd/display/amdgpu_dm/amdgpu_dm_color.c | 39 +++
> 1 file changed, 39 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgp
On 2023-09-29 03:35, Pekka Paalanen wrote:
> On Thu, 28 Sep 2023 16:16:57 -0400
> Harry Wentland wrote:
>
>> On 2023-09-25 15:49, Melissa Wen wrote:
>>> Brief documentation about pre-defined transfer function usage on AMD
>>> display driver and standardized EO
On 2023-09-21 10:15, Sebastian Andrzej Siewior wrote:
> This is a revert of the commit mentioned below while it is not wrong, as
> in the kernel will explode, having migrate_disable() here it is
> complete waste of resources.
>
> Additionally commit message is plain wrong the review tag does not m
On 2023-10-02 06:58, Sebastian Andrzej Siewior wrote:
> On 2023-09-22 07:33:26 [+0200], Christian König wrote:
>> Am 21.09.23 um 16:15 schrieb Sebastian Andrzej Siewior:
>>> Hi,
>>>
>>> I stumbled uppon the amdgpu driver via a bugzilla report. The actual fix
>>> is #4 + #5 and the rest was made whi
On 2023-10-03 15:54, Harry Wentland wrote:
> On 2023-10-02 06:58, Sebastian Andrzej Siewior wrote:
>> On 2023-09-22 07:33:26 [+0200], Christian König wrote:
>>> Am 21.09.23 um 16:15 schrieb Sebastian Andrzej Siewior:
>>>> Hi,
>>>>
>>>> I
.org/drm/amd/-/issues/2610
> Signed-off-by: Hamza Mahfooz
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/drm_edid.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 0454da505687..b
On 2023-10-20 14:06, Stylon Wang wrote:
> Many of the DC files have either incomplete or incorrect copyright
> notice. This patchset aims to address this and also make lives
> less difficult for those doing backport/upstream activities.
>
Series is
Reviewed-by: Harry Went
On 2023-10-20 12:42, Rodrigo Siqueira wrote:
> When DML 2 was introduced, it changed part of the generic sequence of
> DC, which caused issues on previous DCNs with DMUB support. This commit
> ensures the new sequence only works for new DCNs from 3.5 and above.
>
> Cc: Vitaly Prosyak
> Cc: Rom
Cc: Vitaly Prosyak
> Cc: Roman Li
> Cc: Qingqing Zhuo
> Cc: Daniel Wheeler
> Cc: Alex Deucher
>
Didn't realize this would make the change much bigger but I think
it'll be more consistent in the long-term.
Reviewed-by: Harry Wentland
Harry
> Rodrigo Siqueira (2):
orth
> Tested-by: Mark Broadworth
> Signed-off-by: Hamza Mahfooz
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/am
ebased this patchset with the latest code
> from amd-staging-drm-next, and I also changed patch 2.
>
> Thanks
> Siqueira
This set looks good to me and should hopefully help others when
digging into the AMD display driver.
Reviewed-by: Harry Wentland
Harry
>
> Rodrigo Siqueir
; would require some thoughtful design. Let's just disable idle
> optimizations for PSR2 for now.
>
Great writeup. Wish every bugfix came with details like this.
> Fixes: 7cc191ee7621 ("drm/amd/display: Implement MPO PSR SU")
> Signed-off-by: Leo Li
With Thors
On 2022-09-06 12:46, Melissa Wen wrote:
> Hi,
>
> From all feedback at [3DLUT_RFC] and an extensive AMD driver
> examination, here I am back with a first attempt to wire up a user 3D
> LUT (post-blending) to DC interface via DM CRTC color mgmt :)
>
> I'm following some specific approaches to h
+Leo
On 9/30/22 06:27, Shirish S wrote:
> [Why]
> psr feature continues to be enabled for non capable links.
>
Do you have more info on what issues you're seeing with this?
> [How]
> disable the feature on links that are not capable of the same.
>
> Signed-off-by: Shirish S
> ---
> drivers/
t; drm: document DRM_MODE_PAGE_FLIP_ASYNC
> amd/display: only accept async flips for fast updates
> drm: introduce drm_mode_config.atomic_async_page_flip_not_supported
> drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits
> drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP
> amd/display: indicate support for atomic async pag
On 9/12/22 11:59, Maíra Canal wrote:
> From: Tales Aparecida
>
> The fixed31_32 library performs a lot of the mathematical operations
> involving fixed-point arithmetic and the conversion of integers to
> fixed-point representation.
>
> This unit tests intend to assure the proper functioning
aconnector->base.name);
>
> aconnector->base.force = DRM_FORCE_OFF;
> - aconnector->base.override_edid = false;
I'm not even sure the DRM_FORCE_OFF business is right.
Either way, I don't think amdgpu should be messing with
override_edid, so
On 2022-10-11 09:41, Alex Deucher wrote:
> It's not used outside of dcn32_fpu.c.
>
> Reported-by: kernel test robot
> Fixes: 20dad3813b3c15 ("drm/amd/display: Add a helper to map
> ODM/MPC/Multi-Plane resources")
> Signed-off-by: Alex Deucher
Re
On 2022-10-06 11:32, Alex Deucher wrote:
> Fixes a warning in dc.c.
>
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/dri
On 2022-10-10 17:36, Alex Deucher wrote:
> It's MIT.
>
> Fixes: b73353f7f3d434 ("drm/amd/display: Use the same cursor info across
> features")
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/inc/h
; Fixes: 9b3d76527f6e ("drm/amd/display: Revert adding degamma coefficients")
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On 2022-10-10 10:41, Alex Deucher wrote:
> It's not used outside of virtual_link_hwss.c. Fixes
> a -Wmissing-prototypes warning.
>
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.c | 2
On 2022-10-10 03:38, Yang Li wrote:
> The result of 'pwr_status == 0' is Boolean, and the question mark
> expression is redundant.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2354
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
Reviewe
d_stream and dc_update_planes_and_stream
I think you mean
"dc_commit_streams and dc_update_planes_and_stream"
Harry
> respectively.
>
> Cc: Nicholas Kazlauskas
> Cc: Harry Wentland
> Signed-off-by: Rodrigo Siqueira
> Co-developed-by: Aurabindo Pillai
> Signed-off-by:
tom streams? Why are they needed? Please elaborate.
> Fix this by doing the dc state copy right after the dc_commit_state()
> call.
>
> Cc: Nicholas Kazlauskas
> Cc: Harry Wentland
> Reviewed-by: Rodrigo Siqueira
> Signed-off-by: Aurabindo Pillai
> ---
>
> Cc: Nicholas Kazlauskas
> Cc: Harry Wentland
> Signed-off-by: Rodrigo Siqueira
> Co-developed-by: Aurabindo Pillai
> Signed-off-by: Aurabindo Pillai
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 16
> 1 file changed, 16 insertions(+)
>
> dif
On 2022-10-17 11:38, Hamza Mahfooz wrote:
> Currently, if we encounter unimplemented functions, it is difficult to
> tell what caused them just by looking at dmesg and that is compounded by
> the fact that it is often hard to reproduce said issues, for instance we
> have had reports of this cond
counter an unimplemented function.
>
> Signed-off-by: Hamza Mahfooz
Reviewed-by: Harry Wentland
Harry
> ---
> v2: detail specific instance that I'm interested in and use ASSERT()
> instead of WARN().
>
> v3: move ASSERT()s inside the new if blocks.
> ---
&g
On 2022-10-18 08:28, Rodrigo Siqueira wrote:
> From: Aurabindo Pillai
>
> The SubVP feature introduces a new mechanism named phantom streams,
> which can be summed up as a fake stream used to calculate the required
> parameters for handing the cache request and cache reading for a small
> port
I left a couple comments that we should follow up on but in order to
unblock SubVP I'm okay to take this in its current form (i.e. for Navi 3x
only). Please follow up on my other questions as part of the work to
switch all ASICs to the new sequence.
Thanks, also for splitting this into smalle
On 2022-10-18 08:28, Rodrigo Siqueira wrote:
> DC stream can be seen as a representation of the DCN backend or the data
> struct that represents the center of the display pipeline. The front end
> (i.e., planes) is connected to the DC stream, and in its turn, streams
> are connected to the DC li
t declared. Should it be static?
>
> Signed-off-by: ruanjinjie
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/
ld it be static?
>
> Signed-off-by: ruanjinjie
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> b/driv
On 2022-10-20 18:10, Rafael Mendonca wrote:
> This is an extension of commit fd3bc691fc7b ("drm/amd/display: Remove
> duplicate code across dcn30 and dcn31"), which removed duplicate code for
> the function CalculateBytePerPixelAnd256BBlockSizes() across dcn30 and
> dcn31. At the time the aforem
Series is
Reviewed-by: Harry Wentland
Harry
On 2022-10-24 15:22, Hamza Mahfooz wrote:
> This reverts commit 55eea8ef98641f6e1e1c202bd3a49a57c1dd4059.
>
> This quirk is now handled in the DRM core, so we can drop all of
> the internal code that was added to handle it.
>
> Si
Fixes: f4a59996c408 ("drm/amd/display: Include surface of unaffected streams")
> Reported-by: Stephen Rothwell
> Signed-off-by: Alex Deucher
> Cc: Rodrigo Siqueira
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
> 1 file change
27;void(struct clk_mgr_internal *, int)'
>
> I.e. the type of the 2nd parameter of
> rn_vbios_smu_set_dcn_low_power_state() in the declaration is int, while
> the definition spells enum dcn_pwr_state. Synchronize them to the
> latter (and add a forward enum declaration).
>
me it looks like this if I
wanted to set the first device to a minimum of 2 and leave the default
for the 2nd one:
amdgpu.backlight_min=2:-1
Either way, this patch is
Reviewed-by: Harry Wentland
Harry
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=203439>>
> Signed-off-by:
.
>
> Signed-off-by: Hamza Mahfooz
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 7 ---
> 2 files changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd
t; So in that case you probably want to add something like
> options amdgpu backlight_min=2 to /etc/modprobe.d/amdgpu.conf
> (and also run update-initramfs if amdgpu is loaded by initramfs).
>
> I'll add some examples to commit message in v2.
>
Awesome. Thanks.
Harry
> Filip
On 2022-02-15 16:44, Alex Deucher wrote:
> From: Leo Li
>
> Initialize DMUB for DCN316. Use same funcs as DCN31 for
> DCN316.
>
> Acked-by: Prike Liang
> Signed-off-by: Leo Li
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> ...
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2 +-
> drivers/gpu/drm/amd/display/include/dal_asic_id.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource
; Acked-by: Alex Deucher
> Signed-off-by: Leo Li
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c
> b/drivers/gpu/drm/
On 2022-02-18 07:12, Simon Ser wrote:
> On Friday, February 18th, 2022 at 12:54, Hans de Goede
> wrote:
>
>> On 2/18/22 12:39, Simon Ser wrote:
>>> On Friday, February 18th, 2022 at 11:38, Hans de Goede
>>> wrote:
>>>
What I'm reading in the above is that it is being considered to allow
>
On 2022-02-18 05:03, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> These on stack copies of the modes appear to be pointless.
> Just look at the originals directly.
>
> Cc: Harry Wentland
> Cc: Leo Li
> Cc: Rodrigo Siqueira
> Cc: Alex Deucher
> Cc: amd-
when != S
> + drm_mode_init(&M, &E);
> +
> S1
>
> @@
> expression decl.E;
> @@
> - &*E
> + E
>
> Cc: Harry Wentland
> Cc: Leo Li
> Cc: Rodrigo Siqueira
> Cc: Alex Deucher
> Cc: amd-gfx@lists.freedesktop.org
> Signed-off-by: Ville Syrjälä
Re
> - memcpy(mode, E, S)
> + drm_mode_copy(mode, E)
> )
>
> @depends on !is_mode_copy@
> struct drm_display_mode mode;
> expression E;
> @@
> (
> - mode = E
> + drm_mode_copy(&mode, &E)
> |
> - memcpy(&mode, E, S)
> + drm_mode_copy(&
On 2022-02-22 01:03, Yifan Zhang wrote:
> From: "Tianci.Yin"
>
> this patch adds GTT domain support for dcn 3.1.5 and 3.1.6
>
> Signed-off-by: Tianci.Yin
> Signed-off-by: Yifan Zhang
Acked-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/amdgpu
g/drm/amd/-/issues/1916>> Cc: Maíra Canal
>
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd
to be used.
>
> [How]
>
> Fix dcn316's definition of the DfPstateTable_t struct to align with PMFW
>
> Signed-off-by: Leo Li
Acked-by: Harry Wentland
Harry
> ---
> .../amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c| 11 ++-
> .../drm/amd/display/
Series is
Reviewed-by: Harry Wentland
Harry
On 2022-02-24 14:15, Magali Lemes wrote:
> This patchset addresses a few warnings reported by the Kernel Test Robot and
> sparse.
>
> Magali Lemes (4):
> drm/amd/display: Adjust functions documentation
> drm/amd/display: Add
gt; by removing the over-specified array size from the argument declarations.
>
> This helps with the ongoing efforts to globally enable
> -Wstringop-overflow.
>
> Link: https://github.com/KSPP/linux/issues/181>> Signed-off-by: Gustavo A. R.
> Silva
Acked-by: Harry Wentl
t
> supported by link encoder and sink.
>
> Signed-off-by: Tianci.Yin
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
On 2022-03-08 17:02, Hans de Goede wrote:
> Hi,
>
> On 3/8/22 21:56, Sean Paul wrote:
>> From: Sean Paul
>>
>> This patch adds the necessary hooks to make amdgpu aware of privacy
>> screens. On devices with privacy screen drivers (such as thinkpad-acpi),
>> the amdgpu driver will defer probe u
On 2022-03-09 13:58, Alex Deucher wrote:
> Enable scatter/gather display for DCN 3.1.6.
>
> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff
mostly the
> same as the DCN10 interface, but the bit definitions have changed for
> the debug bus.
>
> Signed-off-by: Nicholas Kazlauskas
> Reviewed-by: Eric Yang
Reviewed-by: Harry Wentland
Harry
> ---
> .../drm/amd/display/dc/dcn10/dcn10_hubbub.c | 1 +
> .../a
On 3/11/22 10:33, Shirish S wrote:
> [Why]
> comparing pwm bl values (coverted) with user brightness(converted)
> levels in commit_tail leads to continuous setting of backlight via dmub
> as they don't to match.
Why do the values not match? It looks like the value mismatch
is our root cause. I
gt; It worked before by accident, but can falsely assert 0 depending on HW
> state transitions. The most frequent of which appears to be when
> all pipes turn off during IGT tests.
>
> Cc: Harry Wentland
> Fixes: d158560fc0e1 ("drm/amd/display: Add pstate verification and rec
info in
dpp_setup if it's available.
Signed-off-by: Harry Wentland
Cc: sta...@vger.kernel.org
Cc: hersenxs...@amd.com
Cc: ikshwaku.chau...@amd.com
Cc: nicholas.kazlaus...@amd.com
Cc: chandan.vurdigerenata...@amd.com
---
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp.c | 3 +++
drivers/gpu/dr
On 2022-03-25 00:05, Ryan Lin wrote:
> Disable ABM feature when the system is running on AC mode to get
> the more perfect contrast of the display.
It says patch 3 out of 25. Are there other patches? If so, I can't
find them in my mailbox and neither can patchwork
https://patchwork.freedesktop.
ul
With the subject line fixed as per Christian's comment this is
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 5 +++--
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8
> 2 files changed, 7 insertions(+), 6 deletion
On 2022-03-28 12:54, Melissa Wen wrote:
> On 03/28, Simon Ser wrote:
>> Thanks a lot for you patch! I've noticed as well that amdgpu ignores
>> the plane alpha property [1]. I'll try to find time to test it.
> Hi Simon,
>
> So you've faced this kind of issue many times :/
> Let me know the resu
i.e. exactly what this patch is doing.
Based on that this patch is
Reviewed-by: Harry Wentland
Harry
>
>
>
> Regards,
> Shirish S
>
> -Original Message-
> From: S, Shirish
> Sent: Monday, March 14, 2022 12:24 PM
> To: Wentland, Harry ; S, Shirish ;
On 2022-03-24 19:10, Ryan Lin wrote:
> Disable ABM feature when the system is running on AC mode to get
> the more perfect contrast of the display.
>
> Signed-off-by: Ryan Lin
>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 ++
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c|
On 2022-03-29 10:33, Harry Wentland wrote:
>
>
> On 2022-03-24 19:10, Ryan Lin wrote:
>> Disable ABM feature when the system is running on AC mode to get
>> the more perfect contrast of the display.
>>
>> Signed-off-by: Ryan Lin
>>
>> ---
if (per_pixel_alpha && pipe_ctx->plane_state->global_alpha) {
>> + blnd_cfg.alpha_mode =
>> MPCC_ALPHA_BLEND_MODE_PER_PIXEL_ALPHA_COMBINED_GLOBAL_GAIN;
>> + blnd_cfg.global_gain = pipe_ctx->plane_state->global_alpha_value;
>> + } else
On 2022-03-31 13:26, David Zhang wrote:
> [why & how]
> In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU
Please fix up the type in "fileds"
> support.
>
> Signed-off-by: David Zhang
With that fixed this patch is
Reviewed-by: Harry Wentland
On 2022-04-03 10:21, Tom Rix wrote:
> Smatch reports this issue
> hdcp1_execution.c:500:29: warning: function
> 'mod_hdcp_hdcp1_dp_execution' with external linkage
> has definition
>
Which branch are you using?
I don't see the 'extern' on
https://gitlab.freedesktop.org/agd5f/linux/-/blob/
On 2022-04-04 11:43, Tom Rix wrote:
>
> On 4/4/22 8:22 AM, Harry Wentland wrote:
>>
>> On 2022-04-03 10:21, Tom Rix wrote:
>>> Smatch reports this issue
>>> hdcp1_execution.c:500:29: warning: function
>>> 'mod_hdcp_hdcp1_dp_execution' w
On 2022-04-07 01:52, Haowen Bai wrote:
> The pointer dc is dereferencing pointer plane_state before plane_state
> is being null checked. Fix this by assigning plane_state->ctx->dc to
> dc only if plane_state is not NULL, otherwise just NULL.
>
> Signed-off-by: Haowen Bai
> ---
> drivers/gpu/d
On 2022-04-07 02:00, Haowen Bai wrote:
> Smatch reports the following:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2174
> dcn10_enable_vblanks_synchronization() warn: if statement not indented
>
> Signed-off-by: Haowen Bai
Reviewed-by: Harry W
On 2022-04-07 12:07, Alex Deucher wrote:
> Actually this just causes another warning. Dropped for now. More below.
>
> On Thu, Apr 7, 2022 at 11:52 AM Alex Deucher wrote:
>>
>> Applied. Thanks!
>>
>> Alex
>>
>> On Thu, Apr 7, 2022 at 10:18 AM
On 2022-04-08 02:53, Bhanuprakash Modem wrote:
> It's useful to know the connector's max supported bpc for IGT
> testing. Expose it via a debugfs file on the connector "output_bpc".
>
> Example: cat /sys/kernel/debug/dri/0/DP-1/output_bpc
>
> Cc: Jani Ni
tc debugfs from
> connector debugfs, since we are getting this info from crtc_state.
>
Does the amd_max_bpc test pass after this change?
Harry
> Cc: Harry Wentland
> Cc: Rodrigo Siqueira
> Signed-off-by: Bhanuprakash Modem
> ---
> .../gpu/drm/amd/display/am
On 2022-04-08 11:23, Modem, Bhanuprakash wrote:
> On Fri-08-04-2022 08:33 pm, Harry Wentland wrote:
>>
>>
>> On 2022-04-08 02:53, Bhanuprakash Modem wrote:
>>> As drm_connector already have the display_info, instead of creating
>>> "output_bpc"
On 2022-04-19 10:19, Christian König wrote:
We just need to reserve the BO here, no need for using ttm_eu.
Signed-off-by: Christian König
Acked-by: Harry Wentland
Harry
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 32 ++-
1 file changed, 17 insertions(+), 15
On 2022-04-19 10:42, Christian König wrote:
Am 19.04.22 um 16:37 schrieb Harry Wentland:
On 2022-04-19 10:19, Christian König wrote:
We just need to reserve the BO here, no need for using ttm_eu.
Signed-off-by: Christian König
Acked-by: Harry Wentland
What about the second patch
On 2022-04-21 10:10, Alex Deucher wrote:
It's not used outside of dcn31_hubp.c.
Signed-off-by: Alex Deucher
Reviewed-by: Harry Wentland
Harry
---
drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gp
On 2022-04-22 10:28, Melissa Wen wrote:
On 04/21, Harry Wentland wrote:
On 2022-04-21 15:20, Melissa Wen wrote:
On 04/21, Harry Wentland wrote:
On 2022-04-21 10:37, Melissa Wen wrote:
Hi all,
I'm examining how DRM color management properties (degamma, ctm, gamma)
are applied t
501 - 600 of 3330 matches
Mail list logo
