Re: [PATCH v3 3/4] amd/display: add cursor rotation check

On 2023-08-17 09:44, Harry Wentland wrote: > On 2023-08-17 06:53, Simon Ser wrote: >> The commit 1347385fe187 ("drm/amd/display: don't expose rotation >> prop for cursor plane") removed the rotation property for the >> cursor plane, assuming the cursor woul

Re: [PATCH 02/18] drm/amd/display: Create one virtual connector in DC

On 2023-08-17 09:58, Alex Deucher wrote: > On Thu, Aug 17, 2023 at 8:45 AM Alex Hung wrote: >> >> From: Harry Wentland >> >> [WHAT] >> Prepare a virtual connector for writeback. > > I presume the main point of virtual connectors in DC is for writeb

Re: [PATCH] drm/amd/display: fix mode scaling (RMX_.*)

tings to be unintentionally overwritten. So, since > dm_state is never NULL now, we can use old_stream to determine if we > should call drm_mode_set_crtcinfo() because we only need to set the crtc > timing parameters for entirely new streams. > > Cc: Harry Wentland > Cc: Rodrigo Siqu

Re: [PATCH] drm/amd/display: register edp_backlight_control() for DCN301

rework recent update PHY state commit") > Suggested-by: Swapnil Patel > Signed-off-by: Hamza Mahfooz Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/dcn301/dcn301_init.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/d

Re: [PATCH] drm/amd/display: Fix up kdoc format for 'dc_set_edp_power'

On 2023-08-25 06:38, Srinivasan Shanmugam wrote: Fixes the following W=1 kernel build warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:5261: warning: Cannot understand *** Cc: Ian Chen Cc: Rodrigo Siqueira Cc: Harry Wentland Cc: Aurabindo

Re: [PATCH] drm: Fix DSC throughput mode 0 mask definition

fication. > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: Nikola Cornij > Cc: Jani Nikula > Cc: Manasi Navare > Cc: Ville Syrjälä > Fixes: d7cd0e053b1 (drm/amd/display: Add 170Mpix/sec DSC throughput support) > Signed-off-by: Rodrigo Siqueira Rev

Re: [PATCH] dc.c:use kzalloc without test

On 2019-10-23 4:32 a.m., zhongshiqi wrote: > dc.c:583:null check is needed after using kzalloc function > > Signed-off-by: zhongshiqi Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 4 > 1 file changed, 4 insertions(+) > >

Re: [PATCH] drm/amd/amdgpu: make undeclared variables static

On 2019-10-19 3:24 a.m., Wambui Karuga wrote: > Make the `amdgpu_lockup_timeout` and `amdgpu_exp_hw_support` variables > static to remove the following sparse warnings: > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:103:19: warning: symbol > 'amdgpu_lockup_timeout' was not declared. Should it be static

Re: [PATCH] drm/amd/amdgpu: correct length misspelling

. You can do that by providing a range to "git format-patch". I usually call git format-patch with the -o parameter to put all my patches in a directory. Then I can send it with "git send-email *" in that directory. Reviewed-by: Harry Wentland This won't apply cleanly

Re: [PATCH] drm/radeon: remove assignment for return value

e; > -return ret; > > Signed-off-by: Wambui Karuga Thanks for your patch. Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/radeon/cik.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/cik.c b/driver

Re: [PATCH 01/11] drm/amdgpu: Add ucode support for DMCUB

On 2019-10-31 11:40 a.m., Li, Roman wrote: > On Behalf Of: Hersen Wu > Series is: > Reviewed-by: Hersen Wu I only managed to skim the patches but it looks reasonable. Series is Acked-by: Harry Wentland Harry > > -Original Message- > From: amd-gfx On

Re: [PATCH] drm/amdgpu: Show resolution correctly in mode validation debug output

On 2019-10-30 2:58 p.m., n...@neil.mayhew.name wrote: > From: Neil Mayhew This requires your Signed-off-by. See [1]. With that fixed your change looks good and is Reviewed-by: Harry Wentland You can simply reply to this email with your Signed-off-by and I can add it when merging, or you

Re: [PATCH] drm/amdgpu: Show resolution correctly in mode validation debug output

On 2019-11-01 11:47 a.m., Neil Mayhew wrote: > On 2019-11-01 9:13 a.m., Harry Wentland wrote: >> On 2019-10-30 2:58 p.m., n...@neil.mayhew.name wrote: >>> From: Neil Mayhew >> This requires your Signed-off-by. See [1]. >> >> With that fixed your change loo

Re: [PATCH v2 1/2] drm: Add support for DP 1.4 Compliance edid corruption test 4.2.2.6

On 2019-11-01 3:38 p.m., Jerry (Fangzhi) Zuo wrote: > DP 1.4 edid corruption test requires source DUT to write calculated > CRC, not the corrupted CRC from reference sink. > > Return the calculated CRC back, and initiate the required sequence. > > -v2: Have separate routine for returning real CRC

Re: [PATCH] drm/amd/display: Add ENGINE_ID_DIGD condition check for Navi14

On 2019-11-01 9:37 p.m., Wu, Hersen wrote: > > Reviewed-by: Hersen Wu > > > > -Original Message- > From: Liu, Zhan > Sent: Friday, November 1, 2019 9:35 PM > To: Wu, Hersen ; amd-gfx@lists.freedesktop.org; > Kazlauskas, Nicholas ; Lakha, Bhawanpreet > ; Li, Roman ; Siqueira, Rodrig

Re: drm/amd/display: Add HDCP module - static analysis bug report

On 2019-11-04 5:53 a.m., Daniel Vetter wrote: > On Wed, Oct 9, 2019 at 10:58 PM Daniel Vetter wrote: >> On Wed, Oct 9, 2019 at 10:46 PM Lakha, Bhawanpreet >> wrote: >>> >>> I misunderstood and was talking about the ksv validation specifically >>> (usage of drm_hdcp_check_ksvs_revoked()). >> >> Hm

Re: drm/amd/display: Add HDCP module - static analysis bug report

Nov 4, 2019 at 11:55 AM Daniel Vetter wrote: >>>>> >>>>> On Mon, Nov 04, 2019 at 03:23:09PM +, Harry Wentland wrote: >>>>>> On 2019-11-04 5:53 a.m., Daniel Vetter wrote: >>>>>>> On Wed, Oct 9, 2019 at 10:58 PM Daniel Vetter wrote: &g

Re: drm/amd/display: Add HDCP module - static analysis bug report

On 2019-11-05 9:23 a.m., Daniel Vetter wrote: > On Tue, Nov 5, 2019 at 3:17 PM Harry Wentland wrote: >> >> >> >> On 2019-11-05 8:14 a.m., Daniel Vetter wrote: >>> On Tue, Nov 5, 2019 at 1:52 PM Alex Deucher wrote: >>>> >>>> On Mon,

Re: [PATCH] drm/amdgpu/display: fix the build when CONFIG_DRM_AMD_DC_DCN is not set

On 2019-11-06 8:52 p.m., Alex Deucher wrote: > Need to protect some DSC functions. > > Signed-off-by: Alex Deucher Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --g

Re: [PATCH 00/14] HDCP 2 Content Protection v2

alysis bug > drm/amd/display: Fix static analysis bug in validate_bksv > Changes are Reviewed-by: Harry Wentland Harry > > Bhawanpreet Lakha (14): > drm/amd/display: Add PSP block to verify HDCP2.2 steps > drm/amd/display: Add DDC handles for HDCP2.2 > drm/amd/display: A

Re: [PATCH] drm/amd/display: Use pixel encoding 444 for dongle usb-c to hdmi

will still use RGB. Because maybe the RGB issue is also specific to that > graphic card which > is VEGA"M". So that is why the patch only tries to match hdmi cases > together, whether it is direct connection or through usb-c. > > - > Julien > > > > On Tu

Re: [PATCH 1/2] drm/amd/display: Return correct error value

rt with eDP > and I think you're guaranteed to have those resources as instance 0. > That sounds like an incorrect way of handling this. Mikita, can you check, though, with the original authors (Anthony?) of this function and make sure you get an ack from them? If there's no objections

Re: [PATCH -next] drm/amd/display: Fix old-style declaration

On 2019-11-11 7:28 a.m., YueHaibing wrote: > Fix a build warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: > warning: 'static' is not at beginning of declaration > [-Wold-style-declaration] > > Signed-off-by: YueHaibing Revi

Re: [PATCH -next] drm/amd/display: Fix old-style declaration

On 2019-11-12 2:51 a.m., Yuehaibing wrote: > On 2019/11/12 10:39, Joe Perches wrote: >> On Mon, 2019-11-11 at 20:28 +0800, YueHaibing wrote: >>> Fix a build warning: >>> >>> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:75:1: >>> warning: 'static' is not at beginning of declaration >>> [-Wol

Re: [PATCH 0/4] drm/amd/display: remove some set but not used variables

ariable 'bp' in > bios_parser.c > drm/amd/display: remove set but not used variable 'min_content' > These would be fine as a single patch as well but I don't have a strong preference either way. Patches are: Reviewed-by: Harry Wentland Harry > drivers/gp

Re: [PATCH 1/2] drm/dsc: Update drm_dsc to reflect native 4.2.0 DSC spec

On 2019-11-14 4:20 p.m., Cornij, Nikola wrote: > This looks good, too. > Can we treat this as your reviewed-by for both changes? Usually people mark these as reviewed with a Reviewed-by: Harry Wentland Thanks, Harry > -Original Message- > From: mikita.lip...@amd.

Re: [PATCH 01/12] amdgpu: add UAPI for creating encrypted buffers

On 2019-11-20 11:49 a.m., Luben Tuikov wrote: > On 2019-11-19 21:41, Marek Olšák wrote: >> On Tue, Nov 19, 2019 at 8:52 PM Luben Tuikov > > wrote: >> >> On 2019-11-14 10:34 p.m., Aaron Liu wrote: >> > From: Huang Rui mailto:ray.hu...@amd.com>> >> > >> >

Re: [PATCH 01/12] amdgpu: add UAPI for creating encrypted buffers

On 2019-11-20 12:05 p.m., Harry Wentland wrote: > On 2019-11-20 11:49 a.m., Luben Tuikov wrote: >> On 2019-11-19 21:41, Marek Olšák wrote: >>> On Tue, Nov 19, 2019 at 8:52 PM Luben Tuikov >> <mailto:luben.tui...@amd.com>> wrote: >>> >>> On 201

Re: [PATCH v2] drm/amd/display: Fix Apple dongle cannot be successfully detected

On 2019-11-22 1:33 a.m., Louis Li wrote: > On Thu, Nov 21, 2019 at 08:47:50AM -0500, Kazlauskas, Nicholas wrote: >> On 2019-11-21 8:40 a.m., Kazlauskas, Nicholas wrote: >>> On 2019-11-21 3:31 a.m., Li, Ching-shih (Louis) wrote: Hi reviewers, What is the review result for this patch

Re: [PATCH v2] drm/amd/display: Fix Apple dongle cannot be successfully detected

On 2019-11-25 4:49 a.m., Louis Li wrote: > On Fri, Nov 22, 2019 at 10:31:19AM -0500, Harry Wentland wrote: >> >> >> On 2019-11-22 1:33 a.m., Louis Li wrote: >>> On Thu, Nov 21, 2019 at 08:47:50AM -0500, Kazlauskas, Nicholas wrote: >>>> On 2019-1

Re: [PATCH] drm/amd/display: Use NULL for pointer assignment in copy_stream_update_to_stream

7C0%7C1%7C637101346080296409&sdata=6HK3wWYMoILbiBisjoHkFwopV%2BuJYUh8wCDhMSvRQQ8%3D&reserved=0 > Signed-off-by: Nathan Chancellor Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-

Re: [PATCH v4] drm: Add support for DP 1.4 Compliance edid corruption test 4.2.2.6

On 2019-11-25 4:36 p.m., Zuo, Jerry wrote: > Please kindly give a review on my latest revision. Thanks a lot. > Both patches are Reviewed-by: Harry Wentland Harry > Regards, > Jerry > > -Original Message- > From: Jerry (Fangzhi) Zuo > Sent: November 5, 20

Re: [PATCH] drm/amd/display: re-enable wait in pipelock, but add timeout

.cgi?id=112266 > Bug: https://bugzilla.kernel.org/show_bug.cgi?id=205169 > Signed-off-by: Alex Deucher Patch is Reviewed-by: Harry Wentland Harry > --- > .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 19 +++ > 1 file changed, 19 insertions(+) > > diff --g

Re: [PATCH][next] drm/amd/display: fix double assignment to msg_id field

ot;drm/amd/display: Add PSP block to verify HDCP2.2 steps") > Signed-off-by: Colin Ian King Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/a

Re: [PATCH] drm/amd/display: Fix wrongly passed static prefix

bove and also for letting the compiler optimize > better. > > Fixes: 62d591a8e00c ("drm/amd/display: create new files for hubbub functions") > Signed-off-by: Takashi Iwai Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/dcn10/dcn10

Re: [PATCH 0/4] drm/amd/display: Remove unneeded semicolon

Series is Reviewed-by: Harry Wentland Harry On 2019-11-27 9:31 p.m., zhengbin wrote: > zhengbin (4): > drm/amd/display: Remove unneeded semicolon in bios_parser.c > drm/amd/display: Remove unneeded semicolon in bios_parser2.c > drm/amd/display: Remove unneeded semicolon in hd

[PATCH] drm/amd/display: Drop AMD_EDID_UTILITY defines

We don't use this upstream in the Linux kernel. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc_dsc.h | 2 -- drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 8 drivers/gpu/drm/amd/display/dc/dc_types.h| 4 3 files changed, 14 deletions(-) diff --

Re: [PATCH] drm/amd/display: Load TA firmware for navi10/12/14

for navi10/12/14. >> This is already being done for raven/picasso and >> is needed for supporting hdcp on navi >> >> Signed-off-by: Bhawanpreet Lakha Reviewed-by: Harry Wentland Harry >> --- >>  drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 25

Re: [PATCH v8 12/17] drm/dp_mst: Add branch bandwidth validation to MST atomic check

th needs doesn't exceed available bandwidth. > The funtion is called in drm_dp_mst_atomic_check after > drm_dp_mst_atomic_check_topology_state to fully verify that > the proposed topology is supported. > > Cc: Jerry Zuo > Cc: Harry Wentland > Cc: Lyude Paul > Si

Re: amdgpu: Enable full DCN support on POWER

On 2019-12-05 6:02 p.m., Liu, Zhan wrote: > > >> -Original Message- >> From: amd-gfx On Behalf Of >> Timothy Pearson >> Sent: 2019/December/05, Thursday 4:58 PM >> To: amd-gfx >> Subject: [PATCH] [RFC v2] amdgpu: Enable full DCN support on POWER >> >> DCN requires floating point support

Re: [PATCH] drm/amdgpu/display: add fallthrough comment

/* fall through */ >>> >>> I am a bit confusing here. Why a comment can avoid a compiler warning? >> >> The kernel enables fall through warnings, so unless there is a comment >> mentioning that are are expecting

Re: [PATCH v8 04/17] drm/dp_mst: Fill branch->num_ports

removed from the list, decrement num_ports. > > v2: remember to decrement on port removal > v3: don't explicitly init to 0 > > Reviewed-by: Lyude Paul > Reviewed-by: Harry Wentland > Signed-off-by: David Francis > Signed-off-by: Mikita Lipski > --- > drivers/g

Re: [PATCH] drm: Add FEC registers for LT-tunable repeaters

On 2019-12-05 8:58 a.m., Rodrigo Siqueira wrote: > FEC is supported since DP 1.4, and it was expanded for LT-tunable in DP > 1.4a. This commit adds the address registers for > FEC_ERROR_COUNT_PHY_REPEATER1 and FEC_CAPABILITY_PHY_REPEATER1. > > Cc: Abdoulaye Berthe > Cc: Harry W

Re: [PATCH 6/6] drm/amd/display: add event type check before restart the authentication

Patches 1-3 are Reviewed-by: Harry Wentland Patches 4-6 are Acked-by: Harry Wentland Harry On 2019-12-12 12:06 p.m., Bhawanpreet Lakha wrote: > From: Xiaodong Yan > > [Why] > Some combined docks will always trigger CP_IRQ but there's nothing the driver > needs to t

Re: [PATCH 3/3] drm/amd/display: add missing dcn link encoder regs

Series is Reviewed-by: Harry Wentland Harry On 2019-12-11 10:45 a.m., roman...@amd.com wrote: > From: Roman Li > > [Why] > The earlier change: "check phy dpalt lane count config" > uses link encoder registers not defined properly. > That caused regression

Re: [PATCH] drm/amd/display: Remove unneeded semicolon

On 2019-12-14 4:12 a.m., zhengbin wrote: > Fixes coccicheck warning: > > drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c:412:90-91: Unneeded > semicolon > > Reported-by: Hulk Robot > Signed-off-by: zhengbin Reviewed-by: Harry Wentland Harry > --- >

Re: [PATCH v3] drm/amd/display: Fix AppleDongle can't be detected

On 2019-12-11 2:33 a.m., Louis Li wrote: > [Why] > External monitor cannot be displayed consistently, if connecting > via this Apple dongle (A1621, USB Type-C to HDMI). > Experiments prove that the dongle needs 200ms at least to be ready > for communication, after it drives HPDsignal high, and DPCD

Re: amdgpu fails compilation with CONFIG_FORTIFY_SOURCE

Thanks for the fix. We've moved to logging functionality more closely aligned with the rest of DRM and dropped logger.c a while back. Harry On 2018-09-05 02:43 PM, Ján Kosterec wrote: > amdgpu driver fails compilation when compiling with CONFIG_FORTIFY_SOURCE > kernel option: > > In function ‘

Re: [PATCH 1/6] drm/dp_mst: Introduce drm_dp_mst_connector_atomic_check()

igned-off-by: Lyude Paul > Cc: sta...@vger.kernel.org This does seem like a saner way to handle the case when the MST connector is gone. As this doesn't currently seem to affect amdgpu directly and I therefore might miss something I'll leave the RB to someone else, but you have my

Re: [PATCH 6/6] drm/amdgpu/dm/mst: Use drm_dp_mst_connector_atomic_check()

that the only atomic DRM driver without the > ->best_encoder() bug is amdgpu. Congrats AMD! > > Signed-off-by: Lyude Paul Reviewed-by: Harry Wentland Harry > --- > .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 12 > 1 file changed, 12 insertions(+)

Re: [PATCH v2 1/6] drm/dp_mst: Introduce drm_dp_mst_connector_atomic_check()

ctor_atomic_check() > function that DRM drivers can call in order to have CRTC enabling > commits fail automatically if the MST port driving the connector no > longer exists. We'll also be able to expand upon this later as well once > we add MST fallback retraining support. >

Re: [PATCH] drm/amd/display: remove redundant null pointer check before kfree

On 2018-09-21 10:10 AM, zhong jiang wrote: > On 2018/9/21 21:56, Harry Wentland wrote: >> On 2018-09-21 09:12 AM, zhong jiang wrote: >>> kfree has taken the null pointer into account. hence it is safe >>> to remove the redundant null pointer check before kfree. >

Re: [PATCH] drm/amd/display: Change status's type in aux_reply_transaction_data

On 2018-09-24 06:22 PM, Nathan Chancellor wrote: > On Mon, Sep 24, 2018 at 03:07:16PM -0700, Nick Desaulniers wrote: >> On Fri, Sep 21, 2018 at 2:55 PM Nathan Chancellor >> wrote: >>> >>> Clang warns when one enumerated type is implicitly converted to another. >>> >>> drivers/gpu/drm/amd/amdgpu/..

Re: [PATCH 05/16] drm/amd/display: Add function to fetch clock requirements

On 2018-09-26 01:42 PM, sunpeng...@amd.com wrote: > From: Eryk Brol > > Also add dram clock to clocks struct, for systems that uses them. > > Signed-off-by: Eryk Brol > Reviewed-by: Jun Lei > Acked-by: Leo Li > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 13 + > drivers/gpu

[PATCH] drm/amd/display: Work around race beetween hw_done and wait_for_flip

erence to all commits in the state before drm_crtc_commit_hw_done is called and release those after drm_atomic_helper_wait_for_flip has finished. Signed-off-by: Harry Wentland --- Would something like this work? I get the strong sense that this happens because Intel and IMX use the helpers in the

Re: [PATCH v2] drm/amd/display: Signal hw_done() after waiting for flip_done()

> hw_done() signal. > > Note that both the i915 and imx drivers have this sequence flipped > already, masking this problem. > > Signed-off-by: Shirish S > Signed-off-by: Leo Li Thanks for the additional explanation. Took me a while to understand what was happening here. Let

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

On 2018-10-01 03:15 AM, Daniel Vetter wrote: > On Mon, Sep 24, 2018 at 02:15:34PM -0400, Nicholas Kazlauskas wrote: >> These patches are part of a proposed new interface for supporting variable >> refresh rate via DRM properties. >> >> === Changes from v1 === >> >> For drm: >> >> * The variable_

Re: [PATCH v2] drm/amd/display: Use proper enums in process_channel_reply

ED_HPD_DISCON; >>> ~ ^~~ >>> >>> The current enum is incorrect, it should be from aux_transaction_reply, >>> so use AUX_TRANSACTION_REPLY_HPD_DISCON. >>> >>> Reported-by: Nick Desaulniers >>> Sugge

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

On 2018-10-03 02:35 PM, Manasi Navare wrote: > On Wed, Oct 03, 2018 at 10:41:20AM +0200, Daniel Vetter wrote: >> On Tue, Oct 02, 2018 at 10:49:17AM -0400, Harry Wentland wrote: >>> >>> >>> On 2018-10-01 03:15 AM, Daniel Vetter wrote: >>>> On

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

On 2018-10-03 04:41 AM, Daniel Vetter wrote: > On Tue, Oct 02, 2018 at 10:49:17AM -0400, Harry Wentland wrote: >> >> >> On 2018-10-01 03:15 AM, Daniel Vetter wrote: >>> On Mon, Sep 24, 2018 at 02:15:34PM -0400, Nicholas Kazlauskas wrote: >>>> These patche

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

On 2018-10-03 04:25 AM, Mike Lothian wrote: > Hi > > I'm curious to know whether this will/could work over PRIME > I don't see why this shouldn't work over PRIME as long as the presenting GPU supports the new variable refresh rate API, but I know very little about prime, so maybe someone else

Re: [PATCH v4 4/4] drm/amd/display: Set FreeSync state using drm VRR properties

On 2018-10-11 12:39 PM, Nicholas Kazlauskas wrote: > Support for AMDGPU specific FreeSync properties and ioctls are dropped > from amdgpu_dm in favor of supporting drm variable refresh rate > properties. > > The drm vrr_capable property is now attached to any DP/HDMI connector. > Its value is upda

Re: [PATCH v4 4/4] drm/amd/display: Set FreeSync state using drm VRR properties

On 2018-10-11 04:56 PM, Kazlauskas, Nicholas wrote: > On 10/11/2018 04:39 PM, Harry Wentland wrote: >> On 2018-10-11 12:39 PM, Nicholas Kazlauskas wrote: >>> Support for AMDGPU specific FreeSync properties and ioctls are dropped >>> from amdgpu_dm in favor of supportin

Re: [PATCH] drm/amdgpu/display: dm/amdgpu: make dp phy debugfs for eDP

RM_MODE_CONNECTOR_DisplayPort || > + connector->base.connector_type == > + DRM_MODE_CONNECTOR_eDP) { Indenting looks funky. Would be nice to get that cleaned up before merge. Anyways, beside the bikeshedding this is Review

Re: [RFC] drm/amd/display: add SI support to AMD DC

On 2018-10-14 5:47 p.m., Mauro Rossi wrote: > Hi, > > reporting about some progress made during the weekend, > thanks to Sylvain feedback & suggestions. > > I have rebased and updated the series on top of > https://cgit.freedesktop.org/~agd5f/linux/?h=amd-staging-drm-next > > Here is the amd_dc_

Re: [RFC] drm/amd/display: add SI support to AMD DC

On 2018-10-15 5:06 p.m., Harry Wentland wrote: > On 2018-10-14 5:47 p.m., Mauro Rossi wrote: >> Hi, >> >> reporting about some progress made during the weekend, >> thanks to Sylvain feedback & suggestions. >> >> I have rebased and updated the series on to

[PATCH 2/2] drm/amd/display: Stop leaking planes

[Why] drm_plane_cleanup does not free the plane. [How] Call drm_primary_helper_destroy which will also free the plane. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd

[PATCH 1/2] drm/amdgpu: Drop amdgpu_plane

It's unnecessarily duplicating drm_plane_type. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 8 +--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 38 +-- 2 files changed, 20 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/dr

[PATCH] drm/amd/display: Fix MST dp_blank REG_WAIT timeout

frame+0x3d/0xa2 ---[ end trace 3ed7b77a97d60f72 ]--- Signed-off-by: Jerry (Fangzhi) Zuo Reviewed-by: Hersen Wu Acked-by: Harry Wentland Tested-by: Lyude Paul --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/g

[PATCH] drm/amd/display: Check hpd_gpio for NULL before accessing it

dal_gpio_open and dal_gpio_unlock_pin dereference hpd_gpio. Check for NULL before calling those functions. Fixes: e261568f94d6 ("drm/amd/display: add gpio lock/unlock") Reported-by: Przemek Socha CC: Chiawen Huang CC: Tony Cheng Signed-off-by: Harry Wentland --- I don't have a

[PATCH] drm/amd/display: don't call dm_pp_ function from an fpu block

n/end. Cc: sta...@vger.kernel.org Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.c b/drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.c

Re: [PATCH 2/2] drm/amdgpu/display: give aux i2c buses more meaningful names

On 2020-04-16 3:43 p.m., Alex Deucher wrote: > Mirror what we do for i2c display buses. > > Signed-off-by: Alex Deucher Series is Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- > .../gpu/drm/amd

Re: [PATCH 05/35] drm/amd/display: Remove byte swapping for dmcub abm config table

On 2020-04-17 8:09 a.m., Christian König wrote: > Am 17.04.20 um 12:43 schrieb Michel Dänzer: >> On 2020-04-17 11:22 a.m., Christian König wrote: >>> Agreed, just wanted to reply as well since I think something is not >>> correctly understood here. >>> >>> The cpu_to_be16() and be16_to_cpu() functi

Re: [PATCH] drm: amdgpu: fix kernel-doc struct warning

ixes: a269e44989f3 ("drm/amdgpu: Avoid reclaim fs while eviction lock") > Signed-off-by: Randy Dunlap > Cc: Signed-off-by: Alex Sierra > Cc: Felix Kuehling > Cc: Christian König > Cc: Alex Deucher > Cc: David (ChunMing) Zhou > Cc: amd-gfx@lists.freedesktop.org Rev

Re: [PATCH] drm: amd: display: fix kernel-doc struct warning

r' > > Fixes: 52704fcaf74b ("drm/amd/display: Initialize HDCP work queue") > Signed-off-by: Randy Dunlap > Cc: Bhawanpreet Lakha > Cc: Harry Wentland > Cc: Alex Deucher > Cc: Leo Li > Cc: amd-gfx@lists.freedesktop.org Reviewed-by: Harry Wentland Harry

Re: [PATCH] drm: amd/display: fix Kconfig help text

62236b3bc0 ("drm/amd/dc: Add dc display driver (v2)") > Signed-off-by: Randy Dunlap > Cc: Harry Wentland > Cc: Alex Deucher > Cc: Krzysztof Kozlowski Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/Kconfig |8 ++-- > 1 file changed

Re: FreeBSD / amdgpu / Vega 3, pstate TEST_DEBUG_DATA: 0x0

On 2020-04-24 8:34 a.m., Andriy Gapon wrote: > > First, I understand that my platform is not directly supported and probably > not > very interesting, but I still hope to get some tips or pointers. > Hi Andriy, yeah, limited insight here since FreeBSD isn't something I'm familiar with. :) > I

Re: FreeBSD / amdgpu / Vega 3, pstate TEST_DEBUG_DATA: 0x0

On 2020-04-27 4:43 p.m., Andriy Gapon wrote: > On 24/04/2020 20:22, Harry Wentland wrote: >> On 2020-04-24 8:34 a.m., Andriy Gapon wrote: >>> >>> First, I understand that my platform is not directly supported and probably >>> not >>> very inte

Re: [PATCH] drm: Correct DP DSC macro typo

places that attempt to access this > macro. > > Signed-off-by: Rodrigo Siqueira Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 2 +- > include/drm/drm_dp_helper.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions

Re: [PATCH] drm/amd/display: Add dm support for DP 1.4 Compliance edid corruption test

On 2020-04-29 1:58 p.m., Jerry (Fangzhi) Zuo wrote: > It works together with drm framework > "drm: Add support for DP 1.4 Compliance edid corruption test" > > Signed-off-by: Jerry (Fangzhi) Zuo > --- > .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 40 ++- > 1 file changed, 1

Re: [PATCH] drm/amd/display: Add dm support for DP 1.4 Compliance edid corruption test

E but do not > set connector->edid_corrupt > 3. For invalid extension blocks, drm doesn't set > connector->edid_corrupt. This case will be further handled by > dm_helpers_parse_edid_caps() with 3 times retries. > If failed any step above with EDID_BAD_

Re: [PATCH] drm/amd/amdgpu: Update update_config() logic

he settings after the call to remove display is called. > > Change-Id: I8235998b8fac3d58d24edf86bb5d7cc030f1e375 Please drop the Change-Id before merging. > Signed-off-by: Leo (Hanghong) Ma Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu

[PATCH 1/3] drm/amd/display: Add DC Debug mask to disable features for bringup

* DC_DISABLE_DSC * DC_DISABLE_CLOCK_GATING Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 ++ drivers/gpu/drm/amd/include

[PATCH 3/3] drm/amd/display: Respect PP_STUTTER_MODE but don't override DC_DISABLE_STUTTER

Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index bf347ca43064..9d833264

[PATCH 2/3] drm/amd/display: Fix disable_stutter debug option

[Why & How] One call was forcing stutter on instead of looking at the debug option. Ensure we always check the debug option unless we want to force stutter off. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c | 1 - drivers/gpu/drm/amd/displa

[PATCH 0/3] Adding DC debug options

is a collection of features that are enabled by default. Harry Wentland (3): drm/amd/display: Add DC Debug mask to disable features for bringup drm/amd/display: Fix disable_stutter debug option drm/amd/display: Respect PP_STUTTER_MODE but don't override DC_DISABLE_STUTTER drivers/g

Re: [PATCH 1/3] drm/amd/display: Add DC Debug mask to disable features for bringup

On 2020-05-12 12:54 p.m., Kazlauskas, Nicholas wrote: > On 2020-05-12 12:45 p.m., Harry Wentland wrote: >> [Why] >> At bringup we want to be able to disable various power features. >> >> [How] >> These features are already exposed as dc_debug_options and exercis

Re: [PATCH 1/3] drm/amd/display: Add DC Debug mask to disable features for bringup

On 2020-05-12 12:54 p.m., Kazlauskas, Nicholas wrote: > On 2020-05-12 12:45 p.m., Harry Wentland wrote: >> [Why] >> At bringup we want to be able to disable various power features. >> >> [How] >> These features are already exposed as dc_debug_options and exercis

[PATCH 2/3] drm/amd/display: Don't load DMCU for Raven 1

load on Raven 1. Only load it for Raven 2 and Picasso. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/di

[PATCH 1/3] drm/amd/display: Add ASICREV_IS_PICASSO

[WHY] We only want to load DMCU FW on Picasso and Raven 2, not on Raven 1. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/include/dal_asic_id.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/include/dal_asic_id.h b/drivers

[PATCH 3/3] drm/amd/display: Drop DCN1_01 guards

[WHY] These were only needed for bringup. They're not needed anymore. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/Kconfig | 6 -- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 -- .../display/dc/bios/command_table_helper2.c | 5 - .../gpu/dr

Re: [PATCH 3/3] drm/amd/display: Drop DCN1_01 guards

On 2019-05-14 2:02 p.m., Kazlauskas, Nicholas wrote: > On 5/14/19 1:49 PM, Harry Wentland wrote: >> >> [WHY] >> These were only needed for bringup. They're not needed anymore. >> >> Signed-off-by: Harry Wentland > > Series is: > > Reviewed-by

Re: [PATCH 1/3] drm/amd/display: Add ASICREV_IS_PICASSO

On 2019-05-14 2:20 p.m., Kazlauskas, Nicholas wrote: > [CAUTION: External Email] > > On 5/14/19 1:49 PM, Harry Wentland wrote: >> >> [WHY] >> We only want to load DMCU FW on Picasso and Raven 2, not on Raven 1. >> >> Signed-off-by: Harry Wentland >>

Re: [PATCH] drm/amd/display: Allow faking displays as VRR capable.

On 2019-04-30 3:56 p.m., Mario Kleiner wrote: > [CAUTION: External Email] > > On Tue, Apr 30, 2019 at 2:22 PM Kazlauskas, Nicholas > wrote: >> >> On 4/30/19 3:44 AM, Michel Dänzer wrote: >>> [CAUTION: External Email] >>> >>> On 2019-04-30 9:37 a.m., Mario Kleiner wrote: Allow to detect any

Re: [PATCH 2/2] drm/amd/display: Use new connector state when getting color depth

Series is Reviewed-by: Harry Wentland Harry On 2019-05-22 11:11 a.m., Nicholas Kazlauskas wrote: > [CAUTION: External Email] > > [Why] > The current state on the connector is queried when getting the max bpc > rather than the new state. This means that a new max bpc value can o

Re: [PATCH v2 2/2] drm/amd/display: Use new connector state when getting color depth

easonable > defaults in place. That should probably be addressed at some point. > > This change now (correctly) causes a modeset to occur when changing the > max bpc for a connector. > > v2: Drop extra TODO. > > Cc: Leo Li > Cc: Harry Wentland > Signed-off-by: Nich

Re: [PATCH 0/2] drm/amd/display: Add HDR output metadata support for amdgpu

now since that's all the > DRM interface supports. It requires a modeset for entering and exiting HDR > but the metadata can be changed without one. > > Cc: Harry Wentland > Series is Reviewed-by: Harry Wentland Harry > Nicholas Kazlauskas (2): > drm/amd/dis

Re: RX 580 and 5K displays, bandwidth validation failed whith multiple monitors

On 2019-05-27 10:58 a.m., Gaël HERMET wrote: > Hi, > > I have been facing an issue with my 5K display (iiyama ProLite > XB2779QQS-S1). > > It works fine as long as it is the only active monitor, as soon as I > activate another monitor the main one (5k) can't display more than 4k. > > Debug using

Re: [PATCH] drm/amd/display: Add back missing hw translate init for DCN1_01

N1_01 when loading the driver. > > [How] > Add it back. > > Cc: Harry Wentland > Fixes: 97df424fe7a7 ("drm/amd/display: Drop DCN1_01 guards") > Signed-off-by: Nicholas Kazlauskas Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/g

Re: [PATCH] drm/amdgpu/display: Drop some new CONFIG_DRM_AMD_DC_DCN1_01 guards

On 2019-05-31 12:37 p.m., Alex Deucher wrote: > These got added back by subsequent merges accidently. > > Signed-off-by: Alex Deucher Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 -- > drivers/gpu/drm/amd/display/dc/clk_

<    5   6   7   8   9   10   11   12   13   14   >