Re: [PATCH v2] drm/amd/powerplay:clean up the residual mutex for smu_hw_init

2019-06-26 Thread Kevin Wang
Reviewed-by: Kevin Wang On 6/25/19 3:43 PM, Prike Liang wrote: > The mutex for procting SMU during hw_init was removed as system > will be deadlock when smu_populate_umd_state_clk try get SMU mutex. > Therefore need remove the residual mutex from failed path. >

Re: [PATCH 1/2] drm/amdgpu/powerplay: FEATURE_MASK is 64 bit so use ULL

2019-06-26 Thread Kevin Wang
Reviewed-by: Kevin Wang Best Regards, Kevin On 6/25/19 9:58 PM, Alex Deucher wrote: > ULL is needed for 32 bit arches. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 2 +- > drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 2 +- >

Re: [PATCH] drm/amd/powerplay: warn on smu interface version mismatch

2019-06-26 Thread Kevin Wang
please add this message in patch commit. after Reviewed-by: Kevin Wang Best Regards, Kevin On 6/26/19 2:34 PM, Yuan, Xiaojie wrote: > Current SMU IF version check is too strict, driver with old smu11_driver_if.h > sometimes works fine with new SMU firmware. We prefer to see a w

<    1   2