Re: [PATCH v2 1/2] drm/amdgpu: Temporarily disable broken Clang builds due to blown stack-frame

2022-11-27 Thread Nathan Chancellor
te kernel > panic on most architectures. We'll revert this when the following bug report > has been resolved: https://github.com/llvm/llvm-project/issues/41896. > > Suggested-by: Arnd Bergmann > Signed-off-by: Lee Jones Reviewed-by: Nathan Chancellor > --- > driv

Re: [PATCH v2 2/2] Kconfig.debug: Provide a little extra FRAME_WARN leeway when KASAN is enabled

2022-11-27 Thread Nathan Chancellor
gt; > Signed-off-by: Lee Jones Reviewed-by: Nathan Chancellor > --- > lib/Kconfig.debug | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index c3c0b077ade33..82d475168db95 100644 > --- a/lib/Kconfig.debug > +++ b

[PATCH 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

2023-01-04 Thread Nathan Chancellor
the rest of the test infrastructure will catch any lurking problems. I would like this series to stay together so that there is no opportunity for breakage so please consider giving acks so that this can be carried via the kbuild tree. --- Nathan Chancellor (12): MIPS: Always

[PATCH 12/14] drm/amd/display: Do not add '-mhard-float' to dml_ccflags for clang

2023-01-04 Thread Nathan Chancellor
d this flag to GCC builds. Commit 0f0727d971f6 ("drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines") added '-msse2' to prevent clang from emitting software floating point routines. Signed-off-by: Nathan Chancellor --- Cc: har

[PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

2023-01-11 Thread Nathan Chancellor
ked (Nick, Segher) - Patch 7: Move '-z noexecstack' into new ldflags-y variable (Nick) - Patch 8: Reword commit message to explain the problem in a clearer manner (Nick) - Link to v1: https://lore.kernel.org/r/20221228-drop-qunused-arguments-v1-0-658cbc8fc...@kernel.org --- Nathan

[PATCH v2 12/14] drm/amd/display: Do not add '-mhard-float' to dml_ccflags for clang

2023-01-11 Thread Nathan Chancellor
d this flag to GCC builds. Commit 0f0727d971f6 ("drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines") added '-msse2' to prevent clang from emitting software floating point routines. Signed-off-by: Nathan Chancellor Acked-by: Alex Deuc

Re: [PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

2023-01-23 Thread Nathan Chancellor
Hi Naresh, On Mon, Jan 23, 2023 at 07:28:10PM +0530, Naresh Kamboju wrote: > FYI, > [ please provide comments, feedback and improvements on build/ ltp smoke > tests ] > > LKFT test farm have fetched your patch series [1] > [PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS >

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Nathan Chancellor
On Wed, Jun 15, 2022 at 03:28:52PM -0400, Alex Deucher wrote: > On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap wrote: > > > > > > > > On 6/14/22 23:01, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since 20220614: > > > > > > > on i386: > > # CONFIG_DEBUG_FS is not set > > > > > > ../dri

Re: linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Nathan Chancellor
On Wed, Jun 15, 2022 at 04:45:16PM -0400, Alex Deucher wrote: > On Wed, Jun 15, 2022 at 4:24 PM Nathan Chancellor wrote: > > > > On Wed, Jun 15, 2022 at 03:28:52PM -0400, Alex Deucher wrote: > > > On Wed, Jun 15, 2022 at 3:01 PM Randy Dunlap > > > wrote: > &

Re: [PATCH 16/31] drm/amd/display: refactor function transmitter_to_phy_id

2022-06-17 Thread Nathan Chancellor
Chao-kai Wang > Acked-by: Alan Liu > Reviewed-by: Nicholas Kazlauskas > Signed-off-by: Nathan Chancellor > Signed-off-by: Alex Deucher How did I end up in the signoff chain for a patch I have never seen up until this point? That should definitely be cleaned up. Additionally, this

Re: [PATCH v4 18/21] compiler.h: RFC - s/__LINE__/__COUNTER__/ in __UNIQUE_ID fallback

2023-07-13 Thread Nathan Chancellor
; Lets see what lkp-robot says about this. > > CC: Luc Van Oostenryck (maintainer:SPARSE > CHECKER) > CC: Nathan Chancellor (supporter:CLANG/LLVM BUILD SUPPORT) > CC: Nick Desaulniers (supporter:CLANG/LLVM BUILD > SUPPORT) > CC: Tom Rix (reviewer:CLANG/LLVM BUILD SUP

Re: [PATCH] drm/amd/display: Allow building DC with clang on RISC-V

2023-07-18 Thread Nathan Chancellor
ed for, so I agree. Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > > drivers/gpu/drm/amd/display/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/Kconfig > b/drivers/gpu/drm/amd/display/Kconfig >

Re: [PATCH 1/6] drm: execution context for GEM buffers v7

2023-07-22 Thread Nathan Chancellor
Hi Christian, On Tue, Jul 11, 2023 at 03:31:17PM +0200, Christian König wrote: > This adds the infrastructure for an execution context for GEM buffers > which is similar to the existing TTMs execbuf util and intended to replace > it in the long term. > > The basic functionality is that we abstrac

Re: [PATCH] drm/radeon: Prefer 'unsigned int' to bare use of 'unsigned'

2023-07-29 Thread Nathan Chancellor
On Sat, Jul 29, 2023 at 09:12:05PM +0700, Bagas Sanjaya wrote: > On Fri, Jul 28, 2023 at 10:35:19PM +0800, 孙冉 wrote: > > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > > > > Signed-off-by: Ran Sun > > Your From: address != SoB identity While the comment below is a completely valid c

[PATCH -next] drm/amd/display: Add a conversion function for transmitter and phy_id enums

2019-10-30 Thread Nathan Chancellor
entry for reading psr state") Link: https://github.com/ClangBuiltLinux/linux/issues/758 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 38 ++- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_li

Re: [03/14] drm/amd/display: Add execution and transition states for HDCP2.2

2019-11-23 Thread Nathan Chancellor
On Thu, Nov 07, 2019 at 10:56:17AM -0500, Bhawanpreet Lakha wrote: > The module works like a state machine > > +-+ > --> | Execution.c | -- > | +-+ | >

[PATCH] drm/amd/display: Use NULL for pointer assignment in copy_stream_update_to_stream

2019-11-25 Thread Nathan Chancellor
ate->dsc_config = false; ^ 2 warnings generated. Fixes: f6fe4053b91f ("drm/amd/display: Use a temporary copy of the current state when updating DSC config") Link: https://github.com/ClangBuiltLinux/linux/issues/777 Signed-off-by: Nathan

[PATCH] drm/amdgpu: Ensure ret is always initialized when using SOC15_WAIT_ON_RREG

2019-11-25 Thread Nathan Chancellor
in the future, make the SOC15_WAIT_ON_RREG macro initialize its ret variable before the while loop that can time out. This macro's return value is always checked so it should set ret in both the success and fail path. Link: https://github.com/ClangBuiltLinux/linux/issues/776 Signed-off-by: Nathan

[PATCH] drm/amd/display: Change status's type in aux_reply_transaction_data

2018-09-21 Thread Nathan Chancellor
of implicitly or explicitly converting between types, just change status to type uint8_t (since its max size is 255) which avoids this construct altogether. Reported-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/dc/dc_ddc_types.h | 2 +- 1 file change

[PATCH] drm/amd/powerplay: Change id parameter type in pp_atomfwctrl_get_clk_information_by_clkid

2018-09-21 Thread Nathan Chancellor
es, change id's type to uint8_t in pp_atomfwctrl_get_clk_information_by_clkid so no conversion happens. Reported-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/powerplay/hwmgr/ppatomfwctrl.c | 3 ++- drivers/gpu/drm/amd/powerplay/hwmgr/ppatomfwctrl.h | 2 +- 2 file

Re: [PATCH] drm/amd/display: Change status's type in aux_reply_transaction_data

2018-09-24 Thread Nathan Chancellor
On Mon, Sep 24, 2018 at 03:07:16PM -0700, Nick Desaulniers wrote: > On Fri, Sep 21, 2018 at 2:55 PM Nathan Chancellor > wrote: > > > > Clang warns when one enumerated type is implicitly converted to another. > > > > drivers/gpu/drm/amd/amdgpu/../display/dc

Re: [PATCH v2] drm/amd/display: Use proper enums in process_channel_reply

2018-09-27 Thread Nathan Chancellor
On Thu, Sep 27, 2018 at 11:06:33AM -0700, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another. > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c:315:19: warning: > implicit conversion from enumeratio

[PATCH v2] drm/amd/display: Use proper enums in process_channel_reply

2018-09-27 Thread Nathan Chancellor
e current enum is incorrect, it should be from aux_transaction_reply, so use AUX_TRANSACTION_REPLY_HPD_DISCON. Reported-by: Nick Desaulniers Suggested-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- v1 -> v2: * Rather than change status to an integer, use the proper enumerated type fr

[PATCH] drm/amd/display: Pass app_tf by value rather than by reference

2018-12-11 Thread Nathan Chancellor
when NULL was used for app_tf. Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 7 +++ drivers/gpu/drm/amd/display/modules/inc/mod_freesync.h | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/modu

Re: [PATCH] drm/amd/display: Pass app_tf by value rather than by reference

2018-12-11 Thread Nathan Chancellor
On Tue, Dec 11, 2018 at 02:07:31PM -0800, Nick Desaulniers wrote: > On Tue, Dec 11, 2018 at 1:42 PM Nathan Chancellor > wrote: > > > > On Tue, Dec 11, 2018 at 01:25:00PM -0800, Nick Desaulniers wrote: > > > On Mon, Dec 10, 2018 at 3:42 PM Nathan Chancellor > >

Re: [PATCH] drm/amd/display: Pass app_tf by value rather than by reference

2018-12-11 Thread Nathan Chancellor
On Tue, Dec 11, 2018 at 01:25:00PM -0800, Nick Desaulniers wrote: > On Mon, Dec 10, 2018 at 3:42 PM Nathan Chancellor > wrote: > > > > Clang warns when an expression that equals zero is used as a null > > pointer constant (in lieu of NULL): > > > > drivers/gpu

[PATCH] drm/amdkfd: Fix if preprocessor statement above kfd_fill_iolink_info_for_cpu

2019-01-21 Thread Nathan Chancellor
Clang warns: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:866:5: warning: 'CONFIG_X86_64' is not defined, evaluates to 0 [-Wundef] #if CONFIG_X86_64 ^ 1 warning generated. Fixes: d1c234e2cd10 ("drm/amdkfd: Allow building KFD on ARM64 (v2)") Signed-off-by: Nathan Chance

Re: [PATCH] drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines

2019-01-24 Thread Nathan Chancellor
el.org # 4.19 > Reported-by: S, Shirish > Reported-by: Matthias Kaehlcke > Suggested-by: James Y Knight > Suggested-by: Nathan Chancellor > Signed-off-by: Nick Desaulniers > Tested-by: Guenter Roeck Tested-by: Nathan Chancellor > --- > drivers/gpu/drm/amd/disp

Re: [PATCH] drm/amd/display: Pass app_tf by value rather than by reference

2019-01-26 Thread Nathan Chancellor
On Fri, Dec 14, 2018 at 08:09:00PM +, Wentland, Harry wrote: > On 2018-12-11 5:07 p.m., Nick Desaulniers wrote: > > On Tue, Dec 11, 2018 at 1:42 PM Nathan Chancellor > > wrote: > >> > >> On Tue, Dec 11, 2018 at 01:25:00PM -0800, Nick Desaulniers wrote: >

[PATCH] drm/amd/display: Use memset to initialize variables in amdgpu_dm_atomic_commit_tail

2019-02-01 Thread Nathan Chancellor
y underscan and ABM commit") Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.

[PATCH] drm/amd/display: Use memset to initialize variables in fill_plane_dcc_attributes

2019-02-01 Thread Nathan Chancellor
[1]: https://lore.kernel.org/lkml/022e41c0-8465-dc7a-a45c-64187ecd9...@amd.com/ [2]: https://lore.kernel.org/lkml/20181128.215241.702406654469517539.da...@davemloft.net/ Fixes: 7df7e505e82a ("drm/amd/display: Set requested plane state DCC params for GFX9") Signed-off-by: Nathan Chancellor ---

[PATCH] drm/amd/display: Use memset to initialize variable in wait_for_training_aux_rd_interval

2019-02-01 Thread Nathan Chancellor
itialized union") Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c index 92f565ca1260..5ee36

Re: [PATCH] drm/amd/display: Pass app_tf by value rather than by reference

2019-02-22 Thread Nathan Chancellor
On Mon, Dec 10, 2018 at 04:42:01PM -0700, Nathan Chancellor wrote: > Clang warns when an expression that equals zero is used as a null > pointer constant (in lieu of NULL): > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4435:3: > warning: expression which ev

Re: [PATCH] drm/amd/display: avoid passing enum as NULL pointer

2019-03-07 Thread Nathan Chancellor
On Thu, Mar 07, 2019 at 11:34:29AM +0100, Arnd Bergmann wrote: > The mod_freesync_build_vrr_infopacket() function uses rather obscure > calling conventions, where an enum is passed in through a pointer, > and a NULL pointer is expected to behave the same way as the zero-value > (TRANSFER_FUNC_UNKNO

[PATCH] drm/amd/display: Remove pointless NULL checks in dmub_psr_copy_settings

2020-03-02 Thread Nathan Chancellor
display: Driverside changes to support PSR in DMCUB") Link: https://github.com/ClangBuiltLinux/linux/issues/915 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/d

[PATCH] drm/amdgpu: Initialize shadow to false in gfx_v9_0_rlcg_wreg

2020-03-18 Thread Nathan Chancellor
ensure shadow is always used initialized. Fixes: 2e0cc4d48b91 ("drm/amdgpu: revise RLCG access path") Link: https://github.com/ClangBuiltLinux/linux/issues/936 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2] drm/amdgpu: Remove unnecessary variable shadow in gfx_v9_0_rlcg_wreg

2020-03-18 Thread Nathan Chancellor
s the condition for another if statement; combine the two if statements and remove shadow to make the code cleaner and resolve this warning. Fixes: 2e0cc4d48b91 ("drm/amdgpu: revise RLCG access path") Link: https://github.com/ClangBuiltLinux/linux/issues/936 Suggested-by: Joe Perches Re

[PATCH] drm/amd/display: Fix 64-bit division error on 32-bit platforms in mod_freesync_build_vrr_params

2020-03-31 Thread Nathan Chancellor
t; did you mean: __aeabi_uidivmod >>> defined in: arch/arm/lib/lib.a(lib1funcs.o) Use div_u64 in the two locations that do 64-bit divisior, which both have a u64 dividend and u32 divisor. Fixes: 349a370781de ("drm/amd/display: LFC not working on 2.0x range monitors") Signed-off

Re: mmotm 2020-03-30-18-46 uploaded (freesync)

2020-03-31 Thread Nathan Chancellor
On Mon, Mar 30, 2020 at 11:18:26PM -0700, Randy Dunlap wrote: > On 3/30/20 6:47 PM, a...@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2020-03-30-18-46 has been uploaded to > > > >http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-of-the-mo

[PATCH] drm/amdgpu: Avoid integer overflow in amdgpu_device_suspend_display_audio

2020-05-02 Thread Nathan Chancellor
drm/amdgpu: put the audio codec into suspend state before gpu reset V3") Link: https://github.com/ClangBuiltLinux/linux/issues/1017 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

Re: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

2019-03-20 Thread Nathan Chancellor
can make one then. > > Thanks > xinhui > > > -Original Message- > From: Nathan Chancellor > Sent: 2019年3月20日 8:54 > To: Deucher, Alexander ; Koenig, Christian > ; Zhou, David(ChunMing) ; Pan, > Xinhui > Cc: amd-gfx@lists.freedesktop.org; dri-de...@

[PATCH] drm/amd/powerplay: Zero initialize num_of_levels in vega20_set_single_dpm_table

2019-03-20 Thread Nathan Chancellor
s the same. Fixes: 870b996f955f ("drm/amd/powerplay: set defalut dpm table for smu") Link: https://github.com/ClangBuiltLinux/linux/issues/425 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

2019-03-20 Thread Nathan Chancellor
Hi all, The introduction of this file in commit dbd249c24427 ("drm/amdgpu: add amdgpu_ras.c to support ras (v2)") introduces the following Clang warnings: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:544:23: warning: implicit conversion from enumeration type 'enum amdgpu_ras_block' to different enume

Re: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

2019-03-20 Thread Nathan Chancellor
struct amdgpu_device *adev); void amdgpu_ras_post_init(struct amdgpu_device *adev); > On Wed, Mar 20, 2019 at 2:37 AM Koenig, Christian > wrote: > > > Am 20.03.19 um 05:34 schrieb Nathan Chancellor: > > > On Wed, Mar 20, 2019 at 01:31:27AM +, Pan, Xinhui wrote: > &

Re: [PATCH][next] drm/amdgpu: fix return of an uninitialized value in variable ret

2019-05-10 Thread Nathan Chancellor
Fix this by not returning > ret but instead returning -EINVAL on the zero lo_base_addr case. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: a6ac0b44bab9 ("drm/amdgpu: add df perfmon regs and funcs for xgmi") > Signed-off-by: Colin Ian King R

Re: [v3] drm/amdgpu: add badpages sysfs interafce

2019-05-17 Thread Nathan Chancellor
On Thu, May 09, 2019 at 10:31:05AM +, Pan, Xinhui wrote: > add badpages node. > it will output badpages list in format > gpu pfn : gpu page size : flags > > example > 0x : 0x1000 : R > 0x0001 : 0x1000 : R > 0x0002 : 0x1000 : R > 0x0003 : 0x1000 : R > 0x0

[PATCH] drm/amdgpu: Add braces to initialize task_info subojects

2018-09-12 Thread Nathan Chancellor
}; ^ {} 1 warning generated. Reported-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- 2 files changed, 2

Re: [PATCH] drm/amdgpu: Add braces to initialize task_info subojects

2018-09-12 Thread Nathan Chancellor
On Wed, Sep 12, 2018 at 10:38:30AM -0700, Nick Desaulniers wrote: > On Tue, Sep 11, 2018 at 5:26 PM Nathan Chancellor > wrote: > > > > Clang warns if there are missing braces around a subobject > > initializer. > > > > drivers/gpu/drm/amd/amdgpu/gmc_v8_

Re: [PATCH] drm/amdgpu: Add braces to initialize task_info subojects

2018-09-12 Thread Nathan Chancellor
On Wed, Sep 12, 2018 at 02:44:34PM -0400, Alex Deucher wrote: > On Wed, Sep 12, 2018 at 2:40 PM Nathan Chancellor > wrote: > > > > On Wed, Sep 12, 2018 at 10:38:30AM -0700, Nick Desaulniers wrote: > > > On Tue, Sep 11, 2018 at 5:26 PM Nathan Chancellor > > > w

[PATCH v2] drm/amd: Properly initialize all subobjects in structures

2018-09-12 Thread Nathan Chancellor
drm/amd but do this conversion for all instances of this idiom for consistency (also used by several other locations in the kernel tree). Reported-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- v1 -> v2: * Use empty braces for initialization as suggested by Nick * Convert all users

Re: [PATCH] drm/amdgpu: Add braces to initialize task_info subojects

2018-09-12 Thread Nathan Chancellor
On Wed, Sep 12, 2018 at 01:24:34PM -0700, Richard Smith wrote: > On Wed, Sep 12, 2018 at 10:38 AM Nick Desaulniers > wrote: > > > On Tue, Sep 11, 2018 at 5:26 PM Nathan Chancellor > > wrote: > > > > > > Clang warns if there are missing brac

Re: [CI-NOTIFY]: TCWG Bisect tcwg_kernel/llvm-release-aarch64-next-allmodconfig - Build # 48 - Successful!

2019-12-17 Thread Nathan Chancellor
On Tue, Dec 17, 2019 at 09:19:37AM -0800, 'Nick Desaulniers' via Clang Built Linux wrote: > Bhawanpreet, I suspect you're missing the header to include udelay in > drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp2_execution.c. > Can you please send a fix for this? > arm allyesconfig is al

[PATCH] drm/amdgpu: Fix implicit enum conversion in gfx_v9_4_ras_error_inject

2020-01-30 Thread Nathan Chancellor
k: https://github.com/ClangBuiltLinux/linux/issues/849 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c index e19d275f3f7d..f0

[PATCH] drm/amd/display: Don't take the address of skip_scdc_overwrite in dc_link_detect_helper

2020-02-14 Thread Nathan Chancellor
newline after this if block. Fixes: a760fc1bff03 ("drm/amd/display: add monitor patch to disable SCDC read/write") Link: https://github.com/ClangBuiltLinux/linux/issues/879 Signed-off-by: Nathan Chancellor --- As an aside, I don't see skip_scdc_overwrite assigned a value anywhere, is this

[PATCH] drm/amd/display: Fix 32-bit divide error in wait_for_alt_mode

2019-08-20 Thread Nathan Chancellor
/display/dc/core/dc_link.o:(wait_for_alt_mode) in archive >>> drivers/built-in.a time_taken_in_ns is of type unsigned long long so we need to use div_u64 to avoid this error. Fixes: b5b1f4554904 ("drm/amd/display: Enable type C hotplug") Reported-by: Randy Dunlap Signed-off

Re: [PATCH 6/6] [RESEND] drm/amdgpu: work around llvm bug #42576

2019-10-02 Thread Nathan Chancellor
On Wed, Oct 02, 2019 at 09:51:37AM -0700, 'Nick Desaulniers' via Clang Built Linux wrote: > > Apparently this bug is still present in both the released clang-9 > > and the current development version of clang-10. > > I was hoping we would not need a workaround in clang-9+, but > > it seems that we

arm32 build failure after abe882a39a9c ("drm/amd/display: fix issue with eDP not detected on driver load")

2019-06-17 Thread Nathan Chancellor
Hi all, After commit abe882a39a9c ("drm/amd/display: fix issue with eDP not detected on driver load") in -next, arm32 allyesconfig builds start failing at link time: arm-linux-gnueabi-ld: drivers/gpu/drm/amd/display/dc/core/dc_link.o: in function `dc_link_detect': dc_link.c:(.text+0x260c): undefi

[PATCH 5/7] drm/amd/display: Use proper enum conversion functions

2019-07-03 Thread Nathan Chancellor
Fixes: a43913ea50a5 ("drm/amd/powerplay: add function get_clock_by_type_with_latency for navi10") Fixes: e5e4e22391c2 ("drm/amd/powerplay: add interface to get clock by type with latency for display (v2)") Link: https://github.com/ClangBuiltLinux/linux/issues/586 Signed

[PATCH 2/7] drm/amd/powerplay: Use memset to initialize metrics structs

2019-07-03 Thread Nathan Chancellor
clock freq interface for navi10") Fixes: ab43c4bf1cc8 ("drm/amd/powerplay: fix fan speed show error (for hwmon pwm)") Link: https://github.com/ClangBuiltLinux/linux/issues/583 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 8 ++-- 1 file ch

[PATCH 6/7] drm/amd/powerplay: Use proper enums in vega20_print_clk_levels

2019-07-03 Thread Nathan Chancellor
xes: 096761014227 ("drm/amd/powerplay: support sysfs to get socclk, fclk, dcefclk") Link: https://github.com/ClangBuiltLinux/linux/issues/587 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(

[PATCH 1/7] drm/amdgpu/mes10.1: Fix header guard

2019-07-03 Thread Nathan Chancellor
d ("drm/amdgpu/mes10.1: add ip block mes10.1 (v2)") Link: https://github.com/ClangBuiltLinux/linux/issues/582 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/amdgpu/mes_v10_1.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v10_1.h

[PATCH 4/7] drm/amd/powerplay: Zero initialize freq in smu_v11_0_get_current_clk_freq

2019-07-03 Thread Nathan Chancellor
-> Mhz)") Link: https://github.com/ClangBuiltLinux/linux/issues/585 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b/drivers/gpu/drm/amd/powerplay/smu_v11_

[PATCH 7/7] drm/amd/powerplay: Zero initialize current_rpm in vega20_get_fan_speed_percent

2019-07-03 Thread Nathan Chancellor
es: ee0db82027ee ("drm/amd/powerplay: move PPTable_t uses into asic level") Link: https://github.com/ClangBuiltLinux/linux/issues/588 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/g

[PATCH 0/7] amdgpu clang warning fixes on next-20190703

2019-07-03 Thread Nathan Chancellor
Hi all, I don't do threaded patches very often so if I have messed something up, please forgive me :) This series fixes all of the clang warnings that I saw added in next-20190703. The full list is visible in the gist linked below and each full individual warning can be seen in the GitHub link in

[PATCH 3/7] drm/amd/powerplay: Use proper enums in smu_adjust_power_state_dynamic

2019-07-03 Thread Nathan Chancellor
uot;drm/amd/powerplay: Unify smu handle task function (v2)") Link: https://github.com/ClangBuiltLinux/linux/issues/584 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/d

Re: [PATCH] drm/amd/powerplay: work around enum conversion warnings

2019-07-08 Thread Nathan Chancellor
Hi Arnd, On Mon, Jul 08, 2019 at 03:57:06PM +0200, Arnd Bergmann wrote: > A couple of calls to smu_get_current_clk_freq() and smu_force_clk_levels() > pass constants of the wrong type, leading to warnings with clang-8: > > drivers/gpu/drm/amd/amdgpu/../powerplay/vega20_ppt.c:995:39: error: implic

Re: [1/2] drm/amd/powerplay: smu_v11_0: fix uninitialized variable use

2019-07-08 Thread Nathan Chancellor
On Mon, Jul 08, 2019 at 04:07:58PM +0200, Arnd Bergmann wrote: > A mistake in the error handling caused an uninitialized > variable to be used: > > drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:1102:10: error: variable > 'freq' is used uninitialized whenever '?:' condition is false > [-Wer

Re: [PATCH 0/7] amdgpu clang warning fixes on next-20190703

2019-07-09 Thread Nathan Chancellor
On Mon, Jul 08, 2019 at 11:55:50AM -0400, Alex Deucher wrote: > Applied the series. thanks! > > Alex Thank you :) I don't see the enum conversion ones in your current tree. If they indeed caused issues, could you guys please look into fixing the warnings properly yourselves (maybe something lik

Re: [PATCH 5/7] drm/amd/display: Use proper enum conversion functions

2019-07-09 Thread Nathan Chancellor
On Tue, Jul 09, 2019 at 08:51:33PM +0200, Arnd Bergmann wrote: > On Thu, Jul 4, 2019 at 7:52 AM Nathan Chancellor > wrote: > > > > clang warns: > > > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_pp_smu.c:336:8: > > warning: implicit co

Re: [PATCH] drm/amd/display: return 'NULL' instead of 'false' from dcn20_acquire_idle_pipe_for_layer

2019-07-12 Thread Nathan Chancellor
4e6352c16 ("drm/amd/display: Add DCN2 HW Sequencer and Resource") > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor

Re: [PATCH 6/7] drm/amd/powerplay: Use proper enums in vega20_print_clk_levels

2019-07-15 Thread Nathan Chancellor
On Mon, Jul 15, 2019 at 11:25:29AM +0200, Arnd Bergmann wrote: > On Thu, Jul 4, 2019 at 7:52 AM Nathan Chancellor > wrote: > > > > clang warns: > > > > drivers/gpu/drm/amd/amdgpu/../powerplay/vega20_ppt.c:995:39: warning: > > implicit conversion from enu

Re: [PATCH 5/7] drm/amd/display: Use proper enum conversion functions

2019-07-18 Thread Nathan Chancellor
On Wed, Jul 03, 2019 at 10:52:16PM -0700, Nathan Chancellor wrote: > clang warns: > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_pp_smu.c:336:8: > warning: implicit conversion from enumeration type 'enum smu_clk_type' > to different enumeration typ

[PATCH] drm/amd/powerplay: Zero initialize some variables

2019-08-04 Thread Nathan Chancellor
he path of least resistance right now as every other change will be driver wide so do that here. I only make the comment now as food for thought. Fixes: b4af964e75c4 ("drm/amd/powerplay: make power limit retrieval as asic specific") Link: https://github.com/ClangBuiltLinux/linux/issue

<    1   2