or_signal))
return false;
default:
break;
Looks good. Fixing the indenting or merging the conditions would be a
good idea, however.
Reviewed-by: Nicholas Kazlauskas
___
amd-gf
significant refactoring
would likely be needed.
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c
b/drivers/gpu/drm/amd/powerplay/smumgr
ve no EDID in order to go to
+* fail-safe mode
+*/
+ if (!dc_is_dp_signal(link->connector_signal))
+ return false;
default:
break;
}
Reviewed
issues by using the real size for the buffer and
making use of strscpy (which always terminates).
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amd
This does get called from both dce120 and dce112, but it will also any
fix any problems for dce112 as well. Looks fine to me.
Reviewed-by: Nicholas Kazlauskas
Nicholas Kazlauskas
On 07/12/2018 10:09 AM, Harry Wentland wrote:
The driver is expecting clock frequency in kHz, while SMU returns
devel/2017-October/155207.html
https://lists.freedesktop.org/archives/dri-devel/2018-September/189404.html
https://lists.freedesktop.org/archives/dri-devel/2018-September/190910.html
Nicholas Kazlauskas (4):
drm: Add vrr_capable property to the drm connector
drm: Add vrr_enabled
g variable refresh rates using
drm_connector_attach_vrr_capable_property().
The value should be updated based on driver and hardware capabiltiy
by using drm_connector_set_vrr_capable_property().
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/drm_connec
to implement support.
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/drm_atomic_uapi.c | 4
drivers/gpu/drm/drm_crtc.c| 2 ++
drivers/gpu/drm/drm_mode_config.c | 6 ++
include/drm/drm_crtc.h| 9 +
include/drm/drm_mode_config.h | 5 +
5 files changed, 26
These include the drm_connector 'vrr_capable' and the drm_crtc
'vrr_enabled' properties.
Signed-off-by: Nicholas Kazlauskas
---
Documentation/gpu/drm-kms.rst | 7 +++
drivers/gpu/drm/drm_connector.c | 22 ++
2 files changed, 29 insertions(+)
diff --git
refresh state and capability before the CRTC
disable pass.
(3) Performing VRR stream updates on-flip is needed for enabling BTR
support.
VRR packets and timing adjustments are now tracked and compared to
previous values sent to the hardware.
Signed-off-by: Nicholas Kazlauskas
---
.../gpu/drm
linked below for reference:
https://lists.freedesktop.org/archives/amd-gfx/2018-April/021047.html
https://lists.freedesktop.org/archives/dri-devel/2017-October/155207.html
https://lists.freedesktop.org/archives/dri-devel/2018-September/189404.htm
https://lists.freedesktop.org/archives/dri-deve
These include the drm_connector 'vrr_capable' and the drm_crtc
'vrr_enabled' properties.
Signed-off-by: Nicholas Kazlauskas
---
Documentation/gpu/drm-kms.rst | 7 +++
drivers/gpu/drm/drm_connector.c | 22 ++
2 files changed, 29 insertions(+)
diff --git
to implement support.
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/drm_atomic_uapi.c | 4
drivers/gpu/drm/drm_crtc.c| 2 ++
drivers/gpu/drm/drm_mode_config.c | 6 ++
include/drm/drm_crtc.h| 9 +
include/drm/drm_mode_config.h | 5 +
5 files changed, 26
g variable refresh rates using
drm_connector_attach_vrr_capable_property().
The value should be updated based on driver and hardware capabiltiy
by using drm_connector_set_vrr_capable_property().
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/drm_connec
state and capability before the CRTC
disable pass.
(3) Performing VRR stream updates on-flip is needed for enabling BTR
support.
VRR packets and timing adjustments are now tracked and compared to
previous values sent to the hardware.
Signed-off-by: Nicholas Kazlauskas
---
.../gpu/drm/amd
evel/2018-September/189404.htm
https://lists.freedesktop.org/archives/dri-devel/2018-September/190910.html
https://lists.freedesktop.org/archives/dri-devel/2018-October/192211.html
https://lists.freedesktop.org/archives/dri-devel/2018-October/192874.html
Nicholas Kazlauskas (4):
drm: Add vrr_capa
g variable refresh rates using
drm_connector_attach_vrr_capable_property().
The value should be updated based on driver and hardware capabiltiy
by using drm_connector_set_vrr_capable_property().
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/drm_connec
to
previous values sent to the hardware.
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 7 -
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 255 +-
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 7 +-
3 files changed, 138 insertions(+), 131
to implement support.
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/drm_atomic_uapi.c | 4
drivers/gpu/drm/drm_crtc.c| 2 ++
drivers/gpu/drm/drm_mode_config.c | 6 ++
include/drm/drm_crtc.h| 9 +
include/drm/drm_mode_config.h | 5 +
5 files changed, 26
These include the drm_connector 'vrr_capable' and the drm_crtc
'vrr_enabled' properties.
Signed-off-by: Nicholas Kazlauskas
---
Documentation/gpu/drm-kms.rst | 7 +++
drivers/gpu/drm/drm_connector.c | 22 ++
2 files changed, 29 insertions(+)
diff --git
attributes to both libdrm and amdgpu_dm.
Signed-off-by: Nicholas Kazlauskas
---
include/uapi/drm/amdgpu_drm.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h
index 6a0d77dcfc47..faaad04814e4 100644
--- a/include/uapi/drm
bug.cgi?id=201585
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200645
Fixes: e03fd3f300f6 ("drm/amd/display: Do not limit color depth to 8bpc")
Signed-off-by: Nicholas Kazlauskas
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c| 16
.../gpu/drm/amd/display/a
the panel since it
follows Intel's existing driver conventions.
This proprety should be removed once common drm support for max bpc
lands.
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 5 +
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 2 ++
2 files
2017-October/155207.html
https://lists.freedesktop.org/archives/dri-devel/2018-September/189404.htm
https://lists.freedesktop.org/archives/dri-devel/2018-September/190910.html
https://lists.freedesktop.org/archives/dri-devel/2018-October/192211.html
https://lists.freedesktop.org/archives/dri-devel/
lip timestamp from being the previous timestamp
to the calculation to the next timestamp when position >= vtotal.
Signed-off-by: Nicholas Kazlauskas
Reviewed-by: Harry Wentland
Cc: Michel Dänzer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 7 ++-
1 file changed, 6 insertions(+), 1 de
g variable refresh rates using
drm_connector_attach_vrr_capable_property().
The value should be updated based on driver and hardware capability
by using drm_connector_set_vrr_capable_property().
Signed-off-by: Nicholas Kazlauskas
Reviewed-by: Manasi Navare
Reviewed-by: Harry Wentland
---
drive
to
previous values sent to the hardware.
Signed-off-by: Nicholas Kazlauskas
Reviewed-by: Harry Wentland
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 7 -
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 255 +-
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 7 +-
3 files
These include the drm_connector 'vrr_capable' and the drm_crtc
'vrr_enabled' properties.
Signed-off-by: Nicholas Kazlauskas
Cc: Harry Wentland
Cc: Manasi Navare
Cc: Pekka Paalanen
Cc: Ville Syrjälä
Cc: Michel Dänzer
---
Documentation/gpu/drm-kms.rst | 7
drivers/gpu/drm
ri-devel/2018-September/190910.html
https://lists.freedesktop.org/archives/dri-devel/2018-October/192211.html
https://lists.freedesktop.org/archives/dri-devel/2018-October/192874.html
Nicholas Kazlauskas (5):
drm: Add vrr_capable property to the drm connector
drm: Add vrr_enabled property to drm CRT
lip timestap from being the previous timestamp
to the calculation to the next timestamp when position >= vtotal.
Signed-off-by: Nicholas Kazlauskas
Cc: Michel Dänzer
Cc: Harry Wentland
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
to
previous values sent to the hardware.
Signed-off-by: Nicholas Kazlauskas
Reviewed-by: Harry Wentland
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 7 -
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 255 +-
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 7 +-
3 files
These include the drm_connector 'vrr_capable' and the drm_crtc
'vrr_enabled' properties.
Signed-off-by: Nicholas Kazlauskas
Cc: Harry Wentland
Cc: Manasi Navare
Cc: Pekka Paalanen
Cc: Ville Syrjälä
Cc: Michel Dänzer
---
Documentation/gpu/drm-kms.rst | 7
drivers/gpu/drm
g variable refresh rates using
drm_connector_attach_vrr_capable_property().
The value should be updated based on driver and hardware capabiltiy
by using drm_connector_set_vrr_capable_property().
Signed-off-by: Nicholas Kazlauskas
Reviewed-by: Manasi Navare
Reviewed-by: Harry Wentland
---
drive
to implement support.
Signed-off-by: Nicholas Kazlauskas
Reviewed-by: Harry Wentland
Cc: Manasi Navare
---
drivers/gpu/drm/drm_atomic_uapi.c | 4
drivers/gpu/drm/drm_crtc.c| 2 ++
drivers/gpu/drm/drm_mode_config.c | 6 ++
include/drm/drm_crtc.h| 9 +
include/drm
convetion is already in use for other drivers.
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 5 +
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h| 2 ++
2 files changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
b/drivers/g
. This was the old
default before the range was uncapped.
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 15 +++
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 +
2 files changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/amd/display
that the current implementation treats
variable_refresh_enabled as a strict requirement for sending
the VRR enable *or* disable packet.
Signed-off-by: Nicholas Kazlauskas
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 232 +-
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 6 +-
2
is atomic it isn't filtered
from legacy userspace queries. This allows for Xorg userspace drivers
to implement support in non-atomic setups.
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/drm_atomic_helper.c | 1 +
drivers/gpu/drm/drm_atomic_uapi.c | 6 ++
drivers/gpu/drm/drm_crtc.c
://lists.freedesktop.org/archives/dri-devel/2017-October/155207.html
https://lists.freedesktop.org/archives/dri-devel/2018-September/189404.html
Nicholas Kazlauskas
Nicholas Kazlauskas (3):
drm: Add variable refresh rate properties to connector
drm: Add variable refresh property to DRM CRTC
drm/amd
is a userspace
controlled option.
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/drm_atomic_uapi.c | 6 ++
drivers/gpu/drm/drm_connector.c | 35 +++
include/drm/drm_connector.h | 27
3 files changed, 68 insertions(+)
diff
Wentland
Signed-off-by: Nicholas Kazlauskas
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 90 ++-
1 file changed, 88 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index
if
plane->state->fb != new_state->fb.
A new field was added (cursor_update) to dm_plane_state that's only
ever set to true during the fast path. If it's true, then cleanup_fb
doesn't unpin and unref the fb.
Cc: Leo Li
Cc: Harry Wentland
Cc: Michel Dänzer
Signed-off-by: Nicholas Kazlauskas
-off-by: Nicholas Kazlauskas
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 23 +++
1 file changed, 8 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 01badda14079
nce regressions for two specific IGT
tests:
- cursor-vs-flip-toggle
- cursor-vs-flip-varying-size
Cc: Leo Li
Cc: Harry Wentland
Cc: Michel Dänzer
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 ++
1 file changed, 10 insertions(+)
diff --
tps://bugs.freedesktop.org/show_bug.cgi?id=108912
Fixes: e64abff2f133 ("drm/amd/display: Use private obj helpers for
dm_atomic_state")
Cc: Leo Li
Cc: Harry Wentland
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 in
low framerate compensation,
"below the range".
[How]
Hook up the pre-flip and post-flip handlers from the FreeSync module.
These adjust the minimum/maximum vrr range to duplicate frames
when appropriate by tracking flip timestamps.
Cc: Leo Li
Cc: Harry Wentland
Signed-off-by: Nichol
On 2018-12-05 9:30 a.m., Li, Sun peng (Leo) wrote:
>
>
> On 2018-12-05 8:40 a.m., Nicholas Kazlauskas wrote:
>> [Why]
>> When application flip-rate is below the minimum vrr refresh rate.
>>
>> Variable refresh rate monitors extend the front porch duratio
/show_bug.cgi?id=106175
Cc: Leo Li
Cc: Harry Wentland
Signed-off-by: Nicholas Kazlauskas
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 67 ++-
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 8 +++
2 files changed, 73 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm
On 2018-12-05 3:44 p.m., Grodzovsky, Andrey wrote:
>
>
> On 12/05/2018 03:42 PM, Kazlauskas, Nicholas wrote:
>> On 2018-12-05 3:26 p.m., Grodzovsky, Andrey wrote:
>>>
>>> On 12/05/2018 02:59 PM, Nicholas Kazlauskas wrote:
>>>> [Why]
>>>>
On 2018-12-05 3:26 p.m., Grodzovsky, Andrey wrote:
>
>
> On 12/05/2018 02:59 PM, Nicholas Kazlauskas wrote:
>> [Why]
>> Legacy cursor plane updates from drm helpers go through the full
>> atomic codepath. A high volume of cursor updates through this slow
>> co
the native mode's refresh but this isn't always
the case.
For example, if the monitor is 1080p@144Hz and the preferred mode is
60Hz then even if the user selects 1080p@144Hz as their selected mode
they'll get 1080p@60Hz.
Cc: Bhawanpreet Lakha
Cc: Leo Li
Cc: Harry Wentland
Signed-off-by: Nicholas
and hangs under certain
conditions.
[How]
Duplicate the properties.
Fixes: 91b66c47ba34 ("drm/amd/display: Set RMX_ASPECT as default")
Cc: Bhawanpreet Lakha
Cc: Leo Li
Cc: Harry Wentland
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++
r
property")
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index ce00e56814ed..ede93d53e209 10
value.
Fixes: b333730d126e ("drm/amd/display: Fix Scaling (RMX_*) for DC driver")
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdg
n appropriate by tracking flip timestamps.
Cc: Harry Wentland
Signed-off-by: Nicholas Kazlauskas
Acked-by: Leo Li
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 79 ++-
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +-
2 files changed, 62 insertions(+), 19 deletions(-)
diff --
. This is the
case as of writing, but any future uses of dc->current_state from
within atomic_check should be considered incorrect.
Cc: Harry Wentland
Cc: Leo Li
Signed-off-by: Nicholas Kazlauskas
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 58 ++-
1 file changed, 6 insertions(+),
m_state private object is now locked this should
also fix issues that could arise if submitting non-blocking commits
from different threads.
Cc: Harry Wentland
Cc: Leo Li
Signed-off-by: Nicholas Kazlauskas
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 290 ++
.../gpu/d
sing drm VRR properties")
Cc: Harry Wentland
Cc: Leo Li
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/disp
as a userspace
controlled option.
Change-Id: I5f60f8b57534e1d3dacda4c64c6c9106b42f4439
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/drm_atomic.c| 9 +
drivers/gpu/drm/drm_connector.c | 35 +
include/drm/drm_connector.h | 27
for reference:
https://lists.freedesktop.org/archives/amd-gfx/2018-April/021047.html
https://lists.freedesktop.org/archives/dri-devel/2017-October/155207.html
Nicholas Kazlauskas
Anthony Koo (1):
drm/amd/display: Refactor FreeSync module
Harry Wentland (3):
drm/amdgpu: fill
is atomic it isn't filtered
from legacy userspace queries. This allows for Xorg userspace drivers
to implement support in non-atomic setups.
Change-Id: I5a5044f48fc68fcdbcfaa5141e83b44747d7116b
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/drm_atomic.c| 6 ++
drivers/gpu/drm
From: Hawking Zhang
v2:
resolve undefined symbol in xserver 1.16
Signed-off-by: Hawking Zhang
Signed-off-by: Nicholas Kazlauskas
---
src/Makefile.am| 2 +
src/amdgpu_dri2.c | 24 ++
src/amdgpu_drv.h | 5 ++
src/amdgpu_extension.c | 176
are linked below for reference:
https://lists.freedesktop.org/archives/amd-gfx/2018-April/021047.html
https://lists.freedesktop.org/archives/dri-devel/2017-October/155207.html
Nicholas Kazlauskas
Hawking Zhang (5):
Enable/Disable freesync when enter/exit fullscreen game v2
Set freesync
From: Harry Wentland
Add the ioctl to enable/disable freesync.
Signed-off-by: Harry Wentland
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 15 +++
-by: Nicholas Kazlauskas
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 50 +++
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 --
2 files changed, 18 insertions(+), 35 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display
This is no longer needed with the addition of the DRM properties.
The base driver correctly checks that notify_freesync is non-null before
calling so there shouldn't be any null pointer dereferences as a result
of this.
Change-Id: If0833b201c81303ca4062393e873faf3ef7c143b
Signed-off-by: Nicholas
With the introduction of new properties in DRM these amdgpu driver
specific ones are no longer necessary.
Change-Id: Idc88f2e3e036aacc8fe726b15db03d900e509e7c
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 12
drivers/gpu/drm/amd/amdgpu
-by: Nicholas Kazlauskas
---
src/amdgpu_dri2.c | 26 ---
src/amdgpu_drv.h | 5 +-
src/amdgpu_extension.c | 149 +++--
src/amdgpu_extension.h | 7 +-
src/amdgpu_kms.c | 45 -
src/amdgpu_present.c | 8 ---
src/drmmode_display.c
From: Hawking Zhang
It prefers that freesync is enable/disable per client lifecycle
rather than per flip. With the patch, freesync will be disabled
when clientgone or switch to windowed mode.
Change-Id: I2c725bd045c4855f9e1436f0791755b0a47a6ecc
Signed-off-by: Hawking Zhang
Reviewed-by: Flora
From: Hawking Zhang
v2:
fix ddx build warning unused var
The change supports the following scenario when freesync enabled for steam game
1). use Alt+Tab to run-time switch between windowed mode and fullscreen mode
2). use option setting to switch between windowed mode and fullscreen mode
Also
From: Harry Wentland
Add code to tear down freesync modules when disabled.
Signed-off-by: Harry Wentland
Signed-off-by: Alex Deucher
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 40 ++-
1 file changed, 29 insertions(+), 11 deletions(-)
diff --git
From: Harry Wentland
Add connector properties for controlling freesync.
Signed-off-by: Harry Wentland
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 13 +
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 4
From: Hawking Zhang
OGL send freesync request to ddx driver when it makes a drawable as current
DDX driver only set the client to be freesync capable when it is a fullscreen
size one.
Change-Id: Ie25ff11f58104546c52a253d6a5f85aa62532d4d
Signed-off-by: Hawking Zhang
Reviewed-by: Flora Cui
---
From: Hawking Zhang
There is BadDrawable/BadMatch case for dixLookupDrawable. But DDX driver don't
need to fail the request with BadValue. Instead, only make sure the drawable is
successfully found and check its size
Change-Id: I1ca6e04d611b2d5e81a54e500c90fb1644675f67
Signed-off-by: Hawking
Resolves __udivdi3 missing errors when building for i386.
Fixes: 6378ef012ddc ("drm/amd/display: Add below the range support for
FreeSync")
Change-Id: I4ded5790160054e6908367f20a63257225517714
Cc: Leo Li
Cc: Harry Wentland
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/a
t;drm/amd/display: Call into DC once per multiplane flip")
Fixes: ea39594e0855 ("drm/amd/display: Perform plane updates only when needed")
Cc: Michel Dänzer
Cc: Leo Li
Cc: Harry Wentland
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
The extra ; in the macro definition creates an empty statement
preventing any variable declarations from occuring after
any use of to_dm_plane_state(...).
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On 2019-02-26 11:03 p.m., Vishwakarma, Pratik wrote:
>
> On 2/26/2019 4:16 AM, Bhawanpreet Lakha wrote:
>> From: Nicholas Kazlauskas
>>
>> [Why]
>> Raven has support for combining pipes for DRM_PLANE_TYPE_OVERLAY use
>> but no overlays are exposed to user
To help xf86-video-amdgpu and mesa know DC supports updating the
tiling attributes for a framebuffer per-flip.
Cc: Michel Dänzer
Cc: Marek Olšák
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
and
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 --
2 files changed, 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu
[Why]
Can happen on ASICs with 6 planes, but this isn't a bug since we haven't
written outside the array.
[How]
Use <= instead of <.
Cc: Leo Li
Cc: Michel Dänzer
Reported-by: Michel Dänzer
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2
eed to
be explicitly cleaned up are the ones that have failed to register.
By dropping the explicit free on every plane in the mode_info->planes
list this patch also fixes a double-free in the case where we fail to
initialize only some of the planes.
Cc: Leo Li
Cc: Harry Wentland
Signed-off-by: Ni
, during amdgpu_dm_commit_planes
We use the fill_plane_tiling_attributes in all 3 locations and it
already needs the address to update DCC attributes, so the surface
address update logic can be moved into this helper.
Cc: Leo Li
Signed-off-by: Nicholas Kazlauskas
---
.../gpu/drm/amd/display
since the chroma plane is half size of the luma plane for NV12.
Leave a TODO indicating that those should be set based on the actual
surface format instead since this is only correct for YUV420 formats.
Cc: Leo Li
Cc: Harry Wentland
Signed-off-by: Nicholas Kazlauskas
---
.../gpu/drm/amd/d
.
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
index fcaaac30e84b..a58072bbc9b8 100644
--- a/drivers/gpu/drm/amd
The buffers should be cleared when possible but we also don't want
buffer creation to fail in the rare case where the ring isn't ready
during the call. This could happen during some suspend/resume sequences.
Cc: Christian König
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/amdgpu
in the
low range but it didn't cover the upper range. Expand the condition
to include both.
Cc: Sun peng Li
Cc: Harry Wentland
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu
The brace initialization used here generates errors on some
compilers. Use memset to make this more portable.
Cc: Sun peng Li
Cc: Harry Wentland
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion
confirm enum value using
the debugfs attribute helpers.
The debugfs_create_file_unsafe can be used instead of
debugfs_create_file as per the documentation.
v2: Use debugfs helpers for getting and setting the value (Christian)
Cc: Leo Li
Cc: Harry Wentland
Signed-off-by: Nicholas Kazlauskas
memset to make this more portable.
v2: Specify the compiler / diagnostic in the commit message (Paul)
Cc: Sun peng Li
Cc: Harry Wentland
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
buffer.
Nicholas Kazlauskas
On 2/12/19 12:46 PM, Grodzovsky, Andrey wrote:
> I suspect the issue is that amdgpu_dm_do_flip is holding the BO reserved
> and then stack waiting for fences to signal in
> reservation_object_wait_timeout_rcu (which won't signal because there
> wa
[Why]
eDP was missing in the checks for supported VRR connectors.
[How]
Attach the properties for eDP connectors too.
Cc: Leo Li
Cc: Harry Wentland
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=202449
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm
[Why]
It's useful to know the min and max vrr range for IGT testing.
[How]
Expose the min and max vfreq for the connector via a debugfs file
on the connector, "vrr_range".
Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range
Cc: Harry Wentland
Cc: Leo Li
Signed-off-by
: 43a6a02eb355 ("drm/amd/display: Re-enable CRC capture following modeset")
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display
confirm enum value.
Cc: Leo Li
Cc: Harry Wentland
Signed-off-by: Nicholas Kazlauskas
---
.../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 77 ++-
1 file changed, 75 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
b/drivers/gpu
.
[How]
Use our reset helper to allocate an initial state and reset the values
to their defaults. We were already doing this before, just not for
MST connectors.
Cc: Leo Li
Cc: Roman Li
Cc: Harry Wentland
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
and exiting HDR
but the metadata can be changed without one.
Cc: Harry Wentland
Nicholas Kazlauskas (2):
drm/amd/display: Expose HDR output metadata for supported connectors
drm/amd/display: Only force modesets when toggling HDR
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 155
unnecessary.
The requirement can later be reduced to just entering and exiting HDR
or switching max bpc.
Cc: Harry Wentland
Signed-off-by: Nicholas Kazlauskas
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 125 ++
1 file changed, 125 insertions(+)
diff --git a/drivers/gpu/drm/amd
the stream update. This will only happen in non-modeset
cases.
Cc: Harry Wentland
Signed-off-by: Nicholas Kazlauskas
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 34 +++
1 file changed, 28 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm
: 97df424fe7a7 ("drm/amd/display: Drop DCN1_01 guards")
Signed-off-by: Nicholas Kazlauskas
---
drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_translate.c
b/drivers/gpu/drm/amd/display/dc/gpio/hw_t
1 - 100 of 184 matches
Mail list logo
