Re: [PATCH] drm/amd/powerplay: Fix double unlock bug in smu_sys_set_pp_table()

, March 21, 2019 2:28:22 PM To: Deucher, Alexander; Wang, Kevin(Yang) Cc: Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; Huang, Ray; Gao, Likun; Gui, Jack; amd-gfx@lists.freedesktop.org; kernel-janit...@vger.kernel.org Subject: [PATCH] drm/amd/powerplay: Fix double unlock bug

Re: [PATCH] drm/amd/powerplay: Off by one in vega20_get_smu_msg_index()

From: Dan Carpenter Sent: Thursday, March 21, 2019 5:19 PM To: Deucher, Alexander; Wang, Kevin(Yang) Cc: Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; Huang, Ray; Gao, Likun; Gui, Jack; amd-gfx@lists.freedesktop.org; kernel-janit

[PATCH 1/2] drm/amd/powerplay: optimization function of smu_update_table

in fact, the firmware need 2 parameter: 1.table_id, 2.XferArg so change the function interface to match the firmware code Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 7 +-- drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 5 - 2 files changed, 9

[PATCH 2/2] drm/amd/powerplay: simplify the code of [get|set]_activity_monitor_coeff

use smu_update_table_with_arg to replace old code logic Signed-off-by: Kevin Wang --- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 6 -- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 75 ++- 2 files changed, 7 insertions(+), 74 deletions(-) diff --git

[PATCH] drm/amd/powerplay: simplify sw-smu message map macro

simplify macro of MSG_MAP for sw-smu Signed-off-by:Kevin Wang --- drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 170 ++--- 1 file changed, 85 insertions(+), 85 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c

[PATCH] drm/amd/powerplay: move the smc_if_version to asic file

each asic may be has different smc if version, so move its to asic file to implement. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 2 ++ drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 4 ++-- drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 1 + 3 files

[PATCH v2] drm/amd/powerplay: simplify the code of [get|set]_activity_monitor_coeff

use smu_update_table_with_arg to replace old code logic Signed-off-by: Kevin Wang --- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 6 -- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 75 ++- 2 files changed, 7 insertions(+), 74 deletions(-) diff --git

Re: [PATCH 2/2] drm/amd/powerplay: simplify the code of [get|set]_activity_monitor_coeff

@Quan, Evan<mailto:evan.q...@amd.com> I remake a new patch v2 to fix it, please help me review it. Thanks. Best Regards, Kevin From: Quan, Evan Sent: Tuesday, April 9, 2019 9:33:06 AM To: Wang, Kevin(Yang); amd-gfx@lists.freedesktop.org Cc: Huang, Ray

Re: [PATCH] drm/amd/powerplay: add smu message mutex

From: Huang, Ray Sent: Tuesday, June 4, 2019 1:37 PM To: Xiao, Jack; amd-gfx@lists.freedesktop.org; Deucher, Alexander; Zhang, Hawking Cc: Xiao, Jack; Wang, Kevin(Yang); Quan, Evan; Gui, Jack; Gao, Likun Subject: RE: [PATCH] drm/amd/powerplay: add smu message

[PATCH libdrm] drm: add fallback function to get device name

1.optimize code logic. 2.if not found device name in amdgpu.ids, will return a fallback device name "deviceid:revisionid", eg:69a0:01 Change-Id: I0d0c95a402533a74978681309680cb73d6a36e60 Signed-off-by: Kevin Wang --- amdgpu/amdgpu_asic_id.c | 131 ---

[PATCH libdrm v2] drm: add fallback function to get device name

1.optimize code logic. 2.if not found device name in amdgpu.ids, will return a fallback device name "deviceid:revisionid", eg:69a0:01 Change-Id: I0d0c95a402533a74978681309680cb73d6a36e60 Signed-off-by: Kevin Wang --- amdgpu/amdgpu_asic_id.c | 134 ---

Re: [PATCH libdrm v2] drm: add fallback function to get device name

2. fix miss a close file operation. BR, Kevin From: Wang, Kevin(Yang) Sent: Monday, June 24, 2019 7:48 PM To: amd-gfx@lists.freedesktop.org Cc: Daenzer, Michel; Wang, Kevin(Yang) Subject: [PATCH libdrm v2] drm: add fallback function to get device name 1

Re: [PATCH 247/459] Revert "drm/amdgpu: mask some pm interfaces for navi10 because they are changed or not workable so far"

, Kevin(Yang); Huang, Ray Subject: Re: [PATCH 247/459] Revert "drm/amdgpu: mask some pm interfaces for navi10 because they are changed or not workable so far" Am 17.06.19 um 21:30 schrieb Alex Deucher: > From: Kevin Wang > > This reverts commit fd9c75d217d5b4ed72672722b6621e263

[PATCH] drm/amd/powerplay: add helper function to get smu firmware & if version

add this helper function to get smc version. Change-Id: I6b06470cefd10fafcf06df8a5e8cb03bf79622c0 Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 30 +++ .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 1 + drivers/gpu/drm/amd/powerplay/smu_v11_0.c

[PATCH] drm/amdgpu: add mode1 (psp) reset for navi asic

add mode1 (by psp) reset for navi asic. Change-Id: Id2e7cb11eb7026296d1488c7c39f895b100f206c Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/nv.c | 35 + 1 file changed, 35 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c

Re: [PATCH] drm/amdgpu: add mode1 (psp) reset for navi asic

okay, thanks. Best Regards, Kevin From: Zhang, Hawking Sent: Friday, July 5, 2019 1:02:08 PM To: Wang, Kevin(Yang); amd-gfx@lists.freedesktop.org Cc: Xiao, Jack; kenenth.f...@amd.com Subject: RE: [PATCH] drm/amdgpu: add mode1 (psp) reset for navi asic

Re: [PATCH] drm/amd/powerplay: bug fix for sysfs

Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Quan, Evan Sent: Thursday, July 11, 2019 4:14:11 PM To: Feng, Kenneth; amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: RE: [PATCH] drm/amd/powerplay: bug fix for sysfs

[PATCH] drm/amd/powerplay: fix smu clock type change miss error

in the smu module, use the smu_xxxclk type to identify the CLK type use SMU_SCLK, SMU_MCLK to replace PP_SCLK, PP_MCLK. Change-Id: Ifa870aea38f043e1983f6f0560eed2ac070b68b7 Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] drm/amd/powerplay: fix memory allocation failure check

Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Evan Quan Sent: Friday, July 12, 2019 10:34:46 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: fix memory allocation failure check Fix memory

Re: [PATCH 3/3] drm/amd/powerplay: avoid double check feature enabled

thanks, i will make a new patch to fix this problem. Best Regards, Kevin From: Quan, Evan Sent: Friday, July 12, 2019 3:09:54 PM To: Wang, Kevin(Yang); amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: RE: [PATCH 3/3] drm/amd/powerplay: avoid double check

[PATCH 1/3] drm/amd/powerplay: add socclk profile dpm support.

1.miss socclk profile support when bringup. 2.add feature check for socclk. Change-Id: I8f5b92dc8384fd03b540a2f654bd40f1ebf56c85 Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH 2/3] drm/amd/powerplay: add standard profile dpm support for smu

1. the standard dpm is not support before. 2. use auto profile to adapt standard profile. Change-Id: Ib4bfbfe2e5e73c55c9cd2bbd968e102136cc6852 Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/3] drm/amd/powerplay: avoid double check feature enabled

the unforce_dpm_levels doesn't need to check feature enable, because the smu_get_dpm_freq_range function has check feature logic. Change-Id: I6ae62b355aa76a00f0f6e164cd9848fb32fc7c12 Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 23 -- 1 file

[PATCH 1/3] drm/amd/powerplay: add helper of smu_feature_dpmclk_check for smu

add this helper function to check dpm clk feature is enabled. Change-Id: I51a4e9246d83d74a8e687fbc45983848adc960ca Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 71 +-- .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h| 1 + 2 files changed, 49

[PATCH 3/3] drm/amd/powerplay: fix save dpm level error for smu

the save dpm level should be save previous dpm profile level, should not modified by get dpm level function. eg: default auto 1. auto -> standard ==> dpm_level = standard, save_dpm = auto. 2. standard -> auto ==> dpm_level = auto, save_dpm = standard. Change-Id:

[PATCH 2/3] drm/amd/powerplay: avoid double check feature enabled

the unforce_dpm_levels doesn't need to check feature enable, because the smu_get_dpm_freq_range function has check feature logic. Change-Id: I6ae62b355aa76a00f0f6e164cd9848fb32fc7c12 Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 23 -- 1 file

[PATCH v2] drm/amd/powerplay: add helper of smu_clk_dpm_is_enabled for smu

v2: change function name to smu_clk_dpm_is_enabled. add this helper function to check dpm clk feature is enabled. Change-Id: I7f9949033c318fec618a9701df4a082d54a626c8 Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 69 ---

[PATCH] drm/amd/powerplay: add pstate mclk(uclk) support for navi10

add pstate mclk(uclk) support. Change-Id: I7f3bca4901833b4ea213fe02249fc055b80e5cdd Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 1 + drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git

[PATCH] drm/amd/powerplay: add temperature sensor support for navi10

the hwmon interface need temperature sensor type support. 1. SENSOR_HOTSPOT_TEMP 2. SENSOR_EDGE_TEMP(SENSOR_GPU_TEMP) 3. SENSOR_MEM_TEMP Change-Id: I3db762e4032072fae67c95b7ba6d62e20ae5bead Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 42 ++ 1

Re: [PATCH 2/2] drm/amdgpu/navi10: add thermal sensor support for navi10

From: amd-gfx on behalf of Alex Deucher Sent: Thursday, July 4, 2019 10:58:22 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 2/2] drm/amdgpu/navi10: add thermal sensor support for navi10 This was dropped when the code was refactored. Re-add it for navi10.

Re: [PATCH] drm/amd/powerplay: add baco smu reset function for smu11

ping..., which one can help me review this patch. thanks. Best Regards, Kevin From: Wang, Kevin(Yang) Sent: Wednesday, July 3, 2019 11:09:45 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking; Xiao, Jack; Huang, Ray; Wang, Kevin(Yang) Subject: [PATCH

[PATCH] drm/amd/powerplay: add baco smu reset function for smu11

add baco reset support for smu11. it can help gpu do asic reset when gpu recovery. Change-Id: I7714ed03ad87c13e93ca1a7e6aef81eba14667c8 Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c| 6 +- drivers/gpu/drm/amd/amdgpu/nv.c | 9 +-

Re: [PATCH] drm/amd/powerplay: add temperature sensor support for navi10

From: Alex Deucher Sent: Saturday, July 6, 2019 5:06 AM To: Wang, Kevin(Yang) Cc: amd-gfx@lists.freedesktop.org; Xiao, Jack; kenenth.f...@amd.com; Zhang, Hawking Subject: Re: [PATCH] drm/amd/powerplay: add temperature sensor support for navi10 On Wed, Jul 3

Re: [PATCH] drm/amd/powerplay: correct SW smu11 thermal range settings

Hi Evan, the temperature min value should be 0, not -273 on smu11. you can refrence window driver code or register spec. output_ptr->operating_temperature_min_Limit = 0; output_ptr->operating_temperature_max_Limit = ppt_info->software_shutdown_temp; and in smu11, the thermal

Re: [PATCH 2/2] drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus

if any DPM feature is enabled, then DPM is running, return true. if all DPM feature is disabled, the DPM is not running, return false. so the macro of "SMC_DPM_FEATURE" should be include all dpm feature, whether is enabled or supported. i think the @Gui, Jack's patch is

Re: [PATCH 1/4] drm/amd/powerplay: update Arcturus smc fw and driver interface header

Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Evan Quan Sent: Friday, August 16, 2019 2:08 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH 1/4] drm/amd/powerplay: update Arcturus smc fw and driver interface

Re: [PATCH 4/4] drm/amd/powerplay: set Arcturus default fclk as bootup value on dpm disabled

Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Evan Quan Sent: Friday, August 16, 2019 2:08 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH 4/4] drm/amd/powerplay: set Arcturus default fclk as bootup value on dpm

Re: [PATCH 2/4] drm/amd/powerplay: expose supported clock domains only through sysfs

I don't recommend it. What's the problem if we keep it the way it is? maybe other asic also has same problems, if do it, the other asic should add a condition in there too. eg: navi10 don't support sensor of "pp_dpm_pcie". Best Regards, Kevin From: amd-gfx on

[PATCH] drm/amd/powerplay: add smu_smc_read_sensor support for arcturus

the bellow patch refine the sensor read sequence, but missed to add arcuturs support. (arcuturs_ppt.c) drm/amd/powerplay: change smu_read_sensor sequence in smu Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [PATCH 3/4] drm/amd/powerplay: get bootup fclk value

i think we can use a function to retrieve this information without storing it separately. likes: ret = smu_get_atom_data_table(smu, index, , , , (uint8_t **)); because these information is a generic information from atom_common_table_header. and other

[PATCH 1/2] drm/amdgpu: fix typo error amdgput -> amdgpu

fix typo error: change function name from "amdgput_ctx_total_num_entities" to "amdgpu_ctx_total_num_entities". Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 2/2] drm/amdgpu: use exiting amdgput_ctx_total_num_entities function

simplify driver code. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c index 95d8201a738e..89c26bb0f05c 100644 ---

[PATCH] drm/amd/powerplay: fix message of SetHardMinByFreq failed when feature is disabled

the direct send message to smc to set hard clokc will failed when smc clock dpm feature is disabled. so use function of smu_set_hard_freq_range to replace it. the function will check feature enablement. eg: when uclk (mclk) dpm feature is disabled on navi10 [  300.675901] amdgpu: [powerplay]

Re: [bug report] drm/amd/powerplay: implement smc firmware v2.1 for smu11

Hi Dan, Thank you for reporting this bug to me, I will make a fix patch as soon as possible, when patch ready after I send copies to you review, thank you. Best Regards, Kevin From: Dan Carpenter Sent: Monday, August 19, 2019 9:03 PM To: Wang, Kevin(Yang) Cc

[PATCH] drm/amd/powerplay: fix variable type errors in smu_v11_0_setup_pptable

fix size type errors, from uint32_t to uint16_t. it will cause only initializes the highest 16 bits in smu_get_atom_data_table function. Signed-off-by: Kevin Wang Reported-by: Dan Carpenter --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH] drm/amd/powerplay: correct typo

Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Evan Quan Sent: Tuesday, August 20, 2019 12:23 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: correct typo "COMPUTE" was wrongly spelled as

Re: [PATCH 3/4] drm/amd/powerplay: get bootup fclk value

Reviewed-by: Kevin Wang Best Regards, Kevin From: Quan, Evan Sent: Tuesday, August 20, 2019 10:09 AM To: amd-gfx@lists.freedesktop.org Cc: Wang, Kevin(Yang) Subject: RE: [PATCH 3/4] drm/amd/powerplay: get bootup fclk value Ping.. From: Quan, Evan Sent

Re: [PATCH] drm/amd/powerplay: add smu_smc_read_sensor support for arcturus

From: Alex Deucher Sent: Monday, August 19, 2019 11:33 PM To: Wang, Kevin(Yang) Cc: amd-gfx@lists.freedesktop.org ; Feng, Kenneth ; Quan, Evan ; Huang, Ray Subject: Re: [PATCH] drm/amd/powerplay: add smu_smc_read_sensor support for arcturus On Fri, Aug 16

[PATCH] drm/amd/powerplay: remove duplicate macro smu_get_uclk_dpm_states in amdgpu_smu.h

remove duplicate macro smu_get_uclk_dpm_states in amdgpu_smu.h " #define smu_get_uclk_dpm_states(smu, clocks_in_khz, num_states) \ ((smu)->ppt_funcs->get_uclk_dpm_states ? (smu)->ppt_funcs->get_uclk_dpm_states((smu), (clocks_in_khz), (num_states)) : 0) #define

Re: [PATCH] drm/amd/powerplay: correct SW smu11 thermal range settings

: Feng, Kenneth Sent: Tuesday, August 20, 2019 10:51 AM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Wang, Kevin(Yang) Subject: RE: [PATCH] drm/amd/powerplay: correct SW smu11 thermal range settings Reviewed-by: Kenneth Feng mailto:kenneth.f...@amd.com>> From: Quan, Evan Sent: T

Re: [PATCH v2] drm/amd/amdgpu: disable MMHUB PG for navi10

Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Kenneth Feng Sent: Tuesday, August 20, 2019 3:17 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH v2] drm/amd/amdgpu: disable MMHUB PG for navi10 Disable MMHUB PG

[PATCH] drm/amd/powerplay: add smu_map_helper function to unified map function

1. add smu_map to replace old smu_11_0_cmn2aisc_mapping. (next generation of smu ip also need this logic, eg: smu12 13 14...) 2. use smu_map_helper function to unified map code logic in smu Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 19

Re: [PATCH] drm/amd/powerplay: correct SW smu11 thermal range settings

this is not very good. Best Regards, Kevin From: Quan, Evan Sent: Tuesday, August 20, 2019 2:50 PM To: Wang, Kevin(Yang) ; Feng, Kenneth ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amd/powerplay: correct SW smu11 thermal range settings Hi Kevin

[PATCH] drm/amd/powerpaly: fix navi series custom peak level value error

fix other navi asic set peak performance level error. because the navi10_ppt.c will handle navi12 14 asic, it will use navi10 peak value to set other asic, it is not correct. after patch: only navi10 use custom peak value, other asic will used default value. Signed-off-by: Kevin Wang ---

Re: [PATCH 2/2] drm/amd/powerplay: correct the pp_feature output on Arcturus

Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Quan, Evan Sent: Thursday, August 22, 2019 6:20 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH 2/2] drm/amd/powerplay: correct the

Re: [PATCH] drm/amd/powerplay: update cached feature enablement status V2

comment inline. From: amd-gfx on behalf of Evan Quan Sent: Thursday, August 22, 2019 6:18 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: update cached feature enablement status V2 Need to update in cache feature

Re: [PATCH] drm/powerplay: Fix Vega20 Average Power value v4

Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Deucher, Alexander Sent: Thursday, August 22, 2019 9:36 PM To: Russell, Kent ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/powerplay: Fix Vega20 Average Power value v4

[PATCH] drm/amd/powerplay: replace smu->table_count with SMU_TABLE_COUNT in smu

fix bellow patch issue: drm/amd/powerplay: introduce smu table id type to handle the smu table for each asic "This patch introduces new smu table type, it's to handle the different smu table defines for each asic with the same smu ip." before: use smu->table_count to represent the actual

Re: [PATCH] drm/amd/powerplay: replace smu->table_count with SMU_TABLE_COUNT in smu

From: Quan, Evan Sent: Wednesday, September 4, 2019 9:17 AM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org ; Huang, Ray Cc: Wang, Kevin(Yang) Subject: RE: [PATCH] drm/amd/powerplay: replace smu->table_count with SMU_TABLE_COUNT in smu Please d

Re: [PATCH 1/2] drm/amd/powerplay: Add UMD PState Renoir Msg Parameters

i think it's better to merge these two patches into one patch. after fixed: Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Liang, Prike Sent: Wednesday, September 4, 2019 2:01 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander

Re: [PATCH] drm/amd/powerplay: update cached feature enablement status V2

comment inline From: Quan, Evan Sent: Friday, August 23, 2019 12:50 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amd/powerplay: update cached feature enablement status V2 Comment inline From: Wang, Kevin(Yang) Sent

Re: [PATCH] drm/amd/powerplay: update cached feature enablement status V2

. the intent is to make this a public API. if you want to make it is a static function, please split it 2 patches. and indicate the reason. Best Regards, Kevin From: Quan, Evan Sent: Friday, August 23, 2019 1:38 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org

Re: [PATCH v2] drm/amdgpu: fix null pointer deref in firmware header printing

Reviewed-by: Kevin Wang Best Regards, Kevin From: Yuan, Xiaojie Sent: Friday, September 6, 2019 4:04 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Kevin(Yang) ; Yuan, Xiaojie Subject: [PATCH v2] drm/amdgpu: fix null pointer deref in firmware header printing

Re: [PATCH] drm/amd/powerplay: Remove unnecessary comparison statement

Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Austin Kim Sent: Monday, September 9, 2019 12:31 PM To: Deucher, Alexander ; airl...@linux.ie ; dan...@ffwll.ch Cc: Zhou, David(ChunMing) ; amd-gfx@lists.freedesktop.org ;

Re: [PATCH 2/2] drm/amd/powerplay: update smu11_driver_if_arcturus.h

Reviewed-by: Kevin Wang From: amd-gfx on behalf of Quan, Evan Sent: Monday, September 9, 2019 7:33 PM To: amd-gfx@lists.freedesktop.org Cc: Li, Candice ; Gui, Jack ; Quan, Evan Subject: [PATCH 2/2] drm/amd/powerplay: update smu11_driver_if_arcturus.h Also

Re: [PATCH 1/2] drm/amd/powerplay: issue DC-BTC for arcturus on SMU init

Reviewed-by: Kevin Wang From: amd-gfx on behalf of Quan, Evan Sent: Monday, September 9, 2019 7:33 PM To: amd-gfx@lists.freedesktop.org Cc: Li, Candice ; Gui, Jack ; Quan, Evan Subject: [PATCH 1/2] drm/amd/powerplay: issue DC-BTC for arcturus on SMU init

Re: [PATCH] drm/amd/powerplay: Add the interface for geting dpm current power state

comment inline. From: amd-gfx on behalf of Quan, Evan Sent: Monday, September 9, 2019 4:31 PM To: Liang, Prike ; amd-gfx@lists.freedesktop.org Cc: Huang, Ray ; Feng, Kenneth ; Liu, Aaron Subject: RE: [PATCH] drm/amd/powerplay: Add the interface for geting

Re: [PATCH] drm/amdgpu/powerplay: add new mapping for APCC_DFLL feature

Reviewed-by: Kevin Wang From: Yuan, Xiaojie Sent: Tuesday, September 17, 2019 7:04 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Quan, Evan ; Wang, Kevin(Yang) ; Yuan, Xiaojie Subject: [PATCH] drm/amdgpu/powerplay: add new mapping for APCC_DFLL

[PATCH] drm/amd/powerplay: sort feature status index by asic feature id for smu

before this change, the pp_feature sysfs show feature enable state by logic feature id, it is not easy to read. this change will sort pp_features show index by asic feature id. before: features high: 0x0623 low: 0xb3cdaffb 00. DPM_PREFETCHER ( 0) : enabeld 01. DPM_GFXCLK ( 1)

Re: [PATCH][drm-next] drm/amd/powerplay: fix off-by-one upper bounds limit checks

From: Alex Deucher Sent: Friday, August 2, 2019 2:53 AM To: Colin King Cc: Wang, Kevin(Yang) ; Rex Zhu ; Quan, Evan ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; David Airlie ; Daniel Vetter ; amd-gfx list ; Maling list - DRI developers

Re: [PATCH 25/36] drm/amdgpu/smu11: add smu support for navi12

Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Alex Deucher Sent: Friday, August 2, 2019 4:29 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Hawking ; Quan, Evan ; Yuan, Xiaojie Subject: [PATCH 25/36]

Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes

From: amd-gfx on behalf of Colin King Sent: Thursday, August 1, 2019 4:39 PM To: Rex Zhu ; Quan, Evan ; Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; David Airlie ; Daniel Vetter ; amd-gfx@lists.freedesktop.org ;

[PATCH] drm/amd/powerplay: honor hw limit on fetching metrics data for navi10

too frequently to update mertrics table will cause smu internal error. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 56 +++--- 1 file changed, 38 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c

Re: [PATCH 1/1] drm/amdgpu/powerplay: update Arcturus smu version in new place

Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Le Ma Sent: Friday, August 9, 2019 7:27 PM To: amd-gfx@lists.freedesktop.org Cc: Ma, Le Subject: [PATCH 1/1] drm/amdgpu/powerplay: update Arcturus smu version in new place Follow patch

Re: [PATCH 3/4] drm/amdgpu: add mmhub clock gating for Arcturus

Reviewed-by: Kevin Wang From: amd-gfx on behalf of Le Ma Sent: Friday, August 9, 2019 7:26 PM To: amd-gfx@lists.freedesktop.org Cc: Ma, Le Subject: [PATCH 3/4] drm/amdgpu: add mmhub clock gating for Arcturus Add 2 mmhub instances CG Change-Id:

Re: [PATCH 2/4] drm/amdgpu: increase CGCG gfx idle threshold for Arcturus

Reviewed-by: Kevin Wang From: amd-gfx on behalf of Le Ma Sent: Friday, August 9, 2019 7:26 PM To: amd-gfx@lists.freedesktop.org Cc: Ma, Le Subject: [PATCH 2/4] drm/amdgpu: increase CGCG gfx idle threshold for Arcturus Follow the hw spec, and no need to

Re: [PATCH 1/4] drm/amdgpu: add GFX_CP_LS flag to Arcturus

Reviewed-by: Kevin Wang From: amd-gfx on behalf of Le Ma Sent: Friday, August 9, 2019 7:26 PM To: amd-gfx@lists.freedesktop.org Cc: Ma, Le Subject: [PATCH 1/4] drm/amdgpu: add GFX_CP_LS flag to Arcturus Missed AMD_CG_SUPPORT_GFX_CP_LS accidently when commit

Re: [PATCH 4/4] drm/amdgpu: enable mmhub clock gating for Arcturus

Reviewed-by: Kevin Wang From: amd-gfx on behalf of Le Ma Sent: Friday, August 9, 2019 7:26 PM To: amd-gfx@lists.freedesktop.org Cc: Ma, Le Subject: [PATCH 4/4] drm/amdgpu: enable mmhub clock gating for Arcturus Init MC_MGCG/LS flag. Also apply to athub CG.

[PATCH] drm/amd/powerplay: add callback function of get_thermal_temperature_range

1. the thermal temperature is asic related data, move the code logic to xxx_ppt.c. 2. replace data structure PP_TemperatureRange with smu_temperature_range. 3. change temperature uint from temp*1000 to temp (temperature uint). Signed-off-by: Kevin Wang Signed-off-by: Kenneth Feng Acked-by:

[PATCH v2] drm/amd/powerplay: add helper of smu_clk_dpm_is_enabled for smu

v2: change function name to smu_clk_dpm_is_enabled. add this helper function to check dpm clk feature is enabled. Change-Id: I7f9949033c318fec618a9701df4a082d54a626c8 Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 69 ---

撤回: [PATCH v2] drm/amd/powerplay: add helper of smu_clk_dpm_is_enabled for smu

Wang, Kevin(Yang) 将撤回邮件“[PATCH v2] drm/amd/powerplay: add helper of smu_clk_dpm_is_enabled for smu”。 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

撤回: [PATCH v2] drm/amd/powerplay: add helper of smu_clk_dpm_is_enabled for smu

Wang, Kevin(Yang) 将撤回邮件“[PATCH v2] drm/amd/powerplay: add helper of smu_clk_dpm_is_enabled for smu”。 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

撤回: [PATCH v2] drm/amd/powerplay: add helper of smu_clk_dpm_is_enabled for smu

Wang, Kevin(Yang) 将撤回邮件“[PATCH v2] drm/amd/powerplay: add helper of smu_clk_dpm_is_enabled for smu”。 ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/powerplay: add callback function of get_thermal_temperature_range

@Feng, Kenneth<mailto:kenneth.f...@amd.com> please help me review this patch, this patch is reveiwed before. but this patch is missed from navi10 topic branch. Best Regards, Kevin From: Wang, Kevin(Yang) Sent: Tuesday, July 23, 2019 5:31:47 PM To: a

Re: [PATCH] drm/amd/powerplay: change smu_read_sensor sequence in smu

it looks fine for me, please @Deucher, Alexander double check confirm. Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Kenneth Feng Sent: Tuesday, July 23, 2019 5:39 PM To:

Re: [PATCH] drm/amd/powerplay: add callback function of get_thermal_temperature_range

sday, July 23, 2019 7:15:59 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org ; Deucher, Alexander Cc: Huang, Ray ; Feng, Kenneth ; Wang, Kevin(Yang) Subject: RE: [PATCH] drm/amd/powerplay: add callback function of get_thermal_temperature_range Please do not change the output te

[PATCH] drm/amd/powerplay: fix temperature granularity error in smu11

in this patch, drm/amd/powerplay: add callback function of get_thermal_temperature_range the driver missed temperature granularity change on other temperature. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 18 +- 1 file changed, 9 insertions(+), 9

Re: [PATCH] drm/amd/powerplay: change smu_read_sensor sequence in smu

From: Alex Deucher Sent: Saturday, July 20, 2019 1:53 AM To: Wang, Kevin(Yang) Cc: amd-gfx@lists.freedesktop.org ; Huang, Ray ; Feng, Kenneth Subject: Re: [PATCH] drm/amd/powerplay: change smu_read_sensor sequence in smu On Fri, Jul 19, 2019 at 1:03 PM Wang

[PATCH] drm/amd/powerplay: change sysfs pp_dpm_xxx format for navi10

the navi10 gfxclk (sclk) support fine grained DPM, so use level 1 to show current dpm freq in sysfs pp_dpm_xxx Change-Id: Idae2424f8cc91fe94cebe7f3103e112b4f912fbc Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 41 +- 1 file changed, 33

Re: [PATCH] drm/amd/powerplay: change sysfs pp_dpm_xxx format for navi10

is same as min or max, the output will be a little strange 0: 300M * 1: 300M 2: 1800M Please check how raven handle this situation. Regards, Evan > -Original Message- > From: Wang, Kevin(Yang) > Sent: Thursday, July 18, 2019 4:02 PM > To: amd-gfx@lists.freedesktop.or

[PATCH v2] drm/amd/powerplay: change sysfs pp_dpm_xxx format for navi10

v2: set average clock value on level 1 when current clock equal min or max clock (fine grained dpm support). the navi10 gfxclk (sclk) support fine grained DPM, so use level 1 to show current dpm freq in sysfs pp_dpm_xxx Change-Id: I14daa6e30c52c89795708ec06660862bb4591036 Signed-off-by: Kevin

[PATCH] drm/amd/powerplay: custom peak clock freq for navi10

1.NAVI10_PEAK_SCLK_XTX1830 Mhz 2.NAVI10_PEAK_SCLK_XT 1755 Mhz 3.NAVI10_PEAK_SCLK_XL 1625 Mhz Change-Id: I48863a9d0e261b9e7778a6c0e4a8762d7c978da6 Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 65 ++-

Re: [PATCH] drm/amd/powerplay: custom peak clock freq for navi10

Comment inline From: Quan, Evan Sent: Friday, July 19, 2019 1:03 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Huang, Ray ; Xu, Feifei ; Gui, Jack Subject: RE: [PATCH] drm/amd/powerplay: custom peak clock freq for navi10

[PATCH v2] drm/amd/powerplay: custom peak clock freq for navi10

v2: add function smu_default_set_performance_level as default dpm level handler. change function name smu_set_performance_level to smu_asic_set_performance_level v1: 1.NAVI10_PEAK_SCLK_XTX1830 Mhz 2.NAVI10_PEAK_SCLK_XT 1755 Mhz 3.NAVI10_PEAK_SCLK_XL 1625 Mhz Change-Id:

[PATCH] drm/amd/powerplay: remove redundancy debug log in smu

remove redundacy debug log in smu. eg: [ 6897.969447] amdgpu: [powerplay] smu 11 clk dpm feature 1 is not enabled [ 6897.969448] amdgpu: [powerplay] smu 11 clk dpm feature 1 is not enabled [ 6897.969448] amdgpu: [powerplay] smu 11 clk dpm feature 1 is not enabled [ 6899.024114] amdgpu: [powerplay]

[PATCH] drm/amd/powerplay: change smu_read_sensor sequence in smu

each asic maybe has different read sensor method. so change read sensor sequence in smu. read sensor sequence: asic sensor --> smc sensor (smu 11...) --> default_sensor (common) Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c| 26 +--

[PATCH] drm/amd/powerplay: refine AMDGPU_PP_SENSOR_XXX index for powerplay

for patch: drm/amd/powerplay: expose current hotspot and memory temperatures V2 this patch will add some new sensor type to enum amd_pp_sensors, we should add these types to tail to be compatible with the sensor in effect. eg: some application will use old amd_pp_sensors type, likes umr. the umr

Re: [PATCH] drm/amd/powerplay: change smu_read_sensor sequence in smu

From: Alex Deucher Sent: Friday, July 19, 2019 11:17 PM To: Wang, Kevin(Yang) Cc: amd-gfx@lists.freedesktop.org ; Huang, Ray ; Feng, Kenneth Subject: Re: [PATCH] drm/amd/powerplay: change smu_read_sensor sequence in smu On Fri, Jul 19, 2019 at 7:23 AM Wang

Re: [PATCH] drm/amd/powerplay: change smu_read_sensor sequence in smu

lex Deucher wrote: > >> On Fri, Jul 19, 2019 at 12:01 PM Wang, Kevin(Yang) >> wrote: >> >> >> >> From: Alex Deucher >> Sent: Friday, July 19, 2019 11:17 PM >> To: Wang, Kevin(Yang) >> Cc: amd-gfx@lists.

Re: [PATCH] drm/amd/powerplay: fix deadlock around smu_handle_task V2

Reviewed-by: Kevin Wang Best Regards, Kevin From: Quan, Evan Sent: Tuesday, July 16, 2019 11:01:43 AM To: Quan, Evan; amd-gfx@lists.freedesktop.org Cc: Wang, Kevin(Yang) Subject: RE: [PATCH] drm/amd/powerplay: fix deadlock around smu_handle_task V2 Ping

  1   2   3   >