[PATCH v2] drm/amd/amdgpu: S4 issue for amdgpu

2016-09-03 Thread jimqu
reset the asic if adapter is not powerdown when doing freeze() thaw() and restore(), in order to get a valid state of adapter. Change-Id: Ibb03ab3c2ce6ef3c83affbe767308dc22474f563 Signed-off-by: JimQu <jim...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.

[PATCH] drm/amd/amdgpu: S4 issue for amdgpu

2016-09-01 Thread jimqu
reset the asic if adapter is not powerdown when doing freeze() thaw() and restore(), in order to get a valid state of adapter. Change-Id: Id2e4587c06b556eb651ab9277ffc903f780dea56 Signed-off-by: JimQu <jim...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.

[PATCH 3/3] drm/amd/amdgpu: compute ring test fail during S4 on CI

2016-08-29 Thread jimqu
unhalt F32`s Instrction Fetch Unit after all rings are inited. Change-Id: Ib27e4e02e7e2782a9ab528f5358dce5ff2501e17 Signed-off-by: JimQu <jim...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/d

[PATCH 2/3] drm/amd/amdgpu: sdma resume fail during S4 on CI

2016-08-29 Thread jimqu
SDMA could be fail in the thaw() and restore() processes, do software reset if each SDMA engine is busy. Change-Id: Iaff231330c256fbd297f2a98edb2d956bd0d78f8 Signed-off-by: JimQu <jim...@amd.com> --- drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH 0/3] S4 issue on CI

2016-08-29 Thread jimqu
These series patches are used for fixing S4 issue on CI jimqu (3): drm/amd/amdgpu: VCE ring test fail during S4 on CI drm/amd/amdgpu: sdma resume fail during S4 on CI drm/amd/amdgpu: compute ring test fail during S4 on CI drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 7 ++- drivers/gpu

[PATCH 1/3] drm/amd/amdgpu: VCE ring test fail during S4 on CI

2016-08-29 Thread jimqu
Set up the VCE clock no matter dpm is enabled or not. Change-Id: I68e315f8b62c6e3a8636bc5e14036ecc11d980b4 Signed-off-by: JimQu <jim...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/

[PATCH] drm/amd/amdgpu: S3 resumed failed after 4-5 times loop

2016-08-18 Thread jimqu
-by: JimQu <jim...@amd.com> --- drivers/gpu/drm/amd/amdgpu/vce_v2_0.c | 123 +++--- 1 file changed, 84 insertions(+), 39 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v2_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v2_0.c index 9e70df9..6ce7c07 100644 --- a/d

[PATCH] drm/amdgpu: fix the wrong value of UVD bo size

2016-08-23 Thread jimqu
Driver allocate bo for restore UVD fw ,cache, stack , etc. the firmware size is not only ucode size but the ucode and header. Change-Id: I886c099fa123c4814de9b7db3559c30e7b41fd1b Signed-off-by: JimQu <jim...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 2 +- 1 file changed, 1 ins

[PATCH] drm/amdgpu: atombios stuck executing during S3 stress test

2016-10-19 Thread jimqu
Sometimes, atombios may be stucked when resume back. Duo to PCIE has set to D3cold, the ACC of GFX adapter is power-down. it should re-init the scratch registers. with the change, test is pass more than 80 cycles on Fiji. Change-Id: I9cf40c475c4a5a31216949d50cc5e30b74dc21c4 Signed-off-by: JimQu

[PATCH] drm/amdgpu: avoid drm error log during S3 on RHEL7.3

2016-10-20 Thread jimqu
Change-Id: I04dc3d2749d162367a6745ea0e618c4d7d3cae8d Signed-off-by: JimQu <jim...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

[PATCH] drm/amdgpu: fix the issue that nodes[0] is not removed from the allocator

2016-11-01 Thread jimqu
Change-Id: Id960af4bf93036a8a39306c374e2cafdc1bef055 Signed-off-by: JimQu <jim...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gpu/drm/amd/

[PATCH] udev_monitor_receive_device() will block when hotplug monitor

2016-12-13 Thread jimqu
udev_monitor_receive_device() will block and wait for the event of udev use select() to ensure that this will not block. Change-Id: I4e8f4629580222e94f55a4c03070741bf5f4024c Signed-off-by: JimQu <jim...@amd.com> --- src/drmmode_display.c | 22 +++--- 1 file changed, 19 inse

Re: y4T�TCH 4/4] drm/amdgpu: Add audio component support

2018-07-26 Thread jimqu
On 2018年07月25日 16:20, Takashi Iwai wrote: On Wed, 25 Jul 2018 10:02:34 +0200, jimqu wrote: On 2018年07月25日 13:46, Takashi Iwai wrote: On Wed, 25 Jul 2018 07:38:37 +0200, Qu, Jim wrote: Jim: Just like Alex said, we want driver can get eld info when hotplug in new device. amdgpu driver

Re: [V3] vga_switcheroo: set audio client id according to bound GPU id

2018-07-17 Thread jimqu
and I'd love to merge it for 4.19, I'd prefer taking through sound git tree, unless anyone has objection. Thanks to Takashi and Lukas great help. Please kindly help merge the patch into suitable branch. Thanks JimQu thanks, Takashi ___ amd-gfx mailing

Re: [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-14 Thread jimqu
we also use it on the audio client. if we set VGA_SWITCHEROO_UNKNOWN_ID to gpu clients, client_is_audio(client) will be true, since -1 in memory is presented as 0x(if it is 64bit asic). thanks JimQu Thanks, Lukas ___

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-14 Thread jimqu
to use DC to support new asics. so there also need a patch for amdgpu in DC code. Thanks JimQu thanks, Takashi ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-16 Thread jimqu
在 2018/7/16 22:02, Lukas Wunner 写道: On Sat, Jul 14, 2018 at 02:15:24PM +0800, jimqu wrote: ??? 2018/7/13 17:27, Lukas Wunner ??: On Fri, Jul 13, 2018 at 04:06:02PM +0800, Jim Qu wrote: On modern laptop, there are more and more platforms have two GPUs, and each of them maybe have audio

Re: 答复: [PATCH 3/4] drm/radeon: Add audio component support

2018-07-24 Thread jimqu
inquired via get_eld call by HD-audio followed after the notification. thanks, Takashi OK, I got your point. Thanks JimQu ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: 答复: [PATCH 4/4] drm/amdgpu: Add audio component support

2018-07-25 Thread jimqu
which is plugged out, so there is no notify() call on it. Thanks JimQu With None-DC driver, the detect() of connectors will to be preformed in drm_helper_hpd_irq_event() when there is device hotplug. However, amdgpu_connector__detect() maybe need to be modified to fit your change. Thanks

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-10 Thread jimqu
On 2018年07月10日 17:50, Takashi Iwai wrote: On Tue, 10 Jul 2018 11:13:27 +0200, jimqu wrote: On 2018年07月10日 16:01, Takashi Iwai wrote: On Tue, 10 Jul 2018 09:44:42 +0200, Qu, Jim wrote: Hi Takashi, I am not expert in audio driver, so I just update some test result, please help triage

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-10 Thread jimqu
Thanks JimQu 发件人: Takashi Iwai 发送时间: 2018年7月10日 1:09 收件人: Qu, Jim 抄送: Daniel Vetter; Alex Deucher; alsa-de...@alsa-project.org; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Deucher, Alexander 主题: Re: 答复: [alsa-devel]答复:

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-11 Thread jimqu
On 2018年07月11日 17:04, Takashi Iwai wrote: On Wed, 11 Jul 2018 10:41:38 +0200, jimqu wrote: On 2018年07月11日 15:19, Takashi Iwai wrote: On Tue, 10 Jul 2018 13:21:00 +0200, Takashi Iwai wrote: revert the fix of amdgpu suspend issue, audio issue also can be observed. Did you check

Re: 答复: Regression with kernel 4.18 - AMD RX 550 fails IB ring test on power-up

2018-07-11 Thread jimqu
HI Luis, Let us trace the issue one by one. IB test fail: This should be regression issue on 4.18, you can bisect the kernel patches. GPU hang: Fix IB test fail first. Thanks JimQu On 2018年07月11日 17:34, Luís Mendes wrote: Hi Jim, Thanks for your interest in this issue. Actually

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-11 Thread jimqu
On 2018年07月11日 17:53, Takashi Iwai wrote: On Wed, 11 Jul 2018 11:26:11 +0200, jimqu wrote: On 2018年07月11日 17:04, Takashi Iwai wrote: On Wed, 11 Jul 2018 10:41:38 +0200, jimqu wrote: On 2018年07月11日 15:19, Takashi Iwai wrote: On Tue, 10 Jul 2018 13:21:00 +0200, Takashi Iwai wrote: revert

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-11 Thread jimqu
[AMD/ATI] Device [1002:15dd] (rev d1) 06:00.1 Audio device [0403]: Advanced Micro Devices, Inc. [AMD/ATI] Device [1002:15de] Thanks JimQu At best, give the full dmesg output and the lspci -nv output. thanks, Takashi ___ amd-gfx mailing list amd-gfx

Re: [alsa-devel] [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-13 Thread jimqu
use_vga_switcheroo is checked at beginning of the function. so the p which pass into vga_switcheroo_register_audio_client() is constant valid value. Thanks JimQu thanks, Takashi ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freed

Re: [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-13 Thread jimqu
_UNKNOWN_ID can be only used for gpu client, but now we also use it on audio client. Because of -1 in memory is presented as 0x, so the 0x & ID_BIT_AUDIO = ID_BIT_AUDIO, this will confuse people if it used on gpu client. that audio identify bit is set.

Re: 答复: Regression with kernel 4.18 - AMD RX 550 fails IB ring test on power-up

2018-07-11 Thread jimqu
first, and manually modprobe amdgpu. What's about xinit? What is MESA driver version on your platform? Thanks & Regards, Luís On Wed, Jul 11, 2018 at 10:56 AM, jimqu <mailto:ji...@amd.com>> wrote: HI Luis, Let us trace the issue one by one. IB test fail: This s

Re: [alsa-devel] [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-13 Thread jimqu
在 2018/7/14 0:38, Takashi Iwai 写道: On Fri, 13 Jul 2018 17:25:39 +0200, jimqu wrote: 在 2018/7/13 16:46, Takashi Iwai 写道: On Fri, 13 Jul 2018 10:06:02 +0200, Jim Qu wrote: On modern laptop, there are more and more platforms have two GPUs, and each of them maybe have audio codec for HDMP/DP