Re: [PATCH] MAINTAINERS: update radeon/amdgpu/amdkfd git trees

2021-01-08 Thread Abramov, Slava
[AMD Official Use Only - Internal Distribution Only] Why not just https://gitlab.freedesktop.org/agd5f/linux ? From: amd-gfx on behalf of Alex Deucher Sent: Friday, January 8, 2021 2:30 PM To: amd-gfx list ; Maling list - DRI developers ; Dave Airlie ; Daniel

Re: [PATCH] drm/amdgpu/display: re-add surface size calculation in dcn30_hwseq.c

2020-10-27 Thread Abramov, Slava
[AMD Official Use Only - Internal Distribution Only] Looks sane to me. Acked-by: Slava Abramov From: amd-gfx on behalf of Alex Deucher Sent: Tuesday, October 27, 2020 11:20 AM To: amd-gfx list Cc: Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu/display:

Re: [PATCH 1/2] drm/amdgpu/display: fix abm shift and mask lists for DCN3.01/3.02

2020-10-26 Thread Abramov, Slava
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Slava Abramov From: amd-gfx on behalf of Alex Deucher Sent: Monday, October 26, 2020 11:57 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 1/2] drm/amdgpu/display:

Re: [PATCH 2/2] drm/amdgpu/display: drop disconnect_pipes callback for DCN3.01

2020-10-26 Thread Abramov, Slava
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Slava Abramov From: amd-gfx on behalf of Alex Deucher Sent: Monday, October 26, 2020 11:57 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 2/2] drm/amdgpu/display:

Re: [PATCH] drm/amdgpu: No sysfs, not an error condition

2020-09-16 Thread Abramov, Slava
[AMD Official Use Only - Internal Distribution Only] ​Acked-by: Slava Abramov From: amd-gfx on behalf of Luben Tuikov Sent: Wednesday, September 16, 2020 1:08 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Tuikov, Luben Subject: [PATCH]

Re: [PATCH] drm/amd/display: avoid 64-bit division

2019-07-09 Thread Abramov, Slava
Hi Arnd! Thanks for bisecting this issue. I wonder whether you are going to commit your patch or planning to update it and it's still in your work queue. We have one of our 32-bit builds failing because of this issue, so that I would like either to fix it or wait to your fix if it has

Re: [PATCH] drm/amd/display: avoid 64-bit division

2019-07-08 Thread Abramov, Slava
Acked-by: Slava Abramov Tested-by: Slava Abramov From: amd-gfx on behalf of Arnd Bergmann Sent: Monday, July 8, 2019 9:52:08 AM To: Wentland, Harry; Li, Sun peng (Leo); Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel

Re: [PATCH][next] drm/amdgpu/mes10.1: fix duplicated assignment to adev->mes.ucode_fw_version

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 11:05:39 AM To: Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; Xiao, Jack; Zhang, Hawking; amd-gfx@lists.freedesktop.org;

Re: [PATCH][next] drm/amd/powerplay: fix out of memory check on od8_settings

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 11:13:54 AM To: Wang, Kevin(Yang); Rex Zhu; Quan, Evan; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter;

Re: [PATCH] drm/amd/powerplay: fix incorrect assignments to mclk_mask and soc_mask

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 10:45:17 AM To: Wang, Kevin(Yang); Rex Zhu; Quan, Evan; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter;

Re: [PATCH] drm/amd/powerplay: fix off-by-one array bounds check

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 10:24:02 AM To: Rex Zhu; Quan, Evan; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; amd-gfx@lists.freedesktop.org;

Re: [PATCH][next] drm/amdkfd: fix a missing break in a switch statement

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 10:54:43 AM To: Cox, Philip; Oded Gabbay; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; dri-de...@lists.freedesktop.org;

Re: [PATCH][next] drm/amdgpu: fix off-by-one comparison on a WARN_ON message

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 10:08:01 AM To: Zhang, Hawking; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; amd-gfx@lists.freedesktop.org;

Re: [PATCH] drm/amdgpu: fix a missing break in a switch statement

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 10:33:20 AM To: Zhang, Hawking; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; amd-gfx@lists.freedesktop.org;

Re: [PATCH] drm/amd/powerplay: use hardware fan control if no powerplay fan table

2019-06-28 Thread Abramov, Slava
Tested-by: Slava Abramov Acked-by: Slava Abramov From: amd-gfx on behalf of Evan Quan Sent: Thursday, June 27, 2019 11:15:29 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: use hardware fan control if no powerplay fan

Re: [PATCH] drm/amd/doc: add rough outline of tracepoint documentation

2019-05-30 Thread Abramov, Slava
Comments inline (marked with [slava a]). General comment - word capitalisation in the lists is inconsistent From: amd-gfx on behalf of StDenis, Tom Sent: Thursday, May 30, 2019 10:56 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH]

Re: [PATCH 1/2] drm/amd/doc: Add XGMI sysfs documentation

2019-05-24 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of StDenis, Tom Sent: Friday, May 24, 2019 9:23:49 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH 1/2] drm/amd/doc: Add XGMI sysfs documentation [CAUTION: External Email] Signed-off-by:

Re: [PATCH 2/2] drm/amd/doc: Add RAS documentation to guide

2019-05-24 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of StDenis, Tom Sent: Friday, May 24, 2019 9:23:50 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH 2/2] drm/amd/doc: Add RAS documentation to guide [CAUTION: External Email] Signed-off-by:

[PATCH] drm/amdgpu: use div64_ul for 32-bit compatibility v1

2019-05-17 Thread Abramov, Slava
v1: replace casting to unsigned long with div64_ul Change-Id: Ia48671ed0756bb73c7b4760a800bcb6f600cbef2 Signed-off-by: Slava Abramov --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

[PATCH] drm/amdgpu: cast to unsigned int for 32-bit portability

2019-05-16 Thread Abramov, Slava
Without casting, 64-bit division is used implicitly causing DEPMOD failure when building 32-bit kernel. Signed-off-by: Slava Abramov --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

Re: Same bridge number?

2018-11-07 Thread Abramov, Slava
1-877-336-1283 8051546 From: amd-gfx on behalf of Panariti, David Sent: Wednesday, November 7, 2018 9:59:42 AM To: amd-gfx@lists.freedesktop.org Subject: Same bridge number? ___ amd-gfx mailing list

Re: [PATCH xf86-video-amdgpu] Use strcpy for RandR output property names

2018-07-23 Thread Abramov, Slava
Reviewed-by: Slava Abramov From: amd-gfx on behalf of Michel Dänzer Sent: Monday, July 23, 2018 12:45:11 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-amdgpu] Use strcpy for RandR output property names From: Michel Dänzer Instead of

Re: [PATCH xf86-video-amdgpu 1/2] Remove #if 0'd code

2018-06-28 Thread Abramov, Slava
Michel, My review is only for the first patch. Slava From: Michel Dänzer Sent: Thursday, June 28, 2018 4:26:28 AM To: Abramov, Slava Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH xf86-video-amdgpu 1/2] Remove #if 0'd code On 2018-06-27 08:29 PM

Re: [PATCH xf86-video-amdgpu 1/2] Remove #if 0'd code

2018-06-27 Thread Abramov, Slava
I wonder how '#if 0' made its way upstream, but besides this Reviewed-by: Slava Abramov From: amd-gfx on behalf of Michel Dänzer Sent: Wednesday, June 27, 2018 12:39:40 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-amdgpu 1/2] Remove #if

Re: [PATCH] drm/amd/amdgpu: Add a GPU_LOAD entry to sysfs (v2)

2018-06-20 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Tom St Denis Sent: Wednesday, June 20, 2018 12:48:52 PM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH] drm/amd/amdgpu: Add a GPU_LOAD entry to sysfs (v2) This adds what should be a stable

Re: [PATCH] drm/amd/amdgpu: Add a GPU_LOAD entry to sysfs

2018-06-20 Thread Abramov, Slava
Should the comment then say 'get the load' instead of 'get the temperature'? From: StDenis, Tom Sent: Wednesday, June 20, 2018 10:39:25 AM To: Abramov, Slava; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: Add a GPU_LOAD entry to sysfs On 06

Re: [PATCH] drm/amd/amdgpu: Add a GPU_LOAD entry to sysfs

2018-06-20 Thread Abramov, Slava
I see some functions in amdgpu_pm.c have function level documentation, so that it would be good to have this for newly added functions. Another comment is inline. >From: amd-gfx on behalf of Tom St >Denis >Sent: Wednesday, June 20, 2018 8:31 AM >To: amd-gfx@lists.freedesktop.org >Cc:

Re: GPU hang trying to run OpenCL kernels on x86_64

2018-05-04 Thread Abramov, Slava
Luis, Can you please provide more details on your system environment and steps on configuring the software and reproducing the issue? Slava A From: amd-gfx on behalf of Luís Mendes Sent:

Re: [PATCH xf86-video-amdgpu 04/10] Create drmmode_crtc_wait_pending_event helper macro

2017-08-22 Thread Abramov, Slava
From: Michel Dänzer <mic...@daenzer.net> Sent: Tuesday, August 22, 2017 1:52 AM To: Abramov, Slava Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH xf86-video-amdgpu 04/10] Create drmmode_crtc_wait_pending_event helper macro On 18/08/17 11:51 PM, Abramov, Slava wrote: > *From: