[PATCH 01/21] drm/amd/display: update DML2 policy EnhancedPrefetchScheduleAccelerationFinal DCN35

sta...@vger.kernel.org Reviewed-by: Charlene Liu Signed-off-by: Yihan Zhu Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dml2/dml2_policy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_policy.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_poli

[PATCH 07/21] drm/amd/display: Fix incorrect DSC recompute trigger

when compared to the current dc_state, triggering a dsc recompute that should not have happened. Reviewed-by: Rodrigo Siqueira Signed-off-by: Fangzhi Zuo Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 17/21] drm/amd/display: Clip rect size changes should be full updates

actually change. Reviewed-by: Dillon Varone Signed-off-by: Joshua Aberback Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 45 --- drivers/gpu/drm/amd/display/dc/dc.h | 1 - .../amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 2 - 3

[PATCH 14/21] drm/amd/display: fix static analysis warnings

From: Samson Tam [Why & How] Fix static analysis warnings in SPL library Reviewed-by: Alvin Lee Signed-off-by: Samson Tam Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/spl/dc_spl_types.h | 4 +-- .../gpu/drm/amd/display/dc/spl/spl_debug.h

[PATCH 20/21] drm/amd/display: Enable idle workqueue for more IPS modes

From: Leo Li [Why] There are more IPS modes other than DMUB_IPS_ENABLE that enables IPS. We need to enable the hotplug detect idle workqueue for those modes as well. [How] Modify the if condition to initialize the workqueue in all IPS modes except for DMUB_IPS_DISABLE_ALL. Fixes: 514fd3e75d90

[PATCH 12/21] drm/amd/display: avoid set dispclk to 0

From: Charlene Liu [why] set dispclk to 0 cause stability issue. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Nicholas Kazlauskas Signed-off-by: Charlene Liu Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/resource/dcn351

[PATCH 19/21] drm/amd/display: Wait For DET Update Should Use Current State

instead of context. Use pipe from current_state instead of context. This assumes that pipe in the current_state is an OTG_MASTER pipe if the pipe in the context is an OTG_MASTER pipe. Reviewed-by: Dillon Varone Signed-off-by: Austin Zheng Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display

[PATCH 11/21] drm/amd/display: Block UHBR Based On USB-C PD Cable ID

le ID supported platform receives no reply from a DMUB cable id query. Reviewed-by: Wenjing Liu Reviewed-by: Ovidiu Bunea Signed-off-by: Michael Strauss Signed-off-by: Aurabindo Pillai --- .../dc/link/protocols/link_dp_capability.c| 22 ++- 1 file changed, 16 insertions(

[PATCH 16/21] drm/amd/display: Fix cursor visual confirm update

Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c| 2 ++ .../drm/amd/display/dc/core/dc_hw_sequencer.c | 17 + drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 11 +-- .../gpu/drm/amd/display/dc/hwss/hw_sequencer.h | 4 4 files

[PATCH 15/21] drm/amd/display: Update Interface to Check UCLK DPM

functions that can be used to determine power level: -get power profile after a dc_state has undergone full validation Reviewed-by: Aric Cyr Signed-off-by: Austin Zheng Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c| 9 - .../dml21/src/dml2_pmo

[PATCH 18/21] drm/amd/display: Add HDR workaround for specific eDP

sta...@vger.kernel.org Reviewed-by: Rodrigo Siqueira Signed-off-by: Alex Hung Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 11 ++- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 4 drivers/gpu/drm/amd/display/dc/dc_types.h

[PATCH 13/21] drm/amd/display: correct register Clock Gater incorrectly disabled

egister clock branch will always be running. As a consequence, the dynamic power will be higher than expected. Reviewed-by: Alvin Lee Signed-off-by: Charlene Liu Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dpp/dcn35/dcn35_dpp.c | 10 -- 1 file changed, 4 insert

[PATCH 03/21] drm/amd/display: Restore Optimized pbn Value if Failed to Disable DSC

case. Restore the optimized pbn value, instead of using the pbn value under minimum compression. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Wayne Lin Signed-off-by: Fangzhi Zuo Signed-off-by: Aurabindo Pillai --- .../amd/display/amdgpu_dm

[PATCH 08/21] drm/amd/display: Clean up triple buffer enablement code

From: Sung Lee [WHY] Triple buffer enablement currently does not work properly [HOW] Allow triple buffer enablement to happen properly on fast updates Reviewed-by: Aric Cyr Signed-off-by: Sung Lee Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 23

[PATCH 21/21] drm/amd/display: 3.2.302

From: Aric Cyr Signed-off-by: Aric Cyr Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 6d60f7597f88..51fdc0085935 100644

[PATCH 10/21] drm/amd/display: Set Pipe Unlock Order Outside of HWSEQ

unlock order. Indicate which pipes should be unlocked first using array stored in dc scratch memory. Pipes indicated in array can be unlocked in any order. Reviewed-by: Alvin Lee Signed-off-by: Austin Zheng Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 42

[PATCH 04/21] drm/amd/display: Wait for all pending cleared before full update

ead 3 different status registers for pending cleared, one specifically for OTG updates, one specifically for OPTC updates, and the last for surface related updates. Reviewed-by: Dillon Varone Signed-off-by: Alvin Lee Signed-off-by: Aurabindo Pillai --- .../drm/amd/display/dc/core/dc_hw_sequencer.c

[PATCH 09/21] drm/amd/display: Change dc_surface_update cm2_params to const

From: Shunlu Zhang [WHY] cm2_params is used to set update_flags. It's value is not intended to be modified. [WHAT] Change the declaration of cm2_params to be a constant variable Reviewed-by: Tao Huang Reviewed-by: Ariel Bernstein Signed-off-by: Shunlu Zhang Signed-off-by: Aurabindo P

[PATCH 00/21] DC Patches Sept 16, 2024

DC 3.2.302 contains some improvements as summarized below: * Stability fixes in DML, SPL, * Improvements for MST, DSC, eDP, IPS, HDR * Fix clock gating on DCN35 * Fixes from static analysis checks * Other bug fixes and debug improvements ___ Alex Hung (1): drm/amd/display: Add HDR workaround fo

[PATCH 05/21] drm/amd/display: Monitor patch to call blank_stream() before otg off

: Nicholas Kazlauskas Signed-off-by: Zhongwei Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dc_types.h | 1 + drivers/gpu/drm/amd/display/dc/hwss/dcn31/dcn31_hwseq.c | 5 + 2 files changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dc_types.h

[PATCH 06/21] drm/amd/display: Implement new backlight_level_params structure

from PWM to nits or vice versa. [How] Added backlight_level_params struct and modified existing functions to include the new structure. Reviewed-by: Harry Vanzylldejong Signed-off-by: Kaitlyn Tse Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c | 5

[PATCH 02/21] drm/amd/display: disable adaptive scaler and sharpener when integer scaling is enabled

From: Samson Tam [Why & How] When integer scaling is enabled, set taps to 1 and disable adaptive scaler and sharpener. Reviewed-by: Jun Lei Signed-off-by: Samson Tam Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dc_spl_translate.c | 1 + drivers/gpu/drm/amd/displa

Re: [PATCH 0/2] Fix for lightup issue on Lenovo 4k60 HDMI

commit drm/amd/display: Fix Synaptics Cascaded DSC Determination drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Aurabindo Pillai -- Thanks & Regards, Aurabindo Pillai

Re: [PATCH v2 1/5] drm/amd: Introduce additional IPS debug flags

_DISABLE_IPS2_DYNAMIC = 0x2000, + + /** +* @DC_FORCE_IPS_ENABLE: If set, force enable all IPS, all the time. +*/ + DC_FORCE_IPS_ENABLE = 0x4000, }; enum amd_dpm_forced_level; Reviewed-by: Aurabindo Pillai -- Thanks & Regards, Aurabindo Pillai

[PATCH 22/22] drm/amd/display: 3.2.293

From: Aric Cyr Signed-off-by: Aurabindo Pillai Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 272ae1bdc57f..4077c1ddb9c1 100644

[PATCH 21/22] drm/amd/display: remove unused folder

dc/{dcn401,dcn303} are unused since the files in it got moved under their respective new components location. Hence they are no longer necessary Fixes: fb17441f8ce4 ("drm/amd/display: Refactor DCN3X into component folder") Signed-off-by: Aurabindo Pillai Reviewed-by: Leo Li --- drive

[PATCH 20/22] drm/amd/display: Remove duplicate HWSS interfaces

HWSS. - update_plane_addr should only be public, as it's used outside HWSS. Reviewed-by: Rodrigo Siqueira Signed-off-by: Joshua Aberback Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c | 1 - .../gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq

[PATCH 19/22] drm/amd/display: Various DML2 fixes for FAMS2

From: Dillon Varone The disable fams2 operation was reworked, but some of the old code remained. This commit removes the disable_fams2_drr from the dml2_stream_parameters. Reviewed-by: Rodrigo Siqueira Signed-off-by: Dillon Varone Signed-off-by: Aurabindo Pillai --- .../amd/display/dc/dml2

[PATCH 18/22] drm/amd/display: Remove old comments

From: Rodrigo Siqueira Remove some old comments from DCN32/321. Signed-off-by: Rodrigo Siqueira Reviewed-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 4 ++-- drivers/gpu/drm/amd/display/dc/dml/dcn321/dcn321_fpu.c | 4 ++-- 2 files changed, 4 insertions

[PATCH 17/22] drm/amd/display: Check link_res->hpo_dp_link_enc before using it

From: Alex Hung [WHAT & HOW] Functions dp_enable_link_phy and dp_disable_link_phy can pass link_res without initializing hpo_dp_link_enc and it is necessary to check for null before dereferencing. This fixes 1 FORWARD_NULL issue reported by Coverity. Fixes: abdcd93214 ("drm/amd/display: Check l

[PATCH 16/22] drm/amd/display: Add MST debug message when link detection fails

From: Alex Hung [WHY & HOW] dc_link_detect returns a boolean value which can be used to print debug messages when it fails. This fixes 1 CHECKED_RETURN issue reported by Coverity. Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai Signed-off-by: Alex Hung --- drivers/gpu/drm

[PATCH 15/22] drm/amd/display: Check top sink only when multiple streams for DP2

DTBCLK and causes hang. [how] For DP2.0 MST hubs, only treat 1st remote sink as an encoder only when there are multiple displays connected. Reviewed-by: Michael Strauss Signed-off-by: Aurabindo Pillai Signed-off-by: Sung Joon Kim --- .../amd/display/dc/dml2/dml2_internal_types.h | 1 + .../display

[PATCH 14/22] drm/amd/display: Fix Potential Null Dereference

From: Gabe Teeger [what & why] System hang after s4 regression points to code change here. Removing possible NULL dereference. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Nicholas Kazlauskas Signed-off-by: Aurabindo Pillai Signed-off-by: Gabe Te

[PATCH 13/22] drm/amd/display: Add helper function to check for non-address fast updates

From: Ilya Bakoulin [Why/How] Need to identify which fast updates will update more than just the address. Reviewed-by: Alvin Lee Signed-off-by: Aurabindo Pillai Signed-off-by: Ilya Bakoulin --- drivers/gpu/drm/amd/display/dc/core/dc.c | 25 +++- drivers/gpu/drm/amd

[PATCH 12/22] drm/amd/display: rename dcn401_soc to dcn4_variant_a_soc

To distinguish between different soc with same DCN IP, use variants starting with alphabets Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai --- .../drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c| 2 +- .../amd/display/dc/dml2/dml21

[PATCH 11/22] drm/amd/display: rename dcn3/dcn4 to more sound terms

Use more accurate names to refer to the asic architecture. dcn3 in DML actually refers to DCN32 and DCN321, so rename it to dcn32x dcn4 refers to any DCN4x soc., and hence rename dcn4 to dcn4x Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai

[PATCH 10/22] drm/amd/display: Add source select helper functions

From: Hansen Dsouza [why & how] Add source select helpers based on DCCG spec Reviewed-by: Daniel Miess Signed-off-by: Aurabindo Pillai Signed-off-by: Hansen Dsouza --- .../amd/display/dc/dccg/dcn35/dcn35_dccg.c| 324 ++ 1 file changed, 324 insertions(+) diff --g

[PATCH 09/22] drm/amd/display: Check if Mode is Supported Before Returning Result

From: Austin Zheng [Why] Even if the mode is not supported dml2_check_mode_supported() would still return true. This causes an unsupported mode to be programmed. [How] Check if the mode is supported or not and return the proper result. Reviewed-by: Chaitanya Dhere Signed-off-by: Aurabindo

[PATCH 07/22] drm/amd/display: Fix visual confirm bug for SubVP

From: Ryan Seto [Why] Visual confirm was incorrect on dual monitor SubVP setup [How] Adjusted p_state assignment for dual monitor SubVP setup Signed-off-by: Ryan Seto Reviewed-by: Chaitanya Dhere Signed-off-by: Aurabindo Pillai --- .../dc/dml2/dml21/dml21_translation_helper.c | 13

[PATCH 08/22] drm/amd/display: ensure EASF and ISHARP coefficients are programmed together

force EASF coefficients programming Reviewed-by: Alvin Lee Signed-off-by: Aurabindo Pillai Signed-off-by: Samson Tam --- .../display/dc/dpp/dcn401/dcn401_dpp_dscl.c | 28 +-- 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dpp

[PATCH 06/22] drm/amd/display: Add RCG helper functions

From: Hansen Dsouza [why & how] Add standard RCG helpers based on DCCG spec Reviewed-by: Daniel Miess Reviewed-by: Muhammad Ahmed Signed-off-by: Aurabindo Pillai Signed-off-by: Hansen Dsouza --- .../amd/display/dc/dccg/dcn35/dcn35_dccg.c| 307 ++ 1 file changed,

[PATCH 05/22] drm/amd/display: Remove ASSERT if significance is zero in math_ceil2

the ASSERT if the significance is equal to zero to avoid unnecessary noise. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Chaitanya Dhere Signed-off-by: Aurabindo Pillai Signed-off-by: Rodrigo Siqueira --- .../dml2/dml21/src/dml2_standalone_libraries

[PATCH 04/22] drm/amd/display: Refactoring HPO

From: Revalla Hari Krishna [Why] To refactor HPO files [How] Moved hpo related files to specific hpo folder and update Makefiles. Reviewed-by: Martin Leung Signed-off-by: Aurabindo Pillai Signed-off-by: Revalla Hari Krishna --- drivers/gpu/drm/amd/display/dc/dcn30/Makefile | 2

[PATCH 03/22] drm/amd/display: Add private data type for RCG

From: Hansen Dsouza [why & how] Add private data types for better RCG control Reviewed-by: Chris Park Reviewed-by: Yihan Zhu Signed-off-by: Aurabindo Pillai Signed-off-by: Hansen Dsouza --- .../amd/display/dc/dccg/dcn35/dcn35_dccg.c| 81 +++ 1 file changed

[PATCH 02/22] drm/amd/display: Check for NULL pointer

From: Sung Joon Kim [why & how] Need to make sure plane_state is initialized before accessing its members. Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org Reviewed-by: Xi (Alex) Liu Signed-off-by: Aurabindo Pillai Signed-off-by: Sung Joon Kim --- drivers/gpu/drm

[PATCH 01/22] drm/amd/display: Remove hardmax usage for dcn401

From: Dillon Varone [WHY&HOW] Hardmax message will be retired for dcn4, so this removes it. Reviewed-by: Alvin Lee Signed-off-by: Aurabindo Pillai Signed-off-by: Dillon Varone --- .../dc/clk_mgr/dcn401/dcn401_clk_mgr.c| 44 ++- drivers/gpu/drm/amd/display/dc/

[PATCH 00/22] DC Patches for 15 July, 2024

Wheeler Alex Hung (2): drm/amd/display: Add MST debug message when link detection fails drm/amd/display: Check link_res->hpo_dp_link_enc before using it Aric Cyr (1): drm/amd/display: 3.2.293 Aurabindo Pillai (3): drm/amd/display: rename dcn3/dcn4 to more sound terms drm/amd/display: ren

Re: [PATCH] drm: Fix documentation warning for read_mpcc_state in mpc.h

9d7 drm/amd/display: fix documentation warnings for mpc.h -- Thanks & Regards, Aurabindo Pillai

Re: [PATCH] drm/amd/display: Add function banner for idle_workqueue

Reviewed-by: Aurabindo Pillai On 7/15/24 4:57 PM, roman...@amd.com wrote: From: Roman Li [Why] htmldocs warning: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h: warning: Function parameter or struct member 'idle_workqueue' not described in 'amdgpu_display_manager'

Re: [PATCH] drm/amd/display: Add doc entry for program_3dlut_size

phen Rothwell this patch is: Reviewed-by: Aurabindo Pillai -- Thanks & Regards, Aurabindo Pillai

[PATCH] drm/amd/display: fix doc entry for bb_from_dmub

Fixes the warning: Function parameter or struct member 'bb_from_dmub' not described in 'amdgpu_display_manager' Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a

[PATCH] drm/amd: Bump KMS_DRIVER_MINOR version

Increase the KMS minor version to indicate GFX12 DCC support since this contains a major change in how DCC is managed across IPs like GFX, DCN etc. This will be used mainly by userspace like Mesa to figure out DCC support on GFX12 hardware. Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm

Re: [PATCH] drm/amd/display: Allow display DCC for DCN401

On 7/10/24 4:12 PM, Marek Olšák wrote: Can you also increase KMS_DRIVER_MINOR with a proper comment in amdgpu_drv.c, which will be used by Mesa to tell whether display DCC is supported on gfx12? Sure, will do. -- Thanks & Regards, Aurabindo Pillai

Re: [PATCH] drm/amd/display: Allow display DCC for DCN401

On 7/10/24 10:49 AM, Marek Olšák wrote: This will enable display DCC for Wayland because Mesa already exposes modifiers with DCC. Has it been tested? Yes, its working for most resolutions. Investigating issue with certain modes. Marek -- Thanks & Regards, Aurabindo Pillai

[PATCH] drm/amd/display: Allow display DCC for DCN401

To enable mesa to use display dcc, DM should expose them in the supported modifiers. Add the best (most efficient) modifiers first. Signed-off-by: Aurabindo Pillai --- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 31 +++ 1 file changed, 25 insertions(+), 6 deletions(-) diff

[PATCH v2] drm/amd/display: Fix null pointer deref in dcn20_resource.c

] ? dm_update_plane_state.constprop.0+0x4e3/0x6b0 [amdgpu] [ 181.850840] amdgpu_dm_atomic_check+0xdfe/0x1760 [amdgpu] Signed-off-by: Aurabindo Pillai --- .../drm/amd/display/dc/resource/dcn20/dcn20_resource.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd

Re: [PATCH 05/13] drm/amdgpu: remove AMD_FMT_MOD_GFX12_DCC_MAX_COMPRESSED_BLOCK_* definitions

Reviewed-by: Aurabindo Pillai On 6/26/24 2:31 PM, Marek Olšák wrote: They were added accidentally. Signed-off-by: Marek Olšák --- include/uapi/drm/drm_fourcc.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index

Re: [PATCH 13/13] drm/amdgpu: rewrite convert_tiling_flags_to_modifier_gfx12

Reviewed-by: Aurabindo Pillai On 6/26/24 2:31 PM, Marek Olšák wrote: There were multiple bugs, like checking SWIZZLE_MODE before checking GFX12_SWIZZLE_MODE, which has undefined behavior. The function had no effect before (it always returned -EINVAL). Signed-off-by: Marek Olšák

Re: [PATCH 12/13] drm/amdgpu/display: add all gfx12 modifiers

Reviewed-by: Aurabindo Pillai On 6/26/24 2:31 PM, Marek Olšák wrote: Signed-off-by: Marek Olšák --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm

Re: [PATCH 11/13] drm/amdgpu/display: set plane attributes for gfx12 correctly

ne_fill_gfx9_plane_attributes_from_modifiers(adev, afb, format, rotation, plane_size, tiling_info, dcc, Reviewed-by: Aurabindo Pillai -- Thanks & Regards, Aurabindo Pillai

Re: [PATCH 10/13] drm/amdgpu/display: handle gfx12 in amdgpu_dm_plane_format_mod_supported

Reviewed-by: Aurabindo Pillai On 6/26/24 2:31 PM, Marek Olšák wrote: All this code has undefined behavior on GFX12 and shouldn't be executed. Signed-off-by: Marek Olšák --- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 47 ++- 1 file changed, 25 insertions(+

Re: [PATCH 06/13] drm/amdgpu/display: handle gfx12 in dm_check_cursor_fb

Reviewed-by: Aurabindo Pillai On 6/26/24 2:31 PM, Marek Olšák wrote: Checking SWIZZLE_MODE has undefined behavior on gfx12. Signed-off-by: Marek Olšák --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [PATCH] drm/amd/display: Add null check before access structs

state, curr_pipe->plane_state); + if (!phantom_plane) + return; } memcpy(&phantom_plane->address, &curr_pipe->plane_state->address, sizeof(phantom_plane->address)); -- -- Thanks & Regards, Aurabindo Pillai

[PATCH] drm/amd/display: Fix null pointer deref in dcn20_resource.c

] ? dm_update_plane_state.constprop.0+0x4e3/0x6b0 [amdgpu] [ 181.850840] amdgpu_dm_atomic_check+0xdfe/0x1760 [amdgpu] Signed-off-by: Aurabindo Pillai --- .../drm/amd/display/dc/resource/dcn20/dcn20_resource.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH] drm/amd: Add some missing register definitions

Add some register offsets that are required for Display DCC on DCN401 Fixes: 000342e3a22 ("drm/amd: Add reg definitions for DCN401 DCC") Reported-by: Tom St Denis Signed-off-by: Aurabindo Pillai --- .../include/asic_reg/dcn/dcn_4_1_0_offset.h| 18 ++ 1 file c

[PATCH 2/2] drm/amd/display: Enable DCC on DCN401

Add registers and entry points to enable DCC on DCN4x Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc.c | 10 + .../drm/amd/display/dc/core/dc_hw_sequencer.c | 11 + drivers/gpu/drm/amd/display/dc/dc.h | 4 + .../drm/amd/display/dc/dml2

[PATCH 1/2] drm/amd: Add reg definitions for DCN401 DCC

Add the necessary register definitions to enable DCC on DCN4x Signed-off-by: Aurabindo Pillai --- .../include/asic_reg/dcn/dcn_4_1_0_sh_mask.h | 110 ++ 1 file changed, 110 insertions(+) diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_4_1_0_sh_mask.h b/drivers/gpu

[PATCH] drm/amdgpu: init TA fw for psp v14

From: Likun Gao Add support to init TA firmware for psp v14. Signed-off-by: Likun Gao --- drivers/gpu/drm/amd/amdgpu/psp_v14_0.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v14_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v14_0.c index cc0248efa6b6..4d33c95

[PATCH] drm/amd/display: Enable idle optimizations on DCN401

Idle optimizations were disabled due to some bugs which are now fixed in DMCUB and PM firwmare. Enable these the optimizations back. Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/resource/dcn401/dcn401_resource.c| 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers

[PATCH] Revert "drm/amd/display: avoid large on-stack structures"

This reverts commit 44069f0f9b1fe577c5d4f05fa9eb02db8c618adc since the code path is called from FPU context, and triggers error like: [ 26.924055] BUG: sleeping function called from invalid context at include/linux/sched/mm.h:306 [ 26.924060] in_atomic(): 1, irqs_disabled(): 0, non_block: 0,

Re: [PATCH] drm/amd/display: Add null checks for 'stream' and 'plane' before dereferencing

we previously assumed 'plane' could be null (see line 922) Cc: Tom Chung Cc: Nicholas Kazlauskas Cc: Bhawanpreet Lakha Cc: Rodrigo Siqueira Cc: Roman Li Cc: Hersen Wu Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/

[PATCH 10/13] drm/amd/display: Add missing registers for DCN401

From: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- .../include/asic_reg/dcn/dcn_4_1_0_offset.h | 51 ++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_4_1_0_offset.h b/drivers/gpu/drm/amd/include/asic_reg/dc

[PATCH 11/13] drm/amd/display: Move some init routines to dm_sw_init()

Move creation of CGS device node and the DAL allocation list from amdgpu_dm_init() to dm_sw_init() which runs before dmub's sw init hook. This is required for communicating with the VBIOS DMUB image from the VBIOS that was loaded for early pre-os boot. Signed-off-by: Aurabindo P

[PATCH 13/13] drm/amd/display: Enable copying of bounding box data from VBIOS DMUB

Allocate some memory, send the address in chunks to dmub, and finally ask it to copy the bounding box data into the newly allocated memory. Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 121 ++ .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

[PATCH 12/13] drm/amd/display: Add new GPINT command definitions

New commands for enabling copy of DC bounding box values from VBIOS DMUB Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm

[PATCH 08/13] drm/amd/display: Remove incorrect FP context start

All the DC_FP_START/END should be used before call anything from DML2, for this reason, the use of those guards inside DML it is not correct. This commit removes two unnecessary DC_FP_START/END from a dml2 function. Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai --- drivers/gpu

[PATCH 09/13] drm/amd/display: Fix null pointer dereference for dcn401

When ODM slice happens on DCN401, there is a null pointer exception caused by that. This commit address this issue by checking if the required data structures are initialized. Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c

[PATCH 07/13] drm/amd/display: Use DCN 410 includes for DCN401

DCN401 is using DCN 320 headers, which does not have all the right registers for DCN401. This commit just replace DCN320 includes with the one from DCN410. Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/irq/dcn401/irq_service_dcn401.c| 4

[PATCH 06/13] drm/amd/display: Remove unnecessary HPD entry for DCN401

Drop the extra HPD irq entry for DCN401. Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/irq/dcn401/irq_service_dcn401.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn401/irq_service_dcn401.c b

[PATCH 04/13] drm/amd/display: Refactor HUBP into component folder.

From: Pinninti [why] cleaning up the code refactor requires hubp to be in its own component. [how] move all files under newly created hubp folder and fixing the makefiles. Reviewed-by: Rodrigo Siqueira Signed-off-by: Pinninti --- drivers/gpu/drm/amd/display/dc/dcn401/Makefile | 1 -

[PATCH 03/13] drm/amd/display: Remove unused code

From: Rodrigo Siqueira This commit removes some unused code with the required adjustments. Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dc.h | 1 - drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp.h | 2 +- drivers/gpu/drm/amd/display/dc/d

[PATCH 02/13] drm/amd/display: Enable ISHARP support for DCN401

From: Samson Tam [Why] Enable sharpener support for DCN401 [How] - Removed memcmp check that was preventing ISHARP from being enabled. - Add missing ISHARP register defines, masks, and writes. - Add programming of Blur and Scale coefficients. - Program FMT_MODE and NLDELTA registers based on LLS

[PATCH 01/13] drm/amd/display: Fix incorrect cursor position for dcn401

From: "Arvindekar, Sridevi" [Why] Incorrect cursor position calculation in some scenarios. Also for mirror and rotation cases. [How] Fix for incorrect cursor position. Added new test scenarios for diags cursor test. Updated CRC for few of the diags cursor test scenarios. Reviewed-by: Rodrigo

Re: [PATCH 23/24] drm/amd/display: Fix POWERPC_64 compilation

Reviewed-by: Aurabindo Pillai On 5/16/24 3:26 PM, roman...@amd.com wrote: From: Roman Li [Why] Compilation errors while compiling without CONFIG_DRM_AMD_DC_FP: "undefined reference to `dc_bandwidth_in_kbps_from_timing'" [How] Fix Makefile to move dsc files out of DC_F

Re: [PATCH] drm/amd/display: Remove redundant NULL check in dce110_set_input_transfer_func

Reviewed-by: Aurabindo Pillai On 4/23/24 9:29 PM, Srinivasan Shanmugam wrote: This commit removes a redundant NULL check in the `dce110_set_input_transfer_func` function in the `dce110_hwseq.c` file. The variable `tf` is assigned the address of `plane_state->in_transfer_func` unconditiona

[PATCH v2 1/2] drm/amd/display: Enable DCN410 init

Enable initializing Display Manager for DCN410 IP Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index

[PATCH v2 2/2] drm/amd/display: Override DCN410 IP version

Override DCN IP version to 4.0.1 from 4.1.0 temporarily until change is made in DC codebase to use 4.1.0 Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b

[PATCH] drm/amd/display: Override DCN410 IP version

Override DCN IP version to 4.0.1 from 4.1.0 temporarily until change is made in DC codebase to use 4.1.0 Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b

Re: [PATCH] drm/amd/display: re-indent dpp401_dscl_program_isharp()

Patch has been merged to amd-staging-drm-next. On 4/28/24 12:09 PM, Aurabindo Pillai wrote: Thanks for the fix! Reviewed-by: Aurabindo Pillai On 4/28/24 8:42 AM, Dan Carpenter wrote: Smatch complains because some lines are indented more than they should be.  I went a bit crazy re-indenting

Re: [PATCH] drm/amd/display: re-indent dpp401_dscl_program_isharp()

Thanks for the fix! Reviewed-by: Aurabindo Pillai On 4/28/24 8:42 AM, Dan Carpenter wrote: Smatch complains because some lines are indented more than they should be. I went a bit crazy re-indenting this. ;) The comments were not useful except as a marker of things which are left to

[PATCH 37/37] drm/amd/display: 3.2.282

From: Aric Cyr Summary: * Changes across DSC, MST, DMCUB, Panel Replay and misc fixes. * Fixes to cursor programming sequence * Add some missing register defs * Formatting/Sytle fixes Acked-by: Aurabindo Pillai Signed-off-by: Aric Cyr Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd

[PATCH 36/37] drm/amd/display: [FW Promotion] Release 0.0.214.0

From: Anthony Koo - Adjust the dmub_fw_boot_options reserved bits to be correct Acked-by: Aurabindo Pillai Signed-off-by: Anthony Koo Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 35/37] drm/amd/display: Replace uint8_t with u8 for dp_hdmi_dongle_signature_str

From: Rodrigo Siqueira The string dp_hdmi_dongle_signature_str already uses u8 but the string dp_hdmi_dongle_signature_str does not. Just replace uint8_t with u8 for dp_hdmi_dongle_signature_str. Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: Rodrigo Siqueira Tested-by

[PATCH 33/37] drm/amd/display: Keep VBios pixel rate div setting util next mode set

mode set. Reviewed-by: Jun Lei Acked-by: Aurabindo Pillai Signed-off-by: yi-lchen Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 4 ++ .../drm/amd/display/dc/dcn314/dcn314_dccg.c | 12 ++--- .../gpu/drm/amd/display/dc/dcn32/dcn32_dccg.c | 13 +++--- .../

[PATCH 34/37] drm/amd/display: Update dcn351 debug flags and function pointers

From: Sung Joon Kim [why & how] There are potential issues with Z8 and IPS that need to be addressed and need to add in missing function pointers. Reviewed-by: Nicholas Kazlauskas Acked-by: Aurabindo Pillai Signed-off-by: Sung Joon Kim Tested-by: Daniel Wheeler --- drivers/gpu/drm

[PATCH 32/37] drm/amd/display: Disable error correction if it's not supported

From: Cruise [Why] Error correction was enabled in a monitor which doesn't support. [How] Disable error correction if it's not supported Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: Cruise Tested-by: Daniel Wheeler --- .../display/dc/link/protocols/lin

[PATCH 31/37] drm/amd/display: Fix recout calculation for stereo side-by-side

From: Sung Joon Kim [why & how] The recout x offset was incorrect which led to wrong viewport calculation. For stereo side-by-side case, the slice index should be 0 for both split pipes. Reviewed-by: Dmytro Laktyushkin Acked-by: Aurabindo Pillai Signed-off-by: Sung Joon Kim Tested-by: Da

[PATCH 30/37] drm/amd/display: Set cursor attributes before position

s first to ensure hubp has the right attributes to be programmed. Reviewed-by: Agustin Gutierrez Acked-by: Aurabindo Pillai Signed-off-by: Harry Wentland Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 2 +- drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_h

[PATCH 29/37] drm/amd/display: Separate setting and programming of cursor

ommits. Reviewed-by: Agustin Gutierrez Acked-by: Aurabindo Pillai Signed-off-by: Harry Wentland Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 6 +- .../gpu/drm/amd/display/dc/core/dc_stream.c | 87

[PATCH 28/37] Revert "drm/amd/display: Fix incorrect pointer assignment"

-by: Chaitanya Dhere Acked-by: Aurabindo Pillai Signed-off-by: Joshua Aberback Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/core/dc_state.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_state.c b/drivers

  1   2   3   4   5   6   7   >