Re: [PATCH] drm/amdgpu: add the checking to avoid NULL pointer dereference

2018-11-26 Thread Deepak Sharma
if fence was already >> signaled but need to handle case so avoid kernel panic. Seems David patch >> should fix this, I will test it tomorrow. >> >> Mhm, but don't we bail out with an error if we ask for a failed command >> submission? If not that sounds like a bug as well. >> >

Re: drm/amdgpu: Add helper function to get buffer domain

2018-05-25 Thread Deepak Sharma
If look fine , please give rb for this and https://patchwork.freedesktop.org/patch/224850/ Thanks, Deepak On 05/25/2018 05:12 PM, Deepak Sharma wrote: Move logic of getting supported domain to a helper function Signed-off-by: Deepak Sharma <deepak.sha...@amd.com> --- drivers/gpu/d

drm/amdgpu: Add helper function to get buffer domain

2018-05-25 Thread Deepak Sharma
Move logic of getting supported domain to a helper function Signed-off-by: Deepak Sharma <deepak.sha...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c| 10 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 17 - drivers/gpu/drm/amd/amdgpu/amdgpu_object.

drm/amdgpu: Add helper function to get buffer domain

2018-05-24 Thread Deepak Sharma
Move logic of getting supported domain to a helper function Signed-off-by: Deepak Sharma <deepak.sha...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c| 10 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 16 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2

Re: drm/amdgpu: Use GTT for dumb buffer if sg display enabled (v2)

2018-05-23 Thread Deepak Sharma
On 05/23/2018 12:31 AM, Christian König wrote: Am 23.05.2018 um 00:31 schrieb Deepak Sharma: When vram size <= THRESHOLD(256M) lets use GTT for dumb buffer allocation. As SG will be enabled with vram size <= 256M scan out will not be an issue. v2: Use amdgpu_display_supported_domains

drm/amdgpu: Use GTT for dumb buffer if sg display enabled (v2)

2018-05-22 Thread Deepak Sharma
When vram size <= THRESHOLD(256M) lets use GTT for dumb buffer allocation. As SG will be enabled with vram size <= 256M scan out will not be an issue. v2: Use amdgpu_display_supported_domains to get supported domain. Signed-off-by: Deepak Sharma <deepak.sha...@amd.com> --- drivers

Re: [PATCH 1/1] drm/amdgpu: Use GTT for dumb buffer if sg display enabled

2018-05-22 Thread Deepak Sharma
On 05/22/2018 05:12 AM, Christian König wrote: [SNIP] If the BO is moved from VRAM to VRAM (to make it linear) or from VRAM to GTT for scanout doesn't really matter. Not sure what you mean. Dumb BOs are only used for CPU access and scanout, and should be created accordingly. Well what I

[PATCH 1/1] drm/amdgpu: Use GTT for dumb buffer if sg display enabled

2018-05-21 Thread Deepak Sharma
When vram size <= THRESHOLD(256M) lets use GTT for dumb buffer allocation. As SG will be enabled with vram size <= 256M scan out will not be an issue. Signed-off-by: Deepak Sharma <deepak.sha...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 7 +-- 1 file changed, 5 inse