Re: [PATCH 27/57] drm/amdgpu: Add vega20 soc init sequence on emulator (v3)

On Wed, May 16, 2018 at 2:11 PM, Grazvydas Ignotas <nota...@gmail.com> wrote: > On Tue, May 15, 2018 at 5:59 PM, Alex Deucher <alexdeuc...@gmail.com> wrote: >> From: Shaoyun Liu <shaoyun@amd.com> >> >> v2: cleanups (Alex) >> v3: make it vega20

Re: [PATCH 27/57] drm/amdgpu: Add vega20 soc init sequence on emulator (v3)

On Tue, May 15, 2018 at 5:59 PM, Alex Deucher wrote: > From: Shaoyun Liu > > v2: cleanups (Alex) > v3: make it vega20 only (Alex) > > Signed-off-by: Shaoyun Liu > Acked-by: Alex Deucher > Signed-off-by:

Re: [PATCH 29/57] drm/amdgpu: Add vega20 to dc support check

On Tue, May 15, 2018 at 5:59 PM, Alex Deucher wrote: > From: Feifei Xu > > Signed-off-by: Feifei Xu > Reviewed-by: Alex Deucher > Reviewed-by: Hawking Zhang > Signed-off-by: Alex

Re: [PATCH 30/57] drm/amd: Add dce-12.1 gpio aux registers

On Tue, May 15, 2018 at 5:59 PM, Alex Deucher wrote: > From: Roman Li > > Updating dce12 register headers by adding dc registers > required for potential DP LTTPR support. > > Signed-off-by: Roman Li > Acked-by: Alex Deucher

Re: [PATCH 1/8] drm/amd/pp: Add a new pp feature mask bit for OD feature

On Tue, Jan 16, 2018 at 2:02 PM, Rex Zhu wrote: > when this bit was set on module load, > driver will allow the user over/under gpu > clock and voltage through sysfs. > > by default, this bit was not set. > > Reviewed-by: Alex Deucher > Signed-off-by:

Re: [PATCH 2/2] drm/amd/pp: Add custom power profile mode support on Vega10

On Wed, Jan 10, 2018 at 1:01 PM, Rex Zhu wrote: > Change-Id: I0a554cb6a7a56db63a8fc5af60d5c63f65e021d1 > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 39 +++ > drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c |

Re: [PATCH 1/2] drm/amdgpu: use irq-safe lock for kiq->ring_lock

On Tue, Nov 7, 2017 at 9:26 AM, Pixel Ding wrote: > From: pding > > ... > > Signed-off-by: pding You need to fix your git config user.name. Gražvydas ___ amd-gfx mailing list

Re: [PATCH 3/3] drm/amdgpu/radeon: Use radeon by default for CIK GPUs

On Tue, May 30, 2017 at 6:30 AM, Michel Dänzer wrote: > On 29/05/17 06:20 PM, Michel Dänzer wrote: >> From: Michel Dänzer >> >> Even if CONFIG_DRM_AMDGPU_CIK is enabled. >> >> There is no feature parity yet for CIK, in particular amdgpu doesn't >>

Re: [PATCH libdrm v2 1/1] amdgpu: move asic id table to a separate file

to print out the ids file version. Libraries can't print to stdout as it will break all programs that parse the output, apitrace is one such example. > > Thanks, > Sam > > -Original Message- > From: Grazvydas Ignotas [mailto:nota...@gmail.com] > Sent: Friday

Re: [PATCH libdrm v2 1/1] amdgpu: move asic id table to a separate file

On Fri, May 12, 2017 at 12:19 AM, Samuel Li wrote: > From: Xiaojie Yuan > > v2: fix an off by one error and leading white spaces > > Change-Id: I12216da14910f5e2b0970bc1fafc2a20b0ef1ba9 > Reviewed-by: Junwei Zhang > Signed-off-by:

Re: [PATCH 3/3] drm/amdgpu: fix to clear ASIC INIT COMPLETE bit on resuming phase

On Mon, Apr 10, 2017 at 12:37 PM, Huang Rui wrote: > ASIC_INIT_COMPLETE bit must be cleared during S3 resuming phase, > because VBIOS will check the bit to decide if execute ASIC_Init > posting via kernel driver. > > Signed-off-by: Huang Rui > --- >

Re: [PATCH] drm/amdgpu: allow shifts >= 32 in AMDGPU_TILING_SET/GET

On Tue, Mar 21, 2017 at 9:44 PM, Marek Olšák wrote: > From: Marek Olšák > > also adjust the comments > > Signed-off-by: Marek Olšák > --- > include/uapi/drm/amdgpu_drm.h | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-)

[PATCH libdrm 2/3] amdgpu: vamgr_32 can be a struct instead of a pointer

From: Alex Xie <alexbin@amd.com> vamgr_32 is an integral part of amdgpu_device. We don't need to calloc and free it. This can save CPU time, reduce heap fragmentation. Signed-off-by: Alex Xie <alexbin@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com>

[PATCH libdrm 3/3] amdgpu: vamgr can be a struct instead of a pointer

From: Alex Xie <alexbin@amd.com> vamgr is an integral part of amdgpu_device. We don't need to calloc and free it. This can save CPU time, reduce heap fragmentation. Signed-off-by: Alex Xie <alexbin@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com>

[PATCH libdrm 2/3] amdgpu: vamgr_32 can be a struct instead of a pointer

From: Alex Xie <alexbin@amd.com> vamgr_32 is an integral part of amdgpu_device. We don't need to calloc and free it. This can save CPU time, reduce heap fragmentation. Signed-off-by: Alex Xie <alexbin@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com>

[PATCH libdrm 1/3] amdgpu: Free/uninit vamgr_32 in theoretically correct order

From: Alex Xie vamgr_32 is a region inside general VAM range. It is better to free and deinitialize it before general VAM range. Signed-off-by: Alex Xie Reviewed-by: Christian König --- amdgpu/amdgpu_device.c | 4 ++-- 1

[PATCH libdrm 0/3] some -pro patches for integration

I've taken several patches from amdgpu-pro libdrm that look useful to me and I think can be applied already. The only things I did was rebasing, fixing some typos and dropping Change-Id. Alex Xie (3): amdgpu: Free/uninit vamgr_32 in theoretically correct order amdgpu: vamgr can be a struct

Re: [PATCH] drm/amdgpu:guarantee 128dws between vm flush and IB(v3)

On Thu, Jan 19, 2017 at 4:32 PM, Christian König <deathsim...@vodafone.de> wrote: > Am 19.01.2017 um 14:51 schrieb Grazvydas Ignotas: >> >> On Thu, Jan 19, 2017 at 11:10 AM, Christian König >> <deathsim...@vodafone.de> wrote: >>> >>> Am 18.01.2

Re: [PATCH] drm/amdgpu:guarantee 128dws between vm flush and IB(v3)

On Thu, Jan 19, 2017 at 11:10 AM, Christian König wrote: > Am 18.01.2017 um 12:42 schrieb Monk Liu: >> @@ -6743,6 +6741,15 @@ static void gfx_v8_ring_emit_cntxcntl(struct >> amdgpu_ring *ring, uint32_t flags) >> if (amdgpu_sriov_vf(ring->adev)) >>

Re: [PATCH 1/1] drm/amd/amdgpu: get maximum and used UVD handles (v3)

On Thu, Dec 15, 2016 at 4:12 PM, Christian König wrote: > > Regarding which error code to return I think that Emil has the right idea > here. > > Returning -EINVAL usually means that userspace provided an invalid value, > but in this case it doesn't matter which value the

Re: [PATCH 1/1] drm/amd/amdgpu: get maximum and used UVD handles (v3)

On Thu, Dec 15, 2016 at 1:47 PM, Nath, Arindam wrote: >>-Original Message- >>From: Emil Velikov [mailto:emil.l.veli...@gmail.com] >>Sent: Thursday, December 15, 2016 5:01 PM >>To: Nath, Arindam >>Cc: David Airlie; Deucher, Alexander; amd-gfx mailing list; ML

Re: [PATCH 1/7] drm/amdgpu/powerplay: pp module only enable smu when dpm disabled.

On Wed, Nov 2, 2016 at 12:27 PM, Rex Zhu wrote: > Change-Id: I3288a5a4bbca122d59b81e7635be5e5aeda8abeb > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_powerplay.c | 6 +-- > drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 51 >

Re: [PATCH 1/2] drm/amd/powerplay: export a function to read fan rpm

Hi, On Sun, Oct 30, 2016 at 7:10 AM, Edward O'Callaghan <funfunc...@folklore1984.net> wrote: > Howdy, > > On 10/30/2016 07:28 AM, Grazvydas Ignotas wrote: >> Powerplay hwmgr already has an implementation, all we need to do is to call >> it. >> >>

[PATCH] drm/amd/powerplay: don't succeed in getters if fan is missing

Otherwise callers end up using uninitialized data. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c b/d

[PATCH 2/2] drm/amd/amdgpu: expose fan rpm though hwmon

Only for cards that are supported by powerplay. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 21 + 2 files changed, 26 insertions(+) diff --git a/drivers/gpu/d

[PATCH 1/2] drm/amd/powerplay: export a function to read fan rpm

Powerplay hwmgr already has an implementation, all we need to do is to call it. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 18 ++ drivers/gpu/drm/amd/powerplay/inc/amd_powerplay.h | 1 + 2 files chang

Re: [PATCH] drm/amd: fix scheduler fence teardown order

SLUB allocator. > > Fix this by allocating/freeing the SLUB allocator from the module > init/finfi functions just like we do it for hw fences. > > Reported-by: Grazvydas Ignotas <nota...@gmail.com> > Signed-off-by: Christian König <christian.koe...@amd.com> > --- ... > dif

Re: 答复: [PATCH] drm/amdgpu: fix fence slab teardown

On Mon, Oct 24, 2016 at 6:35 AM, Qu, Jim wrote: > I did observed the issue when replace kernel module use DKMS, and it maybe > get error at reboot, got calltrace: > > [ 3529.525360] > = > [ 3529.525361]

[PATCH] drm/amdgpu: update kernel-doc for some functions

The names were wrong. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- drivers/gpu/drm/amd/scheduler/sched_fence.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/scheduler/sched_fence.c b/drivers/gpu/drm/amd/scheduler/sched_fence.c

[PATCH] drm/amdgpu: fix sched fence slab teardown

get a crash in one of rcu threads because callback is called after amdgpu has already been unloaded. Fix it with a rcu_barrier(). Fixes: 189e0fb76304 ("drm/amdgpu: RCU protected amd_sched_fence_release") Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- drivers/gpu/d

[PATCH] drm/amdgpu: fix a vm_flush fence leak

Looks like .last_flush reference is left at teardown. Leak reported by CONFIG_SLUB_DEBUG. Fixes: 41d9eb2c5a2a ("drm/amdgpu: add a fence after the VM flush") Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 in

[PATCH] drm/amdgpu: fix fence slab teardown

a crash in one of rcu threads because callback is called after amdgpu has already been unloaded. Fix it with a rcu_barrier(). Fixes: b44135351a3a ("drm/amdgpu: RCU protected amdgpu_fence_release") Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- drivers/gpu/drm/amd/amdgp

[PATCH] drm/amdgpu: release parent fence reference

It's done in amd_sched_hw_job_reset(), but not in normal job processing. Leak reported by CONFIG_SLUB_DEBUG. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- CONFIG_SLUB_DEBUG reports more leaks related to ioctls, but I was unable to track them down... drivers/gpu/drm/amd/sch

Re: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

Hi, On Thu, Oct 13, 2016 at 10:45 AM, Zhu, Rex wrote: > > The attached patches were also for this issue. > Disable dpm when rmmod amdgpu. It works for modprobe-rmmod-modprobe test, thanks. However with GPU passthrough (giving control of the GPU to a Windows virtual machine

Re: [PATCH 4/4] drm/amdgpu: used cached gca values for vi_read_register

On Wed, Oct 12, 2016 at 2:48 AM, Andy Furniss wrote: > > I still can't shutdown/reboot > as in https://bugs.freedesktop.org/show_bug.cgi?id=98200 > which is fixed for radeon, but apparently not (for me at least) with amdgpu. You probably need a951ed85abd46 that went to

Re: [PATCH 1/7] drm/amdgpu: remove adev pointer from struct amdgpu_bo

On Thu, Sep 29, 2016 at 10:52 AM, Christian König wrote: > From: Christian König > > It's completely pointsless to have two pointers to the > device in the same structur. Several typos here... Gražvydas

Re: [PATCH 4/9] drm/amdgpu:keep bo pinned in prefered domain

Hi, this patch causes failure on my polaris10 card: [drm:gfx_v8_0_ring_test_ring] *ERROR* amdgpu: ring 0 test failed (scratch(0xC040)=0xCAFEDEAD) [drm:amdgpu_init] *ERROR* hw_init of IP block failed -22 amdgpu :01:00.0: amdgpu_init failed Gražvydas On Wed, Sep 28, 2016 at 11:36 AM, Monk

[PATCH] drm/amdgpu/dce11: add missing drm_mode_config_cleanup call

All other amdgpu/dce_v* files have this call, it's only mysteriously missing from dce_v11_0.c since the file was added and causes leaks. Fixes: aaa36a976bbb ("drm/amdgpu: Add initial VI support") Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- drivers/gpu/drm/amd/amdgpu

[PATCH] drm/amdgpu: warn if dp aux is still attached on free

it and warn early. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 4 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c| 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/d

[PATCH] drm/amdgpu: also track late init state

Successful sw_init() and hw_init() states are tracked, but not late_init(). Various error paths may result in amdgpu_fini() being called before .late init is done, so late_init needs to be tracked to avoid unexpected or multiple .late_fini() calls. Signed-off-by: Grazvydas Ignotas <n

Re: [PATCH] drm/amdgpu: disable CRTCs before teardown

On Mon, Sep 26, 2016 at 8:29 PM, Lukas Wunner <lu...@wunner.de> wrote: > On Sun, Sep 25, 2016 at 11:34:48PM +0300, Grazvydas Ignotas wrote: >> Some code called by drm_crtc_force_disable_all() wants to wait for all >> fences, so only do fence teardown after CRTCs are d

[PATCH] drm/amdgpu/i2c: add const where appropriate

Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 14 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.h | 14 +++--- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/d

[PATCH] drm/amdgpu/vce3: don't forget to tear down some rings

We can use .num_rings for that. Fixes: 6f0359ff7307 ("vce3: add support for third vce ring") Cc: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 6 -- 1 file changed, 4 inse

[PATCH] drm/amdgpu: don't leave dangling pointers around

r to clear them and get NULL dereference so that it's obvious what's going wrong. Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 1 + 2 files changed, 3 insertions(+) diff --git a/dri