Re: [PATCH] drm/amd/display: add debugfs entry for trigger_hotplug

ping... 在 2020/9/12 10:22, Jason Yan 写道: The 'trigger_hotplug' entry in debugfs is defined but not wired up. This causes a gcc warning build with W=1. drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:2045:37: warning: ‘dp_trigger_hotplug_debugfs_fops’ defined but not used

[PATCH] drm/amd/display: make get_color_space_type() static

This addresses the following sparse warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:180:26: warning: symbol 'get_color_space_type' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/display/dc/core

[PATCH] drm/amd/display: make two symbols static

: symbol 'dce110_set_cursor_attribute' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce110

[PATCH] drm/amd/display: add debugfs entry for trigger_hotplug

const struct file_operations dp_trigger_hotplug_debugfs_fops = { | ^~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd

[PATCH] drm/amd/amdgpu: remove defined but not used 'crtc_offsets'

Fix the following gcc warning: drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:65:18: warning: ‘crtc_offsets’ defined but not used [-Wunused-const-variable=] static const u32 crtc_offsets[6] = ^~~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/gpu/drm/amd

[PATCH] drm/amd/display: remove variable "result" in dcn20_patch_unknown_plane_state()

Fix the following coccicheck warning: drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c:3216:16-22: Unneeded variable: "result". Return "DC_OK" on line 3229 Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 4 +--- 1 file change

[PATCH] drm/amd/display: remove unused variable 'ret' in dm_suspend()

Fix the following coccicheck warning: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:1574:5-8: Unneeded variable: "ret". Return "0" on line 1586 Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- 1 file changed, 1 insertion(+), 2 dele

[PATCH] drm/amdgpu/smu10: remove duplicate assignment of smu10_hwmgr_funcs members

: drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c:1357:52-53: asic_setup: first occurrence line 1360, second occurrence line 1388 Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr

[PATCH] drm/amd/display: remove duplicate assignment of dcn21_funcs members

/display/dc/dcn21/dcn21_init.c:31:51-52: set_cursor_sdr_white_level: first occurrence line 72, second occurrence line 90 Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/display/dc/dcn21/dcn21_init.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn21

[PATCH] drm/amdgpu: remove conversion to bool in amdgpu_device.c

The '>' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:3004:68-73: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH] drm/amd/display: remove conversion to bool in dcn20_mpc.c

The '==' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning: drivers/gpu/drm/amd/display/dc/dcn20/dcn20_mpc.c:455:70-75: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/display/dc/dcn20

[PATCH] drm/amd/display: remove conversion to bool in dc_link_ddc.c

The '>' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning: drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c:602:28-33: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/display/dc/c

[PATCH] drm/amd/display: remove conversion to bool amdgpu_dm.c

The '==' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:7230:16-21: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/display/amdgpu_dm

[PATCH] drm/amd/powerplay: remove conversion to bool in navi10_ppt.c

The '==' expression itself is bool, no need to convert it to bool again. This fixes the following coccicheck warning: drivers/gpu/drm/amd/powerplay/navi10_ppt.c:698:47-52: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 2

[PATCH] drm/amd/display: remove unneeded conversion to bool

: conversion to bool not needed here Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp_cm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp_cm.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp_cm.c

[PATCH] drm/amd/powerplay: remove defined but not used variables

Robot Signed-off-by: Jason Yan --- .../amd/powerplay/hwmgr/vega10_powertune.c| 23 --- 1 file changed, 23 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_powertune.c index ca9b23b5abc9..9757d47dd6b8

[PATCH] drm/radeon: remove defined but not used variables in ci_dpm.c

:36: warning: ‘defaults_bonaire_pro’ defined but not used [-Wunused-const-variable=] static const struct ci_pt_defaults defaults_bonaire_pro = ^~~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/gpu/drm/radeon/ci_dpm.c | 14

[PATCH] drm/radeon: remove defined but not used 'dte_data_tahiti_le'

Fix the following gcc warning: drivers/gpu/drm/radeon/si_dpm.c:255:33: warning: ‘dte_data_tahiti_le’ defined but not used [-Wunused-const-variable=] static const struct si_dte_data dte_data_tahiti_le = Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/gpu/drm/radeon/si_dpm.c | 18

[PATCH] drm/amdgpu: remove dead code in si_dpm.c

This code is dead, let's remove it. Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/amdgpu/si_dpm.c | 20 1 file changed, 20 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si_dpm.c b/drivers/gpu/drm/amd/amdgpu/si_dpm.c index 0860e85a2d35

[PATCH] drm/amd/display: code clean up in dce80_hw_sequencer.c

[] = { ^~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- .../amd/display/dc/dce80/dce80_hw_sequencer.c | 28 --- 1 file changed, 28 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce80/dce80_hw_sequencer.c