Re: [PATCH] drm/amdgpu: fix i2s_pdata out of bound array access

2022-07-27 Thread Mukunda,Vijendar
On 7/27/22 8:25 PM, Alex Deucher wrote: > On Wed, Jul 27, 2022 at 10:42 AM Vijendar Mukunda > wrote: >> >> Fixed following Smatch static checker warning: >> >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:393 acp_hw_init() >> error: buffer overflow 'i2s_pdata' 3 <= 3 >>

Re: [bug report] drm/amdgpu: create I2S platform devices for Jadeite platform

2022-07-27 Thread Mukunda,Vijendar
On 7/26/22 8:47 PM, Dan Carpenter wrote: > Hello Vijendar Mukunda, > > The patch 4c33e5179ff1: "drm/amdgpu: create I2S platform devices for > Jadeite platform" from Jun 30, 2022, leads to the following Smatch > static checker warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:393

Re: [PATCH RESEND V2 1/3] drm/amdgpu: fix checkpatch warnings

2022-07-05 Thread Mukunda,Vijendar
On 7/5/22 4:51 PM, Christian König wrote: > > > Am 04.07.22 um 15:54 schrieb Vijendar Mukunda: >> From: vijendar >> >> Fixed below checkpatch warnings and errors >> >> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:131: CHECK: Comparison to NULL >> could be written "apd" >>

Re: [PATCH V2 0/5] I2S driver changes for Jadeite platform

2022-07-01 Thread Mukunda,Vijendar
On 7/1/22 5:21 PM, Mark Brown wrote: > On Fri, Jul 01, 2022 at 05:11:02PM +0530, Vijendar Mukunda wrote: > >> This patch set depends on: >> --checkpatch warnings patch >> >> --https://patchwork.kernel.org/project/alsa-devel/patch/20220627125834.481731-1-vijendar.muku...@amd.com/ >

Re: [PATCH 4/5] ASoC: amd: add Machine driver for Jadeite platform

2022-06-30 Thread Mukunda,Vijendar
On 6/30/22 4:40 PM, Mark Brown wrote: > On Thu, Jun 30, 2022 at 08:47:54AM +0530, Vijendar Mukunda wrote: > >> +static int st_es8336_hw_params(struct snd_pcm_substream *substream, >> + struct snd_pcm_hw_params *params) >> +{ >> +int ret = 0; >> +struct

Re: [PATCH 5/5] ASoC: amd: enable machine driver build for Jadeite platform

2022-06-30 Thread Mukunda,Vijendar
On 6/30/22 4:41 PM, Mark Brown wrote: > On Thu, Jun 30, 2022 at 08:47:55AM +0530, Vijendar Mukunda wrote: > >> +depends on SND_SOC_AMD_ACP && I2C && ACPI > > The code treated ACPI as optional so you could relax the ACPI dependency > ot be "ACPI || COMPILE_TEST" (I think the same applies to

Re: [PATCH] drm/amdgpu/acp: Fix slab-out-of-bounds in mfd_add_device in acp_hw_init

2018-07-04 Thread Mukunda,Vijendar
On Tuesday 03 July 2018 09:50 PM, Alex Deucher wrote: On Mon, Jul 2, 2018 at 5:48 PM, Daniel Kurtz wrote: Hi Alex, On Sun, Apr 15, 2018 at 9:48 PM Agrawal, Akshu wrote: On 4/13/2018 9:45 PM, Daniel Kurtz wrote: Commit 51f7415039d4 ("drm/amd/amdgpu: creating two I2S instances for

Re: [PATCH 1/3] ASoC: amd: Report accurate hw_ptr during dma

2017-11-07 Thread Mukunda,Vijendar
Removing URL links and commit-ready description in v2. On Monday 06 November 2017 09:18 PM, Mark Brown wrote: On Fri, Nov 03, 2017 at 04:35:43PM -0400, Alex Deucher wrote: Signed-off-by: Vijendar Mukunda Signed-off-by: Akshu Agrawal

RE: [PATCH 4/8] ASoC: AMD: added condition checks for CZ specific code

2017-06-29 Thread Mukunda, Vijendar
-Original Message- From: Mark Brown [mailto:broo...@kernel.org] Sent: Wednesday, June 28, 2017 11:36 PM To: Alex Deucher Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; alsa-de...@alsa-project.org; airl...@gmail.com; Mukunda, Vijendar; rajeevkumar.li...@gmail.com