Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-18 Thread Sebastian Wick
On Wed, Jan 17, 2024 at 12:58:15PM +, Andri Yngvason wrote: > mið., 17. jan. 2024 kl. 09:21 skrifaði Pekka Paalanen : > > > > On Tue, 16 Jan 2024 14:11:43 + > > Andri Yngvason wrote: > > > > > þri., 16. jan. 2024 kl. 13:29 skrifaði Sebastian Wick &g

Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-16 Thread Sebastian Wick
On Tue, Jan 16, 2024 at 01:13:13PM +, Andri Yngvason wrote: > Hi Sebastian, > > þri., 16. jan. 2024 kl. 11:42 skrifaði Sebastian Wick > : > > > > On Mon, Jan 15, 2024 at 04:05:52PM +, Andri Yngvason wrote: > > > From: Werner Sembach > > > > &g

Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-16 Thread Sebastian Wick
On Mon, Jan 15, 2024 at 04:05:52PM +, Andri Yngvason wrote: > From: Werner Sembach > > Add a new general drm property "force color format" which can be used > by userspace to tell the graphics driver which color format to use. I don't like the "force" in the name. This just selects the

Re: [PATCH 2/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

2024-01-15 Thread Sebastian Wick
On Thu, Jan 11, 2024 at 05:17:46PM +, Andri Yngvason wrote: > mið., 10. jan. 2024 kl. 13:26 skrifaði Daniel Stone : > > > > > > This thing here works entirely differently, and I think we need somewhat > > > new semantics for this: > > > > > > - I agree it should be read-only for userspace, so

Re: [PATCH v4 00/32] drm/amd/display: add AMD driver-specific properties for color mgmt

2023-10-06 Thread Sebastian Wick
On Thu, Oct 05, 2023 at 04:14:55PM -0100, Melissa Wen wrote: > Hello, > > Just another iteration for AMD driver-specific color properties. > Basically, addressing comments from the previous version. > > Recap: this series extends the current KMS color management API with AMD > driver-specific

Re: [PATCH v4 09/32] drm/amd/display: add plane 3D LUT driver-specific properties

2023-10-06 Thread Sebastian Wick
On Thu, Oct 05, 2023 at 04:15:04PM -0100, Melissa Wen wrote: > Add 3D LUT property for plane color transformations using a 3D lookup > table. 3D LUT allows for highly accurate and complex color > transformations and is suitable to adjust the balance between color > channels. It's also more complex

Re: [PATCH v7] drm/doc: Document DRM device reset expectations

2023-08-22 Thread Sebastian Wick
missions. > +This error code means, among other things, that a device reset has happened > and > +it needs to recreate the contexts to keep going. > + > +Reporting causes of resets > +-- > + > +Apart from propagating the reset through the st

Re: [PATCH v6 5/6] drm: Refuse to async flip with atomic prop changes

2023-08-22 Thread Sebastian Wick
On Tue, Aug 15, 2023 at 03:57:09PM -0300, André Almeida wrote: > Given that prop changes may lead to modesetting, which would defeat the > fast path of the async flip, refuse any atomic prop change for async > flips in atomic API. The only exceptions are the framebuffer ID to flip > to and the

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-08-08 Thread Sebastian Wick
On Fri, Aug 4, 2023 at 3:03 PM Daniel Vetter wrote: > > On Tue, Jun 27, 2023 at 10:23:23AM -0300, André Almeida wrote: > > Create a section that specifies how to deal with DRM device resets for > > kernel and userspace drivers. > > > > Acked-by: Pekka Paalanen > > Signed-off-by: André Almeida >

Re: [PATCH v4 1/6] drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits

2023-07-04 Thread Sebastian Wick
On Sat, Jul 1, 2023 at 4:09 AM André Almeida wrote: > > From: Simon Ser > > If the driver supports it, allow user-space to supply the > DRM_MODE_PAGE_FLIP_ASYNC flag to request an async page-flip. > Set drm_crtc_state.async_flip accordingly. > > Document that drivers will reject atomic commits

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-30 Thread Sebastian Wick
On Fri, Jun 30, 2023 at 4:59 PM Alex Deucher wrote: > > On Fri, Jun 30, 2023 at 10:49 AM Sebastian Wick > wrote: > > > > On Tue, Jun 27, 2023 at 3:23 PM André Almeida > > wrote: > > > > > > Create a section that specifies how to deal with DRM

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-30 Thread Sebastian Wick
On Tue, Jun 27, 2023 at 3:23 PM André Almeida wrote: > > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Acked-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > > v4: >

Re: [PATCH 06/36] drm/amd/display: add CRTC driver-specific property for gamma TF

2023-06-06 Thread Sebastian Wick
On Tue, Jun 6, 2023 at 6:19 PM Joshua Ashton wrote: > > > > On 6/1/23 20:17, Harry Wentland wrote: > > > > > > On 5/23/23 18:14, Melissa Wen wrote: > >> Hook up driver-specific atomic operations for managing AMD color > >> properties and create AMD driver-specific color management properties > >>

Re: [PATCH v4 00/13] Enable Colorspace connector property in amdgpu

2023-05-26 Thread Sebastian Wick
With the documentation about RGB and YCC variants added the drm core patches are Reviewed-by: Sebastian Wick On Fri, May 26, 2023 at 6:24 PM Sebastian Wick wrote: > > On Fri, May 26, 2023 at 3:16 PM Pekka Paalanen wrote: > > > > On Thu, 25 May 2023 15:17:56 -0400 > &g

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Sebastian Wick
On Fri, May 26, 2023 at 6:37 PM Simon Ser wrote: > > On Friday, May 26th, 2023 at 18:27, Sebastian Wick > wrote: > > > > + * @DRM_MODE_COLORIMETRY_DEFAULT: > > > + * Driver specific behavior. > > > + * @DRM_MODE_COLORIMETRY_NO_DATA: > > > + * Dri

Re: [PATCH v4 08/13] drm/amd/display: Register Colorspace property for DP and HDMI

2023-05-26 Thread Sebastian Wick
o support with e.g. the appropriate YCC transform when necessary, independent of the sink support. > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ashton > Cc: Simon Ser > Cc: Ville Syrjälä > Cc: Melissa Wen >

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Sebastian Wick
CYCC is "constant luminance" > - correct type for BT.601 > > v4: > - drop DP/HDMI clarifications that might create > more questions than answers > > Signed-off-by: Joshua Ashton > Signed-off-by: Harry Wentland > Reviewed-by: Harry Wentland > > Cc: Pekka

Re: [PATCH v4 00/13] Enable Colorspace connector property in amdgpu

2023-05-26 Thread Sebastian Wick
On Fri, May 26, 2023 at 3:16 PM Pekka Paalanen wrote: > > On Thu, 25 May 2023 15:17:56 -0400 > Harry Wentland wrote: > > > This patchset is based on Joshua's previous patchset [1], as well > > as my previous patchset [2]. > > > > It is > > - enabling support for the colorspace property in

Re: [PATCH v2 00/21] Enable Colorspace connector property in amdgpu

2023-03-21 Thread Sebastian Wick
ctly to the infoframe and reduce the options to sRGB, BT709, > BT601, and BT2020 (and possibly opRGB). > > v2: > - Tested with DP and HDMI analyzers > - Confirmed driver will fallback to lower bpc when needed > - Dropped hunk to set HDMI AVI infoframe as it was a no-op > - Fixed

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Sebastian Wick
On Fri, Mar 17, 2023 at 7:38 PM Ville Syrjälä wrote: > > On Fri, Mar 17, 2023 at 06:40:53PM +0100, Sebastian Wick wrote: > > On Fri, Mar 17, 2023 at 5:34 PM Ville Syrjälä > > wrote: > > > > > > On Fri, Mar 17, 2023 at 05:37:51PM +0200, Pekka Paalanen wrote:

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Sebastian Wick
; > > > On Fri, 17 Mar 2023 14:50:40 +0200 > > > > Ville Syrjälä wrote: > > > > > > > > > On Fri, Mar 17, 2023 at 10:53:35AM +0200, Pekka Paalanen wrote: > > > > > > On Fri, 17 Mar 2023 01:01:38 +0200 > > > >

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-16 Thread Sebastian Wick
; > > > On Thu, 16 Mar 2023 11:50:27 +0200 > > > > Ville Syrjälä wrote: > > > > > > > > > On Thu, Mar 16, 2023 at 01:37:24AM +0100, Sebastian Wick wrote: > > > > > > On Tue, Mar 7, 2023 at 4:12 PM Harry Wentland > > > >

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-15 Thread Sebastian Wick
y the driver. Not great at all. Something to remember for the new property. > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ashton > Cc: dri-de...@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop

Re: [PATCH v3 02/17] drm/connector: Add enum documentation to drm_colorspace

2023-03-09 Thread Sebastian Wick
On Thu, Mar 9, 2023 at 11:03 AM Pekka Paalanen wrote: > > On Thu, 9 Mar 2023 01:56:11 +0100 > Sebastian Wick wrote: > > > On Wed, Mar 8, 2023 at 9:59 AM Pekka Paalanen wrote: > > > > > > On Tue, 7 Mar 2023 10:10:52 -0500 > > > Harry Wentl

Re: [PATCH v3 14/17] drm/amd/display: Add debugfs for testing output colorspace

2023-03-08 Thread Sebastian Wick
hen debugging display > issues. > > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ashton > Cc: dri-de...@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Reviewed-By: Joshua Ashton >

Re: [PATCH v3 11/17] drm/amd/display: Send correct DP colorspace infopacket

2023-03-08 Thread Sebastian Wick
t; Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ashton > Cc: dri-de...@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Reviewed-By: Joshua Ashton > --- > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 38 +++---

Re: [PATCH v3 05/17] drm/connector: Use common colorspace_names array

2023-03-08 Thread Sebastian Wick
Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Uma Shankar > Cc: Ville Syrjälä > Cc: Joshua Ashton > Cc: Jani Nikula > Cc: dri-de...@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.or

Re: [PATCH v3 03/17] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-03-08 Thread Sebastian Wick
lorspace entry > > that userspace can use. > > > > v2: > > - leave CYCC alone for now; it serves a purpose > > - leave BT2020_RGB the new default BT2020 > > > > Signed-off-by: Joshua Ashton > > Signed-off-by: Harry Wentland > > Reviewed-by:

Re: [PATCH v3 02/17] drm/connector: Add enum documentation to drm_colorspace

2023-03-08 Thread Sebastian Wick
ntland > > Hi, > > this effort is really good, but of course I still find things to > nitpick about. If there is no answer to my questions, then I would > prefer the documentation to spell out the unknowns and ambiguities. > > > Cc: Pekka Paalanen > >

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Sebastian Wick
On Tue, Feb 14, 2023 at 9:10 PM Ville Syrjälä wrote: > > On Tue, Feb 14, 2023 at 08:45:00PM +0100, Sebastian Wick wrote: > > On Tue, Feb 14, 2023 at 5:57 PM Harry Wentland > > wrote: > > > > > > > > > > > > On 2/14/23 10:49, Sebastian Wi

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Sebastian Wick
On Tue, Feb 14, 2023 at 5:57 PM Harry Wentland wrote: > > > > On 2/14/23 10:49, Sebastian Wick wrote: > > On Fri, Feb 3, 2023 at 5:00 PM Ville Syrjälä > > wrote: > >> > >> On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: > >>

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Sebastian Wick
On Fri, Feb 3, 2023 at 5:00 PM Ville Syrjälä wrote: > > On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: > > > > > > On 2/3/23 10:19, Ville Syrjälä wrote: > > > On Fri, Feb 03, 2023 at 09:39:42AM -0500, Harry Wentland wrote: > > >>

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Sebastian Wick
On Fri, Feb 3, 2023 at 2:35 PM Ville Syrjälä wrote: > > On Fri, Feb 03, 2023 at 01:59:07PM +0100, Sebastian Wick wrote: > > On Fri, Feb 3, 2023 at 11:40 AM Ville Syrjälä > > wrote: > > > > > > On Fri, Feb 03, 2023 at 02:07:44AM +, Joshua Ashton

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Sebastian Wick
e one BT.2020 colorspace entry > > that userspace can use. > > > > Note: _CYCC was effectively 'removed' by this change, but that was not > > possible to be taken advantage of anyway, as there is currently no > > pixel_encoding control so it would not be possible to outpu

Re: [PATCH v2 18/21] drm/amd/display: Fallback to 2020_YCBCR if the pixel encoding is not RGB

2023-01-25 Thread Sebastian Wick
On Tue, Jan 24, 2023 at 7:57 PM Harry Wentland wrote: > > > > On 1/24/23 10:37, Harry Wentland wrote: > > > > > > On 1/23/23 15:30, Sebastian Wick wrote: > >> A new property to control YCC and subsampling would be the more > >> complete path here. I

Re: [PATCH v2 18/21] drm/amd/display: Fallback to 2020_YCBCR if the pixel encoding is not RGB

2023-01-25 Thread Sebastian Wick
On Wed, Jan 25, 2023 at 2:00 PM Joshua Ashton wrote: > > > > On 1/23/23 20:30, Sebastian Wick wrote: > > A new property to control YCC and subsampling would be the more > > complete path here. If we actually want to fix this in the short-term > > though, we

Re: [PATCH v2 18/21] drm/amd/display: Fallback to 2020_YCBCR if the pixel encoding is not RGB

2023-01-23 Thread Sebastian Wick
is > requested but the output encoding is YCbCr we should > send COLOR_SPACE_2020_YCBCR. > > Signed-off-by: Joshua Ashton > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ashton > Cc:

Re: [PATCH 16/16] drm/amd/display: Don't restrict bpc to 8 bpc

2023-01-05 Thread Sebastian Wick
On Fri, Dec 23, 2022 at 8:10 PM Harry Wentland wrote: > > > > On 12/14/22 04:01, Pekka Paalanen wrote: > > On Tue, 13 Dec 2022 18:20:59 +0100 > > Michel Dänzer wrote: > > > >> On 12/12/22 19:21, Harry Wentland wrote: > >>> This will let us pass kms_hdr.bpc_switch. > >>> > >>> I don't see any

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-05-18 Thread Sebastian Wick
On 2021-05-18 16:19, Harry Wentland wrote: On 2021-05-18 3:56 a.m., Pekka Paalanen wrote: On Mon, 17 May 2021 15:39:03 -0400 Vitaly Prosyak wrote: On 2021-05-17 12:48 p.m., Sebastian Wick wrote: On 2021-05-17 10:57, Pekka Paalanen wrote: On Fri, 14 May 2021 17:05:11 -0400 Harry Wentland

Re: [RFC PATCH v2 1/6] drm/doc: Color Management and HDR10 RFC

2021-05-17 Thread Sebastian Wick
On 2021-05-14 23:07, Harry Wentland wrote: Use the new DRM RFC doc section to capture the RFC previously only described in the cover letter at https://patchwork.freedesktop.org/series/89506/ Update the RFC based on feedback received: * don't use color_encoding property to define color space *

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-05-17 Thread Sebastian Wick
On 2021-05-17 10:57, Pekka Paalanen wrote: On Fri, 14 May 2021 17:05:11 -0400 Harry Wentland wrote: On 2021-04-27 10:50 a.m., Pekka Paalanen wrote: > On Mon, 26 Apr 2021 13:38:49 -0400 > Harry Wentland wrote: ... >> ## Mastering Luminances >> >> Now we are able to use the PQ 2084 EOTF to

Re: [RFC PATCH 1/3] drm/color: Add RGB Color encodings

2021-05-01 Thread Sebastian Wick
On 2021-04-26 20:56, Harry Wentland wrote: On 2021-04-26 2:07 p.m., Ville Syrjälä wrote: On Mon, Apr 26, 2021 at 01:38:50PM -0400, Harry Wentland wrote: From: Bhawanpreet Lakha Add the following color encodings - RGB versions for BT601, BT709, BT2020 - DCI-P3: Used for digital movies