Re: [PATCH libdrm] amdgpu: amdgpu_bo_inc_ref don't return dummy int

2018-09-03 Thread Yu, Qiang
Sorry for not check this patch carefully, indeed a typo, will revert it. Regards, Qiang From: Christian König Sent: Monday, September 3, 2018 6:40:33 PM To: Michel Dänzer; Yu, Qiang Cc: Zhang, Jerry; Koenig, Christian; amd-gfx@lists.freedesktop.org; Deng

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function.

2018-09-03 Thread Yu, Qiang
>> amdgpu_bo_free >> +amdgpu_bo_inc_ref >> amdgpu_bo_import >> amdgpu_bo_list_create >> amdgpu_bo_list_destroy > > Thanks for remembering to add the symbol here, but amdgpu_bo_inc_ref > goes after amdgpu_bo_import in lexical order. :) Oh, haven't notice this is in alphabetic order. >> >>

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function.

2018-09-03 Thread Yu, Qiang
Thanks. Regards, Qiang From: Christian König Sent: Monday, September 3, 2018 4:57:39 PM To: Yu, Qiang; Zhang, Jerry; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian; Deng, Hui Subject: Re: [PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function.

2018-09-03 Thread Yu, Qiang
:14 PM To: Yu, Qiang; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian; Deng, Hui Subject: Re: [PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function. On 09/03/2018 02:55 PM, Qiang Yu wrote: > For Pro OGL be able to work with upstream libdrm. > > Signed-off-by: Qiang Yu &

Re: [PATCH libdrm] amdgpu: add a function to create amdgpu bo internally

2018-08-09 Thread Yu, Qiang
> + r = amdgpu_bo_create(dev, alloc_buffer->alloc_size, args.out.handle, > +buf_handle); > if (r) > - amdgpu_bo_free(bo); > - else > - *buf_handle = bo; > + goto out; > [yuq] the handle is not freed. Do

Re: [PATCH libdrm] amdgpu: add a function to create amdgpu bo internally

2018-08-09 Thread Yu, Qiang
Comments inline. Regards, Qiang From: amd-gfx on behalf of Junwei Zhang Sent: Thursday, August 9, 2018 11:19 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jerry; Koenig, Christian Subject: [PATCH libdrm] amdgpu: add a function to create amdgpu bo

Re: [PATCH xf86-video-amdgpu] Hardcode "non-desktop" RandR property name

2018-07-15 Thread Yu, Qiang
Thanks, looks good for me. Reviewed-by: Qiang Yu Regards, Qiang From: amd-gfx on behalf of Michel Dänzer Sent: Friday, July 13, 2018 4:41:51 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-amdgpu] Hardcode "non-desktop" RandR property

Re: [PATCH xf86-video-amdgpu 1/3] modesetting: Record non-desktop kernel property at PreInit time

2018-07-12 Thread Yu, Qiang
Hi Michel, Could randrproto >= 1.6.0 also be optional? randrproto 1.6 is pretty new so most old xserver doesn't compile with it. When compile latest ddx with various OS we support, it will fail. Maybe we can define RR_PROPERTY_NON_DESKTOP in ddx if not yet. Regards, Qiang

Re: [PATCH libdrm] headers: sync up amdgpu_drm.h with drm-next

2018-03-29 Thread Yu, Qiang
Hi, Can anyone submit it? Thanks, Qiang From: Zhou, David(ChunMing) Sent: Thursday, March 29, 2018 11:07:09 AM To: Yu, Qiang; amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: Re: [PATCH libdrm] headers: sync up amdgpu_drm.h with drm-next Acked

Re: [PATCH libdrm] headers: sync up amdgpu_drm.h with drm-next

2018-03-28 Thread Yu, Qiang
Hi guys, Ping. Regards, Qiang From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Qiang Yu <qiang...@amd.com> Sent: Tuesday, March 20, 2018 2:08:09 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH libdrm] head

Re: [PATCH libdrm] amdgpu: Remove dummy CU_ASSERT_EQUAL.

2017-12-12 Thread Yu, Qiang
Reviewed-by: Qiang Yu <qiang...@amd.com> Regards, Qiang From: Andrey Grodzovsky <andrey.grodzov...@amd.com> Sent: Tuesday, December 12, 2017 9:36:53 PM To: dri-de...@lists.freedesktop.org Cc: amd-gfx@lists.freedesktop.org; Yu, Qiang; Ma, Le;

Re: [PATCH umr] top vram add visible vram usage info

2017-07-11 Thread Yu, Qiang
and push it out. > > Cheers, > Tom > ________ > From: Yu, Qiang > Sent: Monday, July 10, 2017 22:07 > To: amd-gfx@lists.freedesktop.org; StDenis, Tom > Subject: Re: [PATCH umr] top vram add visible vram usage info > &

Re: [PATCH umr] top vram add visible vram usage info

2017-07-10 Thread Yu, Qiang
Hi Tom, Any feedback on this patch? Regards, Qiang From: Qiang Yu <qiang...@amd.com> Sent: Thursday, July 6, 2017 2:32:20 PM To: amd-gfx@lists.freedesktop.org Cc: Yu, Qiang Subject: [PATCH umr] top vram add visible vram usage info Signed-off-by: Qi

Re: AMDGPU without display output

2017-04-13 Thread Yu, Qiang
PS. If you want to use X11/OGL on this no display output card, just add an option to the amdgpu kernel module "virtual_display=all" which will fake a display output so that the xserver can start with amdgpu DDX successfully. You can use remote desktop apps like VNC to view the X screen.

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

2016-08-18 Thread Yu, Qiang
is not a fix for broken code, just a commit from amdgpu DDX to prevent present and DRI2 from flipping at the same time. Regards, Qiang From: Emil Velikov <emil.l.veli...@gmail.com> Sent: Thursday, August 18, 2016 7:03:12 PM To: Yu, Qiang Cc: ML xorg-devel; a

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

2016-08-18 Thread Yu, Qiang
Thanks Michel. I'll update patches in V2 according to your comments. Regards, Qiang From: Michel Dänzer <mic...@daenzer.net> Sent: Thursday, August 18, 2016 4:18:11 PM To: Yu, Qiang Cc: xorg-de...@lists.x.org; amd-gfx@lists.freedesktop.org Subje