RE: [PATCH drm/amdgpu/psp: ignore psp reponse status] drm/amdgpu/psp: ignore psp reponse status

2019-01-14 Thread Yu, Xiangliang
Please add more comments to explain why don't return error. And add my RB with that fix. Reviewed-by: Xiangliang Yu -Original Message- From: amd-gfx On Behalf Of Aaron Liu Sent: Monday, January 14, 2019 4:17 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Aaron Subject: [PATCH

RE: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed

2019-01-03 Thread Yu, Xiangliang
König Sent: Thursday, January 03, 2019 11:00 PM To: Xu, Feifei ; Yu, Xiangliang ; amd-gfx@lists.freedesktop.org; Deucher, Alexander Subject: Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed Hi guys, this patch broke loading older versions of PSP firmware on Vega10

RE: [PATCH] drm/amdgpu/sriov:Correct pfvf exchange logic

2019-01-01 Thread Yu, Xiangliang
Reviewed-By: Xiangliang Yu -Original Message- From: amd-gfx On Behalf Of Emily Deng Sent: Saturday, December 29, 2018 5:56 PM To: amd-gfx@lists.freedesktop.org Cc: Deng, Emily Subject: [PATCH] drm/amdgpu/sriov:Correct pfvf exchange logic The pfvf exchange need be in exclusive mode.

RE: [PATCH] drm/amdgpu: psp_ring_destroy cause psp->km_ring.ring_mem NULL

2018-12-17 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu -Original Message- From: Lou, Wentao Sent: Tuesday, December 18, 2018 3:52 PM To: amd-gfx@lists.freedesktop.org Cc: Lou, Wentao Subject: [PATCH] drm/amdgpu: psp_ring_destroy cause psp->km_ring.ring_mem NULL psp_ring_destroy inside psp_load_fw cause

RE: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed

2018-12-17 Thread Yu, Xiangliang
Anyone to help reviewing? Thanks! -Original Message- From: amd-gfx On Behalf Of Xiangliang Yu Sent: Thursday, December 13, 2018 3:42 PM To: amd-gfx@lists.freedesktop.org Cc: Yu, Xiangliang Subject: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed There isn't ucode

RE: [PATCH 1/2] drm/amdgpu/psp_v3_1: Get psp fw version through reading register

2018-12-12 Thread Yu, Xiangliang
This series reviewed by: Xiangliang Yu -Original Message- From: amd-gfx On Behalf Of Emily Deng Sent: Wednesday, December 12, 2018 5:37 PM To: amd-gfx@lists.freedesktop.org Cc: Deng, Emily Subject: [PATCH 1/2] drm/amdgpu/psp_v3_1: Get psp fw version through reading register If PSP FW

RE: [PATCH v2] drm/amdgpu: Clean sdma wptr register when only enable wptr polling

2018-03-06 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Emily Deng > Sent: Wednesday, March 07, 2018 9:52 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deng, Emily <em

RE: [PATCH] drm/amdgpu: Clean sdma wptr register when only enable wptr polling

2018-03-06 Thread Yu, Xiangliang
Better to add comment above the code. Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Emily Deng > Sent: Tuesday, March 06, 2018 5:17 PM > To: amd-gfx@lists.freed

RE: [PATCH] Revert "drm/amdgpu/gfx8: Fix compute ring failure after resetting"

2018-01-31 Thread Yu, Xiangliang
Ok, thanks! From: Grodzovsky, Andrey Sent: Thursday, February 01, 2018 12:59 AM To: Yu, Xiangliang <xiangliang...@amd.com>; amd-gfx@lists.freedesktop.org; Deng, Emily <emily.d...@amd.com> Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Koenig, Christian <christia

RE: [PATCH] Revert "drm/amdgpu/gfx8: Fix compute ring failure after resetting"

2018-01-25 Thread Yu, Xiangliang
You can add amdgpu_sriov_vf() check to avoid breaking sriov. > -Original Message- > From: Grodzovsky, Andrey > Sent: Friday, January 26, 2018 11:29 AM > To: Yu, Xiangliang <xiangliang...@amd.com>; amd- > g...@lists.freedesktop.org > Cc: Deucher, Alexander &l

RE: [PATCH] Release the mutex hold before backtracing for not supported mxgpu.

2017-12-19 Thread Yu, Xiangliang
> This patch releases the mutex held soon before entering the initialization > function in case the device doesn't support mxgpu. > > Signed-off-by: José Pekkarinen > --- > drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

RE: [PATCH 2/2] drm/amdgpu: use defines for mmBIF_IOV_FUNC_IDENTIFIER fields

2017-12-19 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Alex Deucher > Sent: Tuesday, December 19, 2017 11:07 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, A

RE: [PATCH 1/2] drm/amdgpu: only check mmBIF_IOV_FUNC_IDENTIFIER on tonga/fiji

2017-12-19 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Alex Deucher > Sent: Tuesday, December 19, 2017 11:07 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, A

RE: Topaz mistakenly reported as vf

2017-12-19 Thread Yu, Xiangliang
> Also, I noticed the following patch in case you can consider it for > upstream. Please send it to amd-gfx mailist for code review. > > Best regards. > > José. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org

RE: Topaz mistakenly reported as vf

2017-12-19 Thread Yu, Xiangliang
We can add ASIC check in vi_detect_hw_virtualization function to avoid to entry error path. I'll submit patch later. Thanks! > -Original Message- > From: José Pekkarinen [mailto:jose.pekkari...@canonical.com] > Sent: Tuesday, December 19, 2017 3:27 PM > To: Yu, Xiangliang

RE: Topaz mistakenly reported as vf

2017-12-18 Thread Yu, Xiangliang
Topaz doesn't support SRIOV. > -Original Message- > From: José Pekkarinen [mailto:jose.pekkari...@canonical.com] > Sent: Tuesday, December 19, 2017 3:12 PM > To: Yu, Xiangliang <xiangliang...@amd.com> > Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander > &l

RE: [PATCH] drm/amdgpu/gfx8: Fix compute ring failure after resetting

2017-11-10 Thread Yu, Xiangliang
better solution. > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Xiangliang.Yu > Sent: 2017年11月10日 14:52 > To: amd-gfx@lists.freedesktop.org > Cc: Yu, Xiangliang <xiangliang...@amd.com> > Subject: [PATCH] drm/amdgpu/gfx

RE: [PATCH] drm/amdgpu:fix gpu recover missing skipping

2017-11-07 Thread Yu, Xiangliang
Reviewed-and-tested-By: Xiangliang Yu <xiangliang...@amd.com> > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, November 08, 2017 2:39 PM > To: amd-gfx@lists.freedesktop.org > Cc: Liu

RE: [PATCH] drm/amdgpu:fix gpu recover missing skipping(v2)

2017-11-07 Thread Yu, Xiangliang
Reviewed-By: Xiangliang Yu <xiangliang...@amd.com> > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, November 08, 2017 3:08 PM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Monk <

RE: [PATCH] drm/amdgpu/virt: don't dereference undefined 'module' struct

2017-11-03 Thread Yu, Xiangliang
Reviewed-By: Xiangliang Yu <xiangliang...@amd.com> Thanks! > -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Thursday, November 02, 2017 7:26 PM > To: Deucher, Alexander <alexander.deuc...@amd.com>; Koenig, Christian > <christ

RE: [PATCH 1/2] drm/amdgpu: return error when sriov access requests get timeout

2017-10-31 Thread Yu, Xiangliang
>@@ -450,7 +450,7 @@ static int xgpu_vi_send_access_requests(struct >amdgpu_device *adev, > pr_err("Doesn't get ack from pf, continue\n"); Why don't return error in this place? > } > >- return 0; >+ return r; >} static int xgpu_vi_request_reset(struct

RE: [PATCH 1/2] drm/amdgpu: return error when sriov access requests get timeout (v2)

2017-10-31 Thread Yu, Xiangliang
Reviewed-By: Xiangliang Yu <xiangliang...@amd.com> -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Pixel Ding Sent: Tuesday, October 31, 2017 4:17 PM To: amd-gfx@lists.freedesktop.org; Yu, Xiangliang <xiangliang...@amd.com> Cc:

RE: [PATCH 2/2] drm/amdgpu: retry init if exclusive mode request is failed

2017-10-31 Thread Yu, Xiangliang
RB-by: Xiangliang Yu <xiangliang...@amd.com> -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Pixel Ding Sent: Tuesday, October 31, 2017 3:11 PM To: amd-gfx@lists.freedesktop.org Cc: Ding, Pixel <pixel.d...@amd.com> Subject: [PA

RE: [PATCH] drm/amdgpu: right shift 2 bits for SDMA_GFX_RB_WPTR_POLL_ADDR_LO

2017-09-25 Thread Yu, Xiangliang
RB: Xiangliang Yu <xiangliang...@amd.com> -Original Message- From: Ding, Pixel Sent: Monday, September 25, 2017 2:42 PM To: Liu, Monk <monk@amd.com>; amd-gfx@lists.freedesktop.org; Min, Frank <frank@amd.com>; Deucher, Alexander <alexander.deuc...@amd.

RE: [PATCH 14/18] drm/amdgpu: Fix amdgpu reload failure under SRIOV

2017-09-18 Thread Yu, Xiangliang
pci_enable_device will set power state to D0. This patch is just work around the issue, not address the root cause. -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Tuesday, September 19, 2017 5:07 AM To: Koenig, Christian

RE: [PATCH 14/18] drm/amdgpu: Fix amdgpu reload failure under SRIOV

2017-09-18 Thread Yu, Xiangliang
NAK, Tonga has no this problem, please keep the patch into internal branch for temporally. -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Monk Liu Sent: Monday, September 18, 2017 2:12 PM To: amd-gfx@lists.freedesktop.org Cc: Chen, Horace

RE: Can you tell me which driver supports AMD's sriov?

2017-09-14 Thread Yu, Xiangliang
Need GPU hypervisor driver if supporting amdgpu SRIOV. Right now, we still doesn't upstream the hypervisor driver to kernel, but we have a plan to upstream it. From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of maok...@126.com Sent: Thursday, September 14, 2017 3:57 PM

RE: [PATCH] drm/amdkfd: fix bug device is not added to supported_devices

2017-08-23 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Wang Hongcheng Sent: Wednesday, August 23, 2017 4:58 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Annie <annie.w...@amd.com> Sub

RE: [PATCH 1/1] drm/ttm: Fix accounting error when fail to get pages for pool

2017-08-16 Thread Yu, Xiangliang
I mean I don't know if the patch can fix mem leak issue. -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Michel D?nzer Sent: Wednesday, August 16, 2017 6:03 PM To: Yu, Xiangliang <xiangliang...@amd.com>; Zhou, David(ChunMing) <

RE: [PATCH 1/1] drm/ttm: Fix accounting error when fail to get pages for pool

2017-08-16 Thread Yu, Xiangliang
esday, August 16, 2017 3:20:46 PM To: a...@linux-foundation.org<mailto:a...@linux-foundation.org>; labb...@redhat.com<mailto:labb...@redhat.com>; dri-de...@lists.freedesktop.org<mailto:dri-de...@lists.freedesktop.org>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.

RE: [PATCH 8/8] drm/amdgpu/sdma4: Enable sdma poll mem addr on vega10 for SRIOV

2017-07-25 Thread Yu, Xiangliang
Got it, I'll change it later. Thanks! > From: Frank Min > > While doing flr on VFs, there is possibility to lost the doorbell > writing for sdma, so enable poll mem for sdma, then sdma fw would > check the pollmem holding wptr. > > Signed-off-by: Frank Min

RE: [PATCH] drm/amdgpu: reduce the time of reading VBIOS

2017-07-24 Thread Yu, Xiangliang
Ok, thanks! -Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: Friday, July 21, 2017 10:12 PM To: Yu, Xiangliang <xiangliang...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: reduce the time of reading VBIOS Am 21.07.2017 um

RE: The amd-stagint-4.11 doen't contain the commit ab51ee31dda1a37b473074e402394f879c51d591 in amd-staging-4.9

2017-07-05 Thread Yu, Xiangliang
Please check it with Evan, I remember he remind us to switch to staing-4.11 From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Liu, Monk Sent: Wednesday, July 05, 2017 11:55 AM To: Deng, Emily ; Deucher, Alexander Cc:

RE: [PATCH] drm/amdgpu: extend lock range for race condition when gpu reset

2017-06-16 Thread Yu, Xiangliang
Hi Hongbo, I got soft lockup message as below when running valkan test with two VFs, and work fine if reverting this patch. Could you help check it when you feel free? [ 1920.163455] NMI watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [deqp-vk:2175] [ 1920.163459] Modules linked in: amdkfd

RE: [PATCH] drm/amdgpu: correct clock info for SRIOV

2017-06-05 Thread Yu, Xiangliang
, we need to support this for VI family. > > Alex > > > > > Signed-off-by: Xiangliang Yu <xiangliang...@amd.com> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --g

RE: [PATCH 4/6] drm/amdgpu/psp: Do not load asd for SRIOV

2017-05-05 Thread Yu, Xiangliang
> -Original Message- > From: Huang Rui [mailto:ray.hu...@amd.com] > Sent: Friday, May 05, 2017 2:47 PM > To: Yu, Xiangliang <xiangliang...@amd.com> > Cc: amd-gfx@lists.freedesktop.org; Wang, Daniel(Xiaowei) > <daniel.wa...@amd.com> > Subject: Re: [PATCH

RE: [PATCH] drm/amdgpu: Bypass GMC, UVD and VCE in hw_fini

2017-05-03 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> Thanks! Xiangliang Yu > -Original Message- > From: Trigger Huang [mailto:trigger.hu...@amd.com] > Sent: Thursday, May 04, 2017 10:40 AM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Monk <monk@

RE: [PATCH 3/6] drm/amdgpu:re-write sriov_reinit_early/late

2017-05-03 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, May 03, 2017 11:48 AM > To: amd-gfx@lists.freedesktop.org

RE: [PATCH 5/6] drm/amdgpu:kiq reg access need timeout(v2)

2017-05-03 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, May 03, 2017 11:48 AM > To: amd-gfx@lists.freedesktop.org

RE: [PATCH 4/6] drm/amdgpu:cleanups KIQ ring_funcs emit_frame_size

2017-05-03 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, May 03, 2017 11:48 AM > To: amd-gfx@lists.freedesktop.org

RE: [PATCH 2/6] drm/amdgpu:need som change on vega10 mailbox

2017-05-03 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, May 03, 2017 11:48 AM > To: amd-gfx@lists.freedesktop.org

RE: [PATCH] drm/amdgpu: Enable chained IB MCBP support

2017-04-27 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> Thanks! Xiangliang Yu > -Original Message- > From: Trigger Huang [mailto:trigger.hu...@amd.com] > Sent: Thursday, April 27, 2017 3:18 PM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Monk <monk@

RE: [PATCH] drm/amdgpu: Fix module unload hang by KIQ on Vega10

2017-04-17 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Trigger Huang > Sent: Tuesday, April 18, 2017 10:14 AM > To: amd-gfx@lists.freedesktop.org

RE: [PATCH] drm/amdgpu: Destroy psp ring in hw_fini

2017-04-17 Thread Yu, Xiangliang
Better to add SRIOV case in your commit message, I think bare metal doesn't care re-initialization. Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> with fixing. Thanks! Xiangliang Yu > -Original Message- > From: Trigger Huang [mailto:trigger.hu...@amd.com] > Sent: Tu

RE: [PATCH] drm/amdgpu: set kiq irq in sriov case for gfx_v9.

2017-04-17 Thread Yu, Xiangliang
Please refer to commit 4e683cb26 that fix for gfx8, I think the commit can also fix BUG_ON case of gfx9. Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Monday, April 17, 2017 8:31 PM > To:

RE: [PATCH 2/3] drm/amdgpu/vce4: workaround VCE ring test slow issue

2017-04-11 Thread Yu, Xiangliang
> > -Original Message- > > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > > Of Xiangliang Yu > > Sent: Tuesday, April 11, 2017 3:31 AM > > To: amd-gfx@lists.freedesktop.org > > Cc: Min, Frank; Yu, Xiangliang > > Subject: [

RE: [PATCH] drm/amdgpu: Fix firmware UCODE_ID_STORAGE issue

2017-04-10 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Trigger Huang > Sent: Monday, April 10, 2017 2:46 PM > To: amd-gfx@lists.freedesktop.org > Cc: Huang, Ray &l

RE: [PATCH 3/5] drm/amdgpu/vce4: workaround multi vce engine encoding hang issue

2017-04-10 Thread Yu, Xiangliang
ence could be a known issue with old libdrm, do you > have updated to the latest version? Ok, I'll try it later. > > > > > Signed-off-by: Xiangliang Yu <xiangliang...@amd.com> > > Signed-off-by: Frank Min <frank@amd.com> > > --- > > drivers/gpu/drm

RE: [PATCH 1/6] drm/amdgpu:add PSP block only load_type=PSP

2017-04-05 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> for the series. > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, April 05, 2017 5:11 PM > To: amd-gfx@lists.freedesktop.org > Cc: Liu

RE: [PATCH] drm/amdgpu/virt: fix spelling mistake: "hypervior" -> "hypervisor"

2017-03-30 Thread Yu, Xiangliang
@@ static void xgpu_vi_mailbox_flr_work(struct > work_struct *work) > > r = xgpu_vi_poll_msg(adev, IDH_FLR_NOTIFICATION_CMPL); > if (r) > - DRM_ERROR("failed to get flr cmpl msg from hypervior.\n"); > + DRM_ERROR("failed to

RE: [PATCH 00/13] *** VEGA10 SRIOV PATCHES ***

2017-03-24 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> for the series. Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Friday, March 24, 2017 6:38 PM > To: amd-gfx@lists.free

RE: [PATCH 1/9] drm/amdgpu/gfx9: Switch baremetal to use KIQ for compute ring management. (v2)

2017-03-23 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> for the whole series. > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Alex Deucher > Sent: Friday, March 24, 2017 1:07 AM > To: amd-gfx@lists.freedesktop.org >

RE: [PATCH] drm/amdgpu/virt: don't check VALID bit for FLR completion message

2017-02-23 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Pixel Ding > Sent: Thursday, February 23, 2017 3:09 PM > To: amd-gfx@lists.freedesktop.org > Cc: Ding, P

RE: [PATCH] drm/amdgpu/virt: don't check VALID bit for FLR completion message

2017-02-22 Thread Yu, Xiangliang
> The interrupt after FLR is missed sometimes due to hardware reason, so > guest driver get the notification of FLR completion via polling message. Then > host doesn't write VALID bit to avoid sending interrupt, otherwise the > completion will be handled twice. > > So there's a valid message

RE: [PATCH V2] drm/amdgpu: Fix module unload hang by KIQ IRQ set

2017-02-19 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu < xiangliang...@amd.com> Thanks! Xiangliang Yu > -Original Message- > From: Trigger Huang [mailto:trigger.hu...@amd.com] > Sent: Monday, February 20, 2017 11:03 AM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Monk <monk@

RE: [PATCH] drm/amdgpu: Fix module unload hang by KIQ IRQ set

2017-02-16 Thread Yu, Xiangliang
gt; To: amd-gfx@lists.freedesktop.org > Cc: Liu, Monk <monk@amd.com>; Yu, Xiangliang > <xiangliang...@amd.com>; Huang, Trigger <trigger.hu...@amd.com> > Subject: [PATCH] drm/amdgpu: Fix module unload hang by KIQ IRQ set > > In some cases, manually insmod/rm

RE: [PATCH 11/11] drm/amdgpu:fix kiq_resume routine (V2)

2017-02-08 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, February 08, 2017 5:27 PM > To: amd-gfx@lists.freedesktop.org

RE: [PATCH 08/11] drm/amdgpu:alloc mqd backup

2017-02-08 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, February 08, 2017 5:27 PM > To: amd-gfx@lists.freedesktop.org

RE: [PATCH 04/11] drm/amdgpu:no kiq for mailbox registers access

2017-02-08 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, February 08, 2017 5:27 PM > To: amd-gfx@lists.freedesktop.org

RE: [PATCH 03/11] drm/amdgpu:Refine handshake of mailbox

2017-02-08 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, February 08, 2017 5:27 PM > To: amd-gfx@lists.freedesktop.or

RE: [PATCH 02/11] drm/amdgpu:impl RREG32 no kiq version

2017-02-08 Thread Yu, Xiangliang
Reviewed-by: Xiangliang.Yu Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, February 08, 2017 5:27 PM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Monk > Subject:

RE: [PATCH 05/11] drm/amdgpu:use work instead of delay-work

2017-02-08 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, February 08, 2017 5:27 PM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Monk > Subject: [PATCH 05/11]

RE: [PATCH 12/20] drm/amdgpu:impl mm_r/weg_nokiq

2017-02-07 Thread Yu, Xiangliang
> > +uint32_t amdgpu_mm_rreg_nokiq(struct amdgpu_device *adev, uint32_t > > reg, > > + bool always_indirect) > > +{ > > + uint32_t ret; > > + > > + if ((reg * 4) < adev->rmmio_size && !always_indirect) > > + ret = readl(((void __iomem *)adev->rmmio) + (reg * 4)); >

RE: [PATCH 15/20] drm/amdgpu:use work instead of delay-work

2017-02-07 Thread Yu, Xiangliang
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Deucher, Alexander > Sent: Wednesday, February 08, 2017 12:11 AM > To: Liu, Monk ; amd-gfx@lists.freedesktop.org > Cc: Liu, Monk > Subject: RE: [PATCH

RE: [bug report] drm/amdgpu/virt: implement VI virt operation interfaces

2017-02-06 Thread Yu, Xiangliang
Thanks! I'll fix it. Thanks! Xiangliang Yu > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Monday, February 06, 2017 7:19 PM > To: Yu, Xiangliang <xiangliang...@amd.com> > Cc: amd-gfx@lists.freedesktop.org > Subject: [bug

RE: [PATCH 1/2] drm/amdgpu: don't clean the framebuffer for VF

2017-02-05 Thread Yu, Xiangliang
Acked-by: Xiangliang.Yu Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Pixel Ding > Sent: Monday, February 06, 2017 2:25 PM > To: amd-gfx@lists.freedesktop.org > Cc: Ding, Pixel

RE: [PATCH 1/2] drm/amdgpu/virt: refine handshake between guest and host by mailbox

2017-02-05 Thread Yu, Xiangliang
Reviewed-by: Xiangliang.Yu Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Pixel Ding > Sent: Monday, February 06, 2017 3:00 PM > To: amd-gfx@lists.freedesktop.org > Cc: Xue, Ken

RE: [PATCH 2/2] drm/amdgpu: increase mailbox timeout to 5000ms

2017-02-05 Thread Yu, Xiangliang
Reviewed-by: Xiangliang Yu <xiangliang...@amd.com> Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Pixel Ding > Sent: Monday, February 06, 2017 2:25 PM > To: amd-gfx@lists.freedesktop.

RE: [PATCH 05/21] drm/amdgpu:BUG if gpu_reste and asic_reset from VF

2017-02-05 Thread Yu, Xiangliang
Have you tried the patch for unloading driver? Ps: the index of patch make people confused, I think there are 21 patches in the series. Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Saturday,

RE: [PATCH 02/21] drm/amdgpu:fix golden init for sriov

2017-02-05 Thread Yu, Xiangliang
Does FIJI need the golden init? Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Saturday, February 04, 2017 6:22 PM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Monk > Subject:

RE: [V3 04/11] drm/amdgpu/virt: use kiq to access registers

2017-01-11 Thread Yu, Xiangliang
> -Original Message- > From: Michel Dänzer [mailto:mic...@daenzer.net] > Sent: Thursday, January 12, 2017 1:45 PM > To: Liu, Monk <monk@amd.com>; Christian König > <deathsim...@vodafone.de>; Yu, Xiangliang <xiangliang...@amd.com> > Cc: amd-gfx@list

RE: [V3 06/11] drm/amdgpu/virt: implement VI virt operation interfaces

2017-01-11 Thread Yu, Xiangliang
the error. That what i want to avoid it. > > > -Original Message- > > From: Yu, Xiangliang > > Sent: Wednesday, January 11, 2017 10:43 PM > > To: Liu, Monk <monk@amd.com>; amd-gfx@lists.freedesktop.org > > Cc: Liu, Shaoyun <shaoyun@amd.c

RE: [V3 06/11] drm/amdgpu/virt: implement VI virt operation interfaces

2017-01-11 Thread Yu, Xiangliang
orrow if you have any concern. > -Original Message----- > From: Yu, Xiangliang > Sent: Wednesday, January 11, 2017 10:43 PM > To: Liu, Monk <monk@amd.com>; amd-gfx@lists.freedesktop.org > Cc: Liu, Shaoyun <shaoyun@amd.com> > Subject: RE: [V3 06/11] dr

RE: [V3 05/11] drm/amdgpu/virt: add high level interfaces for virt

2017-01-11 Thread Yu, Xiangliang
> -Original Message- > From: Liu, Monk > Sent: Wednesday, January 11, 2017 10:33 PM > To: Yu, Xiangliang <xiangliang...@amd.com>; amd- > g...@lists.freedesktop.org > Subject: RE: [V3 05/11] drm/amdgpu/virt: add high level interfaces for virt > > See in lines

RE: [V3 06/11] drm/amdgpu/virt: implement VI virt operation interfaces

2017-01-11 Thread Yu, Xiangliang
> -Original Message- > From: Liu, Monk > Sent: Wednesday, January 11, 2017 10:28 PM > To: Yu, Xiangliang <xiangliang...@amd.com>; amd- > g...@lists.freedesktop.org > Cc: Yu, Xiangliang <xiangliang...@amd.com>; Liu, Shaoyun > <shaoyun@amd.com> &g

RE: [V3 05/11] drm/amdgpu/virt: add high level interfaces for virt

2017-01-11 Thread Yu, Xiangliang
->virt.caps &= ~AMDGPU_SRIOV_CAPS_RUNTIME; else > BUG(); /* we shouldn't fail in requesting GPU_RESET, check hypervisor > please */ return r; I think we can't hang out VM so rudely, need to print out error message and do error handling to enhance the process later. > > BR

RE: [V3 00/11] Add support AMD GPU virtualization soultion

2017-01-11 Thread Yu, Xiangliang
> Patch #7 is missing a comment that this applies during driver load/unload, > cause that isn't obvious. Not just only for loading/unloading, resume process will need to request/release full gpu access after FLR (function level reset). Later I'll upstream FLR patches. > > With that fixed the

RE: [V2 02/11] drm/amdgpu/gfx8: implement emit_rreg/wreg function

2017-01-10 Thread Yu, Xiangliang
> -Original Message- > From: Deucher, Alexander > Sent: Tuesday, January 10, 2017 11:35 PM > To: Yu, Xiangliang <xiangliang...@amd.com>; amd- > g...@lists.freedesktop.org > Cc: Yu, Xiangliang <xiangliang...@amd.com> > Subject: RE: [V2 02/11] drm/amdg

RE: [V2 05/11] drm/amdgpu/virt: add high level interfaces for virt

2017-01-10 Thread Yu, Xiangliang
> -Original Message- > From: Christian König [mailto:deathsim...@vodafone.de] > Sent: Tuesday, January 10, 2017 9:59 PM > To: Yu, Xiangliang <xiangliang...@amd.com>; amd- > g...@lists.freedesktop.org > Subject: Re: [V2 05/11] drm/amdgpu/virt: add high level int

RE: [V2 06/11] drm/amdgpu/virt: implement VI virt operation interfaces

2017-01-10 Thread Yu, Xiangliang
> -Original Message- > From: Christian König [mailto:deathsim...@vodafone.de] > Sent: Tuesday, January 10, 2017 10:06 PM > To: Yu, Xiangliang <xiangliang...@amd.com>; amd- > g...@lists.freedesktop.org > Subject: Re: [V2 06/11] drm/amdgpu/virt: implement VI vir

RE: [V2 04/11] drm/amdgpu/virt: use kiq to access registers

2017-01-10 Thread Yu, Xiangliang
> -Original Message- > From: Christian König [mailto:deathsim...@vodafone.de] > Sent: Tuesday, January 10, 2017 10:08 PM > To: Yu, Xiangliang <xiangliang...@amd.com>; amd- > g...@lists.freedesktop.org > Subject: Re: [V2 04/11] drm/amdgpu/virt: use kiq to access regi

RE: [V2 04/11] drm/amdgpu/virt: use kiq to access registers

2017-01-10 Thread Yu, Xiangliang
> -Original Message- > From: Christian König [mailto:deathsim...@vodafone.de] > Sent: Tuesday, January 10, 2017 9:09 PM > To: Yu, Xiangliang <xiangliang...@amd.com>; amd- > g...@lists.freedesktop.org > Subject: Re: [V2 04/11] drm/amdgpu/virt: use kiq to access regi

RE: [V2 06/11] drm/amdgpu/virt: implement VI virt operation interfaces

2017-01-10 Thread Yu, Xiangliang
> -Original Message- > From: Christian König [mailto:deathsim...@vodafone.de] > Sent: Tuesday, January 10, 2017 9:30 PM > To: Yu, Xiangliang <xiangliang...@amd.com>; amd- > g...@lists.freedesktop.org > Subject: Re: [V2 06/11] drm/amdgpu/virt: implement VI vir

RE: [V2 11/11] drm/amdgpu: do not reset gpu for virtualization

2017-01-10 Thread Yu, Xiangliang
> -Original Message- > From: Christian König [mailto:deathsim...@vodafone.de] > Sent: Tuesday, January 10, 2017 9:19 PM > To: Yu, Xiangliang <xiangliang...@amd.com>; amd- > g...@lists.freedesktop.org > Cc: Liu, Monk <monk@amd.com> > Subject: Re: [V2 11

RE: [V2 06/11] drm/amdgpu/virt: implement VI virt operation interfaces

2017-01-10 Thread Yu, Xiangliang
> -Original Message- > From: Christian König [mailto:deathsim...@vodafone.de] > Sent: Tuesday, January 10, 2017 9:16 PM > To: Yu, Xiangliang <xiangliang...@amd.com>; amd- > g...@lists.freedesktop.org > Subject: Re: [V2 06/11] drm/amdgpu/virt: implement VI vir

RE: [V2 05/11] drm/amdgpu/virt: add high level interfaces for virt

2017-01-10 Thread Yu, Xiangliang
> -Original Message- > From: Christian König [mailto:deathsim...@vodafone.de] > Sent: Tuesday, January 10, 2017 9:12 PM > To: Yu, Xiangliang <xiangliang...@amd.com>; amd- > g...@lists.freedesktop.org > Subject: Re: [V2 05/11] drm/amdgpu/virt: add high level int

RE: [PATCH 2/2] drm/amdgpu: remove detect_hw_virtualization interface

2017-01-08 Thread Yu, Xiangliang
>From: Liu, Monk >Sent: Monday, January 09, 2017 11:32 AM >To: Yu, Xiangliang <xiangliang...@amd.com>; amd-gfx@lists.freedesktop.org >Subject: 答复: [PATCH 2/2] drm/amdgpu: remove detect_hw_virtualization interface >after you removed this interface, don'

RE: [PATCH 1/2] drm/amdgpu/vi: move virtualization detection forward

2017-01-08 Thread Yu, Xiangliang
>please change as below accordingly: > 1, call "vi_detect_hw_virtualization" in vi_set_ip_blocks directly That is what my patch does >2, drop below changes: >+   if (amdgpu_sriov_vf(adev)) { >+   amdgpu_ip_block_add(adev, _common_ip_block); >+  

RE: [V2 1/1] drm/amdgpu/gfx8: add support kernel interface queue(KIQ)

2017-01-04 Thread Yu, Xiangliang
> -Original Message- > From: Christian König [mailto:deathsim...@vodafone.de] > Sent: Wednesday, January 04, 2017 10:13 PM > To: Yu, Xiangliang <xiangliang...@amd.com>; Zhou, David(ChunMing) > <david1.z...@amd.com>; amd-gfx@lists.freedesktop.org; Liu, Monk >

RE: [V2 1/1] drm/amdgpu/gfx8: add support kernel interface queue(KIQ)

2017-01-01 Thread Yu, Xiangliang
> -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Saturday, December 31, 2016 2:54 PM > To: Yu, Xiangliang <xiangliang...@amd.com> > Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>; Liu, Monk > <monk@amd.com> > Sub

RE: [V2 1/1] drm/amdgpu/gfx8: add support kernel interface queue(KIQ)

2016-12-27 Thread Yu, Xiangliang
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of zhoucm1 > Sent: Wednesday, December 28, 2016 10:32 AM > To: Yu, Xiangliang <xiangliang...@amd.com>; amd- > g...@lists.freedesktop.org > Cc: Liu, Monk <monk

RE: [V2 1/1] drm/amdgpu/gfx8: add support kernel interface queue(KIQ)

2016-12-27 Thread Yu, Xiangliang
p other queues, without accessing > registers. > > For virtualization, need KIQ to access virtual function registers when running > on guest mode. > > changes in v2: > 1. use amdgpu_bo_create/free_kernel to allocate OB. > > Signed-off-by: Monk Liu <monk@amd.com> &

RE: [PATCH 1/1] drm/amdgpu/gfx8: add support kernel interface queue(KIQ)

2016-12-22 Thread Yu, Xiangliang
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of zhoucm1 > Sent: Thursday, December 22, 2016 5:01 PM > To: Yu, Xiangliang <xiangliang...@amd.com>; amd- > g...@lists.freedesktop.org > Cc: Liu, Monk <monk@am

RE: [PATCH 1/1] drm/amdgpu/gfx8: add support kernel interface queue(KIQ)

2016-12-22 Thread Yu, Xiangliang
> -Original Message- > From: Zhou, David(ChunMing) > Sent: Tuesday, December 20, 2016 5:49 PM > To: Yu, Xiangliang <xiangliang...@amd.com>; amd- > g...@lists.freedesktop.org > Cc: Liu, Monk <monk@amd.com> > Subject: Re: [PATCH 1/1] drm/amdgpu/gfx8: add

RE: [PATCH 09/23] drm/amdgpu: enable virtualization feature for FIJI/TONGA

2016-12-20 Thread Yu, Xiangliang
> -Original Message- > From: Deucher, Alexander > Sent: Tuesday, December 20, 2016 11:53 PM > To: Yu, Xiangliang <xiangliang...@amd.com>; Alex Deucher > <alexdeuc...@gmail.com> > Cc: dl.SRDC_SW_GPUVirtualization > <dl.srdc_sw_gpuvirt

RE: [PATCH 1/1] drm/amdgpu/gfx8: add support kernel interface queue(KIQ)

2016-12-20 Thread Yu, Xiangliang
Ignore the patch, forget add Monk name into signed-off Thanks! Xiangliang Yu > -Original Message- > From: Xiangliang Yu [mailto:xiangliang...@amd.com] > Sent: Tuesday, December 20, 2016 5:41 PM > To: amd-gfx@lists.freedesktop.org > Cc: Yu, Xiangliang <xiangliang...@

RE: [PATCH 13/23] drm/amdgpu/mxgpu: add support for mailbox communication

2016-12-19 Thread Yu, Xiangliang
> -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Tuesday, December 20, 2016 7:25 AM > To: Yu, Xiangliang <xiangliang...@amd.com> > Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>; > dl.SRDC_SW_GPUVirtualization > <dl.srd

RE: [PATCH 19/23] drm/amdgpu/mxgpu: add implementation of GPU virtualization of VI

2016-12-19 Thread Yu, Xiangliang
> -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Tuesday, December 20, 2016 7:35 AM > To: Yu, Xiangliang <xiangliang...@amd.com> > Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>; > dl.SRDC_SW_GPUVirtualization <dl.

RE: [PATCH 21/23] drm/amdgpu: change golden register program sequence of virtualization

2016-12-19 Thread Yu, Xiangliang
Thank monk’s comments. From: Liu, Monk Sent: Tuesday, December 20, 2016 12:09 PM To: Alex Deucher <alexdeuc...@gmail.com>; Yu, Xiangliang <xiangliang...@amd.com> Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>; dl.SRDC_SW_GPUVirtualization <dl.srdc_sw_gpuvirtualizat...

RE: [PATCH 15/23] drm/amdgpu/mxgpu: implement register access function with KIQ

2016-12-19 Thread Yu, Xiangliang
> -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Tuesday, December 20, 2016 7:27 AM > To: Yu, Xiangliang <xiangliang...@amd.com> > Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>; > dl.SRDC_SW_GPUVirtualization > <

  1   2   >