RE: [PATCH] drm/amdgpu: remove distinction between explicit and implicit sync (v2)

[AMD Official Use Only - Internal Distribution Only] Not sue if this is right direction, I think usermode wants all synchronizations to be explicit. Implicit sync often confuses people who don't know its history. I remember Jason from Intel is driving explicit synchronization through the

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

[AMD Official Use Only - Internal Distribution Only] That's fine to me. -David From: Koenig, Christian Sent: Friday, February 21, 2020 11:33 PM To: Deucher, Alexander ; Christian König ; Zhou, David(ChunMing) ; He, Jacob ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Add

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

[AMD Official Use Only - Internal Distribution Only] You can enhance amdgpu_vm_ioctl In amdgpu_vm.c to return vmid to userspace. -David From: He, Jacob Sent: Thursday, February 20, 2020 10:46 PM To: Zhou, David(ChunMing) ; Koenig, Christian ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

[AMD Official Use Only - Internal Distribution Only] Christian is right here, that will cause many problems for simply using VMID in kernel. We already have an pair interface for RGP, I think you can use it instead of involving additional kernel change. amdgpu_vm_reserve_vmid/

Re: [PATCH] drm/ttm: use the parent resv for ghost objects v2

On 2019/10/24 下午6:25, Christian König wrote: > Ping? > > Am 18.10.19 um 13:58 schrieb Christian König: >> This way the TTM is destroyed with the correct dma_resv object >> locked and we can even pipeline imported BO evictions. >> >> v2: Limit this to only cases when the parent object uses a

RE: [PATCH] drm/amdgpu: remove gfx9 NGG

+Alex Yan to confirm which doesn't affect us. -Original Message- From: amd-gfx On Behalf Of Marek Olšák Sent: Friday, September 20, 2019 10:16 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: remove gfx9 NGG From: Marek Olšák Never used. Signed-off-by: Marek Olšák

Re：[PATCH] drm/amdgpu: resvert "disable bulk moves for now"

I dont know dkms status，anyway, we should submit this one as early as possible. 原始邮件 主题：Re: [PATCH] drm/amdgpu: resvert "disable bulk moves for now" 发件人：Christian König 收件人："Zhou, David(ChunMing)" ,amd-gfx@lists.freedesktop.org 抄送： Just to double check: We

RE: [PATCH 2/3] drm/amdgpu: reserve at least 4MB of VRAM for page tables

Do you need update the vram size reported to UMD ? -David -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Monday, September 2, 2019 6:52 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 2/3] drm/amdgpu: reserve at least 4MB of VRAM for page tables This

RE: [PATCH 10/10] drm/amdgpu: stop removing BOs from the LRU v3

Patch #1,#5,#6,#8,#9,#10 are Reviewed-by: Chunming Zhou Patch #2,#3,#4 are Acked-by: Chunming Zhou -David > -Original Message- > From: dri-devel On Behalf Of > Christian K?nig > Sent: Wednesday, May 29, 2019 8:27 PM > To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org

RE: [PATCH 01/11] drm/ttm: Make LRU removal optional.

> -Original Message- > From: Christian König > Sent: Tuesday, May 14, 2019 8:31 PM > To: Olsak, Marek ; Zhou, David(ChunMing) > ; Liang, Prike ; dri- > de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org > Subject: [PATCH 01/11] drm/ttm: Make LRU removal op

Re:[PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

ng CS From: "Koenig, Christian" To: "Zhou, David(ChunMing)" ,"Olsak, Marek" ,"Liang, Prike" ,dri-de...@lists.freedesktop.org,amd-gfx@lists.freedesktop.org CC: [CAUTION: External Email] BO list? No, we stop removing them from the LRU. But we still mov

Re:[PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

Isn't this patch trying to stop removing for all BOs from bo list? -David Original Message Subject: Re: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS From: Christian König To: "Zhou, David(ChunMing)" ,"Koenig, Christian" ,"Olsa

Re:[PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

CS From: Christian König To: "Zhou, David(ChunMing)" ,"Olsak, Marek" ,"Liang, Prike" ,dri-de...@lists.freedesktop.org,amd-gfx@lists.freedesktop.org CC: [CAUTION: External Email] Hui? What do you mean with that? Christian. Am 14.05.19 um 15:12 schrieb Zhou, Da

Re:[PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS

my only concern is how to fresh LRU when bo is from bo list. -David Original Message Subject: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS From: Christian König To: "Olsak, Marek" ,"Zhou, David(ChunMing)" ,"Liang, Prike" ,d

RE: [PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled.

Sorry, I only can put my Acked-by: Chunming Zhou on patch#3. I cannot fully judge patch #4, #5, #6. -David From: amd-gfx On Behalf Of Grodzovsky, Andrey Sent: Friday, April 26, 2019 10:09 PM To: Koenig, Christian ; Zhou, David(ChunMing) ; dri-de...@lists.freedesktop.org; amd-gfx

RE: [PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled.

amd-gfx On Behalf Of Grodzovsky, Andrey Sent: Wednesday, April 24, 2019 12:00 AM To: Zhou, David(ChunMing) ; dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; e...@anholt.net; etna...@lists.freedesktop.org; ckoenig.leichtzumer...@gmail.com Cc: Kazlauskas, Nicholas ; Liu, Monk Sub

Re:[PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled.

do you mean fence timer? why not stop it as well when stopping sched for the reason of hw reset? Original Message Subject: Re: [PATCH v5 6/6] drm/amdgpu: Avoid HW reset if guilty job already signaled. From: "Grodzovsky, Andrey" To: "Zhou, David(Chun

Re:[PATCH v5 3/6] drm/scheduler: rework job destruction

3/6] drm/scheduler: rework job destruction From: "Grodzovsky, Andrey" To: "Zhou, David(ChunMing)" ,dri-de...@lists.freedesktop.org,amd-gfx@lists.freedesktop.org,e...@anholt.net,etna...@lists.freedesktop.org,ckoenig.leichtzumer...@gmail.com CC: "Kazlauskas, Nicholas" ,&

RE: DMA-buf P2P

Which test are you using? Can share? -David > -Original Message- > From: dri-devel On Behalf Of > Christian K?nig > Sent: Thursday, April 18, 2019 8:09 PM > To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org > Subject: DMA-buf P2P > > Hi guys, > > as promised this is

RE: [PATCH 2/9] drm/syncobj: add new drm_syncobj_add_point interface v4

> -Original Message- > From: Lionel Landwerlin > Sent: Saturday, March 30, 2019 10:09 PM > To: Koenig, Christian ; Zhou, David(ChunMing) > ; dri-de...@lists.freedesktop.org; amd- > g...@lists.freedesktop.org; ja...@jlekstrand.net; Hector, Tobias > > Subject: Re:

RE: [PATCH] drm/amdgpu: fix old fence check in amdgpu_fence_emit

> -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Saturday, March 30, 2019 2:33 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: fix old fence check in amdgpu_fence_emit > > We don't hold a reference to the old fence, so it can go away any

Re:[PATCH 1/9] dma-buf: add new dma_fence_chain container v6

cmpxchg be replaced by some simple c sentance? otherwise we have to remove __rcu of chian->prev. -David Original Message Subject: Re: [PATCH 1/9] dma-buf: add new dma_fence_chain container v6 From: Christian König To: "Zhou, David(ChunMing)" ,kbuild test robot

Re:[PATCH] drm/amdgpu: enable bo priority setting from user space

Am 07.03.19 um 14:09 schrieb Zhou, David(ChunMing): Yes, you are right, thanks to point it out. Will see if there is other way. -David send from my phone Original Message Subject: Re: [PATCH] drm/amdgpu: enable bo priority setting from user space From: Christian König To: "Zho

Re:[PATCH] drm/amdgpu: enable bo priority setting from user space

Yes, you are right, thanks to point it out. Will see if there is other way. -David send from my phone Original Message Subject: Re: [PATCH] drm/amdgpu: enable bo priority setting from user space From: Christian König To: "Zhou, David(ChunMing)" ,amd-gfx@lists.freed

RE: [PATCH] drm/amdgpu: force to use CPU_ACCESS hint optimization

> -Original Message- > From: Christian König > Sent: Wednesday, March 06, 2019 7:55 PM > To: Zhou, David(ChunMing) ; Koenig, Christian > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: force to use CPU_ACCESS hint > optimization > > A

RE: [PATCH 1/3] drm/amdgpu: change Vega IH ring 1 config

Acked-by: Chunming Zhou > -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Wednesday, March 06, 2019 5:29 PM > To: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/3] drm/amdgpu: change Vega IH ring 1 config > > Ping? Can anybody review this? > > Thanks,

RE: [PATCH] drm/amdgpu: Error handling issues about CHECKED_RETURN

> -Original Message- > From: Bo YU > Sent: Thursday, February 14, 2019 12:46 PM > To: Deucher, Alexander ; Koenig, Christian > ; Zhou, David(ChunMing) > ; airl...@linux.ie; dan...@ffwll.ch; Zhu, Rex > ; Grodzovsky, Andrey > ; dri-de...@lists.freed

RE: [PATCH] drm/amdgpu: partial revert cleanup setting bulk_movable v2

If Tom tests it OK as well, feel free add my RB to submit it ASAP. -David > -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Thursday, January 31, 2019 3:57 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: partial revert cleanup setting

回复：[PATCH 2/2] drm/amdgpu: cleanup setting bulk_movable

Reviewed-by: Chunming Zhou send from my phone 原始邮件 主题：[PATCH 2/2] drm/amdgpu: cleanup setting bulk_movable 发件人：Christian König 收件人：amd-gfx@lists.freedesktop.org 抄送： We only need to set this to false now when BOs are removed from the LRU. Signed-off-by: Christian König ---

RE: [PATCH libdrm] amdgpu: add a faster BO list API

Looks good to me, Reviewed-by: Chunming Zhou > -Original Message- > From: amd-gfx On Behalf Of > Marek Ol?ák > Sent: Tuesday, January 08, 2019 3:31 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH libdrm] amdgpu: add a faster BO list API > > From: Marek Olšák > > --- >

RE: [PATCH 2/2] drm/amdgpu: disable vm fault irq during prt accessed

Doesn't gpu check PTE prt bit first and then access va range? Even wrte to dummy page, seem there still is no problem, we don't care that content at all. -David > -Original Message- > From: Christian König > Sent: Thursday, January 03, 2019 5:54 PM > To: Zhou, David(ChunMi

RE: [PATCH 2/2] drm/amdgpu: disable vm fault irq during prt accessed

Seems we don't need two page table, we just map every prt range to dummy page, any problem? -David > -Original Message- > From: Zhou, David(ChunMing) > Sent: Thursday, January 03, 2019 5:23 PM > To: Koenig, Christian ; amd- > g...@lists.freedesktop.org > Subject: R

RE: [PATCH 2/2] drm/amdgpu: disable vm fault irq during prt accessed

> -Original Message- > From: Christian König > Sent: Thursday, January 03, 2019 5:05 PM > To: Zhou, David(ChunMing) ; Koenig, Christian > ; Zhou, David(ChunMing) > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 2/2] drm/amdgpu: disable vm fault irq during pr

RE: [Intel-gfx] [PATCH 03/10] drm/syncobj: add new drm_syncobj_add_point interface v2

y add test case to igt, and tested by many existing test, like libdrm unit test, igt related test, vulkan cts, and steam games. -David > -Original Message- > From: Daniel Vetter > Sent: Wednesday, December 12, 2018 7:15 PM > To: Koenig, Christian > Cc: Zhou, David(

RE: [PATCH 01/10] dma-buf: add new dma_fence_chain container v4

Hi Daniel and Chris, Could you take a look on all the patches? Can we get your RB or AB on all patches including igt patch before we submit to drm-misc? We already fix all existing issues, and also add test case in IGT as your required. Btw, the patch set is tested by below tests: a. vulkan

RE: [PATCH v3 2/2] drm/sched: Rework HW fence processing.

ent: Tuesday, December 11, 2018 5:44 AM > To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; > ckoenig.leichtzumer...@gmail.com; e...@anholt.net; > etna...@lists.freedesktop.org > Cc: Zhou, David(ChunMing) ; Liu, Monk > ; Grodzovsky, Andrey > > Subject: [PATCH v

RE: [PATCH -next] drm/amdgpu: remove set but not used variable 'grbm_soft_reset'

> -Original Message- > From: YueHaibing > Sent: Saturday, December 08, 2018 11:01 PM > To: Deucher, Alexander ; Koenig, Christian > ; Zhou, David(ChunMing) > ; airl...@linux.ie; Liu, Leo ; > Gao, Likun ; Panariti, David > ; S, Shirish ; Zhu, Rex > ; Grodzovsk

RE: [PATCH 1/3] drm/amdgpu: use HMM mirror callback to replace mmu notifier v6

Even you should rename amdgpu_mn.c/h to amdgpu_hmm.c/h. -David > -Original Message- > From: amd-gfx On Behalf Of Yang, > Philip > Sent: Friday, December 07, 2018 5:03 AM > To: amd-gfx@lists.freedesktop.org > Cc: Yang, Philip > Subject: [PATCH 1/3] drm/amdgpu: use HMM mirror callback to

RE: [PATCH 02/11] dma-buf: add new dma_fence_chain container v2

> -Original Message- > From: Christian König > Sent: Monday, December 03, 2018 9:56 PM > To: Zhou, David(ChunMing) ; Koenig, Christian > ; dri-de...@lists.freedesktop.org; amd- > g...@lists.freedesktop.org > Subject: Re: [PATCH 02/11] dma-buf: add new dma_fence

RE: [PATCH libdrm 4/5] wrap syncobj timeline query/wait APIs for amdgpu v3

> -Original Message- > From: Christian König > Sent: Friday, November 30, 2018 5:15 PM > To: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH libdrm 4/5] wrap syncobj timeline query/wait APIs for &g

RE: [PATCH] drm/amdgpu: add the checking to avoid NULL pointer dereference

> -Original Message- > From: Christian König > Sent: Monday, November 26, 2018 5:23 PM > To: Sharma, Deepak ; Zhou, David(ChunMing) > ; Koenig, Christian ; > amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: add the checking to avoid NULL pointer

RE: [PATCH] drm/amd: add the checking to avoid NULL pointer dereference

> -Original Message- > From: amd-gfx On Behalf Of > Sharma, Deepak > Sent: Thursday, November 22, 2018 10:37 AM > To: amd-gfx@lists.freedesktop.org > Cc: Sharma, Deepak > Subject: [PATCH] drm/amd: add the checking to avoid NULL pointer > dereference > > when returned fence is not

RE: [PATCH libdrm 5/5] [libdrm] add syncobj timeline tests

> -Original Message- > From: Daniel Vetter On Behalf Of Daniel Vetter > Sent: Monday, November 05, 2018 5:39 PM > To: Zhou, David(ChunMing) > Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH libdrm 5/5] [libdrm] add sync

RE: [PATCH 2/3] drm/amdgpu: drop the sched_sync

> -Original Message- > From: Koenig, Christian > Sent: Monday, November 05, 2018 3:48 PM > To: Liu, Monk ; amd-gfx@lists.freedesktop.org; Zhou, > David(ChunMing) > Subject: Re: [PATCH 2/3] drm/amdgpu: drop the sched_sync > > Am 05.11.18 um 08:24 schrieb Liu, M

RE: [PATCH] drm/amdgpu: wait for IB test on first device open

Reviewed-by: Chunming Zhou > -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Friday, November 02, 2018 4:45 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: wait for IB test on first device open > > Instead of delaying that to the first

RE: [igt-dev] [PATCH] RFC: Make igts for cross-driver stuff mandatory?

Make igt for cross-driver, I think you should rename it first, not an intel specific. NO company wants their employee working on other company stuff. You can rename it to DGT(drm graphics test), and published following libdrm, or directly merge to libdrm, then everyone can use it and develop

RE: [PATCH v2] drm/amdgpu: Patch csa mc address in IB packet

> -Original Message- > From: amd-gfx On Behalf Of Rex > Zhu > Sent: Wednesday, October 24, 2018 2:03 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH v2] drm/amdgpu: Patch csa mc address in IB packet > > the csa buffer is used by sdma engine to do context save

RE: [PATCH 2/2] drm/amdgpu: Fix null point errro

A minor suggestion, not sure if it's proper, Can we insert these callback checking to func? I know these func could be defined as a macro, can we change them to function definition? David > -Original Message- > From: amd-gfx On Behalf Of Rex > Zhu > Sent: Friday, October 19, 2018

RE: [PATCH 7/7] drm/amdgpu: update version for timeline syncobj support in amdgpu

> To: dri-de...@lists.freedesktop.org > Cc: Zhou, David(ChunMing) ; amd- > g...@lists.freedesktop.org > Subject: [PATCH 7/7] drm/amdgpu: update version for timeline syncobj > support in amdgpu > > Signed-off-by: Chunming Zhou > --- > drivers/gpu/drm/amd/amdgpu/am

RE: [PATCH 3/6] drm: add support of syncobj timeline point wait v2

ay, September 25, 2018 5:50 PM To: Jason Ekstrand ; Zhou, David(ChunMing) Cc: amd-gfx mailing list ; Maling list - DRI developers Subject: Re: [PATCH 3/6] drm: add support of syncobj timeline point wait v2 Am 25.09.2018 um 11:22 schrieb Jason Ekstrand: On Thu, Sep 20, 2018 at 6:04 AM Chunming Zh

RE: [PATCH 5/6] drm/amdgpu: add timeline support in amdgpu CS

> -Original Message- > From: Nicolai Hähnle > Sent: Wednesday, September 26, 2018 4:44 PM > To: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 5/6] drm/amdgpu: add timeline support in amdgpu C

RE: [PATCH 5/6] drm/amdgpu: add timeline support in amdgpu CS

> -Original Message- > From: Nicolai Hähnle > Sent: Wednesday, September 26, 2018 5:06 PM > To: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 5/6] drm/amdgpu: add timeline support in amdgpu

RE: Making use of more Gitlab features for xf86-video-amdgpu

After moving patch submitted and reviewed as MRs, mail list will be no useful? And many people could miss new patches, right? Regards, David Zhou > -Original Message- > From: amd-gfx On Behalf Of > Michel D?nzer > Sent: Friday, September 21, 2018 3:13 PM > To:

RE: [PATCH 3/6] drm: add support of syncobj timeline point wait v2

> -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Thursday, September 20, 2018 7:11 PM > To: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 3/6] drm: add support o

RE: [PATCH 2/6] [RFC]drm: add syncobj timeline support v7

> -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Thursday, September 20, 2018 5:35 PM > To: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel > ; Daniel Vetter ; amd- > g...@lists.freedeskto

RE: [PATCH 2/6] [RFC]drm: add syncobj timeline support v7

Ping... > -Original Message- > From: amd-gfx On Behalf Of > Chunming Zhou > Sent: Wednesday, September 19, 2018 5:18 PM > To: dri-de...@lists.freedesktop.org > Cc: Zhou, David(ChunMing) ; amd- > g...@lists.freedesktop.org; Rakos, Daniel ; Daniel > Vette

RE: [PATCH 1/4] [RFC]drm: add syncobj timeline support v6

> -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Wednesday, September 19, 2018 3:45 PM > To: Zhou, David(ChunMing) ; Zhou, > David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel >

RE: [PATCH] drm/amdgpu: remove fence fallback

> -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Tuesday, September 18, 2018 4:43 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: remove fence fallback > > DC doesn't seem to have a fallback path either. > > So when interrupts doesn't

RE: [PATCH] [RFC]drm: add syncobj timeline support v5

> -Original Message- > From: Daniel Vetter On Behalf Of Daniel Vetter > Sent: Saturday, September 15, 2018 12:11 AM > To: Koenig, Christian > Cc: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Dave Airlie > ; Rakos, Dan

RE: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

> -Original Message- > From: Koenig, Christian > Sent: Friday, September 14, 2018 3:27 PM > To: Zhou, David(ChunMing) ; Zhou, > David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel > ; amd-gfx@lists.freedesktop.org; Daniel Vetter

RE: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

> -Original Message- > From: Koenig, Christian > Sent: Thursday, September 13, 2018 5:20 PM > To: Zhou, David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/3] [RFC]d

RE: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

> -Original Message- > From: Christian König > Sent: Thursday, September 13, 2018 4:50 PM > To: Zhou, David(ChunMing) ; Koenig, Christian > ; dri-de...@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel > ; amd-gfx@lists.freedesktop.org > Subject: Re: [

RE: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

> -Original Message- > From: Koenig, Christian > Sent: Thursday, September 13, 2018 2:56 PM > To: Zhou, David(ChunMing) ; Zhou, > David(ChunMing) ; dri- > de...@lists.freedesktop.org > Cc: Dave Airlie ; Rakos, Daniel > ; amd-gfx@lists.freedesktop.org > Subjec

RE: [PATCH] drm/scheduler: Add stopped flag to drm_sched_entity

-Original Message- From: dri-devel On Behalf Of Andrey Grodzovsky Sent: Friday, August 17, 2018 11:16 PM To: dri-de...@lists.freedesktop.org Cc: Koenig, Christian ; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/scheduler: Add stopped flag to drm_sched_entity The flag will prevent

RE: [PATCH 3/4] drm/scheduler: add new function to get least loaded sched v2

Another big question: I agree the general idea is good to balance scheduler load for same ring family. But, when same entity job run on different scheduler, that means the later job could be completed ahead of front, Right? That will break fence design, later fence must be signaled after front

RE: [PATCH 1/2] drm/amdgpu: return bo itself if userptr is cpu addr of bo (v3)

Typo, excepted -> expected -Original Message- From: amd-gfx On Behalf Of Zhou, David(ChunMing) Sent: Tuesday, July 31, 2018 9:41 AM To: Koenig, Christian ; Zhang, Jerry ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 1/2] drm/amdgpu: return bo itself if userptr is cpu addr of

RE: [PATCH 1/2] drm/amdgpu: return bo itself if userptr is cpu addr of bo (v3)

, David(ChunMing) ; Koenig, Christian Subject: Re: [PATCH 1/2] drm/amdgpu: return bo itself if userptr is cpu addr of bo (v3) Am 30.07.2018 um 12:02 schrieb Junwei Zhang: > From: Chunming Zhou > > v2: get original gem handle from gobj > v3: update find bo data structure as u

RE: [PATCH 9/9] drm/amdgpu: create an empty bo_list if no handle is provided

Series is Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx On Behalf Of Christian K?nig Sent: Monday, July 30, 2018 10:52 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 9/9] drm/amdgpu: create an empty bo_list if no handle is provided Instead of having extra

RE: [PATCH] drm/amdgpu: add new amdgpu_vm_bo_trace_cs() function v2

Go ahead with my RB. -Original Message- From: amd-gfx On Behalf Of Christian K?nig Sent: Monday, July 30, 2018 5:19 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: add new amdgpu_vm_bo_trace_cs() function v2 This allows us to trace all VM ranges which should be valid

RE: [PATCH] drm/amdgpu: add new amdgpu_vm_bo_trace_cs() function

Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Friday, July 27, 2018 10:58 PM To: amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey Subject: [PATCH] drm/amdgpu: add new

RE: [PATCH] drm/amdgpu: add proper error handling to amdgpu_bo_list_get

Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Friday, July 27, 2018 9:39 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: add proper error handling to amdgpu_bo_list_get

RE: [PATCH 1/2] drm/amdgpu: remove superflous UVD encode entity

Acked-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Thursday, July 19, 2018 2:45 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 1/2] drm/amdgpu: remove superflous UVD encode entity Not sure

RE: [PATCH] drm/amdgpu/powerplay: use irq source defines for smu7 sources

Rewiewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Thursday, July 19, 2018 5:09 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/powerplay: use irq source

RE: [PATCH 2/2] drm/amdgpu: clean up UVD instance handling v2

Acked-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Thursday, July 19, 2018 2:45 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 2/2] drm/amdgpu: clean up UVD instance handling v2 The whole

RE: [PATCH] drm/amdgpu: fix job priority handling

Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Thursday, July 19, 2018 2:15 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: fix job priority handling The job might already

RE: [PATCH] drm/amdgpu: always initialize job->base.sched

Acked-by: Chunming Zhou , but I think it isn't a nice evaluation although there is comment in code. -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Tuesday, July 17, 2018 3:05 PM To: amd-gfx@lists.freedesktop.org

RE: [PATCH 2/2] drm/amdgpu: change ring priority after pushing the job

Reviewed-by: Chunming Zhou for series. -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Monday, July 16, 2018 9:25 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 2/2] drm/amdgpu: change ring priority after pushing

RE: [PATCH 7/7] drm/amdgpu: minor cleanup in amdgpu_job.c

Series is Acked-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Friday, July 13, 2018 11:20 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 7/7] drm/amdgpu: minor cleanup in amdgpu_job.c Remove

RE: [PATCH v2] drm/amdgpu: Allow to create BO lists in CS ioctl v2

Hi Andrey, Could you add compatibility flag or increase kms driver version? So that user space can keep old path when using new one. Regards, David Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of zhoucm1 Sent: Thursday, July 12, 2018

RE: [PATCH 1/2] drm/amdgpu: switch firmware path for CIK parts

Yes, agree, radeon driver uses radeon path, amdgpu uses amdgpu path, which makes sense to me. The series is Reviewed-by: Chunming Zhou Regards, David Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Tuesday, July 03,

RE: [PATCH] drm/amdgpu: remove duplicated codes

Feel free add my RB on that. Thanks, David Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Flora Cui Sent: Wednesday, June 27, 2018 3:06 PM To: Zhou, David(ChunMing) Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu

RE: [PATCH] drm/amdgpu: remove duplicated codes

Please add patch's comment to describe where and where are duplicated. -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Flora Cui Sent: Wednesday, June 27, 2018 2:10 PM To: amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH]

Re: [PATCH] drm/amdgpu: Add AMDGPU_GPU_PAGES_IN_CPU_PAGE define

current amdgpu driver indeed always set GPU PAGE SIZE is 4096. In fact, our gpu supports bigger page size like 64KB, just we don't use it. I remeber previous amdsoc(old android kernel driver) used 64KB. correct me if I'm wrong. send from Smartisan Pro Michel D鋘zer 于 2018年6月25日 下午5:10写道： On

RE: [PATCH v2 1/2] drm/scheduler: Rename cleanup functions v2.

Acked-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Andrey Grodzovsky Sent: Thursday, June 21, 2018 11:33 PM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: e...@anholt.net; Koenig, Christian ;

RE: [PATCH] drm/amdgpu: skip huge page for PRT mapping

Good catch, Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Junwei Zhang Sent: Monday, June 04, 2018 10:04 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jerry Subject: [PATCH] drm/amdgpu: skip huge page for PRT

RE: [PATCH] drm/amdgpu: add rcu_barrier after entity fini

Looks good, Acked-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Emily Deng Sent: Thursday, May 17, 2018 11:05 AM To: amd-gfx@lists.freedesktop.org Cc: Deng, Emily Subject: [PATCH]

RE: [PATCH 2/2] drm/amdgpu: set ttm bo priority before initialization

md-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: Koenig, Christian <christian.koe...@amd.com>; Zhou, David(ChunMing) <david1.z...@amd.com>; Zhang, Jerry <jerry.zh...@amd.com> Subject: [PATCH 2/2] drm/amdgpu: set ttm bo priority before initialization Signed-off-by

RE: [PATCH] drm/amdgpu: bo could be null when access in vm bo update

Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Junwei Zhang Sent: Monday, April 23, 2018 5:29 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jerry Subject: [PATCH]

RE: [PATCH] drm/scheduler: fix build broken by "move last_sched fence updating prior to job popping"

Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Wednesday, April 18, 2018 6:06 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/scheduler: fix build broken by

RE: PROBLEM: linux-firmware provided firmware files do not support AMDVLK driver

As I known, AMDVLK is running on amdgpu driver, not support readon kernel driver. Regards, David Zhou -Original Message- From: boomboom psh [mailto:andrewston...@gmail.com] Sent: Wednesday, April 18, 2018 11:16 AM To: Deucher, Alexander <alexander.deuc...@amd.com>; Zhou, David(Ch

Re: [PATCH 2/3] drm/amdgpu: refresh per vm bo lru

then how to keep unique lru order? any ideas? To stable performance, we have to keep unique lru order, otherwise like the issue I look into, sometimes F1game is 40fps, sometimes 28fps...even re-validate allowed domains BO. The left root cause is the moved BOs are not same. send from

RE: [PATCH] drm/amdgpu: use separate status for buffer funcs availability v2

Patch#1 is Reviewed-by: Chunming Zhou Patch#2~#4 are Acked-by: Chunming zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Thursday, March 01, 2018 7:53 PM To:

Re: [PATCH 1/2] [WIP]drm/ttm: add waiter list to prevent allocation not in order

. See when you want to prevent a process B from allocating the memory process A has evicted, you need to prevent all concurrent allocation. And we don't do that because it causes a major performance drop. Regards, Christian. Am 26.01.2018 um 14:21 schrieb Zhou, David(ChunMing): You patch will p

Re: [PATCH 1/2] [WIP]drm/ttm: add waiter list to prevent allocation not in order

egards, Christian. Am 26.01.2018 um 13:43 schrieb Christian König: After my investigation, this issue should be detect of TTM design self, which breaks scheduling balance. Yeah, but again. This is indented design we can't change easily. Regards, Christian. Am 26.01.2018 um 13:36 schrieb Zhou, David(ChunMi

Re: [PATCH 1/2] [WIP]drm/ttm: add waiter list to prevent allocation not in order

I am off work, so reply mail by phone, the format could not be text. back to topic itself: the problem indeed happen on amdgpu driver, someone reports me that application runs with two instances, the performance are different. I also reproduced the issue with unit test(bo_eviction_test). They

RE: [PATCH 1/5] drm/amdgpu: add new asic callbacks for HDP flush/invalidation

Seems amdgpu_asic_invalidate_hdp() isn't used any more in following patch. Regards, David Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Friday, January 05, 2018 12:19 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher,

Re: [PATCH 2/4] drm/amdgpu: minor optimize VM moved handling v2

t; > On 2018年01月03日 17:25, Christian König wrote: >> Am 03.01.2018 um 09:10 schrieb Zhou, David(ChunMing): >>> >>> On 2018年01月02日 22:47, Christian König wrote: >>>> Try to lock moved BOs if it's successful we can update the >>>> PTEs directly to the new

Re: [PATCH 2/4] drm/amdgpu: minor optimize VM moved handling v2

On 2018年01月02日 22:47, Christian König wrote: > Try to lock moved BOs if it's successful we can update the > PTEs directly to the new location. > > v2: rebase > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 15 ++- > 1

RE: [PATCH 4/5] drm/amdgpu: rename vm_id to vmid

Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Wednesday, December 20, 2017 9:21 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 4/5] drm/amdgpu: rename vm_id to vmid

RE: [PATCH 3/5] drm/amdgpu: separate VMID and PASID handling

Looks very good, Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Wednesday, December 20, 2017 9:21 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 3/5] drm/amdgpu:

  1   2   >