Re: [PATCH] drm/amdgpu: Correct the place of amdgpu_pm_sysfs_fini

[Alex Deucher]

On Wed, Mar 7, 2018 at 5:17 AM, Emily Deng  wrote:
> The amdgpu_pm_sysfs_fini should call before amdgpu_device_ip_fini,
> or the adev->pm.dpm_enabled would be set to 0, then the device files
> related to pp won't be removed by amdgpu_pm_sysfs_fini when unload
> driver.
>
> Signed-off-by: Emily Deng 

Reviewed-by: Alex Deucher 

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index f67f5bf..8a8f8f6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2096,6 +2096,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev)
>
> amdgpu_ib_pool_fini(adev);
> amdgpu_fence_driver_fini(adev);
> +   amdgpu_pm_sysfs_fini(adev);
> amdgpu_fbdev_fini(adev);
> r = amdgpu_device_ip_fini(adev);
> if (adev->firmware.gpu_info_fw) {
> @@ -2124,7 +2125,6 @@ void amdgpu_device_fini(struct amdgpu_device *adev)
> iounmap(adev->rmmio);
> adev->rmmio = NULL;
> amdgpu_device_doorbell_fini(adev);
> -   amdgpu_pm_sysfs_fini(adev);
> amdgpu_debugfs_regs_cleanup(adev);
>  }
>
> --
> 2.7.4
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amdgpu: Correct the place of amdgpu_pm_sysfs_fini

[Emily Deng]

The amdgpu_pm_sysfs_fini should call before amdgpu_device_ip_fini,
or the adev->pm.dpm_enabled would be set to 0, then the device files
related to pp won't be removed by amdgpu_pm_sysfs_fini when unload
driver.

Signed-off-by: Emily Deng 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index f67f5bf..8a8f8f6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2096,6 +2096,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev)
 
amdgpu_ib_pool_fini(adev);
amdgpu_fence_driver_fini(adev);
+   amdgpu_pm_sysfs_fini(adev);
amdgpu_fbdev_fini(adev);
r = amdgpu_device_ip_fini(adev);
if (adev->firmware.gpu_info_fw) {
@@ -2124,7 +2125,6 @@ void amdgpu_device_fini(struct amdgpu_device *adev)
iounmap(adev->rmmio);
adev->rmmio = NULL;
amdgpu_device_doorbell_fini(adev);
-   amdgpu_pm_sysfs_fini(adev);
amdgpu_debugfs_regs_cleanup(adev);
 }
 
-- 
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx