Re: [PATCH 6/6] drm/amdgpu:PTE flag should be 64 bit width

2017-05-03 Thread Alex Deucher 
On Tue, May 2, 2017 at 11:48 PM, Monk Liu  wrote:
> otherwise we'll lost the high 32 bit for pte, which lead
> to incorrect MTYPE for vega10.
>
> Change-Id: I1b0c7b8df14e340a36d4d2a72c6c03f469fdc29c
> Signed-off-by: Monk Liu 
> Reviewed-by: Christian König 

Reviewed-by: Alex Deucher 

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index 11c6c44..c3fb2f9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -765,7 +765,7 @@ int amdgpu_ttm_recover_gart(struct amdgpu_device *adev)
>  {
> struct amdgpu_ttm_tt *gtt, *tmp;
> struct ttm_mem_reg bo_mem;
> -   uint32_t flags;
> +   uint64_t flags;
> int r;
>
> bo_mem.mem_type = TTM_PL_TT;
> --
> 2.7.4
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 6/6] drm/amdgpu:PTE flag should be 64 bit width

2017-05-01 Thread Christian König 

Am 01.05.2017 um 08:34 schrieb Monk Liu:

otherwise we'll lost the high 32 bit for pte, which lead
to incorrect MTYPE for vega10.

Change-Id: I1b0c7b8df14e340a36d4d2a72c6c03f469fdc29c
Signed-off-by: Monk Liu 


Nice catch, patch is Reviewed-by: Christian König 


---
  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 11c6c44..c3fb2f9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -765,7 +765,7 @@ int amdgpu_ttm_recover_gart(struct amdgpu_device *adev)
  {
struct amdgpu_ttm_tt *gtt, *tmp;
struct ttm_mem_reg bo_mem;
-   uint32_t flags;
+   uint64_t flags;
int r;
  
  	bo_mem.mem_type = TTM_PL_TT;



___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 6/6] drm/amdgpu:PTE flag should be 64 bit width

2017-05-01 Thread Monk Liu 
otherwise we'll lost the high 32 bit for pte, which lead
to incorrect MTYPE for vega10.

Change-Id: I1b0c7b8df14e340a36d4d2a72c6c03f469fdc29c
Signed-off-by: Monk Liu 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 11c6c44..c3fb2f9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -765,7 +765,7 @@ int amdgpu_ttm_recover_gart(struct amdgpu_device *adev)
 {
struct amdgpu_ttm_tt *gtt, *tmp;
struct ttm_mem_reg bo_mem;
-   uint32_t flags;
+   uint64_t flags;
int r;
 
bo_mem.mem_type = TTM_PL_TT;
-- 
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx