Re: [patch] drm/radeon: remove some dead code

2017-02-08 Thread Alex Deucher 
On Tue, Feb 7, 2017 at 8:16 AM, Dan Carpenter  wrote:
> If "rdev->bios" is NULL then we don't need to free it.
>
> Signed-off-by: Dan Carpenter 

applied.  thanks!

>
> diff --git a/drivers/gpu/drm/radeon/radeon_bios.c 
> b/drivers/gpu/drm/radeon/radeon_bios.c
> index 00cfb5d2875f..04c0ed41374f 100644
> --- a/drivers/gpu/drm/radeon/radeon_bios.c
> +++ b/drivers/gpu/drm/radeon/radeon_bios.c
> @@ -638,10 +638,8 @@ static bool radeon_acpi_vfct_bios(struct radeon_device 
> *rdev)
>  vhdr->ImageLength,
>  GFP_KERNEL);
>
> -   if (!rdev->bios) {
> -   kfree(rdev->bios);
> +   if (!rdev->bios)
> return false;
> -   }
> return true;
> }
> }
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [patch] drm/radeon: remove some dead code

2017-02-07 Thread Michel Dänzer 
On 07/02/17 10:16 PM, Dan Carpenter wrote:
> If "rdev->bios" is NULL then we don't need to free it.
> 
> Signed-off-by: Dan Carpenter 
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_bios.c 
> b/drivers/gpu/drm/radeon/radeon_bios.c
> index 00cfb5d2875f..04c0ed41374f 100644
> --- a/drivers/gpu/drm/radeon/radeon_bios.c
> +++ b/drivers/gpu/drm/radeon/radeon_bios.c
> @@ -638,10 +638,8 @@ static bool radeon_acpi_vfct_bios(struct radeon_device 
> *rdev)
>vhdr->ImageLength,
>GFP_KERNEL);
>  
> - if (!rdev->bios) {
> - kfree(rdev->bios);
> + if (!rdev->bios)
>   return false;
> - }
>   return true;

Could be simplified further to

return rdev->bios != NULL;

or maybe

return !!rdev->bios;

Either way,

Reviewed-by: Michel Dänzer 


-- 
Earthling Michel Dänzer   |   http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[patch] drm/radeon: remove some dead code

2017-02-07 Thread Dan Carpenter 
If "rdev->bios" is NULL then we don't need to free it.

Signed-off-by: Dan Carpenter 

diff --git a/drivers/gpu/drm/radeon/radeon_bios.c 
b/drivers/gpu/drm/radeon/radeon_bios.c
index 00cfb5d2875f..04c0ed41374f 100644
--- a/drivers/gpu/drm/radeon/radeon_bios.c
+++ b/drivers/gpu/drm/radeon/radeon_bios.c
@@ -638,10 +638,8 @@ static bool radeon_acpi_vfct_bios(struct radeon_device 
*rdev)
 vhdr->ImageLength,
 GFP_KERNEL);
 
-   if (!rdev->bios) {
-   kfree(rdev->bios);
+   if (!rdev->bios)
return false;
-   }
return true;
}
}
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx