Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-08-03 Thread Arnd Bergmann
On Thu, Jul 30, 2020 at 11:09 PM Luben Tuikov wrote: > On 2020-07-29 9:49 a.m., Alex Deucher wrote: > > On Wed, Jul 29, 2020 at 4:11 AM Christian König > > wrote: > >> > >> Am 28.07.20 um 21:29 schrieb Peilin Ye: > >>> Compiler leaves a 4-byte hole near the end of `dev_info`, causing > >>>

Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-31 Thread Christian König
Am 31.07.20 um 09:10 schrieb Greg Kroah-Hartman: On Fri, Jul 31, 2020 at 08:57:53AM +0200, Christian König wrote: Am 31.07.20 um 08:53 schrieb Greg Kroah-Hartman: On Thu, Jul 30, 2020 at 05:09:07PM -0400, Luben Tuikov wrote: On 2020-07-29 9:49 a.m., Alex Deucher wrote: On Wed, Jul 29, 2020

Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-31 Thread Greg Kroah-Hartman
On Fri, Jul 31, 2020 at 08:57:53AM +0200, Christian König wrote: > Am 31.07.20 um 08:53 schrieb Greg Kroah-Hartman: > > On Thu, Jul 30, 2020 at 05:09:07PM -0400, Luben Tuikov wrote: > > > On 2020-07-29 9:49 a.m., Alex Deucher wrote: > > > > On Wed, Jul 29, 2020 at 4:11 AM Christian König > > > >

Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-31 Thread Greg Kroah-Hartman
On Thu, Jul 30, 2020 at 05:09:07PM -0400, Luben Tuikov wrote: > On 2020-07-29 9:49 a.m., Alex Deucher wrote: > > On Wed, Jul 29, 2020 at 4:11 AM Christian König > > wrote: > >> > >> Am 28.07.20 um 21:29 schrieb Peilin Ye: > >>> Compiler leaves a 4-byte hole near the end of `dev_info`, causing >

Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-31 Thread Christian König
Am 31.07.20 um 08:53 schrieb Greg Kroah-Hartman: On Thu, Jul 30, 2020 at 05:09:07PM -0400, Luben Tuikov wrote: On 2020-07-29 9:49 a.m., Alex Deucher wrote: On Wed, Jul 29, 2020 at 4:11 AM Christian König wrote: Am 28.07.20 um 21:29 schrieb Peilin Ye: Compiler leaves a 4-byte hole near the

Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-30 Thread Luben Tuikov
On 2020-07-29 9:49 a.m., Alex Deucher wrote: > On Wed, Jul 29, 2020 at 4:11 AM Christian König > wrote: >> >> Am 28.07.20 um 21:29 schrieb Peilin Ye: >>> Compiler leaves a 4-byte hole near the end of `dev_info`, causing >>> amdgpu_info_ioctl() to copy uninitialized kernel stack memory to

Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-29 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jul 29, 2020 at 4:11 AM Christian König wrote: > > Am 28.07.20 um 21:29 schrieb Peilin Ye: > > Compiler leaves a 4-byte hole near the end of `dev_info`, causing > > amdgpu_info_ioctl() to copy uninitialized kernel stack memory to userspace > > when `size` is

Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-29 Thread Alex Deucher
On Wed, Jul 29, 2020 at 4:11 AM Christian König wrote: > > Am 28.07.20 um 21:29 schrieb Peilin Ye: > > Compiler leaves a 4-byte hole near the end of `dev_info`, causing > > amdgpu_info_ioctl() to copy uninitialized kernel stack memory to userspace > > when `size` is greater than 356. > > > > In

Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-29 Thread Daniel Vetter
On Wed, Jul 29, 2020 at 10:11 AM Christian König wrote: > > Am 28.07.20 um 21:29 schrieb Peilin Ye: > > Compiler leaves a 4-byte hole near the end of `dev_info`, causing > > amdgpu_info_ioctl() to copy uninitialized kernel stack memory to userspace > > when `size` is greater than 356. > > > > In

Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-29 Thread Christian König
Am 28.07.20 um 21:29 schrieb Peilin Ye: Compiler leaves a 4-byte hole near the end of `dev_info`, causing amdgpu_info_ioctl() to copy uninitialized kernel stack memory to userspace when `size` is greater than 356. In 2015 we tried to fix this issue by doing `= {};` on `dev_info`, which

[Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl()

2020-07-28 Thread Peilin Ye
Compiler leaves a 4-byte hole near the end of `dev_info`, causing amdgpu_info_ioctl() to copy uninitialized kernel stack memory to userspace when `size` is greater than 356. In 2015 we tried to fix this issue by doing `= {};` on `dev_info`, which unfortunately does not initialize that 4-byte