Re: [PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

2016-10-19 Thread StDenis, Tom
the patch was part of a series that was blocking other work and there wasn't sufficient cause to NAK it. Tom From: Michel Dänzer Sent: Tuesday, October 18, 2016 23:49 To: StDenis, Tom; Christian König Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH]

Re: [PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

2016-10-18 Thread Michel Dänzer
On 13/10/16 04:20 PM, Michel Dänzer wrote: > On 13/10/16 12:39 AM, StDenis, Tom wrote: >> It comes from amdgpu_query_gpu_info_init() >> >> >> for (i = 0; i < (int)dev->info.num_shader_engines; i++) { >> unsigned instance = (i << AMDGPU_INFO_MMR_SE_INDEX_SHIFT) | >>

Re: [PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

2016-10-13 Thread Michel Dänzer
On 13/10/16 12:39 AM, StDenis, Tom wrote: > It comes from amdgpu_query_gpu_info_init() > > > for (i = 0; i < (int)dev->info.num_shader_engines; i++) { > unsigned instance = (i << AMDGPU_INFO_MMR_SE_INDEX_SHIFT) | > (*AMDGPU_INFO_MMR_SH_I

Re: [PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

2016-10-12 Thread StDenis, Tom
se * if you don't want to and furthermore I'm already using the write debugfs content (to debug waveforms). Tom From: Michel Dänzer Sent: Tuesday, October 11, 2016 20:34 To: StDenis, Tom; Christian König Cc: amd-gfx@lists.freedesktop.org Subject: Re:

Re: [PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

2016-10-11 Thread Michel Dänzer
On 11/10/16 09:32 PM, StDenis, Tom wrote: > It's used by the UMD though they read from 0/*/* when reading the > RASTER_CONFIG registers (which may be a bug...) We should probably clarify what userspace is trying to do there, and whether the hardware actually does that. -- Earthling Michel Dänze

Re: [PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

2016-10-11 Thread StDenis, Tom
Tom From: Christian König Sent: Tuesday, October 11, 2016 08:30 To: StDenis, Tom; Michel Dänzer Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2) I briefly remember reading in some hardware doc that this actually has a defined behavior. I

Re: [PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

2016-10-11 Thread Christian König
behalf of Michel Dänzer *Sent:* Monday, October 10, 2016 23:52 *To:* Tom St Denis *Cc:* amd-gfx@lists.freedesktop.org *Subject:* Re: [PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2) On 09/10/16 08:58 PM, Tom St Denis wrote: > Allow any of the se/sh/instance fields to be &

Re: [PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

2016-10-11 Thread StDenis, Tom
... hmm.. Tom From: amd-gfx on behalf of Michel Dänzer Sent: Monday, October 10, 2016 23:52 To: Tom St Denis Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2) On 09/10/16 08:58 PM, Tom St Denis wrote

Re: [PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

2016-10-10 Thread Michel Dänzer
On 09/10/16 08:58 PM, Tom St Denis wrote: > Allow any of the se/sh/instance fields to be > specified as a broadcast by submitting 0x3FF. > > (v2) Fix broadcast range checking > > Signed-off-by: Tom St Denis I'm not sure how a "broadcast read" is supposed to work? I can only see the register spe

[PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

2016-10-09 Thread Tom St Denis
Allow any of the se/sh/instance fields to be specified as a broadcast by submitting 0x3FF. (v2) Fix broadcast range checking Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read

2016-10-09 Thread Tom St Denis
Allow any of the se/sh/instance fields to be specified as a broadcast by submitting 0x3FF. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgp