Re: [PATCH] drm/amd/amdgpu: cast mem->num_pages to 64-bits when shifting

2019-06-17 Thread StDenis, Tom
Ok no worries I'll fix it up and push it later today. Btw I didn't use an inline cast because the macro kept breaking. I tried variants of parentheses and nothing worked Odd... Thanks, Tom On June 17, 2019 3:32:03 PM EDT, "Kuehling, Felix" wrote: On 2019-06-17 3:28 p.m., Christian

Re: [PATCH] drm/amd/amdgpu: cast mem->num_pages to 64-bits when shifting

2019-06-17 Thread Kuehling, Felix
On 2019-06-17 3:28 p.m., Christian König wrote: > Am 17.06.19 um 21:15 schrieb Kuehling, Felix: >> Looks good to me. One cosmetic comment inline. With that fixed this >> patch is Reviewed-by:  Felix Kuehling >> >> On 2019-06-14 12:51 p.m., StDenis, Tom wrote: >>> On 32-bit hosts mem->num_pages is

Re: [PATCH] drm/amd/amdgpu: cast mem->num_pages to 64-bits when shifting

2019-06-17 Thread Christian König
Am 17.06.19 um 21:15 schrieb Kuehling, Felix: Looks good to me. One cosmetic comment inline. With that fixed this patch is Reviewed-by:  Felix Kuehling On 2019-06-14 12:51 p.m., StDenis, Tom wrote: On 32-bit hosts mem->num_pages is 32-bits and can overflow when shifted. Add a cast to avoid

Re: [PATCH] drm/amd/amdgpu: cast mem->num_pages to 64-bits when shifting

2019-06-17 Thread Christian König
Reviewed-by: Christian König Am 17.06.19 um 20:21 schrieb Tom St Denis: ping? On Fri, Jun 14, 2019 at 12:51 PM StDenis, Tom > wrote: On 32-bit hosts mem->num_pages is 32-bits and can overflow when shifted.  Add a cast to avoid this. Signed-off-by:

Re: [PATCH] drm/amd/amdgpu: cast mem->num_pages to 64-bits when shifting

2019-06-17 Thread Kuehling, Felix
Looks good to me. One cosmetic comment inline. With that fixed this patch is Reviewed-by:  Felix Kuehling On 2019-06-14 12:51 p.m., StDenis, Tom wrote: > On 32-bit hosts mem->num_pages is 32-bits and can overflow > when shifted. Add a cast to avoid this. > > Signed-off-by: Tom St Denis > ---

Re: [PATCH] drm/amd/amdgpu: cast mem->num_pages to 64-bits when shifting

2019-06-17 Thread Tom St Denis
ping? On Fri, Jun 14, 2019 at 12:51 PM StDenis, Tom wrote: > On 32-bit hosts mem->num_pages is 32-bits and can overflow > when shifted. Add a cast to avoid this. > > Signed-off-by: Tom St Denis > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 8 +--- > 1 file changed, 5

[PATCH] drm/amd/amdgpu: cast mem->num_pages to 64-bits when shifting

2019-06-14 Thread StDenis, Tom
On 32-bit hosts mem->num_pages is 32-bits and can overflow when shifted. Add a cast to avoid this. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git