Re: [PATCH] drm/amd/display: Skip fast cursor updates for fb changes

2018-12-17 Thread Grodzovsky, Andrey
On 12/17/2018 04:53 AM, Michel Dänzer wrote: > On 2018-12-15 6:25 a.m., Grodzovsky, Andrey wrote: >> On 12/14/2018 02:17 PM, Kazlauskas, Nicholas wrote: >>> On 12/14/18 2:06 PM, Grodzovsky, Andrey wrote: In general I agree with Michel that  DRM solution is required to properly address

Re: [PATCH] drm/amd/display: Skip fast cursor updates for fb changes

2018-12-17 Thread Michel Dänzer
On 2018-12-15 6:25 a.m., Grodzovsky, Andrey wrote: > On 12/14/2018 02:17 PM, Kazlauskas, Nicholas wrote: >> On 12/14/18 2:06 PM, Grodzovsky, Andrey wrote: >>> In general I agree with Michel that  DRM solution is required to >>> properly address this but since now it's not really obvious what is

Re: [PATCH] drm/amd/display: Skip fast cursor updates for fb changes

2018-12-14 Thread Grodzovsky, Andrey
On 12/14/2018 02:17 PM, Kazlauskas, Nicholas wrote: > On 12/14/18 2:06 PM, Grodzovsky, Andrey wrote: >> In general I agree with Michel that  DRM solution is required to >> properly address this but since now it's not really obvious what is the >> proper solution it seems to me OK to go with this

Re: [PATCH] drm/amd/display: Skip fast cursor updates for fb changes

2018-12-14 Thread Wentland, Harry
On 2018-12-14 12:26 p.m., Nicholas Kazlauskas wrote: > [Why] > The behavior of drm_atomic_helper_cleanup_planes differs depending on > whether the commit was asynchronous or not. When it's called from > amdgpu_dm_atomic_commit_tail during a typical atomic commit the > plane state has been swapped

Re: [PATCH] drm/amd/display: Skip fast cursor updates for fb changes

2018-12-14 Thread Kazlauskas, Nicholas
On 12/14/18 2:06 PM, Grodzovsky, Andrey wrote: > In general I agree with Michel that  DRM solution is required to > properly address this but since now it's not really obvious what is the > proper solution it seems to me OK to go with this fix until it's found. > > Reviewed-by: Andrey Grodzovsky

Re: [PATCH] drm/amd/display: Skip fast cursor updates for fb changes

2018-12-14 Thread Grodzovsky, Andrey
In general I agree with Michel that  DRM solution is required to properly address this but since now it's not really obvious what is the proper solution it seems to me OK to go with this fix until it's found. Reviewed-by: Andrey Grodzovsky Andrey On 12/14/2018 12:51 PM, Kazlauskas, Nicholas

Re: [PATCH] drm/amd/display: Skip fast cursor updates for fb changes

2018-12-14 Thread Kazlauskas, Nicholas
On 12/14/18 12:47 PM, Grodzovsky, Andrey wrote: > > > On 12/14/2018 12:41 PM, Kazlauskas, Nicholas wrote: >> On 12/14/18 12:34 PM, Grodzovsky, Andrey wrote: >>> >>> On 12/14/2018 12:26 PM, Nicholas Kazlauskas wrote: [Why] The behavior of drm_atomic_helper_cleanup_planes differs

Re: [PATCH] drm/amd/display: Skip fast cursor updates for fb changes

2018-12-14 Thread Grodzovsky, Andrey
On 12/14/2018 12:41 PM, Kazlauskas, Nicholas wrote: > On 12/14/18 12:34 PM, Grodzovsky, Andrey wrote: >> >> On 12/14/2018 12:26 PM, Nicholas Kazlauskas wrote: >>> [Why] >>> The behavior of drm_atomic_helper_cleanup_planes differs depending on >>> whether the commit was asynchronous or not. When

Re: [PATCH] drm/amd/display: Skip fast cursor updates for fb changes

2018-12-14 Thread Kazlauskas, Nicholas
On 12/14/18 12:34 PM, Grodzovsky, Andrey wrote: > > > On 12/14/2018 12:26 PM, Nicholas Kazlauskas wrote: >> [Why] >> The behavior of drm_atomic_helper_cleanup_planes differs depending on >> whether the commit was asynchronous or not. When it's called from >> amdgpu_dm_atomic_commit_tail during a

Re: [PATCH] drm/amd/display: Skip fast cursor updates for fb changes

2018-12-14 Thread Grodzovsky, Andrey
On 12/14/2018 12:26 PM, Nicholas Kazlauskas wrote: > [Why] > The behavior of drm_atomic_helper_cleanup_planes differs depending on > whether the commit was asynchronous or not. When it's called from > amdgpu_dm_atomic_commit_tail during a typical atomic commit the > plane state has been swapped

[PATCH] drm/amd/display: Skip fast cursor updates for fb changes

2018-12-14 Thread Nicholas Kazlauskas
[Why] The behavior of drm_atomic_helper_cleanup_planes differs depending on whether the commit was asynchronous or not. When it's called from amdgpu_dm_atomic_commit_tail during a typical atomic commit the plane state has been swapped so it calls cleanup_fb on the old plane state. However, in the