Re: [PATCH] drm/amd/pm: Activate a more aggressive DPM policy while there's heavy load.

2020-10-27 Thread Ernst Sjöstrand
Is this really a patch for kernel.org? Seems like a hack for Stadia or
something. (And the patch description is not very good...)

This should really be made into a generic solution.

Regards
//Ernst

Den tis 27 okt. 2020 kl 07:38 skrev Li, Xin (Justin) :

> [AMD Official Use Only - Internal Distribution Only]
>
> Fix performace drop while streaming Doom
>
> Signed-off-by: Li, Xin (Justin) 
> Signed-off-by: Zhao, Jiange 
> ---
>  drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 14 ++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> index eab9768029c1..5287ac4e8364 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> @@ -125,6 +125,20 @@ static int pp_hw_init(void *handle)
>
>  ret = hwmgr_hw_init(hwmgr);
>
> +   if (adev->pdev->device == 0x6860 && adev->pdev->revision == 0x07) {
> +   long param[5];
> +
> +   param[0] = 5;  // busy_set_point
> +   param[1] = 60; // FPS
> +   param[2] = 0;  // use_rlc_busy
> +   param[3] = 3;  // min_active_level
> +   param[4] = PP_SMC_POWER_PROFILE_CUSTOM;
> +
> +   mutex_lock(>smu_lock);
> +   ret = hwmgr->hwmgr_func->set_power_profile_mode(hwmgr,
> param, 4);
> +   mutex_unlock(>smu_lock);
> +   }
> +
>  if (ret)
>  pr_err("powerplay hw init failed\n");
>
> --
> 2.24.3 (Apple Git-128)
>
>
> ___
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[PATCH] drm/amd/pm: Activate a more aggressive DPM policy while there's heavy load.

2020-10-27 Thread Li, Xin (Justin)
[AMD Official Use Only - Internal Distribution Only]

Fix performace drop while streaming Doom

Signed-off-by: Li, Xin (Justin) mailto:xin2...@amd.com>>
Signed-off-by: Zhao, Jiange mailto:jiange.z...@amd.com>>
---
 drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c 
b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
index eab9768029c1..5287ac4e8364 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
@@ -125,6 +125,20 @@ static int pp_hw_init(void *handle)

 ret = hwmgr_hw_init(hwmgr);

+   if (adev->pdev->device == 0x6860 && adev->pdev->revision == 0x07) {
+   long param[5];
+
+   param[0] = 5;  // busy_set_point
+   param[1] = 60; // FPS
+   param[2] = 0;  // use_rlc_busy
+   param[3] = 3;  // min_active_level
+   param[4] = PP_SMC_POWER_PROFILE_CUSTOM;
+
+   mutex_lock(>smu_lock);
+   ret = hwmgr->hwmgr_func->set_power_profile_mode(hwmgr, param, 
4);
+   mutex_unlock(>smu_lock);
+   }
+
 if (ret)
 pr_err("powerplay hw init failed\n");

--
2.24.3 (Apple Git-128)

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx