Re: [PATCH] drm/amdgpu/psp: prevent page fault by checking write_frame address(v2) -v2: update the ring_buffer_end address

2017-10-17 Thread Alex Deucher
On Mon, Oct 16, 2017 at 11:26 PM, Evan Quan wrote: > Change-Id: If3b79428b32ffab57b4e75f9c20c2b2d7e600223 > Signed-off-by: Evan Quan Please include a better commit message. Something like: Prevent a a possible buffer overflow when updating the ring buffer

[PATCH] drm/amdgpu/psp: prevent page fault by checking write_frame address(v2) -v2: update the ring_buffer_end address

2017-10-16 Thread Evan Quan
Change-Id: If3b79428b32ffab57b4e75f9c20c2b2d7e600223 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 16 ++-- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 16 ++-- 2 files changed, 28 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] drm/amdgpu/psp: prevent page fault by checking write_frame address

2017-10-16 Thread Alex Deucher
On Mon, Oct 16, 2017 at 5:09 AM, Evan Quan wrote: > Change-Id: If3b79428b32ffab57b4e75f9c20c2b2d7e600223 > Signed-off-by: Evan Quan Please provide a more detailed commit message. Seems like we should look at converting the psp to use the common ring

[PATCH] drm/amdgpu/psp: prevent page fault by checking write_frame address

2017-10-16 Thread Evan Quan
Change-Id: If3b79428b32ffab57b4e75f9c20c2b2d7e600223 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 31 --- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 31 --- 2 files changed, 40 insertions(+), 22