Re: [PATCH] drm/amdgpu/vcn: remove unnecessary included headers

2019-12-16 Thread Alex Deucher
On Mon, Dec 16, 2019 at 3:15 PM Leo Liu wrote: > > Esp. VCN1.0 headers should not be here > > v2: add back the to keep consistent. > > Signed-off-by: Leo Liu Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git

[PATCH] drm/amdgpu/vcn: remove unnecessary included headers

2019-12-16 Thread Leo Liu
Esp. VCN1.0 headers should not be here v2: add back the to keep consistent. Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c index

Re: [PATCH] drm/amdgpu/vcn: remove unnecessary included headers

2019-12-16 Thread Leo Liu
Hi Alex, I searched and found why it get built okay: amdgpu.h includes amdgpu_mode.h, and that include linux/i2c.h. And linux/i2c.h includes linux/acpi.h and that includes linux/modules.h. Tested it by commenting out linux/modules.h from linux/acpi.h, then the build for amdgpu.ko would fail

Re: [PATCH] drm/amdgpu/vcn: remove unnecessary included headers

2019-12-16 Thread Leo Liu
On 2019-12-16 11:36 a.m., Alex Deucher wrote: On Mon, Dec 16, 2019 at 11:06 AM Leo Liu wrote: Esp. VCN1.0 headers should not be here Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 7 --- 1 file changed, 7 deletions(-) diff --git

Re: [PATCH] drm/amdgpu/vcn: remove unnecessary included headers

2019-12-16 Thread Alex Deucher
On Mon, Dec 16, 2019 at 11:06 AM Leo Liu wrote: > > Esp. VCN1.0 headers should not be here > > Signed-off-by: Leo Liu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c >

[PATCH] drm/amdgpu/vcn: remove unnecessary included headers

2019-12-16 Thread Leo Liu
Esp. VCN1.0 headers should not be here Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c index e522025430c7..371f55de42dc 100644 ---