day, April 30, 2019 5:59 PM
> To: Huang, Trigger ; Kuehling, Felix
> ; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/amdgpu: Unmap CSA under SR-IOV in KFD path
>
> Am 30.04.19 um 11:53 schrieb Huang, Trigger:
>> Hi Christian & Felix,
>>
>> Thanks for
m: Christian König
Sent: Tuesday, April 30, 2019 5:23 PM
To: Kuehling, Felix ; Huang, Trigger
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Unmap CSA under SR-IOV in KFD path
[CAUTION: External Email]
Well that is exactly what we already do here. The only problem is we do the
: Re: [PATCH] drm/amdgpu: Unmap CSA under SR-IOV in KFD path
Am 30.04.19 um 11:53 schrieb Huang, Trigger:
> Hi Christian & Felix,
>
> Thanks for the information.
>
> But actually currently CSA is mapped only in amdgpu_driver_open_kms under
> SR-IOV.
> So would you give
rigger Huang
>
> -Original Message-
> From: Christian König
> Sent: Tuesday, April 30, 2019 5:23 PM
> To: Kuehling, Felix ; Huang, Trigger
> ; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/amdgpu: Unmap CSA under SR-IOV in KFD path
>
> [CAUTION: Exter
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Unmap CSA under SR-IOV in KFD path
[CAUTION: External Email]
Well that is exactly what we already do here. The only problem is we do the
wrong check amdgpu_vm_make_compute().
Instead of checking if some page tables are already filled we check
Well that is exactly what we already do here. The only problem is we do
the wrong check amdgpu_vm_make_compute().
Instead of checking if some page tables are already filled we check if
some mapping is already made.
Regards,
Christian.
Am 30.04.19 um 01:34 schrieb Kuehling, Felix:
I
I remember a past discussion to change the CSA allocation/mapping scheme
to avoid this issue in the first place. Can adding the CSA to the VM be
delayed a little to a point after the VM gets converted to a compute VM?
Maybe the first command submission?
Regards,
Felix
On 2019-04-28 6:25
Am 28.04.19 um 12:25 schrieb Trigger Huang:
In amdgpu open path, CSA will be mappened in VM, so when opening
KFD, calling mdgpu_vm_make_compute will fail because it found this
VM is not a clean VM with some mappings, as a result, it will lead
to failed to create process VM object
The fix is
In amdgpu open path, CSA will be mappened in VM, so when opening
KFD, calling mdgpu_vm_make_compute will fail because it found this
VM is not a clean VM with some mappings, as a result, it will lead
to failed to create process VM object
The fix is try to unmap CSA, and actually CSA is not needed
