Re: [PATCH] drm/amdgpu: Add message print when unable to get valid hive

2019-01-07 Thread Deucher, Alexander 
Reviewed-by: Alex Deucher 


From: amd-gfx  on behalf of Liu, Shaoyun 

Sent: Monday, January 7, 2019 11:01:51 AM
To: amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: Add message print when unable to get valid hive

Ping ...

-Original Message-
From: Liu, Shaoyun 
Sent: Friday, January 4, 2019 1:29 PM
To: amd-gfx@lists.freedesktop.org
Cc: Liu, Shaoyun 
Subject: [PATCH] drm/amdgpu: Add message print when unable to get valid hive

Add message print out and return -EINVAL when driver can not get valid hive 
from hive  arrary on xgmi configuration

Change-Id: Ic03927904edf0e384b8c4651e19274bb3f2a7d9a
Signed-off-by: shaoyunl 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
index 8a8bc60..b226631 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
@@ -113,8 +113,13 @@ int amdgpu_xgmi_add_device(struct amdgpu_device *adev)

 mutex_lock(_mutex);
 hive = amdgpu_get_xgmi_hive(adev);
-   if (!hive)
+   if (!hive) {
+   ret = -EINVAL;
+   dev_err(adev->dev,
+   "XGMI: Can not matech hive 0xllx in the hive list.\n",
+   adev->gmc.xgmi.hive_id);
 goto exit;
+   }

 hive_topology = >topology_info;

--
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: Add message print when unable to get valid hive

2019-01-07 Thread Liu, Shaoyun 
Ping ...

-Original Message-
From: Liu, Shaoyun  
Sent: Friday, January 4, 2019 1:29 PM
To: amd-gfx@lists.freedesktop.org
Cc: Liu, Shaoyun 
Subject: [PATCH] drm/amdgpu: Add message print when unable to get valid hive

Add message print out and return -EINVAL when driver can not get valid hive 
from hive  arrary on xgmi configuration

Change-Id: Ic03927904edf0e384b8c4651e19274bb3f2a7d9a
Signed-off-by: shaoyunl 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
index 8a8bc60..b226631 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
@@ -113,8 +113,13 @@ int amdgpu_xgmi_add_device(struct amdgpu_device *adev)
 
mutex_lock(_mutex);
hive = amdgpu_get_xgmi_hive(adev);
-   if (!hive)
+   if (!hive) {
+   ret = -EINVAL;
+   dev_err(adev->dev,
+   "XGMI: Can not matech hive 0xllx in the hive list.\n",
+   adev->gmc.xgmi.hive_id);
goto exit;
+   }
 
hive_topology = >topology_info;
 
--
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amdgpu: Add message print when unable to get valid hive

2019-01-04 Thread Liu, Shaoyun 
Add message print out and return -EINVAL when driver can not get valid hive
from hive  arrary on xgmi configuration

Change-Id: Ic03927904edf0e384b8c4651e19274bb3f2a7d9a
Signed-off-by: shaoyunl 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
index 8a8bc60..b226631 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
@@ -113,8 +113,13 @@ int amdgpu_xgmi_add_device(struct amdgpu_device *adev)
 
mutex_lock(_mutex);
hive = amdgpu_get_xgmi_hive(adev);
-   if (!hive)
+   if (!hive) {
+   ret = -EINVAL;
+   dev_err(adev->dev,
+   "XGMI: Can not matech hive 0xllx in the hive list.\n",
+   adev->gmc.xgmi.hive_id);
goto exit;
+   }
 
hive_topology = >topology_info;
 
-- 
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amdgpu: Add message print when unable to get valid hive

2019-01-04 Thread Liu, Shaoyun 
Add message print out and return -EINVAL when driver can not get valid hive
from hive  arrary on xgmi configuration

Change-Id: Ic03927904edf0e384b8c4651e19274bb3f2a7d9a
Signed-off-by: shaoyunl 
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
index 8a8bc60..b226631 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
@@ -113,8 +113,13 @@ int amdgpu_xgmi_add_device(struct amdgpu_device *adev)
 
mutex_lock(_mutex);
hive = amdgpu_get_xgmi_hive(adev);
-   if (!hive)
+   if (!hive) {
+   ret = -EINVAL;
+   dev_err(adev->dev,
+   "XGMI: Can not matech hive 0xllx in the hive list.\n",
+   adev->gmc.xgmi.hive_id);
goto exit;
+   }
 
hive_topology = >topology_info;
 
-- 
2.7.4

___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx