Re: [PATCH] drm/amdgpu: Allow to create BO lists in CS ioctl.

2018-07-11 Thread Andrey Grodzovsky
This was to avoid extra code in amdgpu_cs_parser_bos when amdgpu_bo_list_get is called. But I see your argument about random id guess (practically unrealistic to happen but still a valid argument). I will do some minor alterations to avoid this and respin the patch. Andrey On 07/11/2018

Re: [PATCH] drm/amdgpu: Allow to create BO lists in CS ioctl.

2018-07-11 Thread Christian König
Am 11.07.2018 um 17:37 schrieb Andrey Grodzovsky: On 07/11/2018 11:05 AM, Christian König wrote: Am 11.07.2018 um 16:51 schrieb Andrey Grodzovsky: [SNIP] + +    bool destroy_bo_list; I think you don't need this. IIRC the bo_list structure was reference counted. So all you need to do is

Re: [PATCH] drm/amdgpu: Allow to create BO lists in CS ioctl.

2018-07-11 Thread Andrey Grodzovsky
On 07/11/2018 11:05 AM, Christian König wrote: Am 11.07.2018 um 16:51 schrieb Andrey Grodzovsky: This change is to support MESA performace optimization. Modify CS IOCTL to allow its input as command buffer and an array of buffer handles to create a temporay bo list and then destroy it when

Re: [PATCH] drm/amdgpu: Allow to create BO lists in CS ioctl.

2018-07-11 Thread Christian König
Am 11.07.2018 um 16:51 schrieb Andrey Grodzovsky: This change is to support MESA performace optimization. Modify CS IOCTL to allow its input as command buffer and an array of buffer handles to create a temporay bo list and then destroy it when IOCTL completes. This saves on calling for BO_LIST

[PATCH] drm/amdgpu: Allow to create BO lists in CS ioctl.

2018-07-11 Thread Andrey Grodzovsky
This change is to support MESA performace optimization. Modify CS IOCTL to allow its input as command buffer and an array of buffer handles to create a temporay bo list and then destroy it when IOCTL completes. This saves on calling for BO_LIST create and destry IOCTLs in MESA and by this improves