Re: [PATCH] drm/amdgpu: Fix build with missing pm_suspend_target_state module export

2021-08-24 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Aug 24, 2021 at 11:16 AM Lazar, Lijo wrote: > > > > On 8/24/2021 3:12 PM, Borislav Petkov wrote: > > From: Borislav Petkov > > > > Building a randconfig here triggered: > > > >ERROR: modpost: "pm_suspend_target_state" > >

Re: [PATCH] drm/amdgpu: Fix build with missing pm_suspend_target_state module export

2021-08-24 Thread Lazar, Lijo
On 8/24/2021 3:12 PM, Borislav Petkov wrote: From: Borislav Petkov Building a randconfig here triggered: ERROR: modpost: "pm_suspend_target_state" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! because the module export of that symbol happens in kernel/power/suspend.c which is

Re: [PATCH] drm/amdgpu: Fix build with missing pm_suspend_target_state module export

2021-08-24 Thread Borislav Petkov
On Tue, Aug 24, 2021 at 07:22:46PM +0530, Lazar, Lijo wrote: > 'pm_suspend_target_state' is only available when CONFIG_PM_SLEEP > is set/enabled. pm_suspend_target_state is available only when CONFIG_SUSPEND is enabled. The extern thing is only a forward declaration. > OTOH, when both SUSPEND

Re: [PATCH] drm/amdgpu: Fix build with missing pm_suspend_target_state module export

2021-08-24 Thread Lazar, Lijo
On 8/24/2021 7:10 PM, Borislav Petkov wrote: On Tue, Aug 24, 2021 at 06:38:41PM +0530, Lazar, Lijo wrote: Without CONFIG_PM_SLEEP and with CONFIG_SUSPEND Can you even create such a .config? The description of "(drm/amdgpu: fix checking pmops when PM_SLEEP is not enabled)" says -

Re: [PATCH] drm/amdgpu: Fix build with missing pm_suspend_target_state module export

2021-08-24 Thread Borislav Petkov
On Tue, Aug 24, 2021 at 06:38:41PM +0530, Lazar, Lijo wrote: > Without CONFIG_PM_SLEEP and with CONFIG_SUSPEND Can you even create such a .config? > I remember giving a reviewed-by for this one, looks like it never got in. > https://www.spinics.net/lists/amd-gfx/msg66166.html A better version

Re: [PATCH] drm/amdgpu: Fix build with missing pm_suspend_target_state module export

2021-08-24 Thread Lazar, Lijo
On 8/24/2021 3:12 PM, Borislav Petkov wrote: From: Borislav Petkov Building a randconfig here triggered: ERROR: modpost: "pm_suspend_target_state" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! because the module export of that symbol happens in kernel/power/suspend.c which is

[PATCH] drm/amdgpu: Fix build with missing pm_suspend_target_state module export

2021-08-24 Thread Borislav Petkov
From: Borislav Petkov Building a randconfig here triggered: ERROR: modpost: "pm_suspend_target_state" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! because the module export of that symbol happens in kernel/power/suspend.c which is enabled with CONFIG_SUSPEND. The ifdef guards in