RE: [PATCH] drm/amdgpu: Move VBIOS version to sysfs

2017-08-28 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Russell, Kent > Sent: Monday, August 28, 2017 8:39 AM > To: Alex Deucher; Christian König > Cc: amd-gfx list > Subject: RE: [PATCH] drm/amdgpu: Move VBIOS version to s

Re: [PATCH] drm/amdgpu: Move VBIOS version to sysfs

2017-08-28 Thread Christian König
3:17 PM To: Christian König Cc: Russell, Kent; amd-gfx list Subject: Re: [PATCH] drm/amdgpu: Move VBIOS version to sysfs On Fri, Aug 25, 2017 at 3:13 PM, Christian König wrote: Am 25.08.2017 um 16:41 schrieb Alex Deucher: On Fri, Aug 25, 2017 at 9:43 AM, Kent Russell wrote: sysfs is more s

RE: [PATCH] drm/amdgpu: Move VBIOS version to sysfs

2017-08-28 Thread Russell, Kent
PATCH] drm/amdgpu: Move VBIOS version to sysfs On Fri, Aug 25, 2017 at 3:13 PM, Christian König wrote: > Am 25.08.2017 um 16:41 schrieb Alex Deucher: >> >> On Fri, Aug 25, 2017 at 9:43 AM, Kent Russell >> wrote: >>> >>> sysfs is more stable, and doesn't r

Re: [PATCH] drm/amdgpu: Move VBIOS version to sysfs

2017-08-25 Thread Alex Deucher
On Fri, Aug 25, 2017 at 3:13 PM, Christian König wrote: > Am 25.08.2017 um 16:41 schrieb Alex Deucher: >> >> On Fri, Aug 25, 2017 at 9:43 AM, Kent Russell >> wrote: >>> >>> sysfs is more stable, and doesn't require root to access >>> >>> Signed-off-by: Kent Russell >> >> Might as well move the v

Re: [PATCH] drm/amdgpu: Move VBIOS version to sysfs

2017-08-25 Thread Christian König
Am 25.08.2017 um 16:41 schrieb Alex Deucher: On Fri, Aug 25, 2017 at 9:43 AM, Kent Russell wrote: sysfs is more stable, and doesn't require root to access Signed-off-by: Kent Russell Might as well move the vbios binary itself to sysfs as well. It should be a stable interface :) Yeah, but

RE: [PATCH] drm/amdgpu: Move VBIOS version to sysfs

2017-08-25 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Russell, Kent > Sent: Friday, August 25, 2017 11:38 AM > To: Alex Deucher > Cc: amd-gfx list > Subject: RE: [PATCH] drm/amdgpu: Move VBIOS version to sysfs > > Ch

RE: [PATCH] drm/amdgpu: Move VBIOS version to sysfs

2017-08-25 Thread Russell, Kent
ugust 25, 2017 10:41 AM To: Russell, Kent Cc: amd-gfx list Subject: Re: [PATCH] drm/amdgpu: Move VBIOS version to sysfs On Fri, Aug 25, 2017 at 9:43 AM, Kent Russell wrote: > sysfs is more stable, and doesn't require root to access > > Signed-off-by: Kent Russell Might as well mo

RE: [PATCH] drm/amdgpu: Move VBIOS version to sysfs

2017-08-25 Thread Russell, Kent
August 25, 2017 9:59 AM To: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Move VBIOS version to sysfs Acked-by: Tom St Denis Seems to be the easiest way to find this is via /sys/bus/pci/devices/${devname}/vbios_version Tom On 25/08/17 09:43 AM, Kent Russell wrote: > sysfs i

Re: [PATCH] drm/amdgpu: Move VBIOS version to sysfs

2017-08-25 Thread Alex Deucher
On Fri, Aug 25, 2017 at 9:43 AM, Kent Russell wrote: > sysfs is more stable, and doesn't require root to access > > Signed-off-by: Kent Russell Might as well move the vbios binary itself to sysfs as well. It should be a stable interface :) Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_devic

Re: [PATCH] drm/amdgpu: Move VBIOS version to sysfs

2017-08-25 Thread Tom St Denis
Acked-by: Tom St Denis Seems to be the easiest way to find this is via /sys/bus/pci/devices/${devname}/vbios_version Tom On 25/08/17 09:43 AM, Kent Russell wrote: sysfs is more stable, and doesn't require root to access Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/amdgpu/amdgpu_de

[PATCH] drm/amdgpu: Move VBIOS version to sysfs

2017-08-25 Thread Kent Russell
sysfs is more stable, and doesn't require root to access Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 54 +- 1 file changed, 23 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/a