Re: [PATCH] drm/amdgpu: Partially revert commit 2dc80b006

2018-06-13 Thread Jan Vesely
nesday, June 13, 2018 9:30 PM > *To:* Koenig, Christian > *Cc:* Zhu, Rex; amd-gfx list > *Subject:* Re: [PATCH] drm/amdgpu: Partially revert commit 2dc80b006 > > Hi, > > can you please improve the commit message? > seeing "Revert $HASH" conveys zero informat

Re: [PATCH] drm/amdgpu: Partially revert commit 2dc80b006

2018-06-13 Thread Zhu, Rex
_ From: jv...@scarletmail.rutgers.edu on behalf of Jan Vesely Sent: Wednesday, June 13, 2018 9:30 PM To: Koenig, Christian Cc: Zhu, Rex; amd-gfx list Subject: Re: [PATCH] drm/amdgpu: Partially revert commit 2dc80b006 Hi, can you please improve the commit message? seeing "Revert $HAS

Re: [PATCH] drm/amdgpu: Partially revert commit 2dc80b006

2018-06-13 Thread William Lewis
On 06/13/2018 08:30 AM, Jan Vesely wrote: Hi, can you please improve the commit message? seeing "Revert $HASH" conveys zero information about the code change. I'm sorry for bringing this up again, but following AMDGPU/Radeon driver development is an exercise in frustration for anyone who is

Re: [PATCH] drm/amdgpu: Partially revert commit 2dc80b006

2018-06-13 Thread Jan Vesely
Hi, can you please improve the commit message? seeing "Revert $HASH" conveys zero information about the code change. I'm sorry for bringing this up again, but following AMDGPU/Radeon driver development is an exercise in frustration for anyone who is not on AMD's payroll. git commit logs like:

Re: [PATCH] drm/amdgpu: Partially revert commit 2dc80b006

2018-06-13 Thread Christian König
Am 13.06.2018 um 13:40 schrieb Rex Zhu: Move the CG enablement out of delay worker thread. 1. CG/PG enablement are part of gpu hw ip initialize, we should wait for them complete. otherwise, there are some potential conflicts, for example, Suspend and CG enablement concurrently. 2. better run ib

[PATCH] drm/amdgpu: Partially revert commit 2dc80b006

2018-06-13 Thread Rex Zhu
Move the CG enablement out of delay worker thread. 1. CG/PG enablement are part of gpu hw ip initialize, we should wait for them complete. otherwise, there are some potential conflicts, for example, Suspend and CG enablement concurrently. 2. better run ib test after hw initialize completely. That