Re: [PATCH] drm/amdgpu: do not modify ring before doing ring validation

2020-02-25 Thread Nirmoy
On 2/25/20 12:08 PM, Christian König wrote: Am 25.02.20 um 12:03 schrieb Nirmoy: On 2/25/20 11:52 AM, Christian König wrote: Am 25.02.20 um 11:39 schrieb Nirmoy Das: changing ring->sched.ready should be done only if the ring is initialized I don't think that this makes much difference.

Re: [PATCH] drm/amdgpu: do not modify ring before doing ring validation

2020-02-25 Thread Christian König
Am 25.02.20 um 12:03 schrieb Nirmoy: On 2/25/20 11:52 AM, Christian König wrote: Am 25.02.20 um 11:39 schrieb Nirmoy Das: changing ring->sched.ready should be done only if the ring is initialized I don't think that this makes much difference. When the rings are freed the hardware and

Re: [PATCH] drm/amdgpu: do not modify ring before doing ring validation

2020-02-25 Thread Nirmoy
On 2/25/20 11:52 AM, Christian König wrote: Am 25.02.20 um 11:39 schrieb Nirmoy Das: changing ring->sched.ready should be done only if the ring is initialized I don't think that this makes much difference. When the rings are freed the hardware and software stack needs to be disabled quite

Re: [PATCH] drm/amdgpu: do not modify ring before doing ring validation

2020-02-25 Thread Christian König
Am 25.02.20 um 11:39 schrieb Nirmoy Das: changing ring->sched.ready should be done only if the ring is initialized I don't think that this makes much difference. When the rings are freed the hardware and software stack needs to be disabled quite some time before. Christian.

[PATCH] drm/amdgpu: do not modify ring before doing ring validation

2020-02-25 Thread Nirmoy Das
changing ring->sched.ready should be done only if the ring is initialized Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c