RE: [PATCH] drm/amdgpu: Fix compile warning in amdgpu_fru_read_eeprom

2020-06-29 Thread Russell, Kent
Message- > From: Koenig, Christian > Sent: Monday, June 29, 2020 8:41 AM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: Fix compile warning in > amdgpu_fru_read_eeprom > > No, problem. I don't know this code but the patch looked k

Re: [PATCH] drm/amdgpu: Fix compile warning in amdgpu_fru_read_eeprom

2020-06-29 Thread Christian König
was fixed and I was breaking and unbreaking it during rebasing. This thread can be ignored. Time for some coffee. Kent -Original Message- From: Koenig, Christian Sent: Monday, June 29, 2020 8:29 AM To: Russell, Kent ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Fi

RE: [PATCH] drm/amdgpu: Fix compile warning in amdgpu_fru_read_eeprom

2020-06-29 Thread Russell, Kent
ne 29, 2020 8:29 AM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: Fix compile warning in > amdgpu_fru_read_eeprom > > Ok, then why does it fix a warning if we make it non-static? > > If the function used it compiled under some #ifdef the

Re: [PATCH] drm/amdgpu: Fix compile warning in amdgpu_fru_read_eeprom

2020-06-29 Thread Christian König
tian König Sent: Monday, June 29, 2020 8:17 AM To: Russell, Kent ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Fix compile warning in amdgpu_fru_read_eeprom Am 29.06.20 um 14:13 schrieb Kent Russell: This fixes the missing-prototypes warning for the amdgpu_fru_read_eeprom funct

RE: [PATCH] drm/amdgpu: Fix compile warning in amdgpu_fru_read_eeprom

2020-06-29 Thread Russell, Kent
u_eeprom.c file. Kent > -Original Message- > From: Christian König > Sent: Monday, June 29, 2020 8:17 AM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: Fix compile warning in > amdgpu_fru_read_eeprom > > Am 29.06.20 um 14

Re: [PATCH] drm/amdgpu: Fix compile warning in amdgpu_fru_read_eeprom

2020-06-29 Thread Christian König
Am 29.06.20 um 14:13 schrieb Kent Russell: This fixes the missing-prototypes warning for the amdgpu_fru_read_eeprom function. Since we declare it in the header, we can make it un-static Well is it used in different files? Otherwise we might just have unused code in the module which can potenti

[PATCH] drm/amdgpu: Fix compile warning in amdgpu_fru_read_eeprom

2020-06-29 Thread Kent Russell
This fixes the missing-prototypes warning for the amdgpu_fru_read_eeprom function. Since we declare it in the header, we can make it un-static Signed-off-by: Kent Russell Reported-by: kernel test robot Change-Id: I2b9419365cb8b38bcfb6582df53b96c83861d6cf --- drivers/gpu/drm/amd/amdgpu/amdgpu_fr

Re: [PATCH] drm/amdgpu: Fix compile warning

2018-08-20 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Rex Zhu Sent: Monday, August 20, 2018 8:26:07 AM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH] drm/amdgpu: Fix compile warning In function ‘gfx_v9_0_check_fw_write_wait’: warning

[PATCH] drm/amdgpu: Fix compile warning

2018-08-20 Thread Rex Zhu
In function ‘gfx_v9_0_check_fw_write_wait’: warning: enumeration value ‘CHIP_TAHITI’ not handled in switch [-Wswitch] Always add default case in case there is no match Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/

Re: [PATCH] drm/amdgpu: fix compile warning

2017-04-06 Thread Zhang, Jerry (Junwei)
On 04/07/2017 03:56 AM, Alex Xie wrote: warning: comparison of distinct pointer types lacks a cast Thanks for your patch. I have fixed it. Please check in our branch. Jerry Change-Id: I317eddd1bd430c98a3c50ec170f592f944081a6e Signed-off-by: Alex Xie --- drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH] drm/amdgpu: fix compile warning

2017-04-06 Thread Alex Xie
warning: comparison of distinct pointer types lacks a cast Change-Id: I317eddd1bd430c98a3c50ec170f592f944081a6e Signed-off-by: Alex Xie --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers

Re: [PATCH] drm/amdgpu: fix compile warning in amdgpu_kms.c

2017-01-02 Thread Christian König
Am 02.01.2017 um 10:23 schrieb Rex Zhu: warning: comparison of distinct pointer types lacks a cast min((size_t)size, bios_size - bios_offset)) Change-Id: Ib77eac5b15d09d169d2e95cff7608b395fb0f64c Signed-off-by: Rex Zhu Reviewed-by: Christian König . --- drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH] drm/amdgpu: fix compile warning in amdgpu_kms.c

2017-01-02 Thread Rex Zhu
warning: comparison of distinct pointer types lacks a cast min((size_t)size, bios_size - bios_offset)) Change-Id: Ib77eac5b15d09d169d2e95cff7608b395fb0f64c Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv