Re: [PATCH] drm/amdgpu: fix doc by clarifying sched_list definition

2020-01-22 Thread Christian König
Am 22.01.20 um 10:38 schrieb Nirmoy Das: expand sched_list definition for better understanding. Also fix a typo atleast -> at least Signed-off-by: Nirmoy Das Reviewed-by: Christian König --- drivers/gpu/drm/scheduler/sched_entity.c | 2 +- include/drm/gpu_scheduler.h | 5

[PATCH] drm/amdgpu: fix doc by clarifying sched_list definition

2020-01-22 Thread Nirmoy Das
expand sched_list definition for better understanding. Also fix a typo atleast -> at least Signed-off-by: Nirmoy Das --- drivers/gpu/drm/scheduler/sched_entity.c | 2 +- include/drm/gpu_scheduler.h | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] drm/amdgpu: fix doc by clarifying sched_list definition

2020-01-22 Thread Nirmoy
On 1/21/20 3:31 PM, William Lewis wrote: + * @sched_list: A list of schedulers (drm_gpu_schedulers). + * Jobs from this entity, can be scheduled on any scheduler There's no reason to separate the subject from the verb here with a comma. Thanks William. + * on

Re: [PATCH] drm/amdgpu: fix doc by clarifying sched_list definition

2020-01-21 Thread William Lewis
If we're worrying about spelling and grammar, see one more nitpick inline. On 1/20/20 10:35 AM, Nirmoy Das wrote: > expand sched_list definition for better understanding. > Also fix a typo atleast -> at least > > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/scheduler/sched_entity.c | 2 +-

Re: [PATCH] drm/amdgpu: fix doc by clarifying sched_list definition

2020-01-20 Thread Luben Tuikov
That looks excellent--thank you for submitting it. Hopefully, the documentation would be more accessible to everyone, so that everyone would contribute. Regards, Luben On 2020-01-20 11:35 a.m., Nirmoy Das wrote: > expand sched_list definition for better understanding. > Also fix a typo atleast

[PATCH] drm/amdgpu: fix doc by clarifying sched_list definition

2020-01-20 Thread Nirmoy Das
expand sched_list definition for better understanding. Also fix a typo atleast -> at least Signed-off-by: Nirmoy Das --- drivers/gpu/drm/scheduler/sched_entity.c | 2 +- include/drm/gpu_scheduler.h | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git