Re: [PATCH] drm/amdgpu: fix error handling in df_v3_6_pmc_start

2019-06-17 Thread Alex Deucher
On Mon, Jun 17, 2019 at 8:57 AM Arnd Bergmann wrote: > > When df_v3_6_pmc_get_ctrl_settings() fails for some reason, we > store uninitialized data in a register, as gcc points out: > > drivers/gpu/drm/amd/amdgpu/df_v3_6.c: In function 'df_v3_6_pmc_start': >

[PATCH] drm/amdgpu: fix error handling in df_v3_6_pmc_start

2019-06-17 Thread Arnd Bergmann
When df_v3_6_pmc_get_ctrl_settings() fails for some reason, we store uninitialized data in a register, as gcc points out: drivers/gpu/drm/amd/amdgpu/df_v3_6.c: In function 'df_v3_6_pmc_start': drivers/gpu/drm/amd/amdgpu/amdgpu.h:1012:29: error: 'lo_val' may be used uninitialized in this function