Re: [PATCH] drm/amdgpu: move the amdgpu_fbdev_set_suspend() further up

2018-07-25 Thread Huang Rui
On Tue, Jul 24, 2018 at 09:32:40AM +0530, Shirish S wrote: > This patch moves amdgpu_fbdev_set_suspend() to the beginning > of suspend sequence. > > This is to ensure fbcon does not to write to the VRAM > after GPU is powerd down. > > Signed-off-by: Shirish S > Reviewed-by: Michel Dänzer

Re: [PATCH] drm/amdgpu: move the amdgpu_fbdev_set_suspend() further up

2018-07-24 Thread Alex Deucher
On Tue, Jul 24, 2018 at 12:02 AM, Shirish S wrote: > This patch moves amdgpu_fbdev_set_suspend() to the beginning > of suspend sequence. > > This is to ensure fbcon does not to write to the VRAM > after GPU is powerd down. > > Signed-off-by: Shirish S > Reviewed-by: Michel Dänzer Reviewed-by:

[PATCH] drm/amdgpu: move the amdgpu_fbdev_set_suspend() further up

2018-07-23 Thread Shirish S
This patch moves amdgpu_fbdev_set_suspend() to the beginning of suspend sequence. This is to ensure fbcon does not to write to the VRAM after GPU is powerd down. Signed-off-by: Shirish S Reviewed-by: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++--- 1 file changed, 3

Re: [PATCH] drm/amdgpu: move the amdgpu_fbdev_set_suspend() further up

2018-07-23 Thread Michel Dänzer
On 2018-07-23 12:06 PM, Shirish S wrote: > This patch moves amdgpu_fbdev_set_suspend() to the beginning > of suspend sequence. Would be nice to have some rationale, e.g.: This is to avoid fbcon trying to write to the GPU's memory when the GPU is already powered down. Other than that looks

[PATCH] drm/amdgpu: move the amdgpu_fbdev_set_suspend() further up

2018-07-23 Thread Shirish S
This patch moves amdgpu_fbdev_set_suspend() to the beginning of suspend sequence. Signed-off-by: Shirish S --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c