Re: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings

2019-04-28 Thread Deucher, Alexander
eifei; Cui, Flora; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings How about amdgpu.lockup_timeout=non-compute-jobs[, gfx, sdma, decode, encode][: compute-jobs] ? This will not break backward compatibility. And I’m not sure how t

RE: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings

2019-04-27 Thread Quan, Evan
: Re: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings How about an interface to change the timeout on a per engine (gfx, compute, dma, etc.) basis? amdgpu.lockup_timeout=,] if only one parameter is given, we change it globably. If more are given, we override the global one

Re: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings

2019-04-26 Thread Deucher, Alexander
From: amd-gfx on behalf of Michel Dänzer Sent: Friday, April 26, 2019 4:35 AM To: Quan, Evan; Koenig, Christian Cc: Xu, Feifei; Cui, Flora; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings On 2019-04-26 10:20

Re: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings

2019-04-26 Thread Michel Dänzer
On 2019-04-26 10:20 a.m., Quan, Evan wrote: > My concern is there is already one module parameter "lockup_timeout". > parm: lockup_timeout:GPU lockup timeout in ms > 0 (default 1) > (int) > > Adding one more "timeout" seems redundant. > And that will makes the description of "locku

Re: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings

2019-04-26 Thread Christian König
t: Friday, April 26, 2019 3:34 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; Cui, Flora Subject: Re: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings Am 26.04.19 um 09:24 schrieb Evan Quan: A new module parameter is added for determining whether or not to enforce time

RE: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings

2019-04-26 Thread Quan, Evan
rom: amd-gfx On Behalf Of > Christian K?nig > Sent: Friday, April 26, 2019 3:34 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Xu, Feifei ; Cui, Flora > Subject: Re: [PATCH] drm/amdgpu: support gpu recovery tests on compute > rings > > Am 26.04.19 um 09:24 schri

Re: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings

2019-04-26 Thread Christian König
Am 26.04.19 um 09:24 schrieb Evan Quan: A new module parameter is added for determining whether or not to enforce timeout on compute jobs. Can we rework that a bit and instead of a bool have a separate millisecond timeout for compute? E.g. default is 0 and that means MAX_SCHEDULE_TIMEOUT unl

[PATCH] drm/amdgpu: support gpu recovery tests on compute rings

2019-04-26 Thread Evan Quan
A new module parameter is added for determining whether or not to enforce timeout on compute jobs. Change-Id: If14b75977312e42dac0431072456e5b69cf1bc2f Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 drivers/gp