[PATCH] drm/scheduler: rework entity creation

2019-12-05 Thread Nirmoy Das
Entity currently keeps a copy of run_queue list and modify it in drm_sched_entity_set_priority(). Entities shouldn't modify run_queue list. Use drm_gpu_scheduler list instead of drm_sched_rq list in drm_sched_entity struct. In this way we can select a runqueue based on entity/ctx's priority for a

Re: [PATCH] drm/scheduler: rework entity creation

2019-12-05 Thread Nirmoy
On 12/5/19 3:42 PM, Nirmoy Das wrote: Entity currently keeps a copy of run_queue list and modify it in drm_sched_entity_set_priority(). Entities shouldn't modify run_queue list. Use drm_gpu_scheduler list instead of drm_sched_rq list in drm_sched_entity struct. In this way we can select a

[RFC PATCH] drm/scheduler: rework entity creation

2019-12-05 Thread Nirmoy Das
Entity currently keeps a copy of run_queue list and modify it in drm_sched_entity_set_priority(). Entities shouldn't modify run_queue list. Use drm_gpu_scheduler list instead of drm_sched_rq list in drm_sched_entity struct. In this way we can select a runqueue based on entity/ctx's priority for a

Re: [RFC PATCH] drm/scheduler: rework entity creation

2019-12-05 Thread Das, Nirmoy
@lists.freedesktop.org ; Das, Nirmoy Subject: Re: [RFC PATCH] drm/scheduler: rework entity creation Am 05.12.19 um 12:04 schrieb Nirmoy: > Hi Christian, > > I am not exactly sure about drm_sched_entity_set_priority() I wonder > if just changing > > entity->priority to ctx->

Re: [RFC PATCH] drm/scheduler: rework entity creation

2019-12-05 Thread Christian König
Am 05.12.19 um 12:04 schrieb Nirmoy: Hi Christian, I am not exactly sure about drm_sched_entity_set_priority() I wonder if just changing entity->priority  to ctx->override_priority should work. With this change drm_sched_entity_select_rq() will chose a rq based on entity->priority which

Re: [RFC PATCH] drm/scheduler: rework entity creation

2019-12-05 Thread Christian König
Am 05.12.19 um 11:52 schrieb Nirmoy Das: Entity currently keeps a copy of run_queue list and modify it in drm_sched_entity_set_priority(). Entities shouldn't modify run_queue list. Use drm_gpu_scheduler list instead of drm_sched_rq list in drm_sched_entity struct. In this way we can select a

Re: [RFC PATCH] drm/scheduler: rework entity creation

2019-12-05 Thread Nirmoy
Hi Christian, I am not exactly sure about drm_sched_entity_set_priority() I wonder if just changing entity->priority  to ctx->override_priority should work. With this change drm_sched_entity_select_rq() will chose a rq based on entity->priority which seems to me correct. But is this