Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-05-22 Thread Michel Dänzer
On 22/05/17 10:54 AM, Michel Dänzer wrote: > On 20/05/17 03:55 AM, Felix Kuehling wrote: >> On 17-05-18 09:17 PM, Michel Dänzer wrote: > > The default at this point should possibly still be for CIK GPUs to be > driven by radeon, even if CONFIG_DRM_AMDGPU_CIK is enabled; Alex and

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-05-21 Thread Michel Dänzer
On 20/05/17 03:55 AM, Felix Kuehling wrote: > On 17-05-18 09:17 PM, Michel Dänzer wrote: >> Obviously, out-of-tree module builds will have to continue doing what >> they've been doing so far with kernels without your patch. I'm thinking >> about making it easier for them with kernels which do have

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-05-19 Thread Felix Kuehling
On 17-05-18 09:17 PM, Michel Dänzer wrote: > Obviously, out-of-tree module builds will have to continue doing what > they've been doing so far with kernels without your patch. I'm thinking > about making it easier for them with kernels which do have your patch. > At some point in the future,

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-05-18 Thread Michel Dänzer
On 19/05/17 04:35 AM, Felix Kuehling wrote: > On 17-04-27 05:22 AM, Michel Dänzer wrote: >> On 27/04/17 05:15 AM, Felix Kuehling wrote: >>> Hi Michel, >>> >>> You said in an earlier email that it doesn't have to be convenient. With >>> that in mind, I went back to a minimalistic solution that

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-05-18 Thread Felix Kuehling
On 17-04-27 05:22 AM, Michel Dänzer wrote: > On 27/04/17 05:15 AM, Felix Kuehling wrote: >> Hi Michel, >> >> You said in an earlier email that it doesn't have to be convenient. With >> that in mind, I went back to a minimalistic solution that doesn't need >> any additional Kconfig options and only

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-27 Thread Michel Dänzer
On 27/04/17 05:15 AM, Felix Kuehling wrote: > > Hi Michel, > > You said in an earlier email that it doesn't have to be convenient. With > that in mind, I went back to a minimalistic solution that doesn't need > any additional Kconfig options and only uses two module parameters (one > in radeon,

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-27 Thread Christian König
Am 26.04.2017 um 22:15 schrieb Felix Kuehling: On 17-04-25 02:28 AM, Michel Dänzer wrote: On 22/04/17 02:05 AM, Felix Kuehling wrote: __setup doesn't work in modules. Right. We could build something like drivers/video/fbdev/core/fb_cmdline.c:video_setup() into the kernel to handle this, but

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-26 Thread Felix Kuehling
On 17-04-25 02:28 AM, Michel Dänzer wrote: > On 22/04/17 02:05 AM, Felix Kuehling wrote: >> __setup doesn't work in modules. > Right. We could build something like > drivers/video/fbdev/core/fb_cmdline.c:video_setup() into the kernel to > handle this, but it's a bit ugly, which is one reason why I

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-26 Thread Michel Dänzer
On 26/04/17 03:06 AM, Nicolai Hähnle wrote: > On 25.04.2017 08:28, Michel Dänzer wrote: >> On 22/04/17 02:05 AM, Felix Kuehling wrote: >> >> So, I'm starting to think we need a shared module for this, which >> provides one or multiple module parameters to choose which driver to use >> for

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-25 Thread Nicolai Hähnle
On 25.04.2017 08:28, Michel Dänzer wrote: On 22/04/17 02:05 AM, Felix Kuehling wrote: __setup doesn't work in modules. Right. We could build something like drivers/video/fbdev/core/fb_cmdline.c:video_setup() into the kernel to handle this, but it's a bit ugly, which is one reason why I was

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-25 Thread Michel Dänzer
On 22/04/17 02:05 AM, Felix Kuehling wrote: > __setup doesn't work in modules. Right. We could build something like drivers/video/fbdev/core/fb_cmdline.c:video_setup() into the kernel to handle this, but it's a bit ugly, which is one reason why I was leaning towards: > s8250_options is only

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-21 Thread Felix Kuehling
__setup doesn't work in modules. s8250_options is only compiled if the driver is not a module. I came up with a different way to parse another module's options. But I can't get the commandline that I would parse in that way: @@ -787,12 +793,45 @@ long amdgpu_drm_ioctl(struct file *filp,

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-20 Thread Michel Dänzer
On 20/04/17 03:59 AM, Felix Kuehling wrote: > On 17-04-11 10:23 PM, Michel Dänzer wrote: >> One possibility would be making each driver also parse the other >> driver's module parameter on the kernel command line. I.e. radeon would >> parse >> >> amdgpu.enable_cik=0 > I looked for a way to do

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-19 Thread Felix Kuehling
On 17-04-11 10:23 PM, Michel Dänzer wrote: > One possibility would be making each driver also parse the other > driver's module parameter on the kernel command line. I.e. radeon would > parse > > amdgpu.enable_cik=0 I looked for a way to do this. I think I figured out the parsing part. But I

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-11 Thread Michel Dänzer
On 11/04/17 10:38 AM, Michel Dänzer wrote: > On 11/04/17 08:21 AM, Felix Kuehling wrote: >> Provide convenient compile time and boot time options for selecting >> CIK ASIC support in either or both drivers. >> >> v2: git add missing files > > [...] > >> diff --git a/drivers/gpu/drm/Kconfig

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-11 Thread Michel Dänzer
On 12/04/17 01:05 AM, Felix Kuehling wrote: > On 17-04-11 12:01 AM, Michel Dänzer wrote: >> One issue with this per-driver enable_cik option is that if the user >> only enables it in the driver where it's disabled by default, without >> also disabling it in the driver where it's enabled by

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-11 Thread Shawn Starr
On 04/11/2017 12:16 PM, Christian König wrote: Am 11.04.2017 um 18:05 schrieb Felix Kuehling: On 17-04-11 12:01 AM, Michel Dänzer wrote: One issue with this per-driver enable_cik option is that if the user only enables it in the driver where it's disabled by default, without also disabling

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-11 Thread Christian König
Am 11.04.2017 um 18:05 schrieb Felix Kuehling: On 17-04-11 12:01 AM, Michel Dänzer wrote: One issue with this per-driver enable_cik option is that if the user only enables it in the driver where it's disabled by default, without also disabling it in the driver where it's enabled by default,

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-11 Thread Felix Kuehling
On 17-04-11 12:01 AM, Michel Dänzer wrote: > One issue with this per-driver enable_cik option is that if the user > only enables it in the driver where it's disabled by default, without > also disabling it in the driver where it's enabled by default, it's back > to the current situation where both

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-11 Thread Felix Kuehling
On 17-04-10 09:42 PM, Michel Dänzer wrote: > On 11/04/17 08:29 AM, Felix Kuehling wrote: >> I tested this with Hawaii on the KFD branch and >> DRM_CIK_BOTH_DEFAULT_AMDGPU. Both modules get loaded, but radeon doesn't >> initialize the device. Amdgpu works with kfdtest. > Did radeon print the "CIK

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-10 Thread Michel Dänzer
On 11/04/17 08:21 AM, Felix Kuehling wrote: > Provide convenient compile time and boot time options for selecting > CIK ASIC support in either or both drivers. > > v2: git add missing files > > Signed-off-by: Felix Kuehling [...] > diff --git

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-10 Thread Michel Dänzer
On 11/04/17 08:29 AM, Felix Kuehling wrote: > I tested this with Hawaii on the KFD branch and > DRM_CIK_BOTH_DEFAULT_AMDGPU. Both modules get loaded, but radeon doesn't > initialize the device. Amdgpu works with kfdtest. Did radeon print the "CIK support disabled by module param" message? --

Re: [PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-10 Thread Felix Kuehling
I tested this with Hawaii on the KFD branch and DRM_CIK_BOTH_DEFAULT_AMDGPU. Both modules get loaded, but radeon doesn't initialize the device. Amdgpu works with kfdtest. To keep the driver code clean I only use straight-forward per-driver options in #ifdefs. The CONFIG_DRM_CIK_... options that

[PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

2017-04-10 Thread Felix Kuehling
Provide convenient compile time and boot time options for selecting CIK ASIC support in either or both drivers. v2: git add missing files Signed-off-by: Felix Kuehling --- drivers/gpu/drm/Kconfig | 51 ++ drivers/gpu/drm/amd/amdgpu/Kconfig