RE: [PATCH 00/19] shadow page table support V2

2016-08-10 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Wednesday, August 10, 2016 7:14 AM > To: Zhou, David(ChunMing); amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 00/19] shadow page table

Re: [PATCH 00/19] shadow page table support V2

2016-08-10 Thread Christian König
Am 10.08.2016 um 08:02 schrieb zhoucm1: On 2016年08月08日 19:04, Christian König wrote: I need to work on the S3 issue again now, going to come back to this patch set when I have more time. I've addressed your previous comments, are you free? Well if you figure out why the heck the UVD engine

Re: [PATCH 00/19] shadow page table support V2

2016-08-09 Thread zhoucm1
On 2016年08月08日 19:04, Christian König wrote: I need to work on the S3 issue again now, going to come back to this patch set when I have more time. I've addressed your previous comments, are you free? how about the other patches? Thanks, David Zhou Regards, Christian.

Re: [PATCH 00/19] shadow page table support V2

2016-08-09 Thread zhoucm1
On 2016年08月08日 19:04, Christian König wrote: Apart from that patch #1: + amdgpu_ttm_placement_init(adev, &placement, + placements, AMDGPU_GEM_DOMAIN_GTT, + AMDGPU_GEM_CREATE_CPU_GTT_USWC); + +return amdgpu_bo_create_restricted(adev, size, byte_align, true,

Re: [PATCH 00/19] shadow page table support V2

2016-08-08 Thread Christian König
Again patch #7 looks like an unrelated fix to me. Please split that from the patch set, add my rb and commit it preliminary. Apart from that patch #1: + amdgpu_ttm_placement_init(adev, &placement, + placements, AMDGPU_GEM_DOMAIN_GTT, +

Re: [PATCH 00/19] shadow page table support V2

2016-08-05 Thread Edward O'Callaghan
On 08/05/2016 07:38 PM, Chunming Zhou wrote: > Since we cannot make sure VRAM is safe after gpu reset, page table backup > is neccessary, shadow page table is sense way to recovery page talbe when > gpu reset happens. Hmm, bit of a nitpick but the following is perhaps a little better wording: s

[PATCH 00/19] shadow page table support V2

2016-08-05 Thread Chunming Zhou
Since we cannot make sure VRAM is safe after gpu reset, page table backup is neccessary, shadow page table is sense way to recovery page talbe when gpu reset happens. We need to allocate GTT bo as the shadow of VRAM bo when creating page table, and make them same. After gpu reset, we will need to u