Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two

2018-09-11 Thread Felix Kuehling
stian. > >> >> Regards, >>    Felix >> >> ____________ >> From: Christian König >> Sent: Tuesday, September 11, 2018 2:49:44 AM >> To: Kuehling, Felix; amd-gfx@lists.freedesktop.org >> Subject: Re: [PATCH 01/11] dr

Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two

2018-09-11 Thread Christian König
Subject: Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two Yeah well the whole patch set depends on that :) Otherwise we don't get pages larger than 2MB for the L1 on Vega10. But another question: Why do you want to clear VRAM on allocation? We perfectly support allocating VRAM

Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two

2018-09-11 Thread Kuehling, Felix
allenging and less effective. Regards, Felix From: Christian König Sent: Tuesday, September 11, 2018 2:49:44 AM To: Kuehling, Felix; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two Yeah well the whole

Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two

2018-09-11 Thread Christian König
Am 11.09.2018 um 11:50 schrieb Huang Rui: On Sun, Sep 09, 2018 at 08:03:29PM +0200, Christian König wrote: Try to allocate VRAM in power of two sizes and only fallback to vram split sizes if that fails. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 52

Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two

2018-09-11 Thread Huang Rui
On Sun, Sep 09, 2018 at 08:03:29PM +0200, Christian König wrote: > Try to allocate VRAM in power of two sizes and only fallback to vram > split sizes if that fails. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 52 > +--- > 1

Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two

2018-09-11 Thread Michel Dänzer
On 2018-09-11 10:20 a.m., Christian König wrote: > Am 11.09.2018 um 09:55 schrieb Michel Dänzer: >> On 2018-09-11 9:46 a.m., Christian König wrote: >>> Am 11.09.2018 um 09:37 schrieb Michel Dänzer: On 2018-09-11 8:49 a.m., Christian König wrote: > But another question: Why do you want to

Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two

2018-09-11 Thread Christian König
Am 11.09.2018 um 09:55 schrieb Michel Dänzer: On 2018-09-11 9:46 a.m., Christian König wrote: Am 11.09.2018 um 09:37 schrieb Michel Dänzer: On 2018-09-11 8:49 a.m., Christian König wrote: But another question: Why do you want to clear VRAM on allocation? We perfectly support allocating VRAM

Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two

2018-09-11 Thread Michel Dänzer
On 2018-09-11 9:46 a.m., Christian König wrote: > Am 11.09.2018 um 09:37 schrieb Michel Dänzer: >> On 2018-09-11 8:49 a.m., Christian König wrote: >>> But another question: Why do you want to clear VRAM on allocation? We >>> perfectly support allocating VRAM without clearing it. >> Which is a

Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two

2018-09-11 Thread Christian König
Am 11.09.2018 um 09:37 schrieb Michel Dänzer: On 2018-09-11 8:49 a.m., Christian König wrote: But another question: Why do you want to clear VRAM on allocation? We perfectly support allocating VRAM without clearing it. Which is a problem of its own, as it can leak information from one process

Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two

2018-09-11 Thread Michel Dänzer
On 2018-09-11 8:49 a.m., Christian König wrote: > > But another question: Why do you want to clear VRAM on allocation? We > perfectly support allocating VRAM without clearing it. Which is a problem of its own, as it can leak information from one process to another. Anyway, not clearing when

Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two

2018-09-11 Thread Christian König
Yeah well the whole patch set depends on that :) Otherwise we don't get pages larger than 2MB for the L1 on Vega10. But another question: Why do you want to clear VRAM on allocation? We perfectly support allocating VRAM without clearing it. Regards, Christian. Am 11.09.2018 um 02:08 schrieb

Re: [PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two

2018-09-10 Thread Felix Kuehling
This looks good. But it complicates something I've been looking at: Remembering which process drm_mm_nodes last belonged to, so that they don't need to be cleared next time they are allocated by the same process. Having most nodes the same size (vram_page_split pages) would make this very easy and

[PATCH 01/11] drm/amdgpu: try allocating VRAM as power of two

2018-09-09 Thread Christian König
Try to allocate VRAM in power of two sizes and only fallback to vram split sizes if that fails. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 52 +--- 1 file changed, 40 insertions(+), 12 deletions(-) diff --git