Re: [PATCH 06/12] drm/amdgpu: Correctly establish the suspend/resume hook for amdkfd

2017-07-06 Thread Yong Zhao
Hi Alex, As far as I know, we never tested suspend/resume on the setting you mentioned. Theoretically it should work. When I read the code now, I was wondering whether we should stop kfd before amdgpu_bo_evict_vram() and amdgpu_fence_driver_suspend(). If that's not needed, it may make more

Re: [PATCH 06/12] drm/amdgpu: Correctly establish the suspend/resume hook for amdkfd

2017-07-06 Thread Yong Zhao
On 2017-07-06 05:44 PM, Alex Deucher wrote: On Thu, Jul 6, 2017 at 5:33 PM, Yong Zhao wrote: Hi Alex, As far as I know, we never tested suspend/resume on the setting you mentioned. Theoretically it should work. Are the kfd s/r entry points global or per GPU? If you have

Re: [PATCH 06/12] drm/amdgpu: Correctly establish the suspend/resume hook for amdkfd

2017-07-06 Thread Alex Deucher
On Thu, Jul 6, 2017 at 5:33 PM, Yong Zhao wrote: > Hi Alex, > > As far as I know, we never tested suspend/resume on the setting you > mentioned. Theoretically it should work. Are the kfd s/r entry points global or per GPU? If you have two GPUs and you suspend one, will it

Re: [PATCH 06/12] drm/amdgpu: Correctly establish the suspend/resume hook for amdkfd

2017-07-06 Thread Alex Deucher
On Mon, Jul 3, 2017 at 5:11 PM, Felix Kuehling wrote: > From: Yong Zhao > > Signed-off-by: Yong Zhao > Reviewed-by: Felix Kuehling Does this work properly for multiple GPUs? E.g., if one is suspended and

Re: [PATCH 06/12] drm/amdgpu: Correctly establish the suspend/resume hook for amdkfd

2017-07-03 Thread Oded Gabbay
On Tue, Jul 4, 2017 at 12:11 AM, Felix Kuehling wrote: > From: Yong Zhao > > Signed-off-by: Yong Zhao > Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ >

[PATCH 06/12] drm/amdgpu: Correctly establish the suspend/resume hook for amdkfd

2017-07-03 Thread Felix Kuehling
From: Yong Zhao Signed-off-by: Yong Zhao Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ drivers/gpu/drm/amd/amdgpu/cik.c | 9 + 2 files changed, 8 insertions(+), 8