Re: [PATCH 1/2] drm/amdgpu: cleanup drm_gpu_scheduler array creation

2020-03-10 Thread Nirmoy
On 3/10/20 12:41 PM, Christian König wrote: Hi Nirmoy, you can stick with that for now. In the long term we should make the priority a parameter of amdgpu_ring_init(). And then amdgpu_ring_init() can gather the rings by priority and type. That in turn would make amdgpu_ring_init_sched()

Re: [PATCH 1/2] drm/amdgpu: cleanup drm_gpu_scheduler array creation

2020-03-10 Thread Christian König
Hi Nirmoy, you can stick with that for now. In the long term we should make the priority a parameter of amdgpu_ring_init(). And then amdgpu_ring_init() can gather the rings by priority and type. That in turn would make amdgpu_ring_init_sched() and amdgpu_ring_init_compute_sched()

Re: [PATCH 1/2] drm/amdgpu: cleanup drm_gpu_scheduler array creation

2020-03-10 Thread Nirmoy
Hi Christian, I think we still need amdgpu_ring.has_high_prio bool. I was thinking of using amdgpu_gfx_is_high_priority_compute_queue() to see if a ring is set to high priority but then I realized we don't support high priority gfx queue on gfx7 and less. Regards, Nirmoy On 3/10/20

[PATCH 1/2] drm/amdgpu: cleanup drm_gpu_scheduler array creation

2020-03-10 Thread Nirmoy Das
Move initialization of struct drm_gpu_scheduler array, amdgpu_ctx_init_sched() to amdgpu_ring.c. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c| 68 --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h| 3 - drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2