Re: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file

2017-11-27 Thread Alex Deucher
1.2017 20:29 schrieb "Liu, Shaoyun" <shaoyun@amd.com>: >>>>> >>>>> I agree that this HW engineer generated file doesn't match the >>>>> coding style from linux software engineer point of view , but >>>>> si

Re: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file

2017-11-27 Thread Tom St Denis
On 27/11/17 04:28 PM, Christian König wrote: Am 27.11.2017 um 21:56 schrieb Alex Deucher: On Mon, Nov 27, 2017 at 3:44 PM, Christian König wrote: Am 27.11.2017 um 21:01 schrieb Felix Kuehling: On 2017-11-27 02:37 PM, Koenig, Christian wrote: And that is a clear NAK

Re: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file

2017-11-27 Thread Christian König
To: Liu, Shaoyun; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file First of let us fix the obvious style problems. Am 27.11.2017 um 19:30 schrieb Shaoyun Liu: > Change-Id: I654d02891b80f3457ddcd80d6a8ea5ace295a89c &g

RE: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file

2017-11-27 Thread Liu, Shaoyun
Subject: Re: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file On Mon, Nov 27, 2017 at 3:44 PM, Christian König <christian.koe...@amd.com> wrote: > Am 27.11.2017 um 21:01 schrieb Felix Kuehling: >> >> On 2017-11-27 02:37 PM, Koenig, Christian wrote: >>&g

Re: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file

2017-11-27 Thread Alex Deucher
/, I don't see a reason to specially >>> change this file without touch else . This file is actually almost >>> identical as soc15ip.h . I think it's easier for us to import >>> other offset file in the future if we keep them un-touched . >>> &g

Re: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file

2017-11-27 Thread Christian König
Subject: Re: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file First of let us fix the obvious style problems. Am 27.11.2017 um 19:30 schrieb Shaoyun Liu: > Change-Id: I654d02891b80f3457ddcd80d6a8ea5ace295a89c > Signed-off-by: Shaoyun Liu <shaoyun@amd.c

RE: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file

2017-11-27 Thread Liu, Shaoyun
...@lists.freedesktop.org] On Behalf Of Tom St Denis Sent: Monday, November 27, 2017 1:54 PM To: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file On 27/11/17 01:30 PM, Shaoyun Liu wrote: > Change-Id: I654d02891b80f3457ddcd80d6a8ea5ace295a89c > Signed-off-by: Shaoy

RE: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file

2017-11-27 Thread Liu, Shaoyun
, November 27, 2017 2:17 PM To: Liu, Shaoyun; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file First of let us fix the obvious style problems. Am 27.11.2017 um 19:30 schrieb Shaoyun Liu: > Change-Id: I654d02891b80f3457ddcd80d6a8ea5ace295a89c

Re: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file

2017-11-27 Thread Christian König
First of let us fix the obvious style problems. Am 27.11.2017 um 19:30 schrieb Shaoyun Liu: Change-Id: I654d02891b80f3457ddcd80d6a8ea5ace295a89c Signed-off-by: Shaoyun Liu --- .../drm/amd/include/asic_reg/vega10/ip_offset_1.h | 1248 1 file

Re: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file

2017-11-27 Thread Tom St Denis
On 27/11/17 01:30 PM, Shaoyun Liu wrote: Change-Id: I654d02891b80f3457ddcd80d6a8ea5ace295a89c Signed-off-by: Shaoyun Liu --- .../drm/amd/include/asic_reg/vega10/ip_offset_1.h | 1248 1 file changed, 1248 insertions(+) create mode 100644

[PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file

2017-11-27 Thread Shaoyun Liu
Change-Id: I654d02891b80f3457ddcd80d6a8ea5ace295a89c Signed-off-by: Shaoyun Liu --- .../drm/amd/include/asic_reg/vega10/ip_offset_1.h | 1248 1 file changed, 1248 insertions(+) create mode 100644