Re: [PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper

2018-09-08 Thread Christian König
fix looks like what I did as well. Just only used one variable and added some extra BUG_ON(). Christian. Thanks, Ray Regards, Christian. Thanks, Ray From: amd-gfx on behalf of Christian König Sent: Thursday, September 6, 2018 6:06 PM To: Huang, Ray Cc: Mic

Re: [PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper

2018-09-08 Thread Huang Rui
_cut_position(, , list2); Am I understanding right? Thanks, Ray > Regards, > Christian. > > > > Thanks, > Ray > > From: amd-gfx on behalf of > Christian König > Sent: Thursday, September 6, 2018 6:06 PM > To: Huang, Ray > Cc: Mic

Re: [PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper

2018-09-07 Thread Christian König
on. Regards, Christian. Thanks, Ray From: amd-gfx on behalf of Christian König Sent: Thursday, September 6, 2018 6:06 PM To: Huang, Ray Cc: Michel Dänzer; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper Am 06.09.2018 um 12:02 schrieb Huang

Re: [PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper

2018-09-06 Thread Christian König
Am 06.09.2018 um 12:02 schrieb Huang Rui: On Fri, Aug 31, 2018 at 05:17:33PM +0200, Christian König wrote: Am 31.08.2018 um 17:15 schrieb Michel Dänzer: On 2018-08-31 3:10 p.m., Christian König wrote: Staring at the function for six hours, just to essentially move one line of code. That

Re: [PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper

2018-09-06 Thread Huang Rui
On Fri, Aug 31, 2018 at 05:17:33PM +0200, Christian König wrote: > Am 31.08.2018 um 17:15 schrieb Michel Dänzer: > >On 2018-08-31 3:10 p.m., Christian König wrote: > >>Staring at the function for six hours, just to essentially move one line > >>of code. > >That sucks, but the commit log should

Re: [PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper

2018-09-02 Thread Zhang, Jerry (Junwei)
On 08/31/2018 09:10 PM, Christian König wrote: Staring at the function for six hours, just to essentially move one line of code. Signed-off-by: Christian König Reviewed-by: Junwei Zhang --- drivers/gpu/drm/ttm/ttm_bo.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-)

Re: [PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper

2018-08-31 Thread Christian König
Am 31.08.2018 um 17:15 schrieb Michel Dänzer: On 2018-08-31 3:10 p.m., Christian König wrote: Staring at the function for six hours, just to essentially move one line of code. That sucks, but the commit log should describe what the problem was and how this patch solves it. Signed-off-by:

Re: [PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper

2018-08-31 Thread Michel Dänzer
On 2018-08-31 3:10 p.m., Christian König wrote: > Staring at the function for six hours, just to essentially move one line > of code. That sucks, but the commit log should describe what the problem was and how this patch solves it. > Signed-off-by: Christian König > --- >

[PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper

2018-08-31 Thread Christian König
Staring at the function for six hours, just to essentially move one line of code. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index