Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed

2019-01-03 Thread Deucher, Alexander
ay, January 03, 2019 11:00 PM > To: Xu, Feifei ; Yu, Xiangliang ; > amd-gfx@lists.freedesktop.org; Deucher, Alexander > Subject: Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command > failed > > Hi guys, > > this patch broke loading older versions of PSP

Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed

2019-01-03 Thread Koenig, Christian
fei ; Yu, Xiangliang ; > amd-gfx@lists.freedesktop.org; Deucher, Alexander > Subject: Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command > failed > > Hi guys, > > this patch broke loading older versions of PSP firmware on Vega10. > > What exactly is the

RE: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed

2019-01-03 Thread Yu, Xiangliang
König Sent: Thursday, January 03, 2019 11:00 PM To: Xu, Feifei ; Yu, Xiangliang ; amd-gfx@lists.freedesktop.org; Deucher, Alexander Subject: Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed Hi guys, this patch broke loading older versions of PSP firmware on Vega10

Re: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed

2019-01-03 Thread Christian König
On Behalf Of Xiangliang Yu Sent: Thursday, December 13, 2018 3:42 PM To: amd-gfx@lists.freedesktop.org Cc: Yu, Xiangliang Subject: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed There isn't ucode when executing INVOKE command, so current code can't check the failure

RE: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed

2018-12-17 Thread Xu, Feifei
Reviewed-by: Feifei Xu -Original Message- From: amd-gfx On Behalf Of Xiangliang Yu Sent: Thursday, December 13, 2018 3:42 PM To: amd-gfx@lists.freedesktop.org Cc: Yu, Xiangliang Subject: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed There isn't ucode when

RE: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed

2018-12-17 Thread Yu, Xiangliang
Anyone to help reviewing? Thanks! -Original Message- From: amd-gfx On Behalf Of Xiangliang Yu Sent: Thursday, December 13, 2018 3:42 PM To: amd-gfx@lists.freedesktop.org Cc: Yu, Xiangliang Subject: [PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed There isn't ucode

[PATCH 2/2] drm/amdgpu/psp: Fix can't detect psp INVOKE command failed

2018-12-12 Thread Xiangliang Yu
There isn't ucode when executing INVOKE command, so current code can't check the failure of INVOKE command. Remove the ucode check. Signed-off-by: Xiangliang Yu --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git